summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2016-03-16loplugin:defaultparamsTor Lillqvist1-3/+3
Change-Id: I6d973c5402317b99c1d0eed85d4bb1de83d35fe2
2016-03-16loplugin:constantparam in xmloff/Noel Grandin37-183/+127
Change-Id: I376f1d4ac65de584f9caa6ba8e25e43216374112 Reviewed-on: https://gerrit.libreoffice.org/23295 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15define ODFSVER_LATEST at a central placeEike Rathke1-1/+1
It's already enough to have to adapt the SvtSaveOptions::GetODFSaneDefaultVersion() mapping for new ODFDefaultVersion values, get rid of the SvXMLExport::getSaneDefaultVersion() place. In the hope that DO NOT USE is taken seriously.. Change-Id: I1eeae698249f68cc375b22cc4cc799107bc14e41
2016-03-14remove some unused typedefs, and inline some use-onceNoel Grandin1-3/+1
Change-Id: I5ada1cff98c0a3e065d126444f8052f444323743 Reviewed-on: https://gerrit.libreoffice.org/23234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11tdf#97966: Remove 'static' keywordsWastack1-1/+1
Change-Id: Id70f9e55fb4ad7d3a501399b055208ea10369c82 Reviewed-on: https://gerrit.libreoffice.org/23131 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09Add missing includesDavid Ostrovsky2-0/+2
These include were needed to compile on Windows, MSVC 14.0 with clang-cl. Change-Id: I4ca5cec8314920e90fcca6fa69ec4df87d680f29 Reviewed-on: https://gerrit.libreoffice.org/23044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08loplugin:constantparam in xmloffNoel Grandin2-14/+13
Change-Id: I531dcf0861ab5a545eec16bf4aa92ac92eb9626e Reviewed-on: https://gerrit.libreoffice.org/23022 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07improve defaultparams lopluginNoel Grandin1-2/+1
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04loplugin:unuseddefaultparams in vcl and xmloffNoel Grandin4-42/+13
and teach the plugin about code that takes the address of a function Change-Id: Ia9d5afef44520aca236659e8176f1e27135ef4fc Reviewed-on: https://gerrit.libreoffice.org/22861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-27xmloff: tdf#97808: allow empty draw:marker-start/marker-end/stroke-dashMichael Stahl1-1/+5
Apparently these are allowed to be empty, which means "nothing". (regression from db1d278dcc308c73eb5edebc20481c96e7f479d8) Change-Id: I13f7998e0986b26c34929afd40b1b4f0fc9efdff
2016-02-25Use rtl::math::isNan()Fabio Buso1-1/+2
isnan() not found causes compilation error System: Archlinux (Kernel Version 4.4) - GCC 5.3.0 Change-Id: Id0bb4555428896678437e8abf228f1c208f1e7a0 Reviewed-on: https://gerrit.libreoffice.org/22695 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-02-25loplugin:unuseddefaultparams in xmloff/Noel Grandin14-74/+35
Change-Id: Ia504a4e96a4ebc8404fe6881e0f77fba29cd00ae
2016-02-25new loplugin:unuseddefaultparamsNoel Grandin8-64/+38
Change-Id: I2c3e7d66be9e3883ea2801ff394948cc580d1e44
2016-02-23new loplugin: commaoperatorNoel Grandin1-1/+2
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-22loplugin:write only fieldsNoel Grandin3-10/+0
Change-Id: I45895e9845a9037da207f001fece427452ed499f
2016-02-19new loplugin: find write-only fieldsNoel Grandin1-1/+0
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-19add "use-wildcards" XML_USE_WILDCARDS, tdf#72196Eike Rathke1-0/+1
to support ODF table:use-wildcards Change-Id: I448bc53dd81d79a29efad9fbd240ae9c059dfd15
2016-02-18[API CHANGE] add Author Initials to XAnnotationCaolán McNamara2-0/+19
and use the users preferred initials for impress annotations i.e. the ones entered in the tools->options and save and load those to/from odf similarly to what we do for writer annotation initials Change-Id: Iadc0e994bfaf58632ce25b8f7cdc737580ee97bc Reviewed-on: https://gerrit.libreoffice.org/22143 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin1-7/+0
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock93-335/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock6-17/+17
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04Replace push(std::make_tuple(...)) with emplace(...)Stephan Bergmann1-4/+4
...the former reportedly caused problems now with GCC 6 libstdc++ Change-Id: I4b13adc71d9e00b14df1c8e875dba9e90cbcdcc7
2016-02-03remove bogus nullprt checks for pContextJochen Nitschke1-11/+2
reported by Cppcheck Change-Id: I737c2bd7be197ef9d0b29b922acd8021fefb7af6 Signed-off-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-on: https://gerrit.libreoffice.org/22059 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-02xmloff: tdf#96147: ODF export: fix duplicate fo:background-colorMichael Stahl2-2/+12
... attributes that happen if both CharHighlight and CharBackColor properties are used, because the CharBackTransparent property wasn't taken into account, and combining the CharBackColor and CharBackTransparent properties happens *after* XMLTextExportPropertySetMapper::ContextFilter() runs. Also, it looks like a transparent highlight wouldn't export properly but apparently DomainMapper::getColorFromId() won't create such. (regression from f880962f5bf26bfaef06bd3f9e67e2d901a2e74c) Change-Id: Ib628ef8bb377482f74fadb97c81afb95fbbf7184
2016-01-31boost::tuple -> std::tupleCaolán McNamara4-24/+23
Change-Id: Ia08c184b792ff73d3ed49d6a5d54dec1a35943e9 Reviewed-on: https://gerrit.libreoffice.org/21955 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin3-5/+5
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-21Move XMLMetaExportComponent_get_implementation to a more reasonable placeStephan Bergmann1-8/+8
Change-Id: Iaf3dc5351453b4aee8ffc1e7fb1bc670c45c507f
2016-01-21cppcheck: variableScopeCaolán McNamara1-2/+2
Change-Id: Id7cf5887c1ef0e0c0aad72ea5ac49f4d3db5065e
2016-01-19Resolves: tdf#96245 relax test for duplicate frame namesCaolán McNamara1-1/+2
to allow duplicated unnamed frames Change-Id: I871849b23d01209f027b6295777db705f7dc86d8
2016-01-18Convert NULL/0 to nullptrPeter Foley1-3/+3
Change-Id: Iee6bb0867afd8aebe36e62b507f1332e3a581838 Reviewed-on: https://gerrit.libreoffice.org/21549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-18loplugin:unreffunStephan Bergmann1-19/+0
Change-Id: If023e3916c7d2fa7f22958304606a2eec418fcf7
2016-01-18tdf#74608 xmloff: Constructor feature for XMLMetaExportComponentkripton4-12/+11
Change-Id: I3edde1291e9dec21420238edb5a05f25849ebfff Reviewed-on: https://gerrit.libreoffice.org/19792 Reviewed-by: Matúš Kukan <matus@libreoffice.org> Tested-by: Matúš Kukan <matus@libreoffice.org>
2016-01-15-Werror=unused-but-set-variableNoel Grandin2-31/+7
Change-Id: I981e1b660dc94333935b3a451847198940e47e99
2016-01-15loplugin:unusedmethods unused return value in include/xmloffNoel Grandin10-65/+20
Change-Id: I6615a467152a50e9c65f04fd0d6c8cc128517bdb
2016-01-13-Werror=addressStephan Bergmann1-4/+1
the original looks odd, but the code was like that ever since it got introduced with 44cfc7cb6533d827fd2d6e586d92c61d7d7f7a70 "re-base on ALv2 code. Includes (at least) relevant parts of:" Change-Id: I327c5a53a2634aca1b36367ee09c068ac610d3f4
2016-01-13-Werror=unused-but-set-variableNoel Grandin1-4/+0
Change-Id: I61a07db63cc8a6bad159ca455f92d604c5e78edc
2016-01-13loplugin:unusedmethods unused return value in xmloff/Noel Grandin9-53/+13
Change-Id: Ia5a3716ca4f7eb987092837ac83a415e5c0730df
2016-01-12xmloff: SvXMLExport::mbExtended is dead nowMichael Stahl1-3/+0
Change-Id: Ie679259deccce87949d7bf8767af707827b4134c
2016-01-12xmloff: there is no reason why office:version should be omittedMichael Stahl1-15/+14
... if a document contains foreign elements or attributes. In fact since ODF 1.2 the office:version attribute is mandatory and any document that omits it is therefore invalid, while "extended conforming" documents are allowed to contain foreign elements and attributes. This mysterious check was there since CVS initial import, but without any justification. Change-Id: Ifeafad2b7af41f06356461adb7ae65dbf7bae11d
2016-01-12typosMichael Stahl1-1/+1
Change-Id: I970429c266cc1a8cf36cfba379b447899b5dbce9
2016-01-11tdf#40517 Export/Import in ODF decimal replacement with spaceLaurent Balland-Poirier2-8/+27
Number format such as "0.???" is saved in ODF with number:decimal-replacement=" " Change-Id: I0dd19b5ea126f380bcf17a3ccc5d8c355119e23b Reviewed-on: https://gerrit.libreoffice.org/21021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-10Fix typosAndrea Gelmini19-22/+22
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08tdf#96480: ODF import: eliminate duplicate cross reference heading bookmarksMichael Stahl5-12/+141
7c3c3006deaaaf1bb3f2f4eeeaf11da3bcebe53c is apparently worse than it appeared at first glance since there are numerous assumptions about bookmarks, such as that if they were inserted successfully they may be copied successfully, which isn't the case for duplicate cross reference bookmarks. So fix this differently, by eliminating the duplicates and mapping all reference fields to refer to the surviving bookmark. It was not possible to do this in SwXBookmark by checking the makeMark() return as that would raise interesting problems such as it's currently guaranteed to have 1:1 SwXBoomarks to core Marks so we can't just connect 2 SwXBookmarks to the same core Mark, and we also can't leave the SwXBookmark unconnected after attach. Another alternative would be to temporarily allow inserting the duplicate bookmarks and then eliminate them after the import, but what is implemented now is to check from xmloff for duplicates, which is reasonably simple. Change-Id: I7ee4854d1c9d8bf74201089cbb7287b1bd8ee3b9
2016-01-08indentation fixesMarkus Mohrhard1-91/+92
Change-Id: Ibc652519d7ccc9a1ec483f19d443c9b5303e0f92
2016-01-05tdf#94205: Use o3tl::make_unique insted of new+std::move.Sheikha AL-Hinai1-4/+2
Change-Id: I9ff14760479d2ac882546e2e5b74ab750ba2fa4b Reviewed-on: https://gerrit.libreoffice.org/20984 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-29cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
2015-12-26xmloff: indent cleanup in headerChris Sherlock1-1/+2
Change-Id: Ibcd03dcdc8936ce95feada20c72a358d5021a1d9 Reviewed-on: https://gerrit.libreoffice.org/20962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-26xmloff: change instances of maName to more descriptive namesChris Sherlock2-4/+4
Change-Id: I7ff771f78481677ae65f933608e484714cd43f4f Reviewed-on: https://gerrit.libreoffice.org/20961 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-22tdf#96181 SVG: Add support for <use> elementXisco Fauli1-0/+1
Change-Id: Ia95c7e35158f8a4c6a597662524c74e1909983bb Reviewed-on: https://gerrit.libreoffice.org/20483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>