summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2014-12-10xmloff: make the export of the horrible field marks aware of auto-stylesMichael Stahl1-96/+105
When exporting the .DOC bugdoc of fdo#87110 to ODF, the auto-styles export will iterate over the fieldmarks in the page header and add the attributes for them but not export the elements, so the first auto-style gets a bunch of duplicate attributes. Change-Id: I3fcf39f03e3d9ae5fca661efa7eb4bbb3eab9f5c (cherry picked from commit 06f85d41d02ebef76487b230f35f2ec638c46c8b)
2014-12-10fdo#87110: xmloff: don't catch IllegalArgumentException hereMichael Stahl2-7/+11
There are at least 2 callers of InsertTextContent() that have non-trivial catch handlers for this exception, which aren't called now. (regression from bebf8ccfba37f77d6a43c7874249b31736467b17) Change-Id: I085b710dfd5877e9b7e71610951543eddf6a6e46 (cherry picked from commit b86f5530161a417d31e28e75408ee80352fadad7)
2014-12-10don't write extension elements into ODF namespaces, related fdo#45266Markus Mohrhard1-6/+6
We will still import the old elements but only write them into the lo-ext namespace. Also it will only be exported for ODF 1.2 extended. (cherry picked from commit 88d3931d92bc89519acf95f0510f6f2a6ff7c72c) Signed-off-by: Michael Stahl <mstahl@redhat.com> Backpoting the export part of this too since the attributes were added in LO 4.3 so the change has very limited impact. Conflicts: xmloff/source/chart/PropertyMap.hxx Change-Id: I1c41716b8b16e186ec84767b4b3a636d083162b8
2014-12-09Resolves: fdo#87108 crash on saving fodgCaolán McNamara1-4/+7
Change-Id: Ib88f0e9b0a3ba229c9e9f6cf20831c16051e3e29 (cherry picked from commit bfd63516c9fd4ec366576f9a0e3c456bc3d530a3)
2014-12-08iimport part for: "use correct xml element name, related fdo#45266"Markus Mohrhard1-0/+3
Change-Id: I8ec31d026f5c6fdc4b7fc573060e7837a337d50b
2014-12-08import part for: " use correct xml element name, related fdo#45266"Markus Mohrhard1-0/+1
Change-Id: Ied71383fc837c7e667455f84937801e8d45f2989
2014-12-08import part for: "export to extension namespace instead of odf ..."Markus Mohrhard1-0/+5
Change-Id: I0b61e05e3b153ba7efe351b18cb705ea6348f546
2014-12-08the xlink:type attribute is mandatory, related fdo#79449Markus Mohrhard1-0/+1
Change-Id: I03c4217f786bc10aa915780dc10ea52d94019b6e
2014-12-08remove invalid attribute that is not read anywayMarkus Mohrhard1-1/+0
Change-Id: Id7770ffda49ba7bc0ebc780c67c56b81152213f7
2014-12-05fdo#86795: xmloff: ODF import: do not import checkbox fieldmark ...Michael Stahl1-15/+34
... if it has start/end, because Writer will become grumpy and crash. Change-Id: I6024051249eeac6ed9e43856fa77db969287f888 (cherry picked from commit 25fd11e78279aef5a6b7656347758e5c67a9c45a)
2014-12-01fdo#85496: add some asserts to detect this sort of problemMichael Stahl1-0/+14
Change-Id: Iff787c8d2a71bc3082192cc98e3d916badee65dd (cherry picked from commit 7a242b463132d67a4a2d6e69319e0da367145cc0)
2014-11-27Resolves: fdo#84043 don't create duplicate Mirrored[X|Y] propertiesCaolán McNamara1-8/+24
regression from 13ef16423e78d3ea825172594f08c47d2f9bfd09 commit 13ef16423e78d3ea825172594f08c47d2f9bfd09 Author: Armin Le Grand <alg@apache.org> Date: Wed Nov 21 13:23:01 2012 +0000 For backward compatibility take mirrorings in setTransformation into account Also found an error in SdrObjCustomShape::TRGetBaseGeometry when MirrorY was used (cherry picked from commit 4116c33b12d3787c406f0348f89efcb1cf409507) Change-Id: I7bfb5dea32b8ab8498e3d92975c49b830c81e6fb (cherry picked from commit 751e5b32c5c361995bf0ba3295f773341fd92c23) Reviewed-on: https://gerrit.libreoffice.org/13149 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl15-0/+15
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl79-0/+89
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-16Remove now useless setTextEmbeddedGraphicURL()Zolnai Tamás1-7/+0
Since this commit: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e it's not necessary to update the package URL. Change-Id: I25c829e9bc0c666838baf19cd60f19938ebb430c
2014-11-14more catch by referenceCaolán McNamara1-1/+1
Change-Id: I2db9f94a517f814ef0854190e6f1194501070409
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava13-15/+15
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini10-11/+11
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11xmloff: XML_DROPDOWN should be XML_DROP_DOWNMichael Stahl4-4/+4
Change-Id: I47247289bb4367faa9a07f3568270718b5423353
2014-11-08xmloff: [loplugin:unusedvariablecheck]Michael Stahl1-1/+0
Change-Id: I5b141d35ab05e1a3f225a980aad1280102a80ee0
2014-11-08xmloff: remove unused parameter of SvxXMLListStyleContext::FillUnoNumRule()Michael Stahl3-15/+9
Change-Id: I359f37ce778d55e6868bd1c78c0ff0d452f36088
2014-11-07Removed #includes including themselvesAndrea Gelmini2-4/+0
Change-Id: I3fe3227967e07b6b0c82dccf3c9400bfe6e1d729 Reviewed-on: https://gerrit.libreoffice.org/12292 Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-05markup with event type not checker typeCaolán McNamara2-1/+3
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin11-56/+55
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-03coverity#705391: xmloff: XMLMergeElemTransformerContext misuse of enumMichael Stahl4-15/+15
The enum types XMLElemTransformerAction and XMLAttrTransformerAction use the same integer values so a mixture of values from these 2 in one switch is very suspicious. In the various *ActionTable arrays in OOo2Oasis/Oasis2OOo there is just one such array that mixes values from the 2 enums, and that is just the values that coverity complains about. The XML_ETACTION_EXTRACT_CHARACTERS was added at a later date in commits 8d374c039e7d349141befe3c9ef97f82f42bfa7 2685b93a6a23867baa4df265bb0cc35abaf76c0e 7d2405a54d13f68a35dfc5f619ad4bdb0b761856 c276550e07f8078fe9345985f70e8384d930a83f ...but it turns out that the XMLAttrTransformerAction ones are handled in StartElement() and ProcessAttrs() methods but the XMLElemTransformerAction ones are handled in CreateChildContext() methods so probably the XML_ATACTION_MOVE_FROM_ELEM* values are in the wrong enum. Change-Id: Ib1791f6eafac4fb1e99334f41c17a90cfb076359
2014-11-03coverity#1250700 Uninitialized scalar fieldCaolán McNamara1-0/+1
Change-Id: I5db51e7864017f0d0e474ed3e253657288245850
2014-10-31Removed duplicated includesAndrea Gelmini2-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31coverity#705348 Missing break in switchEike Rathke1-0/+1
Change-Id: I23e03e45ba4f6d259128bc5e4c2fd5952be05c2f
2014-10-31fdo#80403: Import baseclasses implement FastParser interfacesDaniel Sikeler2-0/+124
SvXMLImportContext implements XFastContextHandler SvXMLImport implements XFastDocumentHandler Change-Id: Id400260af112f4a448fe469c9580f0ebacec4ab6
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini2-2/+2
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-29coverity#735663 Division or modulo by zeroCaolán McNamara1-0/+3
Change-Id: I69410ebe3dcded9951bfa9e83844644147f4416a
2014-10-24XM_TOK_UNKNOWN needs to be in the value range of XMLImageMapToken (ubsan)Stephan Bergmann1-1/+1
Change-Id: Ief14b775851f457becb6f42b9a74e423bb73ed32
2014-10-23coverity#705781 Resource leakCaolán McNamara1-8/+4
Change-Id: Ia802df9c36b59a0130931436be7f5dbea07c0c8c
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann28-83/+3
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11coverity#735353 Unchecked return valueCaolán McNamara1-7/+13
Change-Id: Iab54019d07ac27b4d8247d789c29165d24e2288f
2014-10-11coverity#704113 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: If6537d84953c67801bc1959e17dd3662cd1face7
2014-10-10typo: follwing -> followingAndras Timar1-1/+1
Change-Id: Ia201473c84dc0923e8f4bee6329ad926cd6addd6
2014-10-10UBSan runtime error: division by zeroStephan Bergmann1-1/+3
...triggered by CppunitTest_sw_ooxmlexport. Though it iss unclear to me what is the best fix in this case, emit a style:legend-expansion-aspect-ratio value of 1, emit a style:legend-expansion value of "custom" without an accompanying style:legend-expansion-aspect-ratio (if that is even valid), emit another style:legend-expansion value, or emit no style:legend-expansion attribute (if that is even valid)? Change-Id: I36afe35082a841974bb2480fe11a7a3dd815ddf0
2014-10-08back out even more wrong tools::Time changes, geez..Eike Rathke1-4/+4
Change-Id: I52eb3400769999d7f554c3bdb8746f65b7990388
2014-10-08spelling: instanciated -> instantiatedNoel Grandin1-2/+2
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara1-2/+2
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-04sw textboxes: reimplement ODF import/exportMiklos Vajna3-13/+41
Turns out that for normal TextFrames and rectangular drawinglayer shapes, the engine is written in ODF implicitly. Use the same trick to describe if the shape content should be rendered by SW or editeng. This reverts 9d310ecfce3c2fc481b125e1493a534e2107a68e (sw textboxes: implement ODF import/export, 2014-06-02). Change-Id: Id8afa6368bedcd293e578244abb58e18949bec8d
2014-10-04coverity#1242759 Result is not floating-pointNorbert Thiebaud1-1/+1
Change-Id: I3a358722279d574f96a2270b5dee84b85ddb402f
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin12-17/+17
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01loplugin: cstylecastNoel Grandin28-156/+156
Change-Id: I25b82a96aace448a8debe90c181b22976ea95414
2014-10-01fdo#82577: Handle TimeNoel Grandin7-32/+34
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin2-6/+6
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30xmloff: std::auto_ptr -> std::unique_ptrStephan Bergmann6-29/+15
Change-Id: I8baa6c0573af3629bacbf1891c3196c165883d9e
2014-09-30WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'Tor Lillqvist1-2/+2
Change-Id: Ibcb6abe7162197dec35f4626f158448ff538542f