summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2019-10-28loplugin:stringadd improve detectionNoel Grandin2-4/+3
if one side of the expression is a compile-time-constant, we don't need to worry about side-effects on the other side Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b Reviewed-on: https://gerrit.libreoffice.org/81589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-25speed-up shape import if shapes need z-order rearrangingKatarina Behrens1-0/+37
setting z-order individually on each shape and broadcasting is O(n^2) (remaining shapes also need reordering) and this is bad bad bad for performance Change-Id: Ic9c9137a097f6ff524192693910f221885f77cc4 Reviewed-on: https://gerrit.libreoffice.org/75055 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-25xmloff: create XMLDrawMetaExportOasis instances with an uno constructorMiklos Vajna4-8/+10
See tdf#74608 for motivation. Change-Id: I6dc4fcd75517c137c1bd4de766f67b73eaff1788 Reviewed-on: https://gerrit.libreoffice.org/81480 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-23xmloff: ODF import: reimplement fieldmark-start/fieldmark-endMichael Stahl2-85/+117
This needs to work in a similar way to writerfilter, because it has the same problem: fieldmark has 3 positions but attach() only recieves 2 positions. Insert the fieldmark at the fieldmark-start and move the cursor before the CH_TXT_ATR_FIELDEND character, and when the fieldmark-end arrives, move the cursor forward again. This will slightly change the import of invalid documents, e.g. when a fieldmark-end is missing, but that seems not so important and without a name attribute on the fieldmark-end we can't do any better. Change-Id: I3f0bd738277f56a999e79e4def911101b64b07e7 Reviewed-on: https://gerrit.libreoffice.org/81082 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-23size some stringbuffer to prevent re-allocNoel Grandin1-1/+1
Change-Id: I385587a922c555c320a45dcc6d644315b72510e9 Reviewed-on: https://gerrit.libreoffice.org/81278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21size some stringbuffer to prevent re-allocNoel Grandin1-1/+1
found by the simple expidient of putting asserts in the resize routine. Where an explicit const size is used, I started with 32 and kept doubling until that site did not need resizing anymore. Change-Id: I998787edc940d0a3ba23b5ac37131ab9ecd300f4 Reviewed-on: https://gerrit.libreoffice.org/81138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-20loplugin:virtualdead unused param in RedlineAdjustStartNodeCursorNoel Grandin3-5/+5
Change-Id: Ic8eaad705b0cf8289035f7eee3ad01439fc24ee7 Reviewed-on: https://gerrit.libreoffice.org/81155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-20loplugin:virtualdead unused param in XMLEventContextFactory::CreateContextNoel Grandin5-11/+5
Change-Id: I6fda2e04724d69fd218ffc85f9881b429714e63b Reviewed-on: https://gerrit.libreoffice.org/81154 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-18make bin/update_pch.s always include code in trivial #if'sLuboš Luňák2-19/+9
E.g. #ifdef LIBO_INTERNAL_ONLY is always true for code that builds with our PCHs. Change-Id: I3cf311ea3621b909105754cfea2cb0116b8b67f5 Reviewed-on: https://gerrit.libreoffice.org/80961 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-18xmloff: create XMLDrawSettingsExportOasis instances with an uno constructorMiklos Vajna4-8/+10
See tdf#74608 for motivation. Change-Id: I25fbd841a8f91b51787cebd4b94f5a62cb0d9e07 Reviewed-on: https://gerrit.libreoffice.org/80996 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-17loplugin:virtualdead dead propertygroup functionalityNoel Grandin10-199/+19
ever since it was introduced in commit d09dd8986436f17717443823ef18bd8552fdf408 Date: Wed Sep 15 13:55:34 2010 +0200 dba34a: export/import min-/max-/default-/value for date/time as XML-Schema conformant strings looks like classic over-engineering Change-Id: Ia4e4b65cfe92f522dee238a54a37db01f691750e Reviewed-on: https://gerrit.libreoffice.org/80951 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17Remove some memset callsMike Kaganski2-2/+1
Replace them with default initialization or calloc Change-Id: I747f53c2ced2d0473fd5a5ede4f8520a0633dcc1 Reviewed-on: https://gerrit.libreoffice.org/80805 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann1-2/+2
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-16loplugin:bufferadd loosen some constraintsNoel Grandin1-6/+4
and extend O*StringView to have a constructor that takes a pointer and a length Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8 Reviewed-on: https://gerrit.libreoffice.org/80872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16loplugin:stringadd look through a couple more known-good methodsNoel Grandin1-6/+2
Change-Id: Ifbdb3e41eae665f7dcaf5301aaba2b6e4662cf48 Reviewed-on: https://gerrit.libreoffice.org/80855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-15new loplugin:bufferaddNoel Grandin9-64/+24
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin2-5/+3
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-12Replace some OUStringBuffer by OUString in txtvfldi (xmloff)Julien Nabet1-16/+4
Change-Id: I55cb62b58194128533b416797e65078124e8500a Reviewed-on: https://gerrit.libreoffice.org/80698 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-12Get rid of OUStringBuffer in data2string (xmloff)Julien Nabet1-36/+17
Change-Id: I73d1ff799170739746e4907dae2da628bcff1749 Reviewed-on: https://gerrit.libreoffice.org/80693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-11xmloff: create XMLDrawSettingsExportOOO instances with an uno constructorMiklos Vajna4-13/+10
See tdf#74608 for motivation. Change-Id: I15c879fd2be820a1b6ee878149442ebb46588a30 Reviewed-on: https://gerrit.libreoffice.org/80629 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-11simplify "a = a +" to "a +="Noel Grandin1-2/+2
mostly so that my stringadd loplugin can point out places to improve Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5 Reviewed-on: https://gerrit.libreoffice.org/80618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-09tdf#114441 changed some sal_uLong to better fitting typesChristian Barth2-2/+2
Change-Id: I114a6b028eb59a1ae38c31bc20439a35643fe972 Reviewed-on: https://gerrit.libreoffice.org/80159 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-09loplugin:redundantpointerops check other pointer typesNoel Grandin3-6/+6
as well as unique_ptr Change-Id: I54842bca161ee460fb96c46ca31b6f9c0a7dbbdf Reviewed-on: https://gerrit.libreoffice.org/80455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07use FastParser in linguisticNoel Grandin2-0/+16
Change-Id: Iee2254dc13ccc31d266009ba1eb00f2517484cc7 Reviewed-on: https://gerrit.libreoffice.org/79814 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04xmloff: create XMLDrawMetaExportOOO instances with an uno constructorMiklos Vajna4-8/+10
See tdf#74608 for motivation. Change-Id: Ia7ca975486be09acd2655c59b65e1f2a57774f32 Reviewed-on: https://gerrit.libreoffice.org/80166 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-02tdf#42949 Fix IWYU warnings in xmloff/source/[s-x]*/*cxxGabor Kelemen112-262/+8
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I986ba9f661854d1b5fafc337ec109b0ee558a86a Reviewed-on: https://gerrit.libreoffice.org/79904 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-02loplugin:stringadd in writerfilter..xmloffNoel Grandin9-30/+15
Change-Id: Ib5292f4c702cc1e2994c736250a93e6fb18d1a20 Reviewed-on: https://gerrit.libreoffice.org/79988 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-30tdf#42949 Fix IWYU warnings in xmloff/source/[c-m]*/*cxxGabor Kelemen85-281/+28
Also checked xmloff/qa Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I843917d255f841066ace8d944aa1d00f1b718108 Reviewed-on: https://gerrit.libreoffice.org/79773 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-29Fix typosAndrea Gelmini1-1/+1
Change-Id: I8a93a6ed49661ddfae390a0302fca1fab5c95f14 Reviewed-on: https://gerrit.libreoffice.org/79795 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-27Deduplicate O(U)StringNumber definitions; add toAsciiUpperCaseMike Kaganski1-1/+1
Change-Id: I00e7ce62940907b5f4efc2b7f23f355c3e43ed6b Reviewed-on: https://gerrit.libreoffice.org/79686 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-27xmloff: create XMLDrawContentExportOOO instances with an uno constructorMiklos Vajna4-8/+12
See tdf#74608 for motivation. Change-Id: Ib63744f720a886cd67b4158399e6bf91c6efb128 Reviewed-on: https://gerrit.libreoffice.org/79660 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-24Related: tdf#124600 sw anchored object allow overlap: add ODT filterMiklos Vajna3-0/+4
Expose the AllowOverlap shape property as <style:graphic-properties loext:allow-overlap="..."/>. Change-Id: I6b6e08c67224ac7d4fb87046ea8accf94cdb583f Reviewed-on: https://gerrit.libreoffice.org/79462 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-24tdf#42949 Fix IWYU warnings in xmloff/source/*/*hxxGabor Kelemen66-74/+81
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iaad32419c49406a11f7cfb5856b33539d2a2894b Reviewed-on: https://gerrit.libreoffice.org/79077 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-24support O(U)String::number() for fast string concatenationLuboš Luňák1-2/+2
When I did the fast string concatenation, I didn't add any support for number(), which simply returned a O(U)String, and so it did the extra allocation/deallocation, although that could be avoided. In order to support this, number() now returns a special temporary return type, similarly to O(U)StringConcat, which allows delaying the concatenation the same way. Also similarly, the change of the return type in some cases requires explicit cast to the actual string type. Usage of OString::getStr() is so extensive in the codebase that I actually added it to the helper class, after that it's only relatively few cases. Change-Id: Iba6e158010e1e458089698c426803052b6f46031 Reviewed-on: https://gerrit.libreoffice.org/78873 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák2-2/+2
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-20xmloff: create XMLDrawStylesExportOOO instances with an uno constructorMiklos Vajna4-8/+12
See tdf#74608 for motivation. Change-Id: I875cdd1f1ee4e57522d992768dfbcdb0da9f3fd3 Reviewed-on: https://gerrit.libreoffice.org/79228 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-17tdf#42949 Fix IWYU warnings in xmloff/inc/Gabor Kelemen30-28/+25
Also recheck include/xmloff/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If01cb2844209b119063772d829e4ae21b74fc164 Reviewed-on: https://gerrit.libreoffice.org/78747 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-14tdf#39593 use isUnoTunnelId in xmloffArkadiy Illarionov7-20/+31
Add getUnoTunnelId methods. Change-Id: I80d3568e65ac66ee65ad589755a20270a27e62a7 Reviewed-on: https://gerrit.libreoffice.org/78744 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-13tdf#45789 [API CHANGE] Automatic row height in reportsIlhan Yesil1-2/+2
The controls have now an AutoGrow flag which is saved as style:min-row-height instead of style:row-height on style:table-row-properties in content.xml. In this case the table row height will be allowed to grow to accommodate the content. Note: in the conceptual model of reportdesigner this is a per-control property but in the current implementation, it is a per-row property in the ODF file. Thus, as soon as one control in the row has the AutoGrow property set, they all do. Change-Id: I95c25599e06af0f2f12e72a7cfc0881206f02039 Reviewed-on: https://gerrit.libreoffice.org/53977 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2019-09-13xmloff: create XMLDrawExportOOO instances with an uno constructorMiklos Vajna4-10/+14
See tdf#74608 for motivation. Change-Id: I3829df0f3f9d81257f06ef3c2f4fbe9af98dd953 Reviewed-on: https://gerrit.libreoffice.org/78859 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-10Fix typosAndrea Gelmini1-1/+1
Change-Id: Id62178a1a8b2e05d13c47f1ac4798578f140dbae Reviewed-on: https://gerrit.libreoffice.org/78794 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-09-06Fixing '....' and '..'Andrea Gelmini5-7/+7
Change-Id: I926069d6c1f2712e5020d930f7ff6c62fd00e912 Reviewed-on: https://gerrit.libreoffice.org/78667 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-03loplugin:constmethod in xmloffNoel Grandin20-35/+35
Change-Id: I79ff1001a3ac8fde10de1ab391772e2bfeb6a314 Reviewed-on: https://gerrit.libreoffice.org/78546 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-01Fix '..'Andrea Gelmini1-1/+1
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-29xmloff: create XMLImpressExportOOO instances with an uno constructorMiklos Vajna4-12/+13
See tdf#74608 for motivation. Change-Id: I44c3ac24c19f4ecd1d0d01a9a686b486f3b35c48 Reviewed-on: https://gerrit.libreoffice.org/78236 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-27tdf#107776 sw ODF shape import: make is-textbox check more strictMiklos Vajna1-1/+2
Regression from commit 9835a5823e0f559aabbc0e15ea126c82229c4bc7 (sw textboxes: reimplement ODF import/export, 2014-10-04), the problem was that we assumed graphic autostyles look like: <style:style style:name="gr2" style:family="graphic"> for simple (non-text-box) content, and look like: <style:style style:name="gr1" style:family="graphic" style:parent-style-name="Frame"> for complex (text-box) content. Turns out it's valid to have other parent styles as well, e.g. Graphics, which should not be imported as sw textboxes. With this, the arrow at the bottom of page 3 of the bugdoc is now again on top of the image, i.e. layout compatibility is restored. Change-Id: Icbba8a23c5f66e63090f90e6581ebc98948cb80b Reviewed-on: https://gerrit.libreoffice.org/78155 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-25cid#1448241 silence Explicit null deferenced false positiveCaolán McNamara1-0/+1
Change-Id: Iaf20e2c7c6f8502d902b41f2c109589aaa490a10 Reviewed-on: https://gerrit.libreoffice.org/78075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-25cid#1452763 Unchecked return valueCaolán McNamara1-1/+3
Change-Id: Ib2fa604f7c7635892221db4efa4c44f4f542b622 Reviewed-on: https://gerrit.libreoffice.org/78067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23loplugin:returnconstval in xmloffNoel Grandin5-16/+16
Change-Id: I200080ff1c44544fdb8211e58228fd62465f3732 Reviewed-on: https://gerrit.libreoffice.org/78020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23loplugin:returnconstval in saxNoel Grandin1-1/+1
Change-Id: Icf5c337164b71aab10dd960815eee516822c276c Reviewed-on: https://gerrit.libreoffice.org/77990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 12:44:29 +0000