summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2015-09-03loplugin:stringconstant also for cases using char const v[] = "..."Stephan Bergmann3-12/+12
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann7-40/+40
Change-Id: Ifb6cc6d604d1a2b87491f2e455e65c94a5431095
2015-08-31Fix tdf#93438 Impress generate abnormal style when copy-pastingMark Hung1-0/+4
from Writer with Chinese UI. When user configure UI language as Chinese, style names are also translated. However when Copy-pasting from Writer to Impress ( select RTF fromat with paste-special), Chinese (unicode) style names are borken into multiparts, where some of them are empty string. Neither deleting the abnormal style nor saving the file can be achieved. The only remedy is to remove style with emtpy name with macro. With this patch: 1) Catch NoSuchElementException and ignores it, so user still has chance saving file. 2) Make sure style has valid number before inserting it. 3) Prevent text breaking into multiple tokens by handling ucN in ScanText(). Change-Id: I417f70b81c23ac63c175cc13c548068873d13a38 Reviewed-on: https://gerrit.libreoffice.org/18148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-29o3tl/cow_wrapper: remove boost dependencyDaniel Robertson1-0/+1
Remove boost dependencies from ::o3tl::cow_wrapper, and add the necessary includes to files including checked_delete and noncopyable that do not already include the necessary files. Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686 Reviewed-on: https://gerrit.libreoffice.org/18125 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-27xmloff: ODF export: actually ODF 1.2 does not allow graphic-propertiesMichael Stahl3-8/+24
... in a style with family "paragraph", as detected by a --with-export-validation build due to the unit test added yesterday. So use the loext namespace for the style:graphic-properties element, and also omit it entirely (and rely on the style:paragraph-properties attributes fo:background-*) if the ODF version is set to 1.2 or 1.1. Also adapt a previous check that was missing the "drawing-page" style family, where the style:graphic-properties is allowed (commit 9746dc9ad62e7f3a39961733f2ac204e90289034) (regression from 7d9bb549d498d6beed2c4050c402d09643febdfa) Change-Id: Iedd66483f63020328bd61e1c1e19c62787b8ff6b
2015-08-27Clean up sEmptyURLStephan Bergmann1-3/+1
Change-Id: I63e2f5055a87593708f672341b5849554b4db6fb
2015-08-27Clean up sEmptyStephan Bergmann20-58/+40
Change-Id: If1b2bfe308caa2bce92e73d2c5c86ee273faed93
2015-08-27Clean up aEmptyStephan Bergmann1-3/+2
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
2015-08-26ODF import: workaround dubious draw:fill="solid" on frame stylesMichael Stahl2-2/+16
Since the gradient frame backgrounds were added in LO 4.1, we export this: fo:background-color="transparent" draw:fill="solid" Which doesn't make a whole lot of sense as this is really a "none" fill, and now with the backward compatibility stuff in the style import code we get the pool default color added when setting the BackTransparent property, and with the draw:fill="solid" it becomes visible and the background color is now Sky Blue 1. So try to detect draw:fill="solid" without draw:fill-color attribute and contradicting transparent legacy attribute and nerf it. This way we also export draw:fill="none" again, although still with a bogus draw:fill-color but that shouldn't cause any harm. Change-Id: I1c2bea46ba7d9a3f042b875df0ca12c7f6037909
2015-08-26Clean up aEmptyStrStephan Bergmann1-5/+3
Change-Id: I5befe9deac917a28e80ed193b67ff29b5ba35149
2015-08-19comphelper: reduce copypasta with UniquePtrValueLess functorMichael Stahl1-18/+7
Change-Id: Ib93b818eeebc2f370535d1b061beabf7e8c65257
2015-08-19comphelper: remove unnecessary include <stack>Michael Stahl1-0/+1
Change-Id: I39295d69dd8a48f0f40275830cb6fda4ca0b69f3
2015-08-12cppcheck: variableScopeCaolán McNamara1-1/+1
Change-Id: If24e86a0bdc0c5bdce02bed9981232070b38393c
2015-08-12cppcheck: redundantAssignmentCaolán McNamara1-3/+1
Change-Id: I0dcbe0d2afe3741c146027569a906b19abdfdc06
2015-08-12cppcheck: silence redundantAssignmentCaolán McNamara1-1/+1
Change-Id: If1080d99357b45486739120b9ba43c0f14f39ea8
2015-08-11loplugin: defaultparamsNoel Grandin11-30/+26
Change-Id: I7989a91d8d67a15d3fef13391c5dbf06233f75e9
2015-08-07stupid warningMichael Stahl1-1/+1
Change-Id: I1ec30be94ebfc7449a1bd946a73a52eafbe67264
2015-08-07xmloff: replace boost::ptr_set with std::set<std::unique_ptr>Michael Stahl3-49/+57
boost::ptr_set was actually quite nice here, pity about the obnoxious warnings... Change-Id: I46973635fd26e4f1db96f2806c211b83436bef5e
2015-08-07xmloff: replace boost::ptr_set with std::set<std::unqiue_ptr>Michael Stahl2-36/+45
Change-Id: Iaacebe5d88ad8b124f0891f5a7763b9868a6022a
2015-08-07xmloff: replace boost::ptr_set with std::mapMichael Stahl1-42/+20
Change-Id: Ib4effa78cba72954c21ebadf0c5286b2d5207b4f
2015-08-07xmloff: replace boost::ptr_set with std::setMichael Stahl1-11/+15
Change-Id: Idc03bf695d94f47f2057629b4175c2bdf3a83f22
2015-08-05improve refcounting loplugin to check SvRef-based classesNoel Grandin7-26/+27
Change-Id: I2b3c8eedabeaecd8dcae9fe69c951353a5686883 Reviewed-on: https://gerrit.libreoffice.org/17521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05loplugin:unusedmethodsNoel Grandin2-9/+0
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03inline some use-once typedefsNoel Grandin6-30/+21
Change-Id: I02cbbba56a2ad83e0ac3d806265a7e0d6a29594d Reviewed-on: https://gerrit.libreoffice.org/17495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03new loplugin: refcountingNoel Grandin1-2/+2
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-26Resolves: tdf#91950 optional entries may not be presentCaolán McNamara1-18/+25
here we appear to check if the preceding optional entries are of certain types. Presumably if they are optional then its legal for them not to exist at all, just that if they are there they should be in the right order. Change-Id: Id147b91d7d375d7985d901cda112c7757dc3fb19 Reviewed-on: https://gerrit.libreoffice.org/17336 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-19Fix typosAndrea Gelmini2-2/+2
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-17formatting of public/private/protected section qualifiersNoel Grandin1-1/+1
make it consistent across the codebase, no space between keyword and the colon Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5 Reviewed-on: https://gerrit.libreoffice.org/17148 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann2-2/+2
Change-Id: I06df26c474689126f80236866bd547332e293969
2015-07-15xmloff: ODF import: fix spelling of "extrusion-first-light-level"Andrea Gelmini1-1/+1
The attribute is not imported currently due to the typo, but is exported with the correct spelling from shapeexport.cxx:4377 with XML_EXTRUSION_FIRST_LIGHT_LEVEL. Change-Id: I83d77e7eabbbc961fa4f7faf8e20b47601ba071b Reviewed-on: https://gerrit.libreoffice.org/16641 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-15xmloff: document that AOO 4.1 has fixed the svg:d 'z' relative bugMichael Stahl1-2/+2
Change-Id: I0f62101b7bc9de2281ade3eaaa0a38b16f4ccede
2015-07-15-Werror,-Wunused-private-fieldStephan Bergmann4-15/+0
Change-Id: I7dc6c1db75d38d0fe5ee333d4f6a8697abf59e4b
2015-07-15WaE: 'HAVE_FEATURE_GLTF' is not defined, evaluates to 0Tor Lillqvist1-0/+2
Change-Id: I8fec50dcd380fd6bb77672a898c107483298c027
2015-07-15fix Android buildNoel Grandin1-0/+4
I removed the method in commit a62129aa632c2d574a6560efc19f9de84aed1670 "loplugin:unusedmethods xmloff" Change-Id: I0e543b4b9b572f843f68023396d9344c455c2bc1
2015-07-15loplugin:unusedmethods xmloffNoel Grandin20-96/+0
Change-Id: I9d15d8edcc6746c055336bf31e5b0c15cb971ffe Reviewed-on: https://gerrit.libreoffice.org/17061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann8-55/+16
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13tdf#90133 Comply attributes name with OASIS#3860Laurent Balland-Poirier3-12/+12
See https://issues.oasis-open.org/browse/OFFICE-3860 Change-Id: I707b2e86633bc66df03dba8c43879aa6d5153062 Reviewed-on: https://gerrit.libreoffice.org/16905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-07-13use the DBL_MAX constant that we also use elsewhere, tdf#92457Eike Rathke1-2/+1
Change-Id: Ibc48d12ca6b8eb33b2be29f485aa906c513f0591
2015-07-11write trailing text subformat also to Excel .xls and .xlsx, tdf#92457Eike Rathke1-3/+1
... without generating 0;;;@ from 0;@ that has different semantics. Introduce css::util::NumberFormat::EMPTY to properly flag empty subformats and distinguish from UNDEFINED, everything else would be an ugly hack. SvNumberformat::GetMappedFormatstring() now correctly supports the trailing text subformat, so exports using it should get that automatically. Change-Id: If9a1bcc5ec5dfcf46688035e2b1428ab4747a68d
2015-07-11store trailing text format in ODF, e.g. 0;@ tdf#92457Eike Rathke1-20/+51
A clumsy kludge, but since there is no "all others" condition.. Change-Id: Ie89b786585fdee6688f66f5a7af47ec84409eefa
2015-07-11the last condition is "all other numbers", not the third, tdf#92457Eike Rathke1-3/+3
Change-Id: Ic9571d938c4a8837c5712bafbfb2ebf9f32011df
2015-07-10do not include boost/utility.hppMichael Stahl1-1/+1
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-08Avoid loplugin:staticmethods in non-debug buildStephan Bergmann1-0/+2
Change-Id: I9f98e86556ed4435d24f49b32b848eb9f9a66008
2015-07-08Fix typosAndrea Gelmini1-1/+1
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-03Fix typosAndrea Gelmini16-18/+18
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe Reviewed-on: https://gerrit.libreoffice.org/16713 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-30coverity#1308431 wiggle code to see if this silences coverityCaolán McNamara1-2/+4
Change-Id: I44eae735b710332d87f2f642911e988c796457cd
2015-06-30Fix typosAndrea Gelmini2-2/+2
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28Fix typosAndrea Gelmini2-2/+2
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-27coverity#1308433 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I32750eebbcd5a54d3767d77f4f4b8c54c0888078