summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2014-09-23loplugin: cstylecast, update PTR_CAST macro to use static_castNoel Grandin4-12/+12
I introduce a template method into the PTR_CAST machinery to maintain constness. There is now a FIXME in sd/../docshell.cxx because I needed to use a dynamic_cast there to work around the games it appears to be playing with OLE in-place activation. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler1-1/+1
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-15xmloff: sal_Bool -> boolStephan Bergmann6-11/+11
Change-Id: Ic1e599568ece7e6bba354845a6cf85fa090e67bd
2014-09-12xmloff: remove yet another SunStudio workaroundMichael Stahl1-8/+1
Change-Id: Ic9ec167d921c4c5f08914476bdbdd6a31a9391c1
2014-09-11Avoid ODR-violating name clashStephan Bergmann1-0/+4
Change-Id: I69c3b11b01d520a485b07c8e5397a7f971210af2
2014-09-11Avoid ODR-violating name clashStephan Bergmann2-0/+8
Change-Id: I4911dcb5d902a5b92d4c175054acd220e449459d
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza18-21/+2
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-20xmloff: dead code gives MSVC fitsMichael Stahl1-30/+0
Change-Id: I1aaaaae4a38fb828e6801e444b6345fd8b60f5c1
2014-08-20ODF export: don't write invalid "group-name" attributeMichael Stahl2-6/+4
Radio buttons are grouped via their "form:name" attribute already. Change-Id: I9f8b27a2904d947c3d4665495d36961e3e41d2c6
2014-08-16prevent invalid ods files with loext:fill-characterMarkus Mohrhard2-4/+5
ODF specifies that extension elements in a document are removed before the validation. With our old implementation of the number format export this could result in two number:text elements following each other. According to the spec a number:text element may not follow another number:text element. The number:text element before loext:fill is actually not that interesting so it makes more sense to make this one an extension element. Possible documents showing issues: fdo45268-1.xlsx fdo49150-1.xlsx and many more Change-Id: I3ad92b8a61a246b3dbc0132d9a2c367488a766d0
2014-08-16just use a typedef, don't inherit from boost::ptr_containerMarkus Mohrhard1-2/+0
Change-Id: I1a63802dfeb702f6f6e9506339fd299b98fd8604
2014-08-13update_pchThomas Arnhold1-0/+1
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-12fdo#82165: ODF import: clear all shapes when removing header contentMichael Stahl1-2/+11
Shapes anchored to the first or last paragraph survive setString("") so need to be deleted with some ruse. (regression from b8499fc3dcf474050f026b8d5cd1d9037bbe42b7) Change-Id: I00a8132583c45d1953c207932cc7f02f3065ae77
2014-08-11-Werror,-Wundefined-bool-conversionStephan Bergmann22-40/+40
Change-Id: Icf4a55f7e76a723014a7b8b5f6b9350db7370dd9
2014-08-07fdo#75757: remove inheritance to std::mapTakeshi Abe1-7/+10
Change-Id: I2fd0b43c62c331d866d697c94dd57d17f903111b Reviewed-on: https://gerrit.libreoffice.org/10810 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-05fdo#75757: remove inheritance to std::vectorTakeshi Abe5-15/+5
typedefs just work. Change-Id: Ib91c0d4c383b5efac1ad9b93e574dec62e8234a4 Reviewed-on: https://gerrit.libreoffice.org/10754 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-05fdo#75757: remove inheritance to std::vectorTakeshi Abe1-2/+0
Typedef'ing SvxXMLListStyle_Impl is enough. Change-Id: I281766822aea60794510c959581f0b821aea6642 Reviewed-on: https://gerrit.libreoffice.org/10729 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-31cleanup usage of MapUnit enumNoel Grandin1-4/+4
some places were using the wrong enum constant, and some places were unnnecessarily converting to sal_Int16 Change-Id: I754993533c840cd33106820d99af2dc951f26a80
2014-07-31fix some dodgy FieldUnit conversionsNoel Grandin2-2/+8
the FieldUnit enum was being converted in some dodgy ways and in some places the MapUnit enum values were being used. Change-Id: Ic9aacb84058d1c14c3a4a79ef6676082df9a7270
2014-07-29Fix previous commitStephan Bergmann1-1/+1
Change-Id: Ia6437852a5ecd208510af20915bc982d1014458d
2014-07-29loplugin:stringconcatStephan Bergmann1-1/+1
Change-Id: Iaa5df366118b8766b47e7bd4e9875c44c0e5d8d9
2014-07-29Further OUString cleanup in xmloff/Joren De Cuyper5-181/+105
Change-Id: Ic749119931db569bf26c8d8a58da7d468811f927 Reviewed-on: https://gerrit.libreoffice.org/10598 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-26bnc#885825: Handle ODF import and export of data label border properties.Kohei Yoshida3-0/+32
Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139
2014-07-25Simplify.Kohei Yoshida1-5/+2
Change-Id: Id7826839a6177532bb4c3885e798ac5feb95eaca
2014-07-25Reduce scope levels.Kohei Yoshida1-172/+172
Change-Id: I64684a80c79c3c7f5a8f23b07703fbcee3fe5887
2014-07-25pImplize XMLPropertyHandlerFactory.Kohei Yoshida3-6/+23
Change-Id: Iff524c9065e9374b39db998e3860704555130995
2014-07-25Store the handler as a const pointer.Kohei Yoshida1-3/+3
Handlers are conceptually stateless; we can keep them as const objects. Change-Id: I3d35ab0695037632e82f67f901c9795adf9bdd8d
2014-07-25The 'mutable' keyword exists for this kind of use.Kohei Yoshida1-3/+1
Change-Id: Ic52192f53039b7f1b4529a93c13de74c5f54e7f8
2014-07-25Document what's in the type of the map entry.Kohei Yoshida2-2/+2
And organize xmltypes.hxx a bit to make it easier to follow. Also rename MID_FLAG_PROPERTY_MAY_EXCEPT to MID_FLAG_PROPERTY_MAY_THROW. Change-Id: If18f07159a613555cf031bea5e07c04c7c45abec
2014-07-25Apply pimpl to XMLPropertySetMapper.Kohei Yoshida26-48/+197
Let's hide its implementation for real this time. Change-Id: I18c82f4969f2e3560536a68e9bbd86b9282e2ace
2014-07-23Resolves: #i125289# do apply possible changed <GraphicStreamURL>...Oliver-Rainer Wittmann1-13/+19
only for embedded images which already have its stream inside the package fixes also issue 125290 (cherry picked from commit 9602a121b458e7456fc533dad86f434f846a72ba) Conflicts: xmloff/source/draw/shapeexport2.cxx Change-Id: I5af0093b20f2f291d3a94c690bfbdb59a59320c3
2014-07-20cppcheck: Prefer prefix ++/-- operatorsJulien Nabet1-3/+3
Change-Id: If9fa06958c4ebb45a5d4acf3b2994dd3b79f81bf
2014-07-10fdo#79358: ODF export: fix index boolean property exportMichael Stahl1-1/+1
Due to inverted conditional, only the default values were exported, not the non-default ones... (regression from 8a81f542a6ca566661305c53899b7e422cbaa432) Change-Id: I0b1fc828230695709db49e1643801842d947403c
2014-07-08use SimpleReferenceObject in xmloff moduleNoel Grandin3-27/+3
to replace hand-rolled version Change-Id: I36d4ce14d0c0c8a4b224a240c6e25c8df99b78aa
2014-07-03coverity#704112 Unchecked return valueCaolán McNamara1-8/+10
Change-Id: Ic1147662012426126c1cfcf7cb496a3d03cab794
2014-07-03coverity#736024 help coverity out hereCaolán McNamara1-3/+5
Change-Id: Ia89ed6792bbe84eb20a4b560b0dab4557ad6e8f9
2014-07-03coverity#1223084 Unchecked return valueNorbert Thiebaud1-4/+3
Change-Id: I1573d14412b9e01fe7382796275b83405a3bb994
2014-07-02fix ODF validation errorsMarkus Mohrhard8-9/+18
Introduced by 7d9bb549d498d6beed2c4050c402d09643febdfa Change-Id: I09411486b93a031a0c405579d34d9e744b8002a7
2014-07-02drop UniReference in favour of rtl::ReferenceNoel Grandin82-267/+225
since they're doing the same thing. Change-Id: I76134b6b848db8628f315fe5bd9eb972a6bf0cb6
2014-07-02coverity#705353 Missing break in switch, probably intentionalCaolán McNamara1-0/+1
Change-Id: I17d22443f24de5b4bf5c259e38912abc2c14ab94
2014-07-01-Werror,-Wtautological-constant-out-of-range-compareStephan Bergmann1-1/+1
Looks like 7d9bb549d498d6beed2c4050c402d09643febdfa "Related: #i124638# Second step of DrawingLayer FillAttributes..." accidentally garbled this. Change-Id: I4cdaad4fdebb8b9947e79afbec4a6e0973c55cac
2014-07-01Resolves: #i125045# For XMLPropertyMapper using TEXT_PROP_MAP_SHAPE_PARA...Armin Le Grand2-28/+34
hide the DrawingLayer FillStyle entries by moving them to the front of aXMLParaPropMap and using a higher index for construction (cherry picked from commit 35f3ceaf60f109f45aa7fef7077aead398bed53f) Change-Id: I8244e4dc685a2aa35e4154a43455ff62c8ee58fe
2014-07-01Related: #i124638# Second step of DrawingLayer FillAttributes...Armin Le Grand15-445/+1196
for Writer objects, now added support for Paragraph and PageStyle (including Header and Footer) for direct attributes and style attributes (cherry picked from commit cc25c58f7052827bfebdc9fbeec668c8fa29ed1b) Conflicts: cui/source/factory/dlgfact.cxx cui/source/factory/dlgfact.hxx cui/source/inc/bbdlg.hxx cui/source/inc/cuires.hrc cui/source/tabpages/bbdlg.cxx cui/source/tabpages/bbdlg.src cui/source/tabpages/page.cxx cui/source/tabpages/tparea.cxx include/svx/pagectrl.hxx include/svx/svxdlg.hxx include/svx/svxids.hrc include/xmloff/PageMasterStyleMap.hxx include/xmloff/prstylei.hxx include/xmloff/txtprmap.hxx svx/Package_inc.mk svx/inc/svx/hdft.hxx svx/source/dialog/hdft.cxx svx/source/dialog/pagectrl.cxx svx/source/tbxctrls/tbxcolorupdate.cxx svx/source/unodraw/unobrushitemhelper.cxx sw/Library_sw.mk sw/inc/fillattributes.hxx sw/inc/format.hxx sw/inc/frmatr.hxx sw/inc/frmfmt.hxx sw/inc/hintids.hxx sw/inc/hints.hxx sw/inc/ndtxt.hxx sw/inc/node.hxx sw/inc/swunohelper.hxx sw/inc/unobrushitemhelper.hxx sw/inc/unoprnms.hxx sw/source/core/attr/format.cxx sw/source/core/attr/hints.cxx sw/source/core/doc/docdesc.cxx sw/source/core/doc/docdraw.cxx sw/source/core/doc/docfmt.cxx sw/source/core/doc/docnew.cxx sw/source/core/doc/docredln.cxx sw/source/core/doc/poolfmt.cxx sw/source/core/doc/visiturl.cxx sw/source/core/docnode/node.cxx sw/source/core/inc/frame.hxx sw/source/core/inc/frmtool.hxx sw/source/core/inc/rolbck.hxx sw/source/core/layout/atrfrm.cxx sw/source/core/layout/fillattributes.cxx sw/source/core/layout/findfrm.cxx sw/source/core/layout/paintfrm.cxx sw/source/core/txtnode/ndtxt.cxx sw/source/core/txtnode/thints.cxx sw/source/core/txtnode/txtedt.cxx sw/source/core/undo/rolbck.cxx sw/source/core/unocore/swunohelper.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unomap.cxx sw/source/core/unocore/unoparagraph.cxx sw/source/core/unocore/unoprnms.cxx sw/source/core/unocore/unostyle.cxx sw/source/ui/chrdlg/paradlg.src sw/source/ui/chrdlg/pardlg.cxx sw/source/ui/fmtui/tmpdlg.cxx sw/source/ui/fmtui/tmpdlg.src sw/source/uibase/app/docst.cxx sw/source/uibase/app/docstyle.cxx sw/source/uibase/frmdlg/colex.cxx sw/source/uibase/shells/basesh.cxx sw/source/uibase/shells/textsh1.cxx sw/source/uibase/uiview/viewstat.cxx sw/source/uibase/utlui/uitool.cxx xmloff/inc/PageMasterImportContext.hxx xmloff/inc/xmloff/XMLShapeStyleContext.hxx xmloff/source/draw/XMLShapeStyleContext.cxx xmloff/source/draw/sdpropls.hxx xmloff/source/style/PageMasterExportPropMapper.cxx xmloff/source/style/PageMasterImportContext.cxx xmloff/source/style/PageMasterPropHdlFactory.cxx xmloff/source/style/PageMasterStyleMap.cxx xmloff/source/style/prstylei.cxx xmloff/source/text/txtexppr.cxx xmloff/source/text/txtprhdl.cxx xmloff/source/text/txtprmap.cxx xmloff/source/text/txtstyli.cxx Conflicts: svx/source/dialog/hdft.cxx sw/source/core/doc/visiturl.cxx sw/source/core/txtnode/thints.cxx sw/source/core/txtnode/txtatr2.cxx sw/source/core/unocore/unostyle.cxx Change-Id: I7e8779db6c0cbd1e242b63eab888f468f2de509a
2014-06-29Typo: beeing->beingJulien Nabet3-4/+4
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-28fdo#80009: xmloff: ignore excessive fo:clip valuesMichael Stahl1-0/+7
These cause problems in drawinglayer, and nobody needs a 5km clip. Change-Id: Ic485250413194adbcd0ccf855f12e89e532d7120
2014-06-27loplugin:unreffun: also warn about redundant redeclarationsStephan Bergmann4-49/+0
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27tweak assert so comment appears in abort messageCaolán McNamara1-2/+1
Change-Id: Ibf78e5cd1620f0b61cae030e3870be4a6f87e71d
2014-06-25fixes for up-casting to Reference<XInterface>Noel Grandin1-1/+1
Fix regressions introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking Reference constructor to reduce code noise" Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-24new compilerplugin returnbyrefNoel Grandin1-14/+14
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-21Create SvtSaveOptions() outside of for loop.Matúš Kukan1-1/+1
Helps to save few cycles. Change-Id: Iea908bd84fa1201f05ec698f8de51ea78d841eb6