summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2020-04-29Convert TokenContext to fastparser APIsNoel Grandin21-469/+236
Change-Id: Ib40e2f3d37c52b03f2ecbd67aaeed9605e644fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93163 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-29simplify handling of comparing XML_NAMESPACE valuesNoel Grandin4-11/+11
Change-Id: I18bbf1ee206285842250891ce556d523489855b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-28move the castToFastAttributeList functionNoel Grandin14-64/+26
to the slightly higher namespace, to make it easy and more readable to use directly in a for-loop-range expression. And make it return a reference rather than a pointer, since it is never allowed to be nullptr. Change-Id: I15d0b32493ef65cfc601b247c272b318f1eadfd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann54-6/+67
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-26update pchesCaolán McNamara2-2/+5
Change-Id: I83a61da7dda6c72552eecd377f1c3744c92a797e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25tdf#129898 Use layer DrawnInSlideshow in edit modeRegina Henschel1-0/+9
If 'Mouse pointer as pen' is set in slideshow settings, painting in slideshow becomes persistent. A layer DrawnInSlideshow is created for that purpose during slideshow. But that layer was not known to the view from where the slideshow was started. Generating a layer had been done regardless whether such layer already exists or not. That had produced several layers with identical name. That may not happen, because layers are identified by name. Change-Id: I2ba9bad5babe5a1bba3d1fc69d028d9037d2bd47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92502 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-04-25make FastParser always take a FastTokenHandlerBase subclassNoel Grandin2-4/+2
since most of the call sites already do, and we can skip the slow path this way. Change-Id: I64ed30c51324e0510818f42ef838f97c401bb6dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90326 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-25loplugin:unusedenumconstantsNoel Grandin2-102/+0
Change-Id: If2473097c1c8e66e09238061da9d186d4c8e3d9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92871 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-24xmloff: create SchXMLExport_Styles instances with an uno constructorMiklos Vajna4-20/+7
See tdf#74608 for motivation. Change-Id: Ib15016bf08323936818bd9a26049772d3d6922c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92824 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-22Fix typosAndrea Gelmini1-1/+1
Change-Id: I49d7dc8a2cbcba5413d05d97559321e672ed413a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92655 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen5-0/+5
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-22uiobject.hxx only needs forward declaresCaolán McNamara1-3/+3
and update pches accordingly Change-Id: I411712532fd85961bffe6678416fcdc1d9c7f53d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-17loplugin:buriedassign in tools..xmloffNoel Grandin2-4/+6
Change-Id: I31df6c4fd82c6f6d15bbe5228e92e5171cacba51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-17tdf#131979 Chart ODF import-export of Link to source formatBalazs Varga2-0/+24
setting also into data point styles, fixing lost numbering style of custom data points. (Only export into the data series style was supported previously.) Also fix tdf#131115 - FILEOPEN: Incorrect format of single data label Regression from commit: e57d90cd4e51a1353eafc87bb29cfe6076704a7c (tdf#129173 tdf#129175 Fix number format of data labels) Data point styles in older ODF files do not contain the 'link-data-style-to-source' property, so they used the data series style property during the import previously. Now we set the default false value, if the data point style contains a 'data-style-name' (number format). Change-Id: I4786e62ca75770ed632463bcf1275ece7ea793f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91967 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-17xmloff: create SchXMLExport (flat OOoXML) instances with an uno constructorMiklos Vajna4-21/+11
See tdf#74608 for motivation. Change-Id: I67138b848411d91172ceec7af6826841b017cfdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92390 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-15xmloff: turn this warning into an infoMiklos Vajna1-1/+1
<vmiklos> noelgrandin: is there some way i can silence this "warn:xmloff.core:30241:30241:xmloff/source/core/xmlimp.cxx:739: SvXMLImport::startElement: missing context for element draw:color" warning? i get it 120 times when i do a hello-world odg->pdf conversion :) <noelgrandin> vmiklos, hmmm. I think just turn it off for now. Change-Id: Ib1fcb1a20d51547536a8c5cce0dc16547d34f325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92273 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-11tdf#131931 No version history shownNoel Grandin1-3/+9
regression from commit 1872b44c9a2ee2bd00be54c6c310b72579d7a47f use FastParser for the XMLVersionListImport Change-Id: Ib6e9e14758c25c6ff090fe8f929984449e045c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-09tdf#127792 implement UNO chart attribute MajorOriginTünde Tóth5-26/+49
based on the specification in OFFICE-3936 for ODF 1.4: https://issues.oasis-open.org/browse/OFFICE-3936 Note: import of the embedded chart of the DOCX unit test document uses also ODF format in the background, testing also the extension of the native file format. Follow-up of commit 830e539547c463b932ce643517f880789185032d (tdf#127393 OOXML chart import: fix X axis position setting "CrossBetween"). See also commits with "ShiftedCategoryPosition" in their descriptions. Change-Id: I9cd278ac0172c0fab7c51d585a65c34a0ad60b82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90081 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-09tdf#131966: chart legend attribs width and height unknown for ODF 1.2 (strict)Julien Nabet1-1/+3
Change-Id: Ie4cb7d2c9e5fb7bca88287fcaff03d5c9ca04b8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91942 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-09xmloff: create SchXMLExport_Oasis_Content instances with an uno constructorMiklos Vajna4-27/+10
See tdf#74608 for motivation. Change-Id: I8b485f7e991ce64b8beebffe1ccd3d1e7a083f78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91937 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-06loplugin:unusedvariableplus in xmloffNoel Grandin5-9/+1
Change-Id: I4acc297acb4327249a452a0318964b75e02d38de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-03xmloff: create SchXMLExport_Oasis_Styles instances with an uno constructorMiklos Vajna4-20/+8
See tdf#74608 for motivation. Change-Id: I9eb2702650c94ec064c5403015513efee1e1fe1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91601 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-02loplugin:unusedmethodsNoel Grandin2-25/+0
Change-Id: I906234a38b96c6ba6eaadf7693abd33e98debf50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29tdf#131632 animation effects are missing featuresNoel Grandin3-0/+5
regression from commit 5352d45dd4a04f8f02cf7f6ad4169126d3b3586a Date: Tue Feb 18 15:45:08 2020 +0200 convert AnimationImport to fast-parser APIs Change-Id: I7227b122213c877b8ea5db25239eae8151597a8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-28Fix is_typed_flags for SCAFlagsJulien Nabet1-1/+1
Since: https://cgit.freedesktop.org/libreoffice/core/commit/?id=0c2d51e0daf2ce5e18af915ec40ec3196db8ab88 author Noel Grandin <noel@peralex.com> 2016-05-12 14:32:30 +0200 committer Noel Grandin <noel@peralex.com> 2016-05-12 14:33:35 +0200 commit 0c2d51e0daf2ce5e18af915ec40ec3196db8ab88 (patch) tree 720d61287f718a66747e31a156b0c98eb2d3e24e parent aba06d6f8d69632559ca9a74320fcd048855a3a3 (diff) Convert SCA flags to scoped enum Change-Id: I7bb5b33819cada9410e725d0c45cc7ea10fde1a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen9-15/+0
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-20xmloff: create SchXMLExport_Oasis_Meta instances with an uno constructorMiklos Vajna4-19/+8
See tdf#74608 for motivation. Change-Id: I7881850e264f421e72389cd51ad1e38e625fb334 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90766 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-18Avoid -Werror=unused-but-set-variableStephan Bergmann1-1/+1
...in --enable-debug --enable-werror --disable-assert-always-abort builds like <https://ci.libreoffice.org//job/lo_tb_random_config_linux/2279/>: > /lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux/xmloff/source/core/xmltoken.cxx:3368:18: error: variable ‘foundDuplicate’ set but not used [-Werror=unused-but-set-variable] > 3368 | bool foundDuplicate = false; > | ^~~~~~~~~~~~~~ Change-Id: If9d433082de84c433132276e171ba5c42c24b61c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90699 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-16Revert "loplugin:constfields in xmloff"Noel Grandin78-205/+205
This reverts commit 0302c9b192c3b7ba10daabed61d6864c24c14070. Change-Id: Ib919429e22ad039d6a82fe081f4e5421fe08905d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-16Avoid -Werror=maybe-uninitializedStephan Bergmann1-4/+3
...as seen at least with GCC 10 trunk and --enable-optimized, when bMirroredX/Y were used without checking that reading them with >>= had succeeded. Assuming that in this code (added with b4a6977e05d87fe0a79b266ec30e4f403404f1b4 "tdf#129532 tdf#98839 fixes for mirror of custom shapes") it cannot be guaranteed that rItem.Value is of the right type (so o3tl::forceAccess, which uses assert to verify the right type, would not be appropriate), but that it is an exception-worthy error if rItem.Value is not of the right type (so o3tl::doAccess, which throws a css::uno::RuntimeException upon a wrong type, is appropriate). Change-Id: Ibe6991d69a1d6a0c2c41c839c240050a6355e98b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90337 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi2-4/+4
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-13xmloff: create SchXMLExport_Oasis instances with an uno constructorMiklos Vajna4-24/+13
See tdf#74608 for motivation. Change-Id: Ia4fed34fe8b5e89d2e70950f2939941c96bb5f65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90445 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-10use FastParser in DrawAnnotationContextNoel Grandin3-57/+134
Change-Id: I4228a5ccbd738d2e51473ded511cf4bfd2b6617d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09use FastParser in XMLAnimationsContextNoel Grandin3-138/+128
Change-Id: Ib6c99e7aa9d2797a04b9590c69008f6895f13780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90217 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09StartElement/EndElement in SdXMLGenericPageContext are superfluous nowNoel Grandin2-12/+0
after commit 2176aed0e3a79bd457ad3678490262dae9ea1361 (HEAD -> master) Date: Mon Mar 9 10:09:48 2020 +0200 convert SdXMLGenericPageContext to fastparser Change-Id: I5b1b8dff1a667e4e916b6625a1fca2d0a6b9b9c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09improve loplugin:unusedfieldsNoel Grandin6-28/+18
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09convert SdXMLGenericPageContext to fastparserNoel Grandin7-233/+83
Change-Id: I225fcd104252a32715259b85614298d8a2ffd110 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-07clang-format xmloff with under 5-percent lines of changeMuhammet Kara12-20/+20
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: Ia2b85f00fc182798176d0af686b37f0df59ecb3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90151 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-06loplugin:unusedmethodsNoel Grandin3-55/+0
Change-Id: I698981490eb1391930cdd06821a80a5f770e000e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06xmloff: create SchXMLImport_Content instances with an uno constructorMiklos Vajna4-27/+12
See tdf#74608 for motivation. Change-Id: I27826e04adbf8ae22c0ce026413c58eb1c6d7db8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90067 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-06use more FastParser in ScXMLContentValidationContextNoel Grandin1-0/+5
Change-Id: I958d2ad1a8dc6c2a3da1c1a4fc6bd4f0011367fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05tdf#75330 chart: implement ODF import/export of legend overlay featureTünde Tóth4-11/+40
Follow-up of commit 9fab1ba8ddc59924c633aa17c65f7330a4762726 (tdf#75330 add a new overlay/no-overlay feature for the legend). Change-Id: I7781fd8b926d4add56f3db0d56dceab8e27e5f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89836 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-04ofz#21045 Invalid-enum-valueCaolán McNamara1-1/+1
runtime error: load of value 65535, which is not a valid value for type 'enum LineNumberingToken' Change-Id: I432ba6f46838b499c690f717216b61b127dc2dda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-03tdf#101181 Implement glow effect on shapesTamas Bunth4-0/+17
Glow effect is a color-blurred outline outside of the shape. In ooxml document it is specified with the <a:glow> element. The commit contains the following: - Add support for importing and exporting <a:glow> from ooxml documents. - Assign new properties to XShape which stores glow-related attributes. - A new 2D primitive is introduced in module 'drawinglayer' which is responsible for representing the glow primitive which is to be rendered. + A glow primitive is a clone of the original shape which has been scaled up slightly and a new color has been assigned to it. The radius of the glow effect and the color is defined in the <a:glow> element being imported. - A blur algorithm is introduced in module 'vcl', which is called during rendering the primitive. + The blur algorithm works on a bitmap. + Since the algorithm is CPU-intensive, the result is cached in the processor and it is recalculated only if needed. - Add support for importing and exporting glow effect to ODF format. For that, new attributes of element <style:graphic-properties> has been added: + loext:glow, which can have the values "visible" or "hidden" + loext:glow-radius: which holds the radius of the glow effect in cm. + loext:glow-color: holds the color of the glow effect - Tests have been added to assert properties after pptx import and export. Change-Id: I836aeb5e0f24e2c8d5725834c8c0f98083bc82e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89125 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2020-03-03move some headers inside their moduleNoel Grandin3-2/+31
Change-Id: I026f920d475c4ce56a12d6b29a702673e8bd7a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02don't rely on parser ::characters callback only firing onceNoel Grandin5-103/+84
which is true for the old parser, but not always so for the FastParser. So pre-emptively fix some stuff Change-Id: I405834f1dfd28c98cae87b6de38d238f723edafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89712 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-01use the SetAttribute override in SvXMLStyleContext subclasses consistentlyNoel Grandin7-130/+80
Change-Id: Ibdbf73c5e54fbbb051e4898fd8b3a7a155647b15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89702 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-29tdf#130955 chart export: fix repeated custom labelsBalazs Varga1-2/+0
Do not add mCustomLabelText to aDataPointVector when we write leading empty data points, it is enough to add them, when we write data-point with style. Note: this fixes also DOCX import, when the embedded charts are imported by using ODF export in the background. Regression from commit: 7d2c7e7af04d9604d86d2d605ef95b9abb10966c (tdf#123206 Store custom label as chart:data-label) Change-Id: Ib3b370236323a57ac6800035d71321f7ee5dbe41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89504 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-29tdf#130878 Report does not show label-fieldsNoel Grandin1-0/+2
The critical part was (1) calling m_pFixedContent->Characters instead of m_pFixedContent->characters in OXMLCharContent (2) calling OXMLReportElementBase::EndElement instead of OXMLReportElementBase::endFastElement in OXMLFixedContent Also (3) add a bunch of debugging logging to help find this (4) fix various characters() methods that can no longer rely on being called once for text content in a node Change-Id: Ib8ea88c5ff377311ca70e4292cad6d1f7f7c7323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-29reduce some pointer chasingNoel Grandin1-11/+12
can usd std::optional here Change-Id: I613131a00d64b7a226fe5b0d0f47a7db6ba41599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89713 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-25 04:28:24 +0000