summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2017-12-13Related: tdf#71737: allows links in more indexesCaolán McNamara3-15/+2
tables, objects and user-defined Change-Id: I081446832ee86453227f4838552c88fd9e5cf75f Reviewed-on: https://gerrit.libreoffice.org/46326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-12Related tdf#83877 Add signatureline element to draw:frame, not draw:imageSamuel Mehrbrodt1-1/+1
Because a frame can have multiple (fallback) images, so this would have been added only to the first one. Change-Id: I1c41c5e6fd3959fb5cfb5afb5d4fe98b2e5e3c73 Reviewed-on: https://gerrit.libreoffice.org/46243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-11loplugin:salcall fix functionsNoel Grandin14-212/+212
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08tdf#71737 xmloff: ODF 1.2 doesn't allow hyperlinks in ...Michael Stahl2-2/+24
... text:illustration-index-entry-template, so store these elements only in ODF 1.2 extended, and in loext namespace. Change-Id: Icf919e91114f5c9aed2adc3f5359b9df61eb3433 Reviewed-on: https://gerrit.libreoffice.org/46088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-08tdf#71737: save allows links in illustration index, but load doesn'tCaolán McNamara3-1/+14
since illustration index links were initially implemented by commit 2c10d784deb86501b5488044a61d9fc2efc6321a Date: Tue Jul 16 15:49:44 2013 +0200 fdo#39904, n#825976: implement hyperlinks for Illustrations index (cherry picked from commit 8bb2c7f1556c10508c8ac451c579539ccf5dacfb) Change-Id: I679fb9c40cd5dc55a5d546ef7c533faf9de2e483 Reviewed-on: https://gerrit.libreoffice.org/45967 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-12-05Bin a typedef used just onceTor Lillqvist1-2/+1
Change-Id: I8591b1d872a729402ea6045d2a17dc691fa66788 Reviewed-on: https://gerrit.libreoffice.org/45841 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin2-2/+2
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04tdf#83877 ODF extension to write signature linesSamuel Mehrbrodt1-0/+48
This adds a <loext:signatureline> element to draw:image if the image is a signatureline. Example: <draw:image xlink:href="..."> <loext:signatureline loext:id="..." loext:suggested-signer-name="..." loext:suggested-signer-title="..." loext:suggested-signer-email="..." loext:signing-instructions="..." loext:show-sign-date="true" loext:can-add-comment="false"/> </draw:image> Change-Id: I4d77acec528175fba66556661ab74462f5bd875f Reviewed-on: https://gerrit.libreoffice.org/45153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-04Related tdf#113696 Write fallback graphic for fodf files alsoSamuel Mehrbrodt1-7/+12
Change-Id: I2db10b6a3bf14837160a56813681ba40fa253447 Reviewed-on: https://gerrit.libreoffice.org/45777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-03Use for-range loops in xmlexppr (xmloff)Julien Nabet1-32/+19
Change-Id: I65b20b98082db6cd2bda17f527f7ade7a1123a97 Reviewed-on: https://gerrit.libreoffice.org/45743 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-03Replace list by vector in SchXMLExport (xmloff)Julien Nabet1-10/+10
Change-Id: I279c878891fccddacdc5b8154173105250f39a05 Reviewed-on: https://gerrit.libreoffice.org/45726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-02Replace list by vector in property_description (xmloff)Julien Nabet1-2/+1
Change-Id: I1290e559f17eb1efbfec09419b4e5283263497fb Reviewed-on: https://gerrit.libreoffice.org/45725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-02Replace list by vector in xmlexp (xmloff/sw)Julien Nabet1-9/+6
Use for-range loop with "auto" to modernize a bit Change-Id: I9efd7ad2d60eac6a6ce0f79af6ccb02ec235c35d Reviewed-on: https://gerrit.libreoffice.org/45711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-02Replace list by vector in XMLEventImportHelper (xmloff)Julien Nabet2-8/+8
Change-Id: I5c8ac0a1cad628bd80550d7d0f5cec46d0f66dae Reviewed-on: https://gerrit.libreoffice.org/45724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-02Replace list by vector in DocumentSettingsContext (xmloff)Julien Nabet1-26/+14
Use for-range loops with "auto" to modernize a bit use return of back() instead of retrieving the reverse iterator Change-Id: Ia1236ec19940a30591c3793516a77e686eee6d01 Reviewed-on: https://gerrit.libreoffice.org/45710 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-01tdf#113696 Add mimetype also to fallback graphicSamuel Mehrbrodt1-0/+8
Change-Id: I6eb7bb66aa688b5668d0eacd2ec7131bec2b6955 Reviewed-on: https://gerrit.libreoffice.org/45585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01Use isEmpty() instead of getLength()Samuel Mehrbrodt1-1/+1
Change-Id: I2b67c3eebea09d8bebe045ca98341e3347b08fc7 Reviewed-on: https://gerrit.libreoffice.org/45569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01tdf#113696 Write replacement graphic also to flat odfSamuel Mehrbrodt1-5/+4
Not only to zipped ODF Change-Id: Ic86656aea31c9fc20862628cdd31698b9904e999 Reviewed-on: https://gerrit.libreoffice.org/45568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-30xmloff: turn SvXMLImportContext into a no-op base classMichael Stahl12-28/+28
Fix the non-obvious and potentially dangerous recursion that is implicit in xmloff's context code. SvXMLImportContext::CreateChildContext() now always creates a SvXMLImportContext, does not delegate to SvXMLImport. Rename CreateContext to CreateDocumentContext, to make its purpose of creating only the top-level context more obvious. With the previous changes to CreateContext overrides in sw, reportdesign and dbaccess, this hopefully shouldn't break anything. Change-Id: I9e147bf6297bbac9e8470454881da73f6e39db0a
2017-11-30tdf#113696 Add mimetype to image elementSamuel Mehrbrodt3-21/+30
Otherwise browsers don't recognize base64 encoded svg files. Change-Id: I54d0b87c52a1ca9da1d820751ae32159b88ed28f Reviewed-on: https://gerrit.libreoffice.org/45528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28ODF export: expose font style and weight of embedded fontsMiklos Vajna1-8/+62
We don't need this info ourselves, but when converting the flat ODF output to other formats, this information is hard to find out, so state them explicitly. Names correspond to existing CSS ones, where it's necessary to state these explicitly. The EPUB export will make use of these attributes. (It is unclear why the test fails on the windows_msc_dbgutil_32 slave, it works for me locally.) Change-Id: I05030b6a14aca842e5a740786f3743e9ae838293 Reviewed-on: https://gerrit.libreoffice.org/45384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-28tdf#109202: Convert images to desired format in (f)odt filterKatarina Behrens2-2/+15
Pass down mimetype to SvXMLGraphicHelper Change-Id: I9c81c06d2a1d6168704440094081e99d0bcbbff9 Reviewed-on: https://gerrit.libreoffice.org/41893 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin3-4/+4
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-26No need to test seriesStyle.m_xOldAPISeries n times (xmloff/chart)Julien Nabet1-4/+4
so move it out from the inner loop Change-Id: I367dc428b10ff4554b63ee3cdabfe65ddfb61ea7 Reviewed-on: https://gerrit.libreoffice.org/45291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-26Modernize by using for-range loops (xmloff/chart)Julien Nabet2-108/+80
Change-Id: I505ac79e76738ce39d1768451e7c213246eec88d Reviewed-on: https://gerrit.libreoffice.org/45289 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-26Replace some lists by vectors in xmloffJulien Nabet8-65/+66
Change-Id: Ib321b4716ee95507b9d51ad8320bc7eb7cf35c93 Reviewed-on: https://gerrit.libreoffice.org/45284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-24loplugin:countusersofdefaultparams in sw (1)Noel Grandin2-2/+3
Change-Id: I0d14f9c375f93079aef21ca4f1132adc4e1fe06c Reviewed-on: https://gerrit.libreoffice.org/45207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23xmloff: Drop non-existent XMLTextPropertyHandlerFactory_ImplTakeshi Abe1-3/+0
Change-Id: I9cef470e0592e1b90d2cc0f2830c60938daf873e Reviewed-on: https://gerrit.libreoffice.org/45126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin1-1/+1
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann3-4/+4
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22xmloff: These arrays are constantTakeshi Abe4-7/+7
Change-Id: I834e23610facb8b4b35f0a377e33b744e7725d1f Reviewed-on: https://gerrit.libreoffice.org/45066 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Fix typosAndrea Gelmini1-1/+1
Change-Id: I40b3a46d46f0586d086bdbe41876c088f8c1cb58 Reviewed-on: https://gerrit.libreoffice.org/45007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin3-6/+6
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-16Replace some lists by vectors (xmloff)Julien Nabet3-21/+15
Change-Id: Ide0270ae0b6a17d7c48c0a9ff7901145e00dca6b Reviewed-on: https://gerrit.libreoffice.org/44792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-15loplugin:flatten in xmloffNoel Grandin17-1853/+1880
Change-Id: I782278b8a633094b96788f81ae7066a45d45b5fe Reviewed-on: https://gerrit.libreoffice.org/44750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-13Fix typosAndrea Gelmini1-1/+1
Change-Id: I2a10e087a776ac96b3193226610577227d2492a8 Reviewed-on: https://gerrit.libreoffice.org/44655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-13Fix typosAndrea Gelmini1-1/+1
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-09rename AvoidConfig to FuzzingCaolán McNamara1-1/+1
cause that's what its really used for and a couple of cases are not specifically about avoiding config but avoiding uninteresting disk acccess and what not Change-Id: I4c6454f98388579fcd0bf9798321d30408ab65ee Reviewed-on: https://gerrit.libreoffice.org/44491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-06tdf#112547 element p to draw:object, import expects it thereRegina Henschel1-8/+7
There exists no documents produced by LibreOffice, where text on OLE objects has worked, because import expects the paragraphs inside the draw:object element, but LO has written them outside. The patch changes LO to write the paragraphs inside the draw:object element. The patch does not enable LibreOffice to read the paragraphs in old documents. But versions at least since 5.1 will be able to read text on OLE objects from documents which were produced by versions with applied patch. Change-Id: I879135f1a869e46c32361db653ede05227bab95e Reviewed-on: https://gerrit.libreoffice.org/43696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-11-05ofz#4057 Integer-overflowCaolán McNamara1-2/+4
Change-Id: I6a7ef3ca4c26ce4965deeea27ae47a03169bcf12 Reviewed-on: https://gerrit.libreoffice.org/44320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-04loplugin:constparams in various(1)Noel Grandin1-2/+2
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b Reviewed-on: https://gerrit.libreoffice.org/44261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31loplugin:constantparam in sal,saxNoel Grandin9-12/+11
Change-Id: I7ca2fd05d1cf61f9038c529a853e72fedb1c9ed0 Reviewed-on: https://gerrit.libreoffice.org/44087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30related: tdf#103884 remove gltf/collada featureThorsten Behrens3-149/+0
Change-Id: Icd26ad96c0337844ef1463dabfbe791caa00dd2d Reviewed-on: https://gerrit.libreoffice.org/43972 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-30ofz#3895 Integer-overflowCaolán McNamara1-2/+5
Change-Id: Ibc90bdad5edf2d382e358dde4a0bfce6e4276584 Reviewed-on: https://gerrit.libreoffice.org/44026 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-28tdf#113367 Change namespace from svg to draw for attr transformRegina Henschel2-2/+2
The new feature of rotating images in Writer first time triggers the export of the attribute transform. So now it becomes visible, that it has the wrong namespace, see ODF 19.228 part 1. Change-Id: I00d5e6a12bd564e814679e8be862c7d08baae956 Reviewed-on: https://gerrit.libreoffice.org/43890 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-27ODP: export TextPreRotateAngleSzymon Kłos3-1/+4
Change-Id: I13eb005195ebbdee5016bf279cba423e388723a0 Reviewed-on: https://gerrit.libreoffice.org/43910 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-26tdf#77961 regard layout-grid-print as off when missing.Mark Hung1-0/+3
Change-Id: I8404ebed8ba84ee83528310ee63f796356674553 Reviewed-on: https://gerrit.libreoffice.org/43830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-10-26More loplugin:unnecessaryparenStephan Bergmann1-1/+1
81892b2037453108b9bde1512a500cf3b2ce438a "loplugin:unnecessaryparen when compiling as C++17, so the ParenExpr is no longer hidden behind ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in loplugin:unnecessaryparen. However, that would still not look through implicit CXXConstructExpr, so would still not have found the occurrences in 81892b2037453108b9bde1512a500cf3b2ce438a when compiling in pre-C++17 mode. Therefore, let ignoreAllImplicit also look through CXXConstructExpr. (I am not entirely sure in which situations non-implicit CXXConstructExpr---that should thus not be ignored---would occur, but assume they would be underneath something like a CXXFunctionalCastExpr, which is not ignored.) Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843
2017-10-25no matching overload foundCaolán McNamara1-4/+4
Change-Id: I0e1d28c6ee3e95a28e4b66c49de75fcbf9ca65fe
2017-10-25ofz#3786 Integer-overflowCaolán McNamara1-8/+9
Change-Id: I2f9b404ad5529842b40439e24e35aa5ab9b69531 Reviewed-on: https://gerrit.libreoffice.org/43840 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 08:30:38 +0000