summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2015-10-15cppcheck:variableScopeNoel Grandin1-15/+12
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884 Reviewed-on: https://gerrit.libreoffice.org/19364 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-13coverity#1326118 Constant expression resultCaolán McNamara1-1/+1
Change-Id: I3a5786650e0724f6b6015153df7275851471626c
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann258-1229/+1229
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-09xmloff: fix ODF import of gradient draw:angle attribute a bitMichael Stahl2-9/+8
ODF 1.2 part 3, 18.3.1 angle, says "An angle, as defined in §4.1 of [SVG]" and "If no unit identifier is specified, the value is assumed to be in degrees." Unfortunately OOo could only read and write 10th of degree here. See also https://issues.oasis-open.org/browse/OFFICE-3774 As the first step towards fixing that, implement the import for draw:angle values with an angle unit identifier, but leave the import as-is if the angle identifier is missing. Change-Id: Ib88d417c03998ebcfc569b01492f0e1f851bbc85
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-50/+18
Change-Id: Ia381f1b7558e2882a9dc5b8f6e127d24a4b841c3
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-1/+0
Change-Id: I58f6f4db6f5bdc30402f55aee233e465248becf6
2015-10-07tdf#88154 workaround and unit testMarco Cecchetti3-0/+9
Fixed 45-degree layout for axis labels, too. Change-Id: I9764e281aeee0a439fa9eec1e3b0df840221b72f Reviewed-on: https://gerrit.libreoffice.org/18889 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-10-07tdf#90839: follow-up workMarco Cecchetti2-2/+0
- Removed the data-label-wrap token and related code in xmloff module. - Using the already present `fo:wrap-option` seems to be the preferred solution: investigated to see how the token is imported exported: the class `XMLWordWrapPropertyHdl` takes care of that, luckily it converts the token to a boolean property. - Fixed a minor issue in the code for the data label dialog. Change-Id: Id050fdfeedd3af7fb79be96bfe157c61c4b44191 Reviewed-on: https://gerrit.libreoffice.org/19197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-10-06loplugin:mergeclassesNoel Grandin6-80/+5
Change-Id: I592eef7503bd0b492f73ea5216f436302ad79ca8
2015-10-02should be safe to remove this pieceCaolán McNamara2-7/+0
Change-Id: Ic1c5be7794ff374c32a3c727d6233f69ea38c7aa
2015-10-02make CppunitTest_sw_ww8export work againCaolán McNamara4-0/+89
revert xmloff portion of commit 35e68754ec3cff30c5cdb665688a9b13f29dd439 Author: Noel Grandin <noel@peralex.com> Date: Thu Oct 1 15:10:56 2015 +0200 loplugin:unusedmethods Change-Id: I3d6f1300f4fae2af9e580d1d3b2c2c80fa9e9268 Reviewed-on: https://gerrit.libreoffice.org/19075 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Change-Id: I24aa3f113a77d93c789b063b3c099bf2038e1dad
2015-10-02loplugin:unusedmethodsNoel Grandin4-89/+0
Change-Id: I3d6f1300f4fae2af9e580d1d3b2c2c80fa9e9268 Reviewed-on: https://gerrit.libreoffice.org/19075 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01coverity#1325246 Unchecked dynamic_castCaolán McNamara1-6/+4
Change-Id: Ifa8f9ce23c9c737d7bed9e24c9c32641d915ac76
2015-10-01coverity#1325247 Unchecked dynamic_castCaolán McNamara1-6/+5
Change-Id: I86e3387c277767018565ed0708d35682ba2de3ae
2015-10-01coverity#1325248 Unchecked dynamic_castCaolán McNamara1-4/+4
Change-Id: Iff328c85e859cae2d99f95c3c56ba3585638dd23
2015-10-01coverity#1325249 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: I5789d62424fd01705b64a111dbd121b15d89a3d9
2015-10-01coverity#1325252 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: I70b4c9f705d3da294e3b93f2834db5add9198ec9
2015-10-01coverity#1325253 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: I7151f641ce87fa7ca11af4f0cef6594edb925f91
2015-10-01coverity#1325254 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: I75f9f4cb4f32ae1836e1e6287fa5fce1aa83bdf5
2015-10-01remove old standalone Sun bug numbersNoel Grandin22-37/+0
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-29Fix typosAndrea Gelmini9-9/+9
Change-Id: If2e4adb2ce93c02ee14d831eedf4ef31da04b92d Reviewed-on: https://gerrit.libreoffice.org/18996 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-09-29Fix typosAndrea Gelmini5-5/+5
Change-Id: I2cdfc4e9d8ba1acb7c2548f9394d320c6504207e Reviewed-on: https://gerrit.libreoffice.org/18997 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann1-4/+4
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin1-1/+0
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29tdf#94559: first step to remove rtti.hxxOliver Specht15-56/+56
replaced use of PTR_CAST, IS_TYPE, ISA in avmedia, basctl, basic, cui, dbaccess, vcl,xmloff Change-Id: If4496762e82e896b6fbc362e6626502703c245f5 Reviewed-on: https://gerrit.libreoffice.org/18905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-29Nobody would go down the corridor anymoreMiklos Vajna4-7/+7
Change-Id: Ic2cb2c4d9534d503828308183d55cea5b8d88112
2015-09-20WaE: rewrite as call of rtl::OUString::isEmptyTor Lillqvist1-1/+1
Change-Id: I0dc1a59eaeefd1a55640b94a00142b0fe6696523
2015-09-20chained editeng: Add Chaining-related UNO attributematteocam3-1/+28
Definition and mechanisms for UNO API. Change-Id: I7fd3969804ca9b04881ced0b1e43ab6236cbefcc
2015-09-18boost->stdCaolán McNamara1-1/+0
Change-Id: Ib5132c5623ef5adba28eabeb9ca67f8952a0f56c Reviewed-on: https://gerrit.libreoffice.org/18676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17revert for mac and win unit case crashes after boost->stdCaolán McNamara1-0/+1
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17boost->stdCaolán McNamara1-1/+0
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-09-16boost->stdCaolán McNamara5-17/+15
Change-Id: Ic18be8b86727dd1179a7e39c70493d088ed00557
2015-09-14tdf#92586 xmloff: fix import of stretched background imageMiklos Vajna6-2/+43
The bug document has: <style:page-layout-properties ... style:repeat="no-repeat"> <style:background-image ... style:repeat="stretch"/> </style:page-layout-properties> When a stretched background image is set on a page style using the Writer UI, then these two style:repeat attributes always match, but not in the bugdoc. The later used to have priority, till commit 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02). Fix the problem by extending XMLBackgroundImageContext::EndElement(): if we know that the <style:page-layout-properties> sets the FillBitmapMode property, then don't blindly set BackGraphicLocation, but try to overwrite the exiting FillBitmapMode one. Change-Id: I64ab4363b20cc95003d35acd63ea421472b1c071
2015-09-11xmloff: tdf#88206 replace cppu::WeakImplHelper*Takeshi Abe16-27/+25
with the variadic variants. Change-Id: I47002abab1e025d0683f4cf8ef7b6c99e668d425 Reviewed-on: https://gerrit.libreoffice.org/18479 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-09tdf#90839: support for wrapped text in data labels and for centered data valueMarco Cecchetti3-1/+2
Now in a pie chart the text of a label can be wrapped, the wrapping is automatic and the maximum text width is fixed to almost half the pie radius. This feature is used to import correctly the relative text wrapping property provided by MSO. Moreover the data value and percent value of a label are now centered horizontally, respect with the label text. Conflicts: chart2/qa/extras/xshape/chart2xshape.cxx Change-Id: Ie10d6184365436f763cd9693a5bbefcfa9b3862b Reviewed-on: https://gerrit.libreoffice.org/17193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-09-08clang-analyzer-deadcode.DeadStoresStephan Bergmann1-1/+0
...ever since 4b3df269f81184c4951457daa5181df2bcc5d259 "INTEGRATION: CWS sb19: #i32429# ExplodeFieldMasterName should not try to copy non-existent string parts" Change-Id: Idf642d1c9c5516ad9c837c4cb9d397dc7e3f5e39
2015-09-08clang-analyzer-deadcode.DeadStoresStephan Bergmann1-4/+2
...ever since its inception with e9ec6f67bf4aa0d7474e54b5f55ca71671356a48 "#i110617# avoid changes on copy from calc to writer" Change-Id: I9e26f92f4f50fe728efa7d0ac2ba873a227623ea
2015-09-03loplugin:stringconstant also for cases using char const v[] = "..."Stephan Bergmann3-12/+12
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann7-40/+40
Change-Id: Ifb6cc6d604d1a2b87491f2e455e65c94a5431095
2015-08-31Fix tdf#93438 Impress generate abnormal style when copy-pastingMark Hung1-0/+4
from Writer with Chinese UI. When user configure UI language as Chinese, style names are also translated. However when Copy-pasting from Writer to Impress ( select RTF fromat with paste-special), Chinese (unicode) style names are borken into multiparts, where some of them are empty string. Neither deleting the abnormal style nor saving the file can be achieved. The only remedy is to remove style with emtpy name with macro. With this patch: 1) Catch NoSuchElementException and ignores it, so user still has chance saving file. 2) Make sure style has valid number before inserting it. 3) Prevent text breaking into multiple tokens by handling ucN in ScanText(). Change-Id: I417f70b81c23ac63c175cc13c548068873d13a38 Reviewed-on: https://gerrit.libreoffice.org/18148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-29o3tl/cow_wrapper: remove boost dependencyDaniel Robertson1-0/+1
Remove boost dependencies from ::o3tl::cow_wrapper, and add the necessary includes to files including checked_delete and noncopyable that do not already include the necessary files. Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686 Reviewed-on: https://gerrit.libreoffice.org/18125 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-27xmloff: ODF export: actually ODF 1.2 does not allow graphic-propertiesMichael Stahl3-8/+24
... in a style with family "paragraph", as detected by a --with-export-validation build due to the unit test added yesterday. So use the loext namespace for the style:graphic-properties element, and also omit it entirely (and rely on the style:paragraph-properties attributes fo:background-*) if the ODF version is set to 1.2 or 1.1. Also adapt a previous check that was missing the "drawing-page" style family, where the style:graphic-properties is allowed (commit 9746dc9ad62e7f3a39961733f2ac204e90289034) (regression from 7d9bb549d498d6beed2c4050c402d09643febdfa) Change-Id: Iedd66483f63020328bd61e1c1e19c62787b8ff6b
2015-08-27Clean up sEmptyURLStephan Bergmann1-3/+1
Change-Id: I63e2f5055a87593708f672341b5849554b4db6fb
2015-08-27Clean up sEmptyStephan Bergmann20-58/+40
Change-Id: If1b2bfe308caa2bce92e73d2c5c86ee273faed93
2015-08-27Clean up aEmptyStephan Bergmann1-3/+2
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
2015-08-26ODF import: workaround dubious draw:fill="solid" on frame stylesMichael Stahl2-2/+16
Since the gradient frame backgrounds were added in LO 4.1, we export this: fo:background-color="transparent" draw:fill="solid" Which doesn't make a whole lot of sense as this is really a "none" fill, and now with the backward compatibility stuff in the style import code we get the pool default color added when setting the BackTransparent property, and with the draw:fill="solid" it becomes visible and the background color is now Sky Blue 1. So try to detect draw:fill="solid" without draw:fill-color attribute and contradicting transparent legacy attribute and nerf it. This way we also export draw:fill="none" again, although still with a bogus draw:fill-color but that shouldn't cause any harm. Change-Id: I1c2bea46ba7d9a3f042b875df0ca12c7f6037909
2015-08-26Clean up aEmptyStrStephan Bergmann1-5/+3
Change-Id: I5befe9deac917a28e80ed193b67ff29b5ba35149
2015-08-19comphelper: reduce copypasta with UniquePtrValueLess functorMichael Stahl1-18/+7
Change-Id: Ib93b818eeebc2f370535d1b061beabf7e8c65257
2015-08-19comphelper: remove unnecessary include <stack>Michael Stahl1-0/+1
Change-Id: I39295d69dd8a48f0f40275830cb6fda4ca0b69f3
2015-08-12cppcheck: variableScopeCaolán McNamara1-1/+1
Change-Id: If24e86a0bdc0c5bdce02bed9981232070b38393c
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 22:53:00 +0000