summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2015-02-26cppcheck: redundantAssignmentCaolán McNamara1-14/+3
Change-Id: Iee0fcb8e2b91a6554bedc7e3989c0585a1679a61
2015-02-25remove NUMBERFORMAT_ constantsNoel Grandin2-32/+32
.. in favour of just using the underlying constants from css::util::NumberFormat Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
2015-02-18Change var name: propertie->propertyStateJulien Nabet1-129/+129
Change-Id: I85397752e2660088b378d8ec71765a4167f5183a
2015-02-18Missing includeStephan Bergmann1-0/+4
Change-Id: I067a83ef97e55afc27673c59b0bdae974d7f3232
2015-02-17boost->stdCaolán McNamara8-77/+77
Change-Id: I8371b942d915f777a29ca01cd0aed674db0ca853
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara3-265/+250
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-10cppcheck: cstyleCastCaolán McNamara2-3/+3
Change-Id: I0b5caeac629527112e3c7129b274b076da467d8d
2015-02-10cppcheck: variableScopeCaolán McNamara1-2/+4
Change-Id: I8a2262e6e27f0ea5f43837d5a10cb23525fe6ca5
2015-02-09xmloff: replace legacy DBG_WARNINGsMichael Stahl7-13/+9
Change-Id: I79f20f67e623b8d9607374e8be9a78fa10dc9af6
2015-02-09OFormsRootImport::CreateChildContext: survive a missing css.form.FormsMiklos Vajna1-1/+9
At least moz406390-1.odt has an unreferenced (so uninteresting in practice) <form:form> block. Till there is a real benefit of it, better not add form/database components to the Android component list but teach the user of such code to fail gracefully. Change-Id: I165a09fefa887da7b78a917c43ecc17d8f0ba3e2
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage3-7/+6
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-05Revert "ODF export: don't write invalid "group-name" attribute"Lionel Elie Mamane2-4/+6
This reverts commit 2d4b87f0c1bfd97185a89c18d5b7680d11a958d6. The reverted commit leads to the following regressions: - Basic dialogs (which were not targeted, but impacted, by the reverted commit) with several RadioButtons sharing a group-name (as they will have a tendency to do) cannot be loaded anymore, since the implementation assumes (and checks) that names are unique. - Even in forms, where a RadioButton had both a form:name and a form:group-name attribute, the form:name attribute wins and thus RadioButtons that has the same group-name but different form:name (as they will tend to do) will not anymore be mutually exclusive, which defeats their point. Additionally, since it did not change the UI parts (property editor window), the user was still presented with two different editable properties "Name" and "Group Name", where "Group Name" was empty... Change-Id: I1bff532a5a7336cf2eb0579bcd4e2d16be6480fe
2015-02-05Revert "xmloff: dead code gives MSVC fits"Lionel Elie Mamane1-0/+30
This reverts commit 29e1b2f1ca6e2dcbf9a04c63a3ac1d554cfdcb52 in preparation for reverting 2d4b87f0c1bfd97185a89c18d5b7680d11a958d6
2015-02-05Updated all precompiled headers.Ashod Nakashian2-1/+7
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-03xmloff: write character borders in the extension namespace for nowMiklos Vajna1-38/+68
Change-Id: Ia112cf626126149ea9cf09c5d6ff812d5d5ffec5
2015-02-01Resolves: #i114416# use default service name for scroll bar...Tsutomu Uchino2-0/+7
if failed to detect the control-implementation (cherry picked from commit 23e16b91ad69a123e795d63f2d4862d94412d582) Conflicts: xmloff/source/forms/elementimport.cxx xmloff/source/forms/elementimport.hxx Change-Id: I0ab4f9ff909ceba18a74d38488f6d0bdb3126110
2015-01-28Use vector::dataStephan Bergmann1-2/+1
...in some places where it is obvious that it does not hurt that for an empty vector the obtained pointer is not necessarily a nullptr. Change-Id: Id5d66b1559ca8b8955d379bcdbfae6986ef46a51
2015-01-28remove unused typedefsNoel Grandin2-3/+0
found with some minor modifications to find/find-unused-defines.sh Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd Reviewed-on: https://gerrit.libreoffice.org/14194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-26Visible function type RTTI for Clang -fsanitize=functionStephan Bergmann5-0/+5
...by adding some further SAL_DLLPUBLIC_RTTI type annotations (cf. b4f6b26b5a1a78fecfa95ec2eb7ac8b80495d8aa "SAL_DLLPUBLIC_RTTI for proper RTTI visibility for LLVM") and by making sure relevant function types do not use incomplete types in their parameter and return types (which would make the RTTI hidden). Change-Id: Id7aadcbc0704b9759968ae36266fc9ce11a2e340
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin4-16/+16
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-23fix 64-bit build after OUStringBuffer changeMichael Stahl2-3/+3
Change-Id: I6c5295110292ae48ff0cb3472e4dbea287645d2a
2015-01-23sal: try to avoid abuse of OUStringBuffer(int) ctorMichael Stahl1-1/+1
... to avoid bugs like commit f0d6e0e1e21afd0adf5bd01d771b2d83d8f13a48. Change-Id: I1e41d421609e09bf62a7a04ba34f3a8e8d118fd3
2015-01-20Some more loplugin:cstylecast: xmloffStephan Bergmann1-1/+1
Change-Id: I45cb9467c618eed929c84656a26293c8d6087378
2015-01-19fdo#39440 reduce scope of local variablesMichael Weghorn7-12/+10
This addresses some cppcheck warnings. Change-Id: If7ad3584b3124ed0b337836071af1a5bd0451d85 Reviewed-on: https://gerrit.libreoffice.org/13972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-11LeakSanitizer: leak detected in ooo56669-1.odtCaolán McNamara1-2/+2
Change-Id: Ifdd98068762762316dbfd50fb465ed3c970f53d9
2015-01-09xmloff_uxmloff fails on Linux too, now -> disable it (mergelibs)Matúš Kukan1-1/+1
Would be nicer to fix it though. Change-Id: Ia5f49a69374e9e79a9a16542bc44f279b9e5a6f7
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl4-4/+4
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-08Revert "Don't assume that the ZOrder property of shapes is an enumeration"David Tardon3-21/+12
This reverts commit 66c7dbbf7dfba8cfab63f8d1df72ace87e5bf7ca. See https://gerrit.libreoffice.org/#/c/13554/ . Conflicts: include/xmloff/shapeexport.hxx reportdesign/source/filter/xml/xmlExport.cxx sc/source/filter/xml/xmlexprt.cxx xmloff/source/draw/shapeexport.cxx Change-Id: I14fed9ad043a756a9e2d390c76fa907c349c3a2e
2015-01-06fdo#78921 save embedded fonts in Flat ODFDavid Tardon1-3/+43
Change-Id: I9d8614a5c20bab8e3b3d7c40e2504348c4386b64
2015-01-06fdo#84938: convert SEF_EXPORT_ #defines to 'enum class'Noel Grandin2-68/+68
Change-Id: I7165d0f1b6b4af4de5e5b39a21f36d726a1b0e30
2015-01-06fdo#84938: convert ERROR_ #defines to 'enum class'Noel Grandin2-15/+15
Change-Id: Ie76bac6b91a9faa4f9ff7dbdf2b455ea9016cf72
2015-01-06fdo#84938: convert EXPORT_ #defines to 'enum class'Noel Grandin20-133/+133
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
2015-01-06fdo#84938: convert XML_EXPORT_FLAG_ to 'enum class'Noel Grandin13-24/+24
Change-Id: I43d778e0eee19a56ea37898ec1c4309d3407775e
2015-01-06fdo#84938: convert IMPORT_ constants to 'enum class'Noel Grandin9-37/+37
Change-Id: Idaa8f07c62b3ba93c27ca5fe286720254baac10d
2015-01-06fdo#84938: convert TEXT_PROP_MAP #defines to 'enum class'Noel Grandin5-40/+40
Change-Id: Ia8c5913c60e3d509a906965d813c8d1380396dc6
2015-01-05export format of embedded font tooDavid Tardon1-0/+4
Change-Id: Ife7dbb298861a71987501f3847d3b931c7e83715
2015-01-05read embedded fonts from Flat ODFDavid Tardon2-3/+32
Change-Id: Ic94608f4afac9d8ac05ec3140d195b0526e9420a
2015-01-02Fix simple typos.Andrea Gelmini1-3/+3
Change-Id: I1fdbe47ed7a6e05d2cf20f4c296bffad4bbc6599 Reviewed-on: https://gerrit.libreoffice.org/13719 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara12-27/+26
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-28Revert "Resolves: #i124452# correct svg:viewBox for EnhancedCustomShape..."Andras Timar1-42/+1
This reverts commit c6e316f52021cc26d4c5ec9a7b87a07fbf595b62. The bug #i124452# was in AOO only, no need to fix it in LibreOffice. Especially when the "fix" causes regression. The related fdo#76334 should be fixed one day, but that is a different issue. Conflicts: xmloff/source/draw/ximpcustomshape.cxx Change-Id: Ice0bf378f97e2caf0ee8386d0b5c0b8abcbcd1c2
2014-12-27fdo#84714 ODT import: read <loext:table> inside <draw:custom-shape>Miklos Vajna1-0/+1
A later version of ODF will hopefully allow <table:table> here as well, but read <loext:table> in the meantime. Change-Id: I42a461e0a6e9eff9387379acbab9660a155ecefe
2014-12-20fix buildLionel Elie Mamane1-2/+2
Change-Id: Ia528bd301e2f2ee1f7f3b009e3b9c3f395a4dcdb
2014-12-19correct function name in debug messageLionel Elie Mamane1-1/+1
Change-Id: I9c02fdd99504bdee6654d1072559a4afac6532a3
2014-12-19survive "TextBox" having no valueLionel Elie Mamane1-1/+1
Change-Id: Iebed41cfcc5899387e3defb8d8a0792276349098
2014-12-19Don't assume that the ZOrder property of shapes is an enumerationLionel Elie Mamane3-12/+21
...at least when we can easily not assume it. shapes = shapes of the same XShapes an enumeration = it is the sequence 0, 1, 2, 3, ..., XShapes->getCount()-1 We replace the ZOrder property by the index of the XShape in the XShapes (the same XShapes that is passed to seekShapes()... when that is easy to find. Else, use ZOrder and hope for the best. ZOrders are not always an enumeration. For example, in documents (forms) created by the Base forms wizard, it is not the case. The wrong assumptions was leading to the following bugs in the Base form wizard: - Only the first two controls in the form were successfully saved. The others were just dropped. - Whereas the labels had the proper style (background and text colour) applied while creating the document, these were not saved successfully Change-Id: I15b9a3ef3b16eafa9698332e35d82d51d51627f8
2014-12-19teach XML import/export about unsigned integer typesLionel Elie Mamane2-2/+15
resolves a shitload of warnings like warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:426: OElementImport::implImportGenericProperties: unsupported value type! warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:443: OElementImport::EndElement: could not set the property "ObjIDinMSO"! warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:444: caught an exception! in function:void xmloff::OElementImport::implApplyGenericProperties() type: com.sun.star.lang.IllegalArgumentException Change-Id: Ia598d12e7d9429fe4ad3b1e7173e11e75060a613
2014-12-19two references having same contentLionel Elie Mamane1-5/+4
Change-Id: I2db8842411e39d7d100d0627f8c930bb3f633d77
2014-12-19this is purely informative, SAL_WARN is overkillLionel Elie Mamane1-1/+1
Change-Id: Iccb98e50a678e5c53b69fb1052e3dac83cdcf5f5
2014-12-18xmloff: Use appropriate OUString functions on string constantsStephan Bergmann17-51/+49
Change-Id: I349e0c2575d9a5154ac7002d129a1851a3df7687
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann2-2/+2
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f