Age | Commit message (Collapse) | Author | Files | Lines |
|
...that had inadvertently been removed as part of a larger code removal in
6948c546fdc00dddec7d58e03150dcc87921d6b2 "tdf#75637: Resolve help images via a
vnd.libreoffice.image UCP"
Change-Id: Ic2d5e1a5fa5a10b240bb9e511e6dcb8097e58081
(cherry picked from commit 549e900b4b0047b8cb6c236ea50a3fc046e5fb51)
Reviewed-on: https://gerrit.libreoffice.org/21082
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...which uses the logic already available in VCL's ImplImageTree to locate the
image zip files and find fallbacks for incomplete themes and for localized
images.
(cherry picked from commit 6948c546fdc00dddec7d58e03150dcc87921d6b2, plus
f5174c89cd037d35b975590083cf91b36633808d "...but do not erase localize
attributes from image elements," which is needed to make localized image
references work again)
Conflicts:
vcl/osx/vclnsapp.mm
Change-Id: Ic1c15fcacb6596a27a2b051093232902202bf472
Reviewed-on: https://gerrit.libreoffice.org/19644
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Bin pointless '// predeclarations' or '// forward declarations' comments. If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?
Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.
Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
|
|
Change-Id: I2ee91d07cf9d46cdc385a4db8473550b05e2f0ad
|
|
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
|
|
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
|
|
Change-Id: I08f4e8270061b90b77a976d4ead7462a02fce845
|
|
Change-Id: I5c0e0fbb7ebb3bcb85dee363e77f6f7c47e815d8
|
|
Change-Id: Ie42bd7a48391615ea8f48b24d6bfe2bbebb31a0b
|
|
Change-Id: I88d1d082cc25a185322435a75c94f4c6b4ad12f8
|
|
Change-Id: I035d584af8a802d08dd4e50070b4d290210e20b6
|
|
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
Change-Id: I1aa45f669711a90cce52bafd839bd84eb711436a
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
|
|
Change-Id: I8642ec147cb0dca32dce7ec7f3efec93bcb99cb4
|
|
Change-Id: Id1d5c3cf2f76dbb33606cec1c0f17d4a1f282247
|
|
Change-Id: I28f68ff0c43366b3877244ba272acf967f141e54
|
|
Change-Id: I211d21b09223dfacac18e879993b0f0943b94741
|
|
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
|
|
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
|
|
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
|
|
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I43ed776d52336b822aa6152f0f2a29e39303bb75
|
|
Change-Id: I58cf2391d7bf2480cd12d2b1b4cf73f346f4f95f
|
|
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
|
|
convert places using compareToAscii that should be using equalsAscii
Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
|
|
added header guards for directories basebmp/, chart2/, cppuhelper/,
include/test/, io/test/, sax/test, shell/, writerfilter/, and xmlhelp/
Change-Id: I0e29a9b75c26d71f58aa98986b52f6d3b46015a6
Reviewed-on: https://gerrit.libreoffice.org/9615
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Added header guards to files in directories xml*/*
Change-Id: Ia5dfb9ab494bfbfae7537f2d54ff11331dc8c922
Reviewed-on: https://gerrit.libreoffice.org/9539
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I47582b072bb939cf270a76e430a9f7908b5c1d93
|
|
Change-Id: I6fcece7f7a77060bfa3cd3d40db3fa4f253cf261
|
|
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.
Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
|
|
Change-Id: Ibe0a1006aba2b6cbd87c0bd6ca3acbf9ba7b0fbe
|
|
Change-Id: I82ed4a4868cb22566706ca0f4b1321e0d45016cf
|
|
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
|
|
Change-Id: I0aa1b7023b5100fb855a8a839e44036988d8bc2e
|
|
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
|
|
Change-Id: Ia624a624271b1143c96cd189cc9e4dab4c5ae302
|
|
|
|
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
|
|
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
Change-Id: I806cd7a263dbe37581c8845b4089a76a7d591628
|
|
Change-Id: I1daf6661dd7b5be396bec980da84feaab6e6b80f
|
|
Change-Id: Ie4b0e0923ade427f7ab637e8e76769a6dca957c5
|
|
Change-Id: I92e9bc4bbdf18273d26d666d98401cd83a9b1560
|