summaryrefslogtreecommitdiff
path: root/xmlhelp
AgeCommit message (Collapse)AuthorFilesLines
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl2-2/+5
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-1/+1
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini3-3/+3
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin1-1/+1
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-20loplugin: cstylecastNoel Grandin1-1/+1
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-2/+1
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler2-57/+10
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-11(Rudimentary) C++11 support is a hard requirement nowStephan Bergmann2-8/+1
Change-Id: I43ed776d52336b822aa6152f0f2a29e39303bb75
2014-08-11Resolves: fdo#82025 use strlen instead of stored length byteCaolán McNamara1-6/+9
Change-Id: I58cf2391d7bf2480cd12d2b1b4cf73f346f4f95f
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin2-7/+1
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-04compareToAscii -> equalsAsciiNoel Grandin4-4/+4
convert places using compareToAscii that should be using equalsAscii Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
2014-06-02fdo#68849: Add header guards to all include filesJens Carl1-0/+6
added header guards for directories basebmp/, chart2/, cppuhelper/, include/test/, io/test/, sax/test, shell/, writerfilter/, and xmlhelp/ Change-Id: I0e29a9b75c26d71f58aa98986b52f6d3b46015a6 Reviewed-on: https://gerrit.libreoffice.org/9615 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-29fdo#68849: Add header guards to all include filesJens Carl1-0/+5
Added header guards to files in directories xml*/* Change-Id: Ia5dfb9ab494bfbfae7537f2d54ff11331dc8c922 Reviewed-on: https://gerrit.libreoffice.org/9539 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-27use namespace css instead of com::sunThomas Arnhold1-12/+11
Change-Id: I47582b072bb939cf270a76e430a9f7908b5c1d93
2014-05-24cppcheck: redundantAssignmentThomas Arnhold1-2/+1
Change-Id: I6fcece7f7a77060bfa3cd3d40db3fa4f253cf261
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin2-5/+2
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-13Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part11Julien Nabet2-6/+6
Change-Id: Ibe0a1006aba2b6cbd87c0bd6ca3acbf9ba7b0fbe
2014-05-10Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part9Julien Nabet2-7/+7
Change-Id: I82ed4a4868cb22566706ca0f4b1321e0d45016cf
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin1-1/+1
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-02xmlhelp: sal_Bool->boolNoel Grandin7-13/+13
Change-Id: I0aa1b7023b5100fb855a8a839e44036988d8bc2e
2014-04-19fixincludeguards.sh: some smaller dirsThomas Arnhold18-36/+36
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-15Remove unused codeStephan Bergmann2-4/+0
Change-Id: Ia624a624271b1143c96cd189cc9e4dab4c5ae302
2014-04-14typo: misformed -> malformedThomas Arnhold1-1/+1
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann6-8/+8
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann12-158/+158
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-20de-macroize xmlhelp ContentProviderNorbert Thiebaud2-23/+66
Change-Id: I806cd7a263dbe37581c8845b4089a76a7d591628
2014-03-20kill ucbhelper XTYPEPROVIDER_DECL macroNorbert Thiebaud2-3/+9
Change-Id: I1daf6661dd7b5be396bec980da84feaab6e6b80f
2014-03-20de-macroize xmlhelp tvfactoryNorbert Thiebaud2-66/+4
Change-Id: Ie4b0e0923ade427f7ab637e8e76769a6dca957c5
2014-03-20de-macroize xmlhelp TVBaseNorbert Thiebaud2-69/+6
Change-Id: I92e9bc4bbdf18273d26d666d98401cd83a9b1560
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin1-6/+6
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-05kill XINTERFACE_IMPL_6Norbert Thiebaud1-7/+24
Change-Id: I1445524d3c15a3dec881c1499910779b9d61b840
2014-03-05de-macroize XINTERFACE_DECLNorbert Thiebaud2-2/+12
Change-Id: Iaa1cf999189f6b62547c208eadc38150400ca0fe Reviewed-on: https://gerrit.libreoffice.org/8454 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-04fdo#54938: Convert some places to use cppu::supportsServiceMarcos Paulo de Souza1-6/+3
The last cases are non obvious, so it's pratically done Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547 Reviewed-on: https://gerrit.libreoffice.org/8445 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann15-220/+220
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from xmlhelpAlexander Wilms1-4/+4
Change-Id: Idd4d9d556d6644350d1a14b9f81f5fd0df8ee2d1 Reviewed-on: https://gerrit.libreoffice.org/8344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21coverity#708696 Uninitialized scalar fieldCaolán McNamara1-5/+7
Change-Id: If22c709ebab80d626d3d409fd6ba718781cff07d
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann1-2/+2
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17Remove unnecessary use of OUString constructor in + expressionsNoel Grandin2-18/+16
Convert code like aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp"); to aFilename = OUString::number(nFilePostfixCount) + ".bmp"; Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-06Related: fdo#72022 internal links bustedCaolán McNamara1-1/+1
regression since 58fa3d50aa43102cea8690fd6bf51fb80c007955 Change-Id: I499704d18872da6f2f01cf955a6496104c53dd3f
2013-12-06Resolves: fdo#72022 Integrated help ignored if installedCaolán McNamara1-1/+1
regression since 58fa3d50aa43102cea8690fd6bf51fb80c007955 Change-Id: Ia20f28daace30181652bbbbec3f9845045db03b4
2013-12-02fdo#60698: Merge tvhlp1 into ucpchelp1Marcos Paulo de Souza9-92/+11
tvhlp1 just have 2 files, and this lib is used always with ucpchelp1. By these reasons, we can merge these 2 libs. Change-Id: I515f9c12893c986279ffac91b83879c467b091c7 Reviewed-on: https://gerrit.libreoffice.org/6820 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin5-12/+11
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin4-30/+30
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-13i123670 - Add support for https linksAriel Constenla-Haile1-1/+1
(cherry picked from commit a2afc19e04f8bb3089cbfef34960ad8f0a3b99bf)
2013-11-11xmlhelp: include <> for external includesNorbert Thiebaud6-7/+7
Change-Id: I274968e015f1d0c3d06aa5040f53b72d14c45b9f
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin6-41/+41
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-07remove unnecessary use of OUString constructor in XMLHELP moduleNoel Grandin4-40/+38
Change-Id: I033bcf9cddc58f605fe8d65731f8b312410da7e5
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin1-8/+8
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-10-28gbuild: set Package default target to INSTDIRMichael Stahl1-2/+0
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186