summaryrefslogtreecommitdiff
path: root/xmlhelp
AgeCommit message (Collapse)AuthorFilesLines
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann6-8/+8
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann12-158/+158
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-20de-macroize xmlhelp ContentProviderNorbert Thiebaud2-23/+66
Change-Id: I806cd7a263dbe37581c8845b4089a76a7d591628
2014-03-20kill ucbhelper XTYPEPROVIDER_DECL macroNorbert Thiebaud2-3/+9
Change-Id: I1daf6661dd7b5be396bec980da84feaab6e6b80f
2014-03-20de-macroize xmlhelp tvfactoryNorbert Thiebaud2-66/+4
Change-Id: Ie4b0e0923ade427f7ab637e8e76769a6dca957c5
2014-03-20de-macroize xmlhelp TVBaseNorbert Thiebaud2-69/+6
Change-Id: I92e9bc4bbdf18273d26d666d98401cd83a9b1560
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin1-6/+6
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-05kill XINTERFACE_IMPL_6Norbert Thiebaud1-7/+24
Change-Id: I1445524d3c15a3dec881c1499910779b9d61b840
2014-03-05de-macroize XINTERFACE_DECLNorbert Thiebaud2-2/+12
Change-Id: Iaa1cf999189f6b62547c208eadc38150400ca0fe Reviewed-on: https://gerrit.libreoffice.org/8454 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-04fdo#54938: Convert some places to use cppu::supportsServiceMarcos Paulo de Souza1-6/+3
The last cases are non obvious, so it's pratically done Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547 Reviewed-on: https://gerrit.libreoffice.org/8445 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann15-220/+220
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from xmlhelpAlexander Wilms1-4/+4
Change-Id: Idd4d9d556d6644350d1a14b9f81f5fd0df8ee2d1 Reviewed-on: https://gerrit.libreoffice.org/8344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21coverity#708696 Uninitialized scalar fieldCaolán McNamara1-5/+7
Change-Id: If22c709ebab80d626d3d409fd6ba718781cff07d
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann1-2/+2
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17Remove unnecessary use of OUString constructor in + expressionsNoel Grandin2-18/+16
Convert code like aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp"); to aFilename = OUString::number(nFilePostfixCount) + ".bmp"; Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-06Related: fdo#72022 internal links bustedCaolán McNamara1-1/+1
regression since 58fa3d50aa43102cea8690fd6bf51fb80c007955 Change-Id: I499704d18872da6f2f01cf955a6496104c53dd3f
2013-12-06Resolves: fdo#72022 Integrated help ignored if installedCaolán McNamara1-1/+1
regression since 58fa3d50aa43102cea8690fd6bf51fb80c007955 Change-Id: Ia20f28daace30181652bbbbec3f9845045db03b4
2013-12-02fdo#60698: Merge tvhlp1 into ucpchelp1Marcos Paulo de Souza9-92/+11
tvhlp1 just have 2 files, and this lib is used always with ucpchelp1. By these reasons, we can merge these 2 libs. Change-Id: I515f9c12893c986279ffac91b83879c467b091c7 Reviewed-on: https://gerrit.libreoffice.org/6820 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin5-12/+11
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin4-30/+30
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-13i123670 - Add support for https linksAriel Constenla-Haile1-1/+1
(cherry picked from commit a2afc19e04f8bb3089cbfef34960ad8f0a3b99bf)
2013-11-11xmlhelp: include <> for external includesNorbert Thiebaud6-7/+7
Change-Id: I274968e015f1d0c3d06aa5040f53b72d14c45b9f
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin6-41/+41
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-07remove unnecessary use of OUString constructor in XMLHELP moduleNoel Grandin4-40/+38
Change-Id: I033bcf9cddc58f605fe8d65731f8b312410da7e5
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin1-8/+8
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-10-28gbuild: set Package default target to INSTDIRMichael Stahl1-2/+0
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-24xmlhelp: remove Package_xslMichael Stahl2-19/+0
Change-Id: Id0a5213b39886e2f6929f7ff2c014ed861d1da91
2013-10-24valgrind: on success aHDFData is out of scopeCaolán McNamara1-1/+1
and pData points to data belonging to it Change-Id: I2a3c1f73e4cdcb07d21ef14cb410d351f39cdba8
2013-10-24pEmpty is completely insane to useCaolán McNamara1-4/+2
DbtToStringConverter protects against a NULL pointer, but not a pointer to the too short data that pEmpty provides Change-Id: I5d21e852ce0373eff7d3627e266b9cbc77f5dd09
2013-10-23clean up some include guardsThomas Arnhold1-2/+2
Conflicts: sw/source/ui/inc/content.hxx Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6 Reviewed-on: https://gerrit.libreoffice.org/6388 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-22fdo#54938: Adapt supportsService implementations..Marcos Paulo de Souza1-9/+2
to cppu::supportsService Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14 Reviewed-on: https://gerrit.libreoffice.org/6370 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-16cleanupThomas Arnhold1-2/+1
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
2013-10-03CID#705780 seeing as this is irredeemably wrong remove itCaolán McNamara3-54/+1
This is catastrophically wrong, just appear to be lucky that this code path is never called, so remove it entirely rather than mess around fixing it Change-Id: I4a8a443ed20b7e11cd9cc69b3d66d28087f09db8
2013-09-23Try to fix cross-compilationTor Lillqvist1-1/+1
Add more FOO_FOR_BUILD variables and some gb_Foo_for_build functions. Get rid of gb_INSTROOT and gb_DEVINSTALLROOT, just use INSTROOT. Change-Id: Iee531b02d14fae41edb68ad589a5dec829a60255
2013-09-21CID#707598 uninitialized scalar valuesCaolán McNamara1-0/+1
Change-Id: Id3c6488cfda25ab809bf554216bf2e5161456be0
2013-09-11Towards a working instdir for Mac OS XStephan Bergmann1-1/+1
Introduced gb_INSTROOT, which is the same as $(INSTDIR) except for Mac OS X, where it is $(INSTDIR)/LibreOffice.app/Contents. Most stuff ends up there (so most occurrences of $(INSTDIR) have been replaced with $(gb_INSTROOT)), but SDK- related stuff goes to $(INSTDIR)/$(gb_Package_SDKDIRNAME). (And GeneratedPackage needed to be made more flexible, to allow for packages that go into either of those two places.) For Android and iOS, gb_INSTROOT probably still needs to be set. The most obvious missing thing yet to make instdir work for Mac OS X is the instdir/*/LibreOffice.app/Contents/ure/ vs. instdir/*/LibreOffice.app/Contents/ure-link/ split. Change-Id: I4478edd27b14c92c96d92d5169bdca3ec50d78f5
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák1-1/+1
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-18Further work on the "Mac-like app structure" optionTor Lillqvist2-7/+3
Lots of stuff still either ended up in the wrong place, or was looked up from the wrong place, or both. Fix most cases. Change-Id: I06ebbce207c219f3cd82b4387dd9b3fdb83420d4
2013-08-18Use subfolder names from <config_folders.h>Tor Lillqvist1-1/+1
Change all instances of hardcoded "program", "share" etc subfolder names to use those from <config_folders.h> instead. In normal builds, the end result will not change. Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
2013-08-13fdo#57950: Remove some chained appends in xmhelpJelle van der Waa3-38/+13
Change-Id: I4680547aa1d12d3e8eab3c33e3158845848c2068 Reviewed-on: https://gerrit.libreoffice.org/5376 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-10fdo#62475 removed pointless commentsJelle van der Waa12-265/+0
Change-Id: I4fa01553246fa023806b3fec8e6e756a1efa59f1 Reviewed-on: https://gerrit.libreoffice.org/5342 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-29remove OUString wrap for string literalsThomas Arnhold2-6/+6
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29remove some createFromAscii usageThomas Arnhold1-1/+1
there are a lot more of them: git grep 'createFromAscii[^)]*"' Change-Id: Ibc2e9cae208d8b9c91667bb3b177c6bd6d3a9424
2013-06-13rename HAVE_CXX0X->HAVE_CXX11 and clean up to #define in a config headerLuboš Luňák3-8/+5
Change-Id: Id13e77fe890301a8510952994a91853568a7aea6
2013-06-06stop this decadent waste of precious newlinesMichael Stahl1-71/+0
Change-Id: I803d7d56ba7350fd0f5b2c4efa392d55a0fd4542
2013-06-06xmlhelp: fix reading symlinked .tree filesMichael Stahl1-5/+10
Apparently the .tree files nowadays are symlinked, which was not the case on the libreoffice-4-0 branch... and on viewing the Contents tab it's evident we can't actually read symlinked .tree files, and crash with an STL assert because the children vector is empty. Change-Id: I5a543ef85b827e194120530a486cf19a76837d87
2013-06-05Some String -> OUStringStephan Bergmann2-2/+0
...to get rid of having to additionally link some libs against tl from 27c6434fccfec5fb4184c1efa2057595c8716fad "fdo#46808, Replace usage of SpecialConfigManager" again. Change-Id: Ica161a4f0da320858b6a3901a5a6907737c779f4
2013-06-05fdo#46808, Replace usage of SpecialConfigManagerNoel Grandin7-60/+25
with usage of the underlying SvtPathOptions. The service is just a thing wrapper that serves no real purpose. Change-Id: Id762edf71ba0f699ef091261905c88c2d93e1c12
2013-04-28fdo#63197: convert helpxslJulien Nabet2-3/+5
Change-Id: Icd436733b47d7883209fe73dc1d0099dc87db089 Reviewed-on: https://gerrit.libreoffice.org/3649 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks5-110/+20