summaryrefslogtreecommitdiff
path: root/writerfilter/source/dmapper/TableData.hxx
AgeCommit message (Collapse)AuthorFilesLines
2020-10-06loplugin:const* make some params and methods constNoel1-3/+3
Change-Id: I97c5bbb929a2a4a029af4e6cb0fd571bbc2b698b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104030 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-21tdf#134709 writerfilter: consider gridAfter for table bordersJustin Luth1-0/+5
When the table itself defines borders, those borders should apply to the last cell in each row - even if some grids are skipped with gridAfter. (i.e. it won't be a straight line on the right side). This commit depends on an earlier commit doing this for gridBefore. Prior to this, gridAfter was never actually sent to DomainMapper, so it was always at its initialized value of zero, and it was only handled in the ooxml handlers. So the bulk of this patch is setting up the foundational parts of gridAfter - duplicating what was recently changed in LO 7.1 for gridBefore. Change-Id: Ieaf965fecf618eeaf41c7e8403b536c396138804 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98692 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-20tdf#134685 DOCX table import: fix gridBefore + cell widthLászló Németh1-2/+7
Improve workaround to handle nested tables started at cell start in a row with gridBefore. Omitted gridBefore cells from commit 5483d4e10aad27889b961b9cb94d7ba6c86aed0b (tdf#134606 DOCX table import: fix gridBefore + nesting) resulted less cells in the row than defined by the grid, and the different code path could lead to narrow cell width with partially invisible nested table. Fix this by adding gridBefore cell count to the cell span in the first cell. Regression from commit 70274f86cdc1c023ffdd0130c262c1479262d76b (tdf#116194 DOCX import: fix missing tables with w:gridBefore) Change-Id: If332305d54ff2b34b258270a607fb31ff7380149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98973 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-20compact namespace: writerfilterNoel Grandin1-4/+2
Change-Id: I1dd3aff6c08fb2bce031abd6e88603a4ec9077fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99012 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08tdf#129452 writerfilter: preserve gridSpans longer than currentRowJustin Luth1-0/+19
It is a fairly common thing for table operations to compare items in the same column (like merged cells for example). In order to determine column information, each row's (gridBefore - change-id Ie305477f0e3468a4a923095d76f520d97fe99ffe - and) merged cells need to be known. So save that information in the cell data - and don't just throw it away after the current row has been analyzed. Good grief. Change-Id: Ibfdac336bbb1f7303c7e585a85c94be37ad6f916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97433 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-07tdf#129452 writerfilter: preserve gridBefore longer than currentRowJustin Luth1-1/+10
It is a fairly common thing for table operations to need to compare items in the same column (like merged cells for example). In order to determine column information, each row's gridBefore (and merged cells) need to be known. So save that information in the row data - and don't just throw it away after the current row has been analyzed. Good grief. Change-Id: Ie305477f0e3468a4a923095d76f520d97fe99ffe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97432 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin1-3/+3
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-16Revert "loplugin:constfields in writerfilter"Noel Grandin1-1/+1
This reverts commit e7c6c05ae5a62e1705ffda97c5405eecd1f62a1e. Change-Id: I9072c4ef9c1a941ac3169e2b53dfd25ae7863770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20tdf#42949 Fix IWYU warnings in writerfilter/Gabor Kelemen1-2/+3
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I47ff7eecabc87081eb953c5970a3cbd56c86d728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88897 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-08tdf#116194 DOCX import: fix missing tables with w:gridBeforeLászló Németh1-2/+9
Regression from the commit cf33af732ed0d3d553bb74636e3b14c55d44c153 "handle w:gridBefore by faking cells (fdo#38414)" This patch replaces the previous fix with a better solution, fixing tdf#38414 on the proposed DomainMapper level. (Note: to reject the old fix completely, its follow-up commit w:gridAfter will be handled in a similar way.) Now the related regressions, tdf#111679, tdf#120512 and the complex forms of tdf#116194, tdf120256 and tdf#122608 are fixed, too. Change-Id: Id25f5fb4d9021c87ee8c82782b2038e6fb255673 Reviewed-on: https://gerrit.libreoffice.org/84263 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-09-28loplugin:constmethod in writerfilterNoel Grandin1-7/+7
Change-Id: I1e1c4e574e910ef9683520ae950b14eb4ebbc63f Reviewed-on: https://gerrit.libreoffice.org/79784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:unusedmethodsNoel Grandin1-11/+0
Change-Id: I7db0c27ff2213210ed4b46ebbadc1a2f74a18257 Reviewed-on: https://gerrit.libreoffice.org/61249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28loplugin:unusedmethodsNoel Grandin1-11/+0
Change-Id: I5f9ef043d76c55f2c761fd08a2bc1dae66b675c8 Reviewed-on: https://gerrit.libreoffice.org/61073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-13loplugin:constfields in writerfilterNoel Grandin1-1/+1
Change-Id: Ibe380e1fb35d9defc478d459a988f9f6df13bf35 Reviewed-on: https://gerrit.libreoffice.org/60427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-10tdf#79877 perf loading docx file, writerfilter/ improvementsNoel Grandin1-9/+9
this improves load time by 20%. We switch from shared_ptr to tools::SvRef to manage the objects I noticed some double inheritance like this: DomainMapper LoggedProperties Properties SvRefBase LoggedTable Table SvRefBase so to be safe I made all the ref-count-base-class inheritance virtual. Change-Id: Ia3de9733f5c6966e8171f43d083dcc087040b8cd Reviewed-on: https://gerrit.libreoffice.org/57022 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03loplugin:passstuffbyref more return improvementsNoel Grandin1-1/+1
slightly less restrictive check when calling functions Change-Id: I35e268ac611797b1daa83777cda02288a635aa32 Reviewed-on: https://gerrit.libreoffice.org/47259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-31loplugin:passstuffbyref improved return in emfio,writerfilterNoel Grandin1-1/+1
Change-Id: I237936d62d0f1b17574dd88b5c9de932dc03238e Reviewed-on: https://gerrit.libreoffice.org/47214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27loplugin: unnecessary destructor writerfilter..xmloffNoel Grandin1-1/+0
Change-Id: I511822dc874101ed3b9850b015b746a86d26c3b5 Reviewed-on: https://gerrit.libreoffice.org/33578 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-03cppcheck style fix for noExplicitConstructor in writerfilterJochen Nitschke1-1/+1
make ctors with one parameter explicit Change-Id: I08e753cea9f5ea17d654c889bad37ab7d0f4611e Reviewed-on: https://gerrit.libreoffice.org/31588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-04update loplugin:unnnecessaryvirtual to handler destructorsNoel Grandin1-6/+2
and update modules writerfilter..xmloff with the resulting changes Change-Id: I54d19c22ddb0ff579b32e4934d266c925b19305c Reviewed-on: https://gerrit.libreoffice.org/30530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann1-2/+2
Change-Id: I0add8faa004c14226ef76125a55dc9e82b37a488
2016-04-14loplugin:passstuffbyref in writerfilterNoel Grandin1-3/+3
Change-Id: Ia85f5a7a9846802de7a1495e70d16c9e3418dc3e
2015-12-21loplugin:unusedfields writerfilter,writerperfectNoel Grandin1-5/+0
Change-Id: I8863fcdb0751d2f1becea5b2487d4070e4fd4195
2015-07-21loplugin:unusedmethods writerfilterNoel Grandin1-31/+0
Change-Id: I52441115e14da6c1bcd7ba4926a0f3cc0620366e Reviewed-on: https://gerrit.libreoffice.org/17236 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-30writerfilter: boost::shared_ptr -> c++11 std::shared_ptrMiklos Vajna1-4/+4
Change-Id: Ib5649d8979093bb147c61eebcf95a472ad899672
2014-12-22writerfilter: fold single remaining header of resourcemodel into dmapperMiklos Vajna1-1/+1
Change-Id: I54cc8ebda18c8ca7071c39210687f28adbc4790a
2014-12-06No need to have CellData as a templateMiklos Vajna1-17/+15
Change-Id: I700b817b446cc11b2475800fb5b1f4c8f8c8b003
2014-12-06No need to have RowData as a templateMiklos Vajna1-20/+17
Change-Id: Id93b97b69d1f9d44e5e5314698e7a3a0790e51e3
2014-12-04No need to have TableData as a templateMiklos Vajna1-7/+6
Change-Id: I136f844c3823443a8a42eb7a6e41d3805b085bd1
2014-12-04TableData is only used with PropertiesPointer=TablePropertyMapPtrMiklos Vajna1-18/+10
Change-Id: I613addb6cd8b57fce90659209503f633ee438a58
2014-12-03writerfilter: only dmapper needs TableDataMiklos Vajna1-0/+426
Change-Id: I4c2ead05d845eebe101d34ed8fe9284509beb752
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 03:43:40 +0000