Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920
Signed-off-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit e544f449eded2738b45de4be13c72b128a16bafe)
|
|
Change-Id: I564b4df26c45c035f455ecf6db573b25c5eb4699
(cherry picked from commit 3097a60e97b1070f9a0c6aa4202c7aeeec17954b)
|
|
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 1a8915ef8302b13b781977209ae1fa41f5f659dc)
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
|
|
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 5d5dc059cb4b88fe19e5d92e7d9b9ae581afce98)
|
|
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 69c88a32aad2cafde197e98557868ad069795d60)
|
|
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit aade27554d427649810f5635133519cadfa8002f)
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
|
|
Change-Id: I0e74d800593245fa00013035c9498b77988b072b
(cherry picked from commit 9e06b99129a4eda16e254dfb25a42d440763af06)
|
|
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac
Reviewed-on: https://gerrit.libreoffice.org/16260
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 1f408db49740f8cc6ba67d72b54f49d2e4fdae9b)
|
|
Change-Id: I75354ffea2daede55b34e4cf3321d57196be3d9b
Reviewed-on: https://gerrit.libreoffice.org/19652
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit c7a520868ecf6d5de48dc3964a7bccab3fa480c3)
|
|
Comment indicated "If one of these fields is empty, the button is disabled",
let's stick to this.
Cherry-picked from 2ff595dbf2b42b4b3ee961b63e5da92067aa8fd9
Change-Id: I99dd23339d888c33e7706935842a91f5da681ade
Reviewed-on: https://gerrit.libreoffice.org/19112
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 3a3fb3c5dcbbe974e2f49669bf14937f14261d8a)
|
|
1) Fix value of constants RES_OK, RES_CANCEL and RES_HELP
http://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/awt/PushButtonType.idl#29
2) self.updatePublishUI was wrong because FTP appears in second but there are 2 elements
for each module (local dir, zip, ftp) in pubAware vector
comment was wrong:
- local takes elements 0 and 1
- zip takes elements 2 and 3
- ftp takes elements 4 (that's why "4" is the right value) and 5
see http://opengrok.libreoffice.org/xref/core/wizards/com/sun/star/wizards/web/WWD_Startup.py#509
So fix value passed to self.updatePublishUI + comment
Just a bit of history:
before fix of tdf#92934: Web Wizard: Cannot Export Zip archive (http://cgit.freedesktop.org/libreoffice/core/commit/?id=e72a4a3c2e1608e301daef0b6e87cc70d814e736),
the order seemed to be this one for pubAware: local, ftp, zip (whereas UI order was already local, zip and ftp)
Perhaps the fix was wrong since there was a similar pb for tdf#94421: Web Wizard, option shift when loading saved session
Anyway now the pubAware order is the same as UI order, it may help for readability.
minor
a) increase space for lblStatus (there weren't enough room for some locales, eg French)
b) replace use of copy3 (deprecated) by copy2
Change-Id: I27d3c2dd699fbe2d51a63e462c7b39e78895d1be
Reviewed-on: https://gerrit.libreoffice.org/19115
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit e3f8eb8d3a594e3b8afa51c214f6c5c44d8dde4e)
Reviewed-on: https://gerrit.libreoffice.org/19118
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 2cb902341e0825a212527865ec0cde5d56543d34)
|
|
Inherit from WizardDialog instead of object
Define required constants for buttons
Remove or tweak calls to super methods
Fix call setDialogProperties which was wrong since unification of this method
See ee122cfd36b3af030520f26a6a313bc7cd3156fd
With the patch, FTP dialog opens, we can also connect successfully to an ftp server
Still there are bugs to fix then, first of them directory selection
Change-Id: I86c3c9638114216627d92832c26ad780c12860b4
Reviewed-on: https://gerrit.libreoffice.org/18831
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 7e09b3656472bd5a3ef4090fd2ea6f521956fd53)
Reviewed-on: https://gerrit.libreoffice.org/19068
(cherry picked from commit 05f24922fbf39c00b6d06f8594f0cd9b06b40b2c)
|
|
Just use the right order
LOCAL_PUBLISHER first, ZIP_PUBLISHER second, FTP_PUBLISHER third and last one
Change-Id: I23ff96785910d62bbb2c221932d0ad2a2e755b3c
Reviewed-on: https://gerrit.libreoffice.org/18755
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 09c3e186e8b8562e3d502c5cbdef385753336b7f)
Reviewed-on: https://gerrit.libreoffice.org/18758
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit cfc880da034ae4a504042d3e78703e338eb43ff8)
|
|
Adjust some values for make room (ok with French, German and English UI)
Change-Id: I7600acae64f5ae1110c07798cc950ec73a48deab
Reviewed-on: https://gerrit.libreoffice.org/18787
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 0ca9a3523cb2ccf97d7d13fdf4616af0dbe173d9)
Reviewed-on: https://gerrit.libreoffice.org/18791
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit db25bda687f2981dbad1109357dbc721e4104962)
|
|
Value of 60 allows to display the selected dates + let a margin if year is in 4 numbers one day.
Change-Id: I3d7db50dd318897b0b7a515f9428401c53218c08
Reviewed-on: https://gerrit.libreoffice.org/18786
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 9e99b18f20f46d656c7a52413d23193f75065d1a)
Reviewed-on: https://gerrit.libreoffice.org/18790
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit a0720dab70621edf7286eac1d16004e4a4491f8b)
|
|
pubAware_ adds 2 elements for each of these:
LOCAL_PUBLISHER, ZIP_PUBLISHER, FTP_PUBLISHER
and since ZIP_PUBLISHER is added in second positon,
the right index is 2 not 4
Change-Id: I0a533fd0cefcbbfca0e95628f64fac6258019600
Reviewed-on: https://gerrit.libreoffice.org/18715
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit e72a4a3c2e1608e301daef0b6e87cc70d814e736)
Reviewed-on: https://gerrit.libreoffice.org/18717
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 7a4edfbc4bce290e4e26f55728f670bf24423151)
|
|
this is the canonical order, and it makes the code easier to read
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
(cherry picked from commit 0c18bedb7328493040c1a20822b345e624d6041f)
Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
|
|
Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d8ecad569fd7a254902da154ed8057ec61f3a83
Thank you Matthew Francis for having found the root cause!
Change-Id: I4128368a5f5df6a9fc5f7668fb1f8f330b5795b9
Reviewed-on: https://gerrit.libreoffice.org/18210
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit ed33646cdecac866ab480bf5770726b4a5bfa6c9)
Reviewed-on: https://gerrit.libreoffice.org/18224
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9888f8ab7bccdd2902d619487279999f2ff9ab13
(cherry picked from commit c1617b8d74b5e232efeec864241ada89f874fe63)
Reviewed-on: https://gerrit.libreoffice.org/17513
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
The hard-coded "/" separator causes getFileURLFromSystemPath to fail,
and it's not obvious why the URL is being converted to a system path
in the first place.
Change-Id: I06ebe6d92954c4f3c884ae6f0b327ea8a36c10a4
(cherry picked from commit 8bf374b98d07c24a37933b8c03a53abb3a8ff5c6)
Reviewed-on: https://gerrit.libreoffice.org/17512
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
- correct return value in Execute method: returned alays False, should return True when successful
- Item property of collection did not work because incomplete object initialisation
Change-Id: I9b2e682afb21747766e918bf905e35d9485b751d
Reviewed-on: https://gerrit.libreoffice.org/17351
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
The web wizard runs some XSLT over the exported file. It registers
a handler that is called when the output stream is closed, and this
Process.streamClosedHandler() calls terminate(), which causes the
deadlock, because it wants to join() the extra XSLT thread but the
handler is actually called from the XSLT thread itself.
Fix that by moving the terminate() to another function that runs in the
main thread.
It does not deadlock on Unixes because osl_joinWithThread() actually
detects an attempt to join the calling thread and returns early.
Change-Id: Ia176562fa28b97c7e8956c1e8975c9aa6ee23236
(cherry picked from commit 62de18ab98289fc80984299f13ad71e4a4452ea3)
Reviewed-on: https://gerrit.libreoffice.org/17511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Fixes
Traceback (most recent call last):
File "/home/laci/m/bibisect/lo-linux-dbgutil-daily/opt/program/wizards/web/WWD_Events.py", line 249, in addDocument
oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, self)
TypeError: __init__() missing 1 required positional argument: 'parent_'
and:
Traceback (most recent call last):
File "/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py", line 252, in addDocument
oLoadDocs.loadDocuments()
File "/home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py", line 934, in loadDocuments
doc.cp_URL = FileAccess.connectURLs(files[0], self.files[i])
NameError: global name 'files' is not defined
Change-Id: I737117a6981e541f12453bb9d9b2680f5fb79142
Reviewed-on: https://gerrit.libreoffice.org/16756
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 2f0d1a23759c1b973593bfba642d01fb3df3c269)
Reviewed-on: https://gerrit.libreoffice.org/17034
|
|
Bug in MoveNext and MovePrevious methods of Recordset class module
Reported in https://forum.openoffice.org/en/forum/viewtopic.php?f=47&t=76640
Change-Id: I6d622e803f2ddcea67415bacb720c6084751d837
Reviewed-on: https://gerrit.libreoffice.org/16124
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
|
|
the file name widget is empty when it shouldn't be.
the other wizards get this right
Change-Id: Icdb629e676a73fcf8d8be4352818abbef455bbaf
(cherry picked from commit a3727ad62b7c1a30f9b0531042cce5ce5b8c6089)
|
|
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
|
|
Change-Id: I22a5b9fa29d465a21e682279e6e88d37bd8adf93
|
|
Capital "i" is "İ"
Small "I" is "ı"
Therefore, any BASIC we ship had better be clean of case-insensitive function
name comparisons (or at least those involving "i"s), because they will not
work when the system locale is Turkish.
Change-Id: Ibf3a35a55b6b1ba384731dfa92caf24b51245530
Reviewed-on: https://gerrit.libreoffice.org/14995
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ifa031a872bd618c41b0fbb2e0fd5a17e0f7b0a53
|
|
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
|
|
Add'l BuiltIn i.o. Builtin (cfr. MSAccess property)
Change-Id: Idb539a8e259f76e96224526fd9e2b7a54effec1d
|
|
Change-Id: I1579c4a79f8806d4580b282737e829462361af98
|
|
Change-Id: I5e938a0b53ea7a1b020bc73634bff70913f3ebc3
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Recognizes new ("untitled ...") writer, calc, ... documents.
Necessary for correct toolbars management
Change-Id: Ic1db29b8aebe377e08e6a5101162ca107f2f7154
|
|
Change-Id: I61d6a92e5301e07c9180d94dafec23ef1a06e0ef
|
|
Change-Id: I5b8958561375690dcf81b9fc1bb8e7b4904e0cb0
|
|
Change-Id: I2bdde7524a97039c94a8da5ac5d2eba38c91d71a
|
|
Change-Id: Ie5d18aa59885172bd701ddcfb0e62f5ad3816de9
|
|
Removing last item of a Listbox produces an "Index out of rande" run-time error
Bug reported in user forum https://forum.openoffice.org/en/forum/viewtopic.php?f=47&t=75008
Change-Id: I4bf790f8fee1f88def580dee7bac708b5620fbed
|
|
Change-Id: Ia3195a21ad46b4c9830ee6293135dfe5945986a2
Reviewed-on: https://gerrit.libreoffice.org/13985
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
and remove the need to worry about keeping indexes correct
Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
Change-Id: If6a69eb384b7b7e6c71e96f126a27bcd45709ad4
|
|
Change-Id: I5258b47cba25451b36645e9de3a6a43e3ea3af4c
|
|
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
|
|
found by PMD
Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
|
|
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
|
|
Refine list of supported modules beyond database forms only
Change-Id: I6f43234d653a564fa740724b01b7f2bde58d371d
|
|
Main functionalities:
- show/hide toolbar elements
- modify tooltip
- get/set internal command
- execute internal command
Change-Id: Ice830009f9eabc199727c7d4b54ebf524b026d40
|