Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe
Reviewed-on: https://gerrit.libreoffice.org/16713
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
this is the canonical order, and it makes the code easier to read
Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
|
|
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
|
|
Change-Id: I22a5b9fa29d465a21e682279e6e88d37bd8adf93
|
|
Change-Id: I5e938a0b53ea7a1b020bc73634bff70913f3ebc3
|
|
and remove the need to worry about keeping indexes correct
Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
|
|
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
|
|
found by PMD
Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
|
|
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
|
|
Quoting Noel:
"
The original block of code looked like this before my changes:
MethodInvocation windowHidden = new MethodInvocation("windowHidden", this);
xWindow.addWindowListener((CommonListener) getGuiEventListener());
String dialogName = (String) Helper.getUnoPropertyValue(xDialogModel, PropertyNames.PROPERTY_NAME);
getGuiEventListener().add(dialogName, EVENT_ACTION_PERFORMED, windowHidden);
which is clearly bogus, since "actionPerformed" is not an event on the XWindowListener interface.
"
(see https://bugs.freedesktop.org/show_bug.cgi?id=87123#c14)
Change-Id: I4c4923e6cb21989fcd3e346b099a7e7b15526bf2
|
|
found by UCDetector
Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
|
|
Change-Id: Ifefb5de196a3e5cbaa8945759da42886c69daacf
|
|
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7
Reviewed-on: https://gerrit.libreoffice.org/13477
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8
Reviewed-on: https://gerrit.libreoffice.org/13435
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I727e7f2a7527c60bb45f0ba5d0e88a66c5ccdd6f
|
|
Change-Id: I13f0c7afca233cc0ff6692f8fb442a80c4208d20
|
|
found by UCDetector
Change-Id: Ia98606a98b998a224f821f2e673e788fb0ecf7d1
|
|
found by UCDetector
Change-Id: Ic62ec16bceb9ab7b6898f8a469af65ba3884bb51
|
|
found by UCDetector
Change-Id: I7993f781a9e195d7d591e8a9e94a72ee86d77826
|
|
found by UCDetector
Change-Id: If7d7f7b271f48f82d823a3d7b175adcae91180e3
|
|
Change-Id: I80416b3e2065263abd6015843e3aa6f7b7c0b3e4
|
|
found by UCDetector
Change-Id: I00a35337478111991dec7fa6310e57d3b5a146fa
|
|
Change-Id: Ie4532343cf964ade848454d89b44e381eadb6582
|
|
Change-Id: I2b3d73dc38ab4c5b7ac60bc8b4b3903c36579891
|
|
Change-Id: I3c30d3865302741c7fbdc811e32686a921b6a4df
|
|
Change-Id: I01143a9f3a3b563bf5da58dc4a8ed38c440a5c62
|
|
Change-Id: Ia95a07f798de01bfedcce6cd5e97090e165a7ca9
|
|
Change-Id: Id6a6991704009b909e5108daf65c48722fa97447
|
|
Change-Id: I8379bb8194b86a194c351c5e33e1765b8feb59d2
|
|
Change-Id: Iee0b9e3409f5789a1ca17eb10b100a457dfbdea3
|
|
and remove some unused methods in UnoDialog2, and rename some
parameters to be more explanatory
Change-Id: Ic57510159bebacc1c79d8d689a14bd3cd5a81ae8
|
|
by moving the MethodInvocation to be purely an internal detail
Change-Id: Id7863261abd5ebd30b7596bac756ca5360119283
Reviewed-on: https://gerrit.libreoffice.org/13100
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I68496b47564f4c00c19a62f9f1bf38d3353598f7
Reviewed-on: https://gerrit.libreoffice.org/13095
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
since CommonListener is the only subclass
Change-Id: If10ccb29991d7c48e2c20fc41330572a669f1497
Reviewed-on: https://gerrit.libreoffice.org/13094
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1c8b0ea28b6dbc2b6825f5f30ae0d234b7362d64
Reviewed-on: https://gerrit.libreoffice.org/13093
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I5c790a4b79966c977899a0cdacde8fb41148eb1a
Reviewed-on: https://gerrit.libreoffice.org/13092
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I95c095eb7a6f315019fb851fb20e65314eaebf55
Reviewed-on: https://gerrit.libreoffice.org/13091
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I77dfcaae8950397e0f22c9a3e744e744055b6cf3
|
|
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ied82b0a39ff9dc9c7cc9539dec2b963059f3d4a5
Reviewed-on: https://gerrit.libreoffice.org/12139
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
|
|
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
|
|
the compiler will do it automatically
Change-Id: I6ee57c3500a4c1c1b96919a69b569686e6c0ead9
|
|
Change-Id: I543fe5b8890668f60d6528a2a7ae6d099d5b4945
|
|
Change-Id: Id33384cee3444924e7e8de7d496f117f120b1876
|
|
Change-Id: I2f0156899b75dd8a3a5600be887b6ac9b6fbdec0
|