summaryrefslogtreecommitdiff
path: root/wizards/com/sun/star/wizards/common
AgeCommit message (Collapse)AuthorFilesLines
2020-08-12imp is deprecated since Python v.3.4Mike Kaganski1-2/+10
This avoid Python warnings about this during checks Change-Id: I6647d9c93f3c2fbc1af475f8bc45e03300ee8b79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100518 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-08pyflakes3: fix some reports on wizardsJulien Nabet2-4/+1
Change-Id: I0fef17ccc8f110d1d8bf629737807f1bcc618b76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18Fix 'is' operator for comparisonJens Carl1-1/+1
The 'is' operator should not be used for comparison on some types of literals. In CPython this works by accident and CPython 3.8 introduced a SyntaxWarning (see https://bugs.python.org/issue34850). Change-Id: Ifabe22e4ae3b9e1d3bfd5a663f39500e381cfa6e Reviewed-on: https://gerrit.libreoffice.org/83034 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-27Fix typoAndrea Gelmini4-6/+6
Change-Id: I309ce0b4aade85a510836be0d04bf66c916a464a Reviewed-on: https://gerrit.libreoffice.org/75507 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-04-24tdf#124197 Improve "Unexpected error" user-visible error message wordingDarkByt311-2/+2
Change-Id: I11c2ac4855a5fec2d26255ec3ab14ffe50e0fbbe Reviewed-on: https://gerrit.libreoffice.org/71066 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-29tdf#108523 Removed @author annotationsJaromir Wysoglad1-1/+0
Change-Id: I5905dd94843595b229046c0b4a0f16181c16fd9e Reviewed-on: https://gerrit.libreoffice.org/69869 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-13Fix wizards/NumberFormatter.javaJulien Nabet1-1/+2
Create a brand new odb file (embedded HSQLDB) Create a simple table in it Launch Query wizard, you'll see these on console: ... at com.sun.proxy.$Proxy69.addNew(Unknown Source) at com.sun.star.wizards.common.NumberFormatter.defineNumberFormat(NumberFormatter.java:96) at com.sun.star.wizards.ui.FilterComponent.addNumberFormats(FilterComponent.java:504) at com.sun.star.wizards.query.QueryWizard.buildSteps(QueryWizard.java:233) ... ... at com.sun.proxy.$Proxy69.addNew(Unknown Source) at com.sun.star.wizards.common.NumberFormatter.defineNumberFormat(NumberFormatter.java:96) at com.sun.star.wizards.ui.FilterComponent.addNumberFormats(FilterComponent.java:506) at com.sun.star.wizards.query.QueryWizard.buildSteps(QueryWizard.java:233) ... Root cause is FilterComponent.java uses "YYYY-MM-DD" and "YYYY-MM-DD HH:MM:SS" (lines 504 and 506) If it's ok for English locales, xNumberFormats.queryKey calls fail at least for French locales. Use addNewConverted instead of addNew method to take into account the difference of locales and avoid these stacktraces Change-Id: I5ef6325b8a213ae6758e378c4d3b8560c117042f Reviewed-on: https://gerrit.libreoffice.org/69131 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2019-03-12Remove unused python codeXisco Fauli3-230/+0
This code was automatically converted from Java to Python. It might be used at some point if the remaining java wizards are converted to python, however that's not the case as per today, thus this code is unused. Let's get rid of it as it might create confusion Change-Id: Ic58ade24b10f7a0654b3e8ae39f6afa712589c3d Reviewed-on: https://gerrit.libreoffice.org/67868 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-02-07complete the univerbation of E-mail to Email in the uiCaolán McNamara1-1/+1
it now looks old-fashioned hyphenated Change-Id: I5b2b905277356c1b986f97de29f82ac1c21b1709 Reviewed-on: https://gerrit.libreoffice.org/66796 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-22Related: tdf#121340: Do wizards steps Title CaseSabri Unal1-18/+18
Change-Id: I4ac17e520a93678a1a0e8dfd5fd849eaf276219d Reviewed-on: https://gerrit.libreoffice.org/63776 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-11-06tdf#121188 form controls should have InputRequired false by defaultLionel Elie Mamane1-0/+3
Unless the underlying column is not nullable and has no default value this is only a guess, form designer can change it Change-Id: Ifa403e00b21fdaf86aef383503d54879b25ac62b Reviewed-on: https://gerrit.libreoffice.org/62969 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-04-17Fix typosAndrea Gelmini2-2/+2
Change-Id: If89ec640901253121529c09aef4537c6b13cee1d Reviewed-on: https://gerrit.libreoffice.org/52280 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-05Removed unused code in python wizardsXisco Fauli7-285/+5
This code got unused after 5b3022860abfe7eefd2e25b60b5b2a563b42b3c0 Change-Id: I6c198ab359f8468a9f4d9041b9bc4feb88eedd74 Reviewed-on: https://gerrit.libreoffice.org/49109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-01-14Fix HIDs in Java based Table/Query/Report wizardsGabor Kelemen1-34/+36
Some HIDs were a bit off in these wizards - Report Wizard 'Grouping' page - Table Wizard 'Set primary key' page - Query Wizard 'Grouping' page All these contain a subclass of a FieldSelection. Due to the implementation of HID handling there, we need 4 consecutive HIDs in HelpIds.java for the buttons cmdMoveSelected, cmdMoveAll, cmdRemoveSelected and cmdRemoveAll. Above pages contain subclasses without the MoveAll and RemoveAll buttons so we need empty placeholders in their places to cater for the assumptions of the parent class. This also means that HID numbers must be adjusted a bit, and in ReportWizard.java we need to shift the base HID number of the Sorting page that follows the Grouping page. Change-Id: I944dd4f781aff2c0b0cfd99c3386001506c01440 Reviewed-on: https://gerrit.libreoffice.org/46270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-01-08tdf#114881: Re-introduce ConfigurationUpdateAccessStephan Bergmann1-1/+4
...which had accidentally been removed completely from this part of cb2550750386f51ef7a46a8a664a4ab9de614f8d "Drop lazywrite property, which is silently ignored by configmgr anyway" Change-Id: Ibacacc7b04bbd0a0cc819530594dd042329b366f Reviewed-on: https://gerrit.libreoffice.org/47600 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-07Related: tdf#114873 if fallback returned as result, drop contextCaolán McNamara1-1/+4
Change-Id: I82676e4a0b3dee33e248b3ba81e99f949ee9227a
2018-01-07tdf#114873: localize Letter, fax and agenda wizardsJulien Nabet1-1/+4
Since we use contextual messages, we need to concatenate: - context - EOT character - the message itself see https://www.gnu.org/software/gettext/manual/html_node/MO-Files.html A priori, regression from 00657aef09d854c74fb426a935a3e8b1fc390bb0 Change-Id: Ie3e781e30ce09f0121afff2f0eb0769b1fbd2114 Reviewed-on: https://gerrit.libreoffice.org/47521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22Fix Java wizard HID listGabor Kelemen1-0/+1
A still actively used HID was accidentally removed in commit: https://cgit.freedesktop.org/libreoffice/core/commit/wizards/com/sun/star/wizards/common/HelpIds.java?id=82d863b4a410fa78120d2efc41bd2b3b61f21cee This caused some HIDs in the Form wizard to slide off by one Change-Id: I0142a150f1c65456ba9affe5d997ddabe37d1b3e Reviewed-on: https://gerrit.libreoffice.org/45057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-31Fix Wizard HIDs moved off by oneGabor Kelemen1-0/+1
In commit b3f96d2ccba362a2898bc3a4d365ce7c4d0698e2 I made a mistake that caused a lot of Wizard HIDS go off by one i.e. they were attached to the next UI item. I noticed this in the Fax wizard. Adding one more empty array item seems to fix this. Problem was caused by the replacement of this line with an empty item: "", "HID:WIZARDS_HID_IS_BTN_NONE", # HID:41002 Change-Id: Id7df502ac843ab0e572ca59a046f5bacdda7e9bc Reviewed-on: https://gerrit.libreoffice.org/44075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-09-05Drop lazywrite property, which is silently ignored by configmgr anywayStephan Bergmann2-20/+3
...at least ever since the "new" configmgr reimplementation, 6b849a6aeeb9ea8b1e25e28d5a8be390e425f84e "#i101955# initial work in progress of a configmgr reimplementation (for now in an extra module 'configmgr2')" et al Change-Id: I43430d991647fb2e26762463d51175247db0604b
2017-07-21migrate to boost::gettextCaolán McNamara4-62/+317
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-06-05spelling instanciate -> instantiateNoel Grandin2-2/+2
Change-Id: Ic1393da64328c0dc7e2860334b204139bf537d81 Reviewed-on: https://gerrit.libreoffice.org/38401 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-24convert java wizards to .properties for translationsCaolán McNamara5-71/+42
like LibreOffice java extensions, and nlpsolver and librelogo, do, removes the magic number problem Change-Id: I561249ccebe41c787cd8cdaa80e1d035f27052cc Reviewed-on: https://gerrit.libreoffice.org/37986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-21expand and drop python getResArrayCaolán McNamara1-10/+0
Change-Id: Ie81495a15376b01b0e87ee84628b8c6945897a3d Reviewed-on: https://gerrit.libreoffice.org/37877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-07tdf#99967 (related) Drop Web Wizard HIDsGabor Kelemen2-126/+126
These were used on the recently dropped help pages Change-Id: I391c881b43c49000c37cbe53b111f686eaa64843 Reviewed-on: https://gerrit.libreoffice.org/36093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-02Fix typosAndrea Gelmini2-2/+2
Change-Id: Ibc81246e615d7c68c93e01b84584e78a79bece16 Reviewed-on: https://gerrit.libreoffice.org/34779 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-20Related tdf#99967: Cleanup after Web Wizard dropJulien Nabet2-4/+1
There are still webwizard*.xhp in help/source/text/shared/autopi/ Change-Id: If54d7bfc093c8c0765fd881eeb14f62bc3517194 Reviewed-on: https://gerrit.libreoffice.org/34402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-01StringList isn't required or used by wizardsCaolán McNamara1-5/+0
as shown by commit a96c308e52983b7bc0275e31e50a9b04e5805852 Author: Noel Grandin <noel@peralex.com> Date: Wed Dec 17 10:33:26 2014 +0200 java: these fields can be converted to local variables Change-Id: Ifefb5de196a3e5cbaa8945759da42886c69daacf Change-Id: I4da6c42e0114a891a6b6af8889c94b4332b0b40b
2016-05-25Fix typosAndrea Gelmini2-2/+2
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-14remove some unused Java codeNoel Grandin2-3/+1
found by UCDetector Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
2016-02-04coverity#1326401 Dereference null return valueCaolán McNamara1-18/+10
Change-Id: I7d19233bb0f63f55c87d83e50b7f865f5c7a8ea4
2016-01-20coverity#1326466 Dereference null return valueCaolán McNamara1-12/+4
Change-Id: Iea0dc27bf32499e1f8b38d8a0e90cebe6ab8b31f
2015-11-10Use UIConsts constants for offsets to resource IDs in main/wizards.Damjan Jovanovic1-1/+6
(cherry picked from commit 95efcaf575dced8cc18f2ca9fb874d772ad23595) Change-Id: I8bb247c92f0326da916940f4fc7999d81998297a
2015-11-09java: add some @Override annotationsNoel Grandin2-0/+2
Change-Id: I291db1dff5ab3ce40fda6f822a0e3ff1e6ef36c1 Reviewed-on: https://gerrit.libreoffice.org/19855 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-05java: combine nested if statementsNoel Grandin3-17/+9
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-10-22coverity#1326397 Dereference null return valueCaolán McNamara1-7/+9
Change-Id: Iafb022cf3bbdbaa8a6b230cb60377d90e64fe142
2015-10-20coverity#1326559 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: I1661514bf3002b79544615620843d1e535aabfce
2015-10-20coverity#1326575 Useless callCaolán McNamara1-1/+0
also coverity#1326574 Useless call Change-Id: Ida860ca8ed1475c88e90fc8aaf608c440453a9a0
2015-10-14cid#1326131 'Constant' variable guards dead codeNoel Grandin1-12/+6
Change-Id: I832b2fc243404a6ae9796ad994e901880d3b9260
2015-10-04tdf#94743: Web Wizard: Cannot export in ftpJulien Nabet1-1/+1
1) Fix value of constants RES_OK, RES_CANCEL and RES_HELP http://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/awt/PushButtonType.idl#29 2) self.updatePublishUI was wrong because FTP appears in second but there are 2 elements for each module (local dir, zip, ftp) in pubAware vector comment was wrong: - local takes elements 0 and 1 - zip takes elements 2 and 3 - ftp takes elements 4 (that's why "4" is the right value) and 5 see http://opengrok.libreoffice.org/xref/core/wizards/com/sun/star/wizards/web/WWD_Startup.py#509 So fix value passed to self.updatePublishUI + comment Just a bit of history: before fix of tdf#92934: Web Wizard: Cannot Export Zip archive (http://cgit.freedesktop.org/libreoffice/core/commit/?id=e72a4a3c2e1608e301daef0b6e87cc70d814e736), the order seemed to be this one for pubAware: local, ftp, zip (whereas UI order was already local, zip and ftp) Perhaps the fix was wrong since there was a similar pb for tdf#94421: Web Wizard, option shift when loading saved session Anyway now the pubAware order is the same as UI order, it may help for readability. minor a) increase space for lblStatus (there weren't enough room for some locales, eg French) b) replace use of copy3 (deprecated) by copy2 Change-Id: I27d3c2dd699fbe2d51a63e462c7b39e78895d1be Reviewed-on: https://gerrit.libreoffice.org/19115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-09-21tdf#94351: Web Wizard multiselection doesn't workJulien Nabet1-1/+1
Call getSelectedFiles instead of getFiles+adapt behavior so it deals with an array of files with their full path Change-Id: I21b6c32dea85460461925a9b44dac195d79b7eac Reviewed-on: https://gerrit.libreoffice.org/18714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-04wizards: FileAccess.getURL1 is unusedMichael Stahl1-4/+0
Change-Id: I3afde8e7f8b0b88e8f1a5d1ad71429c2aa7d7a94
2015-08-04wizards: FileAccess.getURL does not work on WindowsMichael Stahl1-4/+6
The hard-coded "/" separator causes getFileURLFromSystemPath to fail, and it's not obvious why the URL is being converted to a system path in the first place. Change-Id: I06ebe6d92954c4f3c884ae6f0b327ea8a36c10a4
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin1-2/+2
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-01-05java: remove dead codeNoel Grandin3-57/+0
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin1-1/+1
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: these fields can be converted to local variablesNoel Grandin1-11/+5
Change-Id: Ifefb5de196a3e5cbaa8945759da42886c69daacf
2014-12-11java: remove some unnecessary interfacesNoel Grandin2-25/+1
Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8 Reviewed-on: https://gerrit.libreoffice.org/13435 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: reduce visibility of fields and methodsNoel Grandin13-54/+54
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05java: static fields should be accessed in a static wayNoel Grandin1-17/+9
Change-Id: I727e7f2a7527c60bb45f0ba5d0e88a66c5ccdd6f