summaryrefslogtreecommitdiff
path: root/winaccessibility
AgeCommit message (Collapse)AuthorFilesLines
2017-05-11Clean up uses of SAL_U/SAL_W: winaccessibilityStephan Bergmann9-161/+143
Change-Id: I8f2abf0d338d01453f273b279e34c882de461b00
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky1-1/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-06Use OUString function variants that take a (narrow) string literalStephan Bergmann1-27/+27
...instead of going via an OUString temporary created from a char16_t string literal Change-Id: I9bdc1fe5e92988fbe227534a183c0c5a86ebc2a1
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann7-61/+61
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04loplugin:redundantcast (clang-cl)Stephan Bergmann1-2/+2
Change-Id: Ie096d75c1bc774e77c589845f61276d1478234ef Reviewed-on: https://gerrit.libreoffice.org/36065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04loplugin:redundantinline (clang-cl)Stephan Bergmann8-8/+8
Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430 Reviewed-on: https://gerrit.libreoffice.org/36063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-03use actual UNO enums in vcl..xmlsecurityNoel Grandin1-2/+1
Change-Id: Id862544f27ebcbe8363f93dc83192d0f0cddb5cc Reviewed-on: https://gerrit.libreoffice.org/36041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I80b6d080aa31ff8b9d043b983993f4d26d8dc87c Reviewed-on: https://gerrit.libreoffice.org/35662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-15loplugin:unncessaryoverride (clang-cl)Stephan Bergmann5-16/+0
Change-Id: Id2b5cd255188e32216d1dd79f3dc5c4f08eb9373
2017-03-11Fix typosAndrea Gelmini2-2/+2
Change-Id: I2be7113bfe86476acfd6550f1eed53eed83c9747 Reviewed-on: https://gerrit.libreoffice.org/35063 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-11Fix (German?) spelling mistakes in comments: s/save/safe (the adjective)Tor Lillqvist1-1/+1
Might be more of them left, I found these by looking for "is save" or "it save". Many more potential misspellings of "Safe" as "Save" in identifiers are left. Need to check individually which of them actually mean "Safe", which mean "Saved" perhaps. Change-Id: I5d3791ea2df2e1d485f65400404972b72af45aec
2017-03-06drop various _MSC_VER < 1900 conditionalsCaolán McNamara1-2/+0
Change-Id: I68d93b260db1f542bb3b44858b61b2d30ae93530 Reviewed-on: https://gerrit.libreoffice.org/34856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-02Fix typosAndrea Gelmini2-10/+10
Change-Id: Ibc81246e615d7c68c93e01b84584e78a79bece16 Reviewed-on: https://gerrit.libreoffice.org/34779 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-12Typo: (De)SelectMutipleChidren->(De)SelectMultipleChidrenJulien Nabet2-4/+4
Change-Id: Ia3a998e3629c5e002379e6a85b015b6546c59fb8 Reviewed-on: https://gerrit.libreoffice.org/34156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-26Remove dynamic exception specificationsStephan Bergmann27-64/+43
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann1-2/+2
Change-Id: I0f967f75dc41b3dc65790cf97bdac992033d1c92
2017-01-06loplugin:salboolStephan Bergmann1-1/+1
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
2016-12-16loplugin:unnecessaryoverride (clang-cl)Stephan Bergmann1-5/+0
Change-Id: Ib98620423606e355cf24ee3954f196d9f073c30d
2016-11-11loplugin:vclwidgetsStephan Bergmann2-3/+3
Change-Id: I518db241a76bccbe060242eeeafd58135b2ac560
2016-11-08typo fix: ressource -> resourceAndras Timar1-1/+1
Change-Id: Id8d1c01b17e711a057a9f3f20e1d0f955b2ea6c8 Reviewed-on: https://gerrit.libreoffice.org/30690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-10-15clang-cl loplugin: winaccessibilityStephan Bergmann62-925/+836
Change-Id: I40f8a6fef9d66b28a1d72551a6873b041b38b09d Reviewed-on: https://gerrit.libreoffice.org/29840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14Fix GetMnemonicCharStephan Bergmann1-13/+10
For one, had a (false) occurrence of loplugin:bodynotinblock. For another, would have erroneously reported 'A' instead of 'B' for "~~A~B". Change-Id: I6b2e09ad0d0e132896a9f2802bf4355a25f2d296 Reviewed-on: https://gerrit.libreoffice.org/29808 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-11cppcheck: uninitMemberVarJochen Nitschke1-4/+4
Change-Id: I4ff6d15941bf561ed67d84e4bda532131c8c7a43 Reviewed-on: https://gerrit.libreoffice.org/29622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10cppcheck: variableScopeJochen Nitschke1-5/+3
Change-Id: I6c8b7aaedf7fcde5165d3a65af54aa0bcafc0b82 Reviewed-on: https://gerrit.libreoffice.org/29624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-02cppcheck invalidPrintfArgTypeJochen Nitschke1-1/+1
signedness and long vs int corrections Change-Id: I67c6b9e05b16f5d8d4693879f1656db50dc7ec48 Reviewed-on: https://gerrit.libreoffice.org/29355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-25-Werror,-Wnonportable-include-path (clang-cl)Stephan Bergmann21-27/+27
Change-Id: Ia468adf0bea2f7fca9b370ef0ff8b05e34b3ac19
2016-05-25SAL_FALLTRHOUGH in Windows-only codeStephan Bergmann1-0/+1
Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
2016-05-25Mark dubious fallthrough cases as "SAL_FALLTHROUGH; //TODO ???" (in Win-only)Stephan Bergmann1-0/+1
Change-Id: If5ee201aab8c4451971a11ea7d7ff943c9a1a726
2016-05-25Harmless missing breakStephan Bergmann1-0/+1
Change-Id: I0e0abfea2f38fdc25077a8c5a9a7d2438cde2362
2016-05-24remove unused struct memberJochen Nitschke1-18/+15
TYPE_BSTR_MAP.type was never used, this makes struct obsolete. replace magic numbers with constants Change-Id: Ifbe236c102f78cc570401254dda2fba9bb2c2a95 Reviewed-on: https://gerrit.libreoffice.org/25228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-19Resolve: "TODO(Q1): Make GetSystemData method virtual"Caolán McNamara2-2/+2
and remove the casting silliness, allowing the removal of cairo_cairo.?xx If anything is to go wrong I'd guess it'll be the windows directx stuff. Change-Id: I3e22c07b9c26ade9b27a245fdd8408de540643f4
2016-05-19rename to two GetSystemData methods to find all call-sitesCaolán McNamara2-2/+2
anyplace calling GetSystemChildSystemData on a SystemChildWindow is definitely right anyplace calling GetWindowSystemData on a Window *might* have intended to call GetSystemChildSystemData on a Window casted back to an underlying SystemChildWindow. Change-Id: I7dcf3a50d0b7ed29bc08cfdb15cc0dcb86be8fa7 Reviewed-on: https://gerrit.libreoffice.org/25158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-16Fix typosAndrea Gelmini1-1/+1
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-04Fix Windows-only code, part 5Stephan Bergmann1-2/+1
Change-Id: I1e51996d1035624b373dc5d27a7528f8351e0934
2016-05-04Fix Windows-only code, part 4Stephan Bergmann1-2/+1
Change-Id: Idf3f8c24a61973068f5354873d25dc2317fbb732
2016-05-01Fix typosAndrea Gelmini1-1/+1
Change-Id: Ideafa411b53fe4a5f2e6559be10c4cb82b58a256 Reviewed-on: https://gerrit.libreoffice.org/24543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-04-Werror,-WshadowStephan Bergmann1-1/+1
Looks odd that this isGet block is a perfect copy of what is already done before this else-if block, but I have no insight at all into that code, so just leave it at that. Change-Id: Ieefd6618cb6b0dc49bc4d2c4733b02be2a8e3f7e
2016-03-04Silence -Werror,-Wnon-virtual-dtor in generated UAccCOM.h (clang-cl)Stephan Bergmann19-18/+168
Change-Id: I9466931485ed5421be589def16185d5c036bdcb8
2016-03-04Silence -Werror,-Wnon-virtual-dtorStephan Bergmann1-0/+1
Change-Id: I3fdf72b014d2ca0b0bd96fc5eba5606b13b32258
2016-03-04-Werror,-WshadowStephan Bergmann1-2/+1
Change-Id: Ic87e8aacb2e8215751422969e78cc58e18fc5a42
2016-03-04-Werror,-WshadowStephan Bergmann1-1/+1
Change-Id: Idf72ab1a311fcbbc81b16d9a3c1e78aaa10332c0
2016-03-04Silence -Werror,-Wnon-virtual-dtor in external includesStephan Bergmann1-0/+1
Change-Id: I2ef42eca934588b219de52dfc7c373395118cc32
2016-02-09Remove excess newlinesChris Sherlock5-6/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-26-Werror,-Wsign-compare (clang-cl)Stephan Bergmann2-3/+5
Change-Id: I7a3f17e84bbf44a472838ab20b4490f1ef3654d6
2016-01-26Silence -Werror,-Wmissing-field-initializers in END_OBJECT_MAP (clang-cl)Stephan Bergmann1-1/+7
Change-Id: Ia9ba7fc6cd94e2d726cd9b1dc72c140af16dd700
2016-01-26Silence more warnings, clang-cl's /W4 now also includes -WextraStephan Bergmann1-0/+1
Change-Id: I20fa3b02570bdbc3ccd297401a7669b0fda5c624
2016-01-26-Werror,-Wunused-parameter (clang-cl)Stephan Bergmann4-7/+7
Change-Id: I1ac58714e04b995ef5229888f0c427104c001318
2016-01-10Fix typosAndrea Gelmini4-4/+4
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-28Silence clang-cl -Wextra-tokens in midl-generated codeStephan Bergmann2-1/+17
Change-Id: Ib7f83de9bd0636cff11c5e75932d2bc8fd8437fa
2015-11-28Silence clang-cl warnings in ATL headersStephan Bergmann1-0/+13
Change-Id: I42fe7bfcd89c11fe2940bff43d4a8653e0026db2