summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2016-02-12split the gtk2 and gtk2 gtkobjectsCaolán McNamara2-22/+184
Change-Id: I32084232c44a12e9641010b51e75710abc827695
2016-02-12tdf#95857 Sort out German plurals ...danielt9983-10/+10
Made a start in removing the incorrect 'Infos' German plural Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60 Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock86-272/+272
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
2016-02-12Related: rhbz#1287593 issue 8, set a 'dark shadow' color based on the themeCaolán McNamara1-16/+8
pick something that is supposed to be a large contrast against the bg but is different from the fg Change-Id: I36d2f9e5aff0e06e89dbb41250e09f9cc972cd4c
2016-02-12Blind Windows fix attemptStephan Bergmann2-2/+2
Change-Id: If4f83dfa0b2977f404715b7a95a73cbcdfc4f5df
2016-02-12-Werror,-Wunused-functionStephan Bergmann1-5/+0
Change-Id: I8bed7d76a76a1fd5cd71731a8dbff19f29fd2854
2016-02-12Related: rhbz#1287593 subissues 1 & 2, pick 'tab' suitable colors from themeCaolán McNamara1-0/+4
we don't use these for "real" tabs in tabcontrols in the gtk3 themeing but they get used in other places Change-Id: Ia55b8a43604f624ac82923897a01050fa4aa2bc9
2016-02-12gtk3: we don't render whatever a CTRL_LISTNET isCaolán McNamara1-0/+1
Change-Id: I21a64250182b4630fa41583d7536081adf441ec5
2016-02-12Related: rhbz#1287593 subissue 6, get suitable hyperlink colors for dark themeCaolán McNamara3-19/+22
Change-Id: Ieb5ed52fa8a9c26b3e839388a58cff295166eed9
2016-02-12add CVE-2016-0952 testcasesCaolán McNamara2-0/+1
Change-Id: Icbd931b51374d70ab0e94a4fe1357342f78e8700
2016-02-12add CVE-2016-0951 testcasesCaolán McNamara2-0/+2
Change-Id: I50ca91f95557b48bb5a55f459c2a6053d2fe8d85
2016-02-12gtk_icon_info_free is deprecatedCaolán McNamara1-6/+3
Change-Id: I7e5494d3a8c8e16da3864d14a9194c430d42202e
2016-02-12tdf#97425 - JVM start parameters should be editable.akki951-0/+6
Added new dialog to edit Java start Parameter. Modified UI of JavaStartParameterDialog using Glade. Renamed Assign Button to Add. Added a function to edit.cxx vcl file to move cursor to last letter of GTKEntry. Change-Id: Ia43e2c0fbced5674a84187de02a9bc9460141f2d Reviewed-on: https://gerrit.libreoffice.org/22220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-12loplugin:unusedmethodsNoel Grandin2-4/+0
Change-Id: I0fb06079ff8a9d0b2f5a2929f31846f91391f5c4 Reviewed-on: https://gerrit.libreoffice.org/22229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-11tdf#97763 - avoid divide by zero for scaling images to tiny dimensions.Michael Meeks1-0/+4
Change-Id: I27efebcc1c24d45c17da2ad2959b673153c3eead Reviewed-on: https://gerrit.libreoffice.org/22297 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-02-11Keep track of ThreadsEnter/Leave acquire counts per threadStephan Bergmann2-15/+10
Appears that gtk_clipboard_wait_for_targets (called from GtkClipboardTransferable::getTransferDataFlavorsAsVector, vcl/unx/gtk3/gtk3gtkinst.cxx) internally calls gdk_threads_leave/enter, so if two threads concurrently try to call into getTransferDataFlavorsAsVector, each with the SolarMutex recursively acquired a different number of times, the GtkYieldMutex::ThreadsLeave/Enter calls can pair up so that the threads' acquire counts get swapped. Then eventually causing one thread to prematurely get the SolarMutex unlocked. This was fairly well reproducible when calling an --enable-dbgutil's soffice with an .oxt file on the command line, causing both the Extension Manager dialog and an empty Writer document to open simultaneously (which apparently both run into the above getTransferDataFlavorsAsVector), and then running into some DBG_TESTSOLARMUTEX assert firing when the SolarMutex had been unlocked prematurely. According to <http://en.cppreference.com/w/cpp/compiler_support>, support for thread_local is available partially since GCC 4.4 and fully only since GCC 4.8, so hope the partial support in GCC 4.7 (our current baseline) is good enough for what is used here. Change-Id: I9fad318078be5f31111a7cbd15d0e1349e7ddd3e Reviewed-on: https://gerrit.libreoffice.org/22291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-11tdf#97715 fix inv. scale calculation in DrawTransformedTextureTomaž Vajngerl1-2/+7
When image was rotated towards 90 degree the ixscale and iyscale went towards infinity. That caused problems in fragment shader areaScaleFastFragmentShader. The problem was with calculation of destination width and height which didn't take rotation into account correctly. This commit takes this calculation from WinSalGraphicsImpl::drawTransformedBitmap. Change-Id: I30f14a1ecda21ef167e58eda8e2fcef00bdfa2b7 Reviewed-on: https://gerrit.libreoffice.org/22289 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-02-11SalYieldMutex::acquire/release should always be called in pairs, no?Stephan Bergmann1-8/+9
Change-Id: Ia108d3d4db2a2f05d306da55a59520e9471bb336
2016-02-11gtk3: adapt to 3.20 style changesCaolán McNamara2-236/+644
todo: get rid of the rest of the getStyleContext foo in favour of additional createStyleContext entries. This appears to now render fine on f23 and f24. upstream gtk now has a foreign drawing demo in gtk-demo. Stuff we are trying to do here can be found in a cleaner single-version state there. And additional demos can be added to keep a reference of how to do this crap up-to-date. Change-Id: I5ae1a52a2cacc6d8178ed1af30a12536ba828050
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin1-3/+2
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-10vcl: actually remove ImplTranslateCommandEvent!Chris Sherlock1-10/+0
Change-Id: Ic120f83c5809074d082a86f677790ce9df35abcb
2016-02-10vcl: ImplTranslate(Command|Mouse)Event changesChris Sherlock1-9/+24
ImplTranslateCommandEvent is used exactly once, so remove this function. ImplTranslateMouseEvent is used a few times, make it local to the file and tweak. Added comments to both areas explaining what is being done. Change-Id: I68cd424a1d586df44957a62a66de3c9876ab873e
2016-02-10opengl: remove unneeded mnBufWidth{Height} from OpenGLSalBitmapTomaž Vajngerl3-24/+6
Change-Id: Idf445b9f6b403a0d37650c14e17b7d754451edf1 Reviewed-on: https://gerrit.libreoffice.org/22258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-02-10vcl: move CommandEvent functions from header to cxx fileChris Sherlock1-0/+162
Moving functions from commandevent.hxx to commandevent.cxx, this means they are no longer inline, but there was no clear reason as to why they were inline in the first place! I've also reordered the header to ensure that CommandEvent is the first fully declared class, the data classes get declared after this (hence the forward declarations). This makes reading this header much easier. One more small thing: a few if statements had braces in the primary if block, but not in the else block, which is IMO bad style and can possibly lead to errors. I've made the else block use braces. Change-Id: I79b010bd66d3c9f4a74d4fa470f62d0263c811f4
2016-02-10opengl: invert50 shader compilation errorTomaž Vajngerl1-3/+3
- can't assign vec4 to vec2 - LHS of `&&' must be scalar boolean Change-Id: I46bef7d41198ed1a33f9c3f7796f25358849852e
2016-02-10Don't fall back to Tool Bar as accessible name for toolbarsNiklas Johansson1-2/+0
There is really no need to force an accessible name on the toolbar The fact that it is a toolbar is already given by the accessible role TOOL_BAR. By giving it the name Tool Bar will make some screen readers read Toolbar toolbar and then whatever control is in focus. Change-Id: Ie033f7f98ece2481b8e4b1ce72f4254a3cfd7303 Reviewed-on: https://gerrit.libreoffice.org/22088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-10tdf#97700 - vcl: opengl - fix memory corrupting size mis-match.Michael Meeks1-0/+6
Change-Id: Iab49a20c85f9deb3e8c60a782050aa4c12b663ad
2016-02-10tdf#97700 - vcl: opengl - add asserts for horrible size mismatch.Michael Meeks1-1/+26
We really need to be sure that our texture and its wrapper agree on the size of the texture, and particularly the buffer it is reading into to avoid DMA'ing junk over the heap. Add paranoid assertions, also add a canary at the end of the texture so we fail hard and fast in this case. Change-Id: Ibf4869fb5cba562aa117943ce0f2f3df21ca7036
2016-02-09vcl: opengl - clear the user buffer after greyscale conversion.Michael Meeks1-0/+4
Change-Id: Ie87fc935bf69b5eb2c620e60d041fb95b544ec96 Reviewed-on: https://gerrit.libreoffice.org/22243 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-09vcl: opengl - do some writes on the CPU to help valgrind in debug mode.Michael Meeks1-0/+6
Change-Id: Ic44a458f7717647f399a9419fcdc8acc812edc97 Reviewed-on: https://gerrit.libreoffice.org/22241 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-09vcl: opengl - fix crashing / memory corrupting issues with updateChecksum.Michael Meeks1-16/+8
Switch to use GetTexture which is robust over a number of corner-cases. Also ensure that we have a valid VCL OpenGLContext. Change-Id: I79b2b8ee241da4ed79e93e30df005e8c32ffcf02 Reviewed-on: https://gerrit.libreoffice.org/22242 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-09Don't leak old m_pSurfaceStephan Bergmann1-0/+5
Change-Id: Ief35b95af3da58845291ab27b4eb09895e0256a2
2016-02-09vcl, libreofficekit: gtk_clipboard_wait_for_contents() may return nullMichael Stahl1-0/+4
Don't crash then. Change-Id: I4980fe4ea56e023cbf303fa43d1e6b383d983d2e
2016-02-09tdf#94097: Move 'Print to file' option to the front pageKatarina Behrens3-50/+40
Change-Id: I4acc09d0a46d82cfc9a63cbffe8e53a1b86f3acd Reviewed-on: https://gerrit.libreoffice.org/21908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-02-09Revert "headless: don't let windows become really visible to avoid paints."Tor Lillqvist1-4/+0
Causes CppunitTest_sd_tiledrendering to fail. This reverts commit 8455fe462a5a0e82ed2f98d303d36623b5920f9d. Change-Id: Ida95ea8855110f2c4322ffdee8fc6865e46ccad3 Reviewed-on: https://gerrit.libreoffice.org/22226 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-02-09gtk3: endless trudge as gtk changes theming yet againCaolán McNamara1-140/+150
start by silencing the warnings Change-Id: I2aa430e712e189a856a10c9d2284ef54dcfcb7d9
2016-02-09tdf#97666 -opengl: convert the bitmap to 8bit grays using GL shaderTomaž Vajngerl9-0/+101
Change-Id: I4d48d29ab752814f71c697a201e70a26ae937775 Reviewed-on: https://gerrit.libreoffice.org/22223 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-02-09headless: don't let windows become really visible to avoid paints.Michael Meeks1-0/+4
Paint at the wrong time has a habit of allocating over-large OutputDevice's for the drawing layer; saves 7Mb of heap for a dummy tilebench document. Change-Id: Ie06df705a55faadea2b06fd24b904d95ae64fd83 Reviewed-on: https://gerrit.libreoffice.org/21919 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-02-09Remove excess newlinesChris Sherlock11-19/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock33-58/+3
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09tdf#97662 - Try to preserve original compressed JPEGs harder.Michael Meeks1-7/+62
Avoiding de-compressing and re-compressing them saves lots of time too. Change-Id: Ie8eb68554627581b2f0584a55bbbdb43c9482bed Reviewed-on: https://gerrit.libreoffice.org/22219 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-02-08vcl: cmdevt.[hc]xx -> commandevent.[hc]xxChris Sherlock5-11/+11
Change-Id: I77b30f28ae5a6fad360d7cada9acfaa9c324408b Reviewed-on: https://gerrit.libreoffice.org/22216 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08headless: for now don't allocate big cairo surfaces for invisible frames.Michael Meeks1-2/+7
This was ~10Mb of RAM for a hello-world.odt under tile-bench. Change-Id: Ie0787676be754ac81eb8ec036c9757a1bb2f2220 Reviewed-on: https://gerrit.libreoffice.org/21918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-02-08tdf#97458 - remove unused intel opengl driver version special-casing.Michael Meeks2-34/+0
Change-Id: I938bcab02edb37a5e7d72f1551867e0f5a4dd89b Reviewed-on: https://gerrit.libreoffice.org/22215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-02-08tdf#97573 Calc tabbar: plus sign with narrower, but min. 2px linesLászló Németh1-4/+4
The "New sheet" icon was a thick cross in some environments instead of a plus sign. Change-Id: If5e3ff189b4aca1ef6a61172998675489796934a Reviewed-on: https://gerrit.libreoffice.org/22113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-08duplicate leaky linesCaolán McNamara1-2/+0
Change-Id: I19e6e4955241d2811678dc15ce07de6ac5b04036
2016-02-08Fix XBM-format cursor dataStephan Bergmann2-2/+2
Change-Id: I7e8dc166a33ad1bf98029a7ed323a7ddcbe74bfb
2016-02-08revert part of "loplugin:unusedmethods"Noel Grandin1-0/+12
<sberg> noelgrandin, just happen to look at b14224fe again; looks a bit scary to remove == or != from cases where both where declared <noelgrandin> sberg, ok, I can revert that part <sberg> noelgrandin, I guess that would be safer (there could be cases where now a different overload could kick in) Change-Id: I5dc41c05dc4439d5adee0e5b3e0a9e1dfb9de3af Reviewed-on: https://gerrit.libreoffice.org/22211 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08cppcheck: noExplicitConstructorCaolán McNamara1-2/+2
Change-Id: I74585aa5a50cd335f4fd0a3ba4fed230b98993c3
2016-02-08loplugin:unusedmethodsNoel Grandin5-89/+0
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 10:56:56 +0000