summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2019-04-30improve loplugin:stringconstantNoel Grandin13-75/+75
to find more places we can elide the OUString() constructor at call sites Change-Id: Ie09f3c61f2c4b4959c97dc98ebcbaf7c51d5d713 Reviewed-on: https://gerrit.libreoffice.org/71514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-30drop Graphic::operator boolNoel Grandin4-21/+11
which tends to interact in very weird ways with other code, for example it makes Graphic appear to have an operator< Change-Id: I335fe8f3644b710bc61291e625cbca7334a37716 Reviewed-on: https://gerrit.libreoffice.org/71532 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Fix typoAndrea Gelmini1-1/+1
Change-Id: Ic4c0977357d7c4feb4100eeb15a6e9a4866374d3 Reviewed-on: https://gerrit.libreoffice.org/71554 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-29tdf#124990: DnD operation can be set to fail in dropCompleteKatarina Behrens2-2/+26
thus we reimplement it for Qt5DropTarget. This is qt5 remix of tdf#118302 (in Calc drop into the same tab should cancel DnD, instead of causing data loss) Change-Id: Ib37ea5a018133779e85e8e131d81bb6cee7d9206 Reviewed-on: https://gerrit.libreoffice.org/71531 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-29unipoll: do the legacy wakeup if not in unipoll mode.Michael Meeks1-2/+16
Change-Id: I7f5663f3316eb2bafcf13d07e2af69ae6f0637f5 Reviewed-on: https://gerrit.libreoffice.org/71445 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Jenkins
2019-04-29gtk_tree_model_iter_parent modifies the 1st arg, not 2ndCaolán McNamara1-1/+0
Change-Id: I015022c4dd68f152ef5e56947031ccf4bfaf2b1c Reviewed-on: https://gerrit.libreoffice.org/71516 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-29clean up iterator code in SystemDependentDataBufferNoel Grandin1-12/+3
Change-Id: I5f0cd0884b6490ae3018de13e3508b76e201d55f Reviewed-on: https://gerrit.libreoffice.org/71507 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-29speed up gtk menu construction at startupNoel Grandin2-6/+21
Change-Id: Ia28b1f0281485691e3b4188d23947014c1eff385 Reviewed-on: https://gerrit.libreoffice.org/71465 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-29optimise ImplScaleConvolutionVer a littleNoel Grandin1-18/+13
cache the reading of the source scan line, and use sal_Int32 for pixels and counts (long is 64-bit on 64-bit linux) Change-Id: Iaa0abc3ed3316d3137184b0c051612874885ddf4 Reviewed-on: https://gerrit.libreoffice.org/71462 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-29Add MetaActionTransparent to the SVM testTomaž Vajngerl1-2/+37
Change-Id: Ia927070883e5647b61876e31d6a0a085e2456f8a Reviewed-on: https://gerrit.libreoffice.org/71498 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add TextAlign,RasterOp to the SVM testTomaž Vajngerl1-4/+38
Change-Id: I58b7bb114864a9fdf901a92d54717964c6f1b68e Reviewed-on: https://gerrit.libreoffice.org/71497 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add LineColor,FillColor,OverlineColor to the SVM testTomaž Vajngerl1-6/+65
Change-Id: Id130dd7739b9662541b50b7792da170da70a6a9b Reviewed-on: https://gerrit.libreoffice.org/71496 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add MetaActionClipRegion to the SVM testTomaž Vajngerl1-2/+29
Change-Id: I51bd172cdd22d55a6800d1e74e38149874629f85 Reviewed-on: https://gerrit.libreoffice.org/71495 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add MetaActionWallpaper to the SVM testTomaž Vajngerl1-2/+34
Change-Id: Icce9c3c5fa826b6f5237d2d0e28fc51555a3e267 Reviewed-on: https://gerrit.libreoffice.org/71494 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add MetaActionHatch to the SVM testTomaž Vajngerl1-2/+44
Change-Id: I96113168d4ae8289cec3a5b0bbd6aa79faf97c48 Reviewed-on: https://gerrit.libreoffice.org/71493 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29update Metafile dumper and change the order of MetaActionsTomaž Vajngerl1-236/+385
Change-Id: Ib851156da20528e7df5197ba96c35727af7bdbb6 Reviewed-on: https://gerrit.libreoffice.org/71492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add all MetaActions to SVM tests as stubs, change order of testsTomaž Vajngerl1-56/+195
Change-Id: Ic0f143ea6871965a5d1e9db4b35db88f8adb5181 Reviewed-on: https://gerrit.libreoffice.org/71491 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28Just apply Asian kerning to unmodified glyphsJan-Marek Glogowski1-5/+3
IMHO the old code was doing the opposite of the comment. But the comment makes more sense then the code, so adjust the code accordingly. OTOH just this code was added in commit f89d70de85a6 ("INTEGRATION: CWS vcl27 (1.30.48); FILE MERGED 2004/09/09 12:33:53 hdu 1.30.48.1: #116489# only apply asian kerning on default-formatted text"). Maybe still a bug? Can't check the bug tracker, as this is pre-Apache, and so can't verify the old bug :-( Change-Id: I550d1524d3e82f7e853820d3e5ddab8cc62228f9 Reviewed-on: https://gerrit.libreoffice.org/71441 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-28Move and fix Asian kerning unicode point checkJan-Marek Glogowski1-10/+10
It's the same then * (1 != c && 2 != c) || (3 != c) * !(1 == c || 2 == c) || !(3 == c) * !((1 == c || 2 == c) && (3 == c)) which is always true. Change-Id: Ib63127319ff7e9c13877ac54aa92427637061812 Reviewed-on: https://gerrit.libreoffice.org/71477 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-28Move lcl_CalcAsianKerning near its only userJan-Marek Glogowski1-50/+47
This function is just used by ApplyAsianKerning, so move it there. While at it drop the unused constant boolean. Same for the comment referencing ImplCalcKerning, which is long gone since a huge merge in commit 2f382d6c2579 ("MWS_SRX644: migrate branch mws_srx644 -> HEAD"). Also "const int"ify ApplyAsianKerning. No need for long, as the lcl_CalcAsianKerning just returns int in the range [-2,+2]. Change-Id: I9b1b3351ab71219c8e2ee49ce441f5222e5c1c4b Reviewed-on: https://gerrit.libreoffice.org/71476 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-28tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski1-4/+1
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I11fa13677c7980e6ac17fc4358406472ee784e41 Reviewed-on: https://gerrit.libreoffice.org/71446 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28prefix member variables of AnimationBitmapTomaž Vajngerl6-84/+90
Change-Id: Ic84773399c95d61f843e4388fe01d00cd4facc5a Reviewed-on: https://gerrit.libreoffice.org/71425 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28move Animation, AnimationBitmap out from clang-format blacklistTomaž Vajngerl2-265/+253
Change-Id: I95fd2d4e164bf04c4457b3e20401270227e21a8f Reviewed-on: https://gerrit.libreoffice.org/71424 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28Separate AnimationBitmap from Animation.{hxx,cxx} sourceTomaž Vajngerl3-31/+55
Change-Id: I982a108b2241c049b595a13d6f39d24ef0266074 Reviewed-on: https://gerrit.libreoffice.org/71423 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28rename animate.hxx to animate/Animation.hxx, more changes followTomaž Vajngerl6-6/+6
This is the first step of refactoring Animation where it is needed to separate AnimationBitmap(s) from the Animation class, which is also responsible for displaying of animation. General idea is to make Graphic work only with AnimationBitmaps, which can be freely be swapped out and in, make copies - all transparantly from the actually displaying them and possibly it will also remove the need to copy the animation objects. Change-Id: If5d55ac1a5b26c3880d4f7602be57742b086f9da Reviewed-on: https://gerrit.libreoffice.org/71406 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28tdf#124944 don't directly adjust fallback layoutsJan-Marek Glogowski1-2/+0
These are adjusted via MultiSalLayout::AdjustLayout, as they just know their own text width, but not the full text width of the MultiSalLayout, so the adjustment is too large. The correct adjustment is done by preparing a DXArray for all glyphs, which is then passed to the individual font fallback layouts for general adjustment. Change-Id: I439527d03df4752e74ff94aee7775a95275be5e2 Reviewed-on: https://gerrit.libreoffice.org/71440 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-28Minimize scope of variablesJan-Marek Glogowski1-2/+3
Change-Id: I6602c84b9bd7143e5e7b224c17559b083c9b7f9c Reviewed-on: https://gerrit.libreoffice.org/71439 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-27Fix typosAndrea Gelmini1-1/+1
Change-Id: Id81e8db5a38b4e4a88cc21c50234c2338e9c41bf Reviewed-on: https://gerrit.libreoffice.org/71421 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Resolves: tdf#124975 toggle parent input blocked only in set_modalCaolán McNamara1-22/+11
since... commit e54762baa8019d02cadd311e750f6ff0d276f67b Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 16 17:17:58 2019 +0100 weld ScTPValidationValue and ScValidationDlg the inc/dev modality on show/hide isn't desirable anymore Change-Id: I5bf908871986160de61508c9678495d0d5a8296d Reviewed-on: https://gerrit.libreoffice.org/71426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27No need to link gtk3_kde5 with generic vclplugKatarina Behrens1-1/+0
like this since initial commit but prolly just copy'n'pasta error Change-Id: Id61c2d8ef1df496738575e4ee4879d71a40b4934 Reviewed-on: https://gerrit.libreoffice.org/71381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27ofz#14469 null derefCaolán McNamara1-1/+3
since... commit af84fc9d906626255aaf136eefc5e55236e0e8a6 Date: Tue Apr 23 15:48:41 2019 +0200 lazy image loading shouldn't read the entire .xls file (tdf#124828) nLength is just an unchecked value in the dff stream, it might not be sane so limit it to the max len of the stream Change-Id: Ia8a2830478952afe1317b5cd795f35059d9b380a Reviewed-on: https://gerrit.libreoffice.org/71412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Use AutoTimer for SystemDependentDataBufferJan-Marek Glogowski2-19/+8
This cache eviction timer is periodic, so just use an AutoTimer, to prevent the "expensive" Start() calls. This will instantly re-schedule the task again. OTOH Stop() is really cheap, as it just sets a bool. Same for IsActive(), which just checks that bool. We do lazy cleanup of stopped tasks in the scheduler. This patch also changes the logic to just start the AutoTimer, if it's not already running and just stops it in the timer handling function, if there is nothing more to do. This way we can save allmost all the previous Start() and Stop() calls, but eventually have a single unneeded wakeup a second later. Change-Id: Iae05483f557b94e07e51c4baae25315596923c9c Reviewed-on: https://gerrit.libreoffice.org/71376 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-04-27tdf#123750 gtk3_kde5: Show removable devices in file dialogMichael Weghorn1-6/+3
Do the same for the gtk3_kde5 VCL plugin as commit 2c69c93fdb871809825fe8b9aff40b7afb093be8 does for the kde5 one. Change-Id: I6fc91d1dbe133bd905c033c9fce7d48c0b6464a0 Reviewed-on: https://gerrit.libreoffice.org/71384 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-04-27weld cluster of change tracking dialogsCaolán McNamara3-34/+189
Change-Id: I42ca7acb41699df91b91a9f59fc68cd30972a397 Reviewed-on: https://gerrit.libreoffice.org/70988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27remove comment in light of fix for tdf#120797Caolán McNamara1-13/+1
Change-Id: I3093f764a26abdbdb651596352ba74b7fa1c3306 Reviewed-on: https://gerrit.libreoffice.org/71399 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Resolves: tdf#124980 drop dangling timerCaolán McNamara1-0/+2
Change-Id: I05ec394ee83f0422ecccf3ae3377818af6feb1d1 Reviewed-on: https://gerrit.libreoffice.org/71398 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Decouple reading/writing of Color into GenericTypeSerializerTomaž Vajngerl7-46/+68
This adds GenericTypeSerializer, which is now responsible of serializing the Color into a stream (other types will follow), but only for the older version of the binary format. The new version we just write the sal_UInt32 mValue directly. This is a start of decoupling the serialization of generic types in tools and vcl module from the actual type, so we can in the future replace those with basegfx variant. Change-Id: I92738e7c178cac5cbca882dcbe45c80cc8269466 Reviewed-on: https://gerrit.libreoffice.org/71404 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-26tdf#124658 - Improve text for the tip-of-the-dayheiko tietze1-2/+4
All strings reviewed Change-Id: I7c9b2460b86576c67221c874bd9f99ea43db17d4 Reviewed-on: https://gerrit.libreoffice.org/71365 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-26tdf#120797: Apply transformation also to the extents of damageKatarina Behrens1-0/+6
since 7034311dce663c895577267110baadbec312d491 affine transformation is passed down to drawPolyPolygon and drawPolyLine functions. The transformation was correctly applied to cairo context, but not the extents of damage so those had old, untransformed coordinates and were therefore not redrawn Change-Id: I61ce005ef8770ce5c4560a9d953cd92f440043be Reviewed-on: https://gerrit.libreoffice.org/71383 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-26tdf#118977 support PDF documents as a clipboard formatTomaž Vajngerl2-0/+15
On macOS it is possible to copy from a PDF a subset of a document, which will be transported as a new PDF document containing the subset. LibreOffice didn't support PDF as a valid clipboard format and previously it also didn't support showing PDFs inside the document, so in such cases it copy-pasted a low resolution bitmap. The result wasn't good. As we are now able to display PDF documents as Graphic in LO, we can also support this use-case. This adds support for the PDF documents as a clipboard format in general and to the macOS backend. This commit only adds support for Writer. Change-Id: Ib982b55391b390ae06974b4ad836e376dd722a4c Reviewed-on: https://gerrit.libreoffice.org/71364 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-26sw: sync UNO API default for ToC link start char style with UIMiklos Vajna2-0/+92
The UI default is in the SwForm ctor, where the content type sets the link start char style to STR_POOLCHR_TOXJUMP. Have the same default in the UNO API in case the import filters don't set it explicitly, since that breaks clickable hyperlinks on PDF export. This also fixes the OSL_ENSURE() failure for missing character formats in SwTextINetFormat::GetCharFormat(). Change-Id: Ifff354d56a569614ca7f5a89dd75f41817300078 Reviewed-on: https://gerrit.libreoffice.org/71366 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-26tdf#123750 kde5: Show removable devices in file dialogMichael Weghorn1-6/+3
As the Qt documentation for 'QFileDialog::supportedSchemes' says, setting supported schemes to a non-empty list restricts the available options: "Setting this property allows to restrict the type of URLs the user will be able to select. It is a way for the application to declare the protocols it will support to fetch the file content. An empty list means that no restriction is applied (the default)." The call to 'QFileDialog::setSupportedSchemes' was copied over from the gtk3_kde5 VCL plugin in commit 6196b7292fbb3168c558e64881601148c15653e4, where it had been added by commit f1b60bd62daff4aaf6465caadd4ad0c447521102 "Support opening of (some) remote URLs through the KDE file dialog". Since only either all schemes (if nothing explicitly set) or a whitelist of supported locations seems to be possible (s.a. the Phabricator changes referenced in the commit message of commit f1b60bd62daff4aaf6465caadd4ad0c447521102), add the "" scheme that makes removable devices shown -- while there doesn't seem to be an official documentation on the available schemes, at least not in KFileWidget's API documentation [1]. A quick test with all new available options after removing the call to 'QFileDialog::setSupportedSchemes' altogether indicated that opening and saving files there doesn't work reliably in all cases, so rather excplicitly add the "" scheme rather than claiming support for all schemes (including e.g. "timeline", "search", "remote", "trash"). [1] https://api.kde.org/frameworks/kio/html/classKFileWidget.html Change-Id: I89dc37d0f06d280e5dd599f90768c13e8edb915b Reviewed-on: https://gerrit.libreoffice.org/71320 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-26cleanup osx/clipboard.{cxx,hxx}Tomaž Vajngerl2-86/+87
Change-Id: Iff472d81f7ef0a3371a0735f025a72c595321efd Reviewed-on: https://gerrit.libreoffice.org/71352 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-26tdf#119965 implement tooltip widget style on macosTomaž Vajngerl2-0/+19
Change-Id: I7625adbf365aa908c072ca42060e926569629044 Reviewed-on: https://gerrit.libreoffice.org/71279 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-26tdf#124598 gtk3_kde5: Link gtk3 side against kf5 libsMichael Weghorn2-0/+10
The separate filepicker executable 'lo_kde5filepicker' used by the gtk3_kde5 VCL plugin needs the KF5 libraries (in particular the 'KFileWidget' class) in order to provide custom controls in the Plasma-native QFileDialog. The gtk3 side ('lo_kde5filepicker') itself doesn't use any functionality from KF5 libraries itself and therefore didn't link against those. When determining which VCL plugin to use on LibreOffice start, a 'dlopen()' is used on the libraries of the potential VCL plugins, which fails if linked libraries are not available, so unsuitable VCL plugin are skipped. This mechanism didn't work for the gtk3_kde5 VCL plugin if KF5 libraries were not installed, since the 'dlopen()' on 'libvclplug_gtk3_kde5lo.so' would succeed, but starting the 'lo_kde5filepicker' process would later fail at runtime due to the missing libraries. To avoid this, make 'libvclplug_gtk3_kde5lo.so' link against KF5 libraries as well to prevent gtk3_kde5 from being used unless all required libraries are actually present. Add a dummy KFileWidget use in Gtk3KDE5FilePicker to prevent smart linkers from not linking unused libraries despite linker flags. While this is a hack, it seems to be acceptable, in particular since gtk3_kde5 is more meant as a temporary solution supposed to be dropped at a later point in time in favor of the pure kde5 VCL plugin. Change-Id: I3a37daaeb1307b4f24f6fd75d7b6ec5ffaade0fd Reviewed-on: https://gerrit.libreoffice.org/71237 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins
2019-04-26Reuse base class IsCurrentThreadStephan Bergmann1-2/+1
Change-Id: Ie185983d7cf546def5e310493c7b26f520bbe08d Reviewed-on: https://gerrit.libreoffice.org/71344 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-26There is no ImplSVMainHook()Tor Lillqvist1-1/+1
Change-Id: Ief2636425712f60cfc6e8f68ee0d3fb01608d8ba Reviewed-on: https://gerrit.libreoffice.org/71317 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-04-26Fix typosAndrea Gelmini2-2/+2
Change-Id: I81d85cb8ae8b0075929beb01e8991d895b94d0c4 Reviewed-on: https://gerrit.libreoffice.org/71314 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-04-25Cut down on -pthread/-lpthread proliferationStephan Bergmann15-20/+0
Building against libstdc++ effectively always requires -pthread anyway (as various standard C++ headers require it, see the comment added to solenv/gbuild/platform/unxgcc.mk), so many explicit uses of -pthread/-lpthread can be removed. Doing a (partial) test build on Linux with Clang -stdlib=libc++ suggests that libc++ indeed doesn't need -pthread as libstdc++ does. The remaining uses of -pthread/-lpthread are mostly in configure.ac for the various BSDs (which somebody else might want to clean up now), and related to external projects. I tried to be careful to remove -pthread/-lpthread from makefiles only when C++ object files are involved (so -pthread will now be included on the link command line by default). Change-Id: I936e082839cb9a434bd273ce5a1f187a4245dfa1 Reviewed-on: https://gerrit.libreoffice.org/71291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-25test unreliable under windowsCaolán McNamara1-1/+1
Change-Id: I1f46c6043b3263ef983991ffa4aa0418006d55a7 Reviewed-on: https://gerrit.libreoffice.org/71292 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 07:25:08 +0000