summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2020-07-21tdf#134646 Remove "nearest paper matching" featureSamuel Mehrbrodt4-64/+14
This was introduced with da62b0feb684b34ab191fb0f03ed5432c14cba97 to find the best paper size for user defined page sizes. However, this leads to problems with Impress: Slides have screen sizes which have no relation to paper sizes. For the slide site "Screen (16:9)" the page size "Executive" is the nearest matching size. However, this paper is (though supported by printers), very uncommon. We do not want the nearest matching paper size the printer supports, but rather we want to fit the slide on the printer default paper. Note that finding a matching print paper still works (and it even has some fuzzy matching), so some sort of "nearest paper matching" still exists, (but with sane limits). Change-Id: Ie60023d64b251954aa50e8bbdd36f6a290b9f278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98396 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 3cfc390ecd7c7e9095c77383c460c522437bdabe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98968 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-20tdf#134085 DrawTransformedBitmap in wrong place for RTLCaolán McNamara2-111/+49
The return of mirror wasn't used, so no effort at a rtl mirror was made anyway. Looking at the similar case of polygons, the highlight polygons in the recently used view are also missing, they have also been misplaced we don't want to mirror polygons, we want to translate them to appear at their mirrored bounding box. Change-Id: Iefd853883bb6b99a352ce6969ceef7bd57046bc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98966 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-17merge needlessly split polygons back in Skia drawing (tdf#133016)Luboš Luňák2-11/+134
There are places in LO code that needlessly split polygons into a group of adjacent polygons. These should theoretically result in the same, but only if antialiasing is not used (where Skia has a problem and according to Skia developers that's not really Skia's fault). So whenever a possibly problematic polygon is asked to be drawn, delay it and try to merge it with followup polygons back into one polygon where those needlessly created problematic edges do not exist. This is indeed just a hack and those problematic places should be fixed, but oh well :/. Change-Id: I1b03fe7c2f5e8c962b0dcb8962196b7fea090146 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98887 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 12147e0322e0fdd1b561c94e7ebd3fdd69ceaac0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98841 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-16flush all Skia drawing before drawing to the screenLuboš Luňák3-1/+3
Otherwise xor drawing might not get applied. Change-Id: Ic1f9496c76c8f1162951e2ac4acbcd131c714a3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98885 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit b0ba9e835060f8f5daf3943a03039ed443705eba) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98839 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-16tdf#134841 image totally clipped outCaolán McNamara1-0/+6
the clip region seems to be out of date, this looks similar to the problem of "compared to other public methods of OutputDevice this test was missing ... one of the goals of the change was to use that method more often, so this may have never been detected before" where typical setup code was missing commit 828504974d70111e4a35b31d579cf42fe660a660 Date: Fri Feb 21 16:58:17 2020 +0100 tdf#130768 speedup huge pixel graphics Cairo Change-Id: Icd1495f3830b69ae207cad308e821257e3e5e44b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-16use consistent Skia pixel position adjustments (tdf#134346)Luboš Luňák2-21/+19
What happens in tdf#134346 is that the same shape was drawn twice, once using drawPolyPolygon() and once as an outline using drawPolyLine(). Those had different offsets, so with AA enabled the tiny difference could be actually visible. Be more consistent with how the pixels are positioned in float coordinates. Change-Id: Id852fef70e7bd829ff0108a86d1ebee29c300e3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98745 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 4bb931a488b8fe7a0b4961956252f667b683a630) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98834 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-13set also RGB/BGR LCD order for Skia text rendering (tdf#134275)Luboš Luňák1-0/+10
Change-Id: I797a851f52d9ba4c18127219b9042348225d14dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98199 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit fada69d6ee05700fd57c8844591562608a900a9d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98089 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-12m_pEntry may be nullCaolán McNamara1-1/+3
Change-Id: I704ff31906437f0d998f3089cf1df43d29187e0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98464 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-10tdf#134601 set entry font as combobox control font to take effectCaolán McNamara1-0/+1
Change-Id: I8cac0ebcd99fbfcd800074cc0d9acd924659753a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08prevent SkiaSalBitmap::Scale() from breaking indexed bitmaps (tdf#134574)Luboš Luňák1-2/+12
Since the actual scaling is done later at some unknown time, the palette mustn't change, but scaling can change colors. Change-Id: Ie254c8b31993d9d509c32a730dd8c8b5d3cb2256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98258 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 3769d01791e54be0fbfc6d706596283213700ad0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98330 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-08use gdk_wayland_window_set_application_id when it becomes availableCaolán McNamara1-7/+26
Change-Id: I60775dcbfbc396f195a71f219668944d0bfecf31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98333 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-05tdf#134479 allow disable font preview to work on existing font comboboxesCaolán McNamara4-19/+44
not just newly created one. you can only restore back to a text-only view, not a text+(icon/whatever) view Change-Id: Ic3becd7a942ee6b1dbabb57eebf1e25d1b626fdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03tdf#131942 no progress bar saving in CalcNoel Grandin1-2/+19
regression from commit a7de363cead5cd0021d2e3df4573d4cbe27df23b. remove unnecessary Window::Update() calls, which immediately follow Invalidate Change-Id: If081f9a54ad7fe528a7885ac796f0ec6a7059872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96975 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 23e8739b98e1fff3be70159182b20642b70122de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97806
2020-07-02Revert "implement Skia workaround for ... (tdf#133016)" (tdf#134346)Luboš Luňák1-18/+0
The workaround breaks a valid use in tdf#134346, so the original problem will need to be handled differently. Change-Id: I1560ef5714a90f1d170341c1b716010a0eb5aafc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97723 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 556c2a41a5114a8a366cd68e3112e7d3a594b45b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97680 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02focus grabbed to options extension page when browsing optionsCaolán McNamara1-2/+3
Window::Show grabs focus to the window if its a system window by default and XWindow::set_visible calls Show with default args Change-Id: Ief3b44068b867fe22f829de5d9722832692a35fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97681 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02actually call Skia init functionLuboš Luňák1-0/+5
The SkGraphics::Init() docs say it's called by global variable initialization, but that doesn't seem to exist. Call it manually, as it decides e.g. which CPU features to use. Change-Id: I7e0e18290240ff2ae3298d5569c22f7dc083dde4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97415 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 080731f27e818a6461f89ada62d2a903c569c35f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97491 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02differentiate between 8bit and any-bit grey palette (tdf#121120)Luboš Luňák12-22/+58
Only the grey palette with 256 colors means that pixel values map directly to color values. Tdf#121120 has an image with 2-bit palette where color index 1 is (255,255,255), but that means the pixel value 1 cannot be just treated as color. Change-Id: Ifbd953af7f291e4fb8032ea0f4c33c0514770856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97283 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 028ae8f61165a95de89993631f96a297c9c1ff94) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97490 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02properly copy pending scale quality in SkiaSalBitmapLuboš Luňák1-1/+2
EnsureBitmapData() was using Create() to make a copy of the bitmap to scale, but the quality was not copied, so it was usually at the default (and slowest) high quality. Change-Id: I7100304a935db420e2d55c2a9450016be1195965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97277 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 3ff036f0a64972e1905367081f87e919d1650d07) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97293 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02cache raster scaling also in Skia's drawAlphaBitmap()Luboš Luňák1-4/+16
Change-Id: I52849097267326cb362b113241179a766d286a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97273 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 172b9142194699d0e847703b0e0cfcabcb1de1ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97292 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02use Skia's SkShader for blending bitmapsLuboš Luňák2-106/+150
It turns out it's sometimes more efficient to use SkCanvas::drawPaint() with SkShader::Blend() used to blend bitmaps together, rather than manually creating temporary SkImage for the blending. This way it saves memory and it also performs faster e.g. for tdf#134237, where when zoomed it processes only relevant parts of the images instead of blending a whole enlarged image). Sadly in raster mode it is sometimes still faster to cache the image (e.g. with tdf#134160), so keep the caching there as well, for when useful. Change-Id: I887ae330907100c21a0d152783fcd7e8ef230355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97238 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 3d37d591377fe532fc0d32e9fbc8e57b8ded6768) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97291 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02do not use VCL scaling algorithm from SkiaLuboš Luňák2-42/+13
The only threaded one is "Super" (i.e. the default one), and Skia at a comparable quality seems to perform better. And the code is simpler too. Change-Id: I366197fe1a033c1f7a5f5c7f9fdcc00bff74dc11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97278 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 2a0c25020a145881a28a3e923b23747287b0d58b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97294 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02use boost::make_shared_noinit()Luboš Luňák1-2/+2
The unnecessary initialization of all elements with plain boost::make_shared() actually shows up in the profiler. Change-Id: I054b13ac74362aca7f2dfa7dc746d3a80c7f1042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97267 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit fd0bcf17122c2b995437c84db49504304c946a10) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97290 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02tdf#130991 Fit the drop-down arrow into its rectJan-Marek Glogowski1-15/+16
Looking at the original fixed-size arrow painting code replaced in commit b62c43d1200e524369d9c7c2bd1dad3044efd672 ("Anti-alias toolbar button drop-downs."), it used some fixed values of 5 and 3 to match the arrow box width of 11. The new code assumes the width is the expected arrow size, minus a minimal margin to separate the arrow from the button border, and there is enough height available. Based on these assumptions, the code now scales, positions and paints the triangle to fill the available space. Change-Id: Ied721e494d105106086ef6252e72ae7395eafe08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97537 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 1cb897a0f65ba066d1e81b62c70c3e46bbdb7ba8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97583 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-01tdf#130991 Scale the drop-down arrow size-requestJan-Marek Glogowski1-2/+4
When requesting the size of the drop-down arrow button, the arrow rect must be scaled, like all other native size requests. Change-Id: Ic0ccd96e812527c880868d385484655526ebb09b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97536 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit ba956e60a868e98d22bc95efd041f423987e7f76) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97576 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-01tdf#134054 Qt5 really scale the toolbox buttonJan-Marek Glogowski1-2/+6
I missed that code in the HiDPI patch. Instead of some fixed 25px size, use the real content size and ask the QStyle for the real size. Change-Id: I227190baab2c1716aa40ef6d16d55dbded0830cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97538 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 36a95b632173d1131c9da5737d2e2958eb4594ce) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97577 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-01tdf#132172 Qt5 just handle visible widget's focusJan-Marek Glogowski1-1/+2
I investigated the state of isWindow() and the SalFrameToTop flags for the detached find toolbar (tdf#126607) and the Impress presentation and the tabbed "page size" drop-down and all had the same status (isWin: 1, flags: 12). Than I had a look at the gtk3 implementation, which just handles focus requests, if the widget is already mapped (gtk_widget_get_mapped). So I also dumped the visibility as the nearest equivalent in Qt to the X11 mapped state, and that was different. In the end Qt now also just handles the focus for already visible widgets, like gtk3, which works for all the cases I tested (incl. tdf#125517). And omiting either activateWindow or setFocus breaks some cases... and I still don't understand the GrabFocusOnly flag, which is just handled in the X11 backends at all... Note: this doesn't happen with 7.0+, because the weld'ed version of that control (commit 3afc718eddcd81232392d46fccc24b8ec626c8df "rework PageSizePopup to be a PopupWindowController") doesn't expose this bug (and also doesn't support mouse-over highlight). Change-Id: Id085732f6a52bbc69ed47fbd3d57454756a03121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97549 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 43e09e1e890bd47ec1445f0b1537fcba3ef95dce) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97574
2020-06-30tdf#134054 toolbox: respect drop-down arrow rectJan-Marek Glogowski1-10/+8
When centering the text and icon on the button, the code didn't take the drop-down arrow rect width into account, resulting in an overlapped arrow. This is especially visible, if the drop-down is shown and the button is wrongly highlighted. There is supposed to be some vertical mode, which I couldn't find in the GUI, so this just adapts the width in horizontal mode. Change-Id: I194780dc32db610041ad0ee45a425e1026c7c4e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97358 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit cb71b364fcc21bd7aa25cacb8c24a8cbc9eabd21) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97379 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-30tdf#134390 update spin button before processing activate signalCaolán McNamara2-2/+10
Change-Id: I698c789c9fe79e931547d8b230a4885393f5ff28 and Related: tdf#134390 allow entry "activate" for gen spinbutton Change-Id: I3c497586479a08089f167ccb890e79e7b9d1f4bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fac0288099ef7acabafa214a47ed0ec342414bae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97477
2020-06-28tdf#131991 Qt5 RTL mirror mouse wheel X positionJan-Marek Glogowski1-1/+3
Just like all the other events, the mouse wheels X position must be mirrord in LO RTL mode. Change-Id: I28e8da0455d941f42f869b08edcdbe570de366c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97338 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit efc333b9bff560de0fd353da28296d8e08f55cee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97306 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-26log properly the compiler used to compile SkiaLuboš Luňák2-12/+5
Using #define's directly from VCL will report the compiler used to compile VCL, which may be different from the one used for Skia. Also truncate the log file on opening. Change-Id: Iddf613613df20505f1abe1dd5468dcc8c7041410 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97090 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 014916c7c76cfaf9baa3f76a2169ba8343f0cfbb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97135 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-26in Skia raster mode cache even enlarging of images (tdf#134160)Luboš Luňák1-7/+14
Change-Id: I842b55cd922eb0e411fd7450e84224b41ba82a2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96989 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 4654ac5aa75abc59226e15d12e77bd9fa95f7528) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97004 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-26one more BmpConversion::N8BitNoConversion for alpha hackLuboš Luňák1-1/+1
This was supposed to be included in 2fcfbd73768b69ba58607a054e7f851be2942992. Change-Id: I79b6f1c953784d3288d3830dbe232630aac392f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96987 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit d502408495e5c27f5690b84e809debcc57da03f7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97002 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-26optimize AlphaMask::BlendWith()Luboš Luňák1-6/+9
It shows up in profiling in some cases (e.g. tdf#134160). - If it's 8-bit, simply work on scanlines instead of pixel by pixel. - The extra precision from using floats doesn't matter and the round() costs something (at least with MSVC). Change-Id: I37bbe31fae03d61946a7382de1fb79cfe2d2ec30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97010 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit a3ef92cfb512ce70c7dc48f7957b40f9f78f5628) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97005 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-25tdf#127138: Fix detection of system icon theme with Qt5/KF5Igor Poboiko1-0/+3
The title is self-explanatory. The QIcon::themeName() actually uses Qt Platform Abstraction plugins, i.e. it's aware of KDE preferred icon theme via Qt Plasma integration module. (note that it is _currently_ broken due to KDE bug https://bugs.kde.org/show_bug.cgi?id=402172, which causes themeName to return empty string; however, it's being worked on) Change-Id: Ibc7cf9ee9ae73b492046219487760561d7d2ea45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94691 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit 584eba1fec6a47f4aae69afbdec7fc761bb68d29) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96997 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-25tdf#133859 Wizard service: disable 'Next' button if path has only base itemIlhan Yesil2-0/+6
If the wizard dialog for extensions has only the base item in the first path, there is no need to proceed to the next page, as there is no one. This will be checked and if so, the 'Next' button disabled. In libreoffice versions before 6.4, an ORoadmap class was used in the wizard. There, if the ORoadmap data are reinitialized, the InCompleteHyperLabel object must be destroyed first, before it will be set to nullptr. Change-Id: I5b4b2e6b3666b58acccace385c622f0a065fc368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95969 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 54a3daec02f2eeada04efcd7958da4152db4611a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96999
2020-06-24do not assume SalBitmap is zero-initialized (tdf#134152)Luboš Luňák1-7/+4
This code apparently expected that bitmaps are initialized with the first color in the palette, but that's not guaranteed to be the case (fails at least with Skia and X11 'gen' bitmaps). Change-Id: Ie4f7412e0a6c4c1110fc5fbb8ab5bed3c96f652f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96864 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 7f75271f91862f333707aae065f40af4d96a89a9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96873 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-19fix coordinate typo in Skia drawTransformedBitmap() (tdf#134129)Luboš Luňák1-1/+1
Change-Id: I562aae9f55701477acd6b5d2cc8a556f3449ecb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96688 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 18a7ecf78fcbee8101313f81bea8fbd5449a2482) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96695
2020-06-17tdf#133692: Spacing within Calc formulabar reworkedThorsten Wagner1-5/+7
Change-Id: I4f590589fdc390bfa11f7db86e65ccab3dd084fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96403 Tested-by: Jenkins Tested-by: Andreas Kainz <kainz.a@gmail.com> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 45261267964d6fa1e820b0e4a7745e2e10fcb5f7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96503 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-17support gtk-copy and gtk-paste stock idsCaolán McNamara2-0/+20
Change-Id: I0d9dc30c62bdfb5976c86bc5a08d5f030eb216e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit baa55eca0b653d4f661c08f5b6593caa3b186e89) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96418 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-17tdf#130449 allow gdk_window_move_to_rect to try GDK_ANCHOR_SLIDECaolán McNamara1-1/+1
as well as GDK_ANCHOR_FLIP if the window placement will put part of the floating window off screen Change-Id: I6b76df371048865cb4b1befea5ba34b38336944e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96495 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17we already have a NoHorzPlacement flag so use thatCaolán McNamara2-5/+23
to indicate we don't want left/right placement Change-Id: Ibda0d4729b7adc997fd45308ea1cd32674ace92d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-16blacklist old intel driver 0.16.2 for Vulkan (tdf#132681)Luboš Luňák1-3/+1
Change-Id: I3d2e0f6a1f43fe44a8396b53806e2f2c59c46d6c Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96454 Tested-by: Jenkins
2020-06-16tdf#131942 no progress bar when saving in calcNoel Grandin1-0/+1
regression from commit a7de363cead5cd0021d2e3df4573d4cbe27df23b remove unnecessary Window::Update() calls, which immediately follow Invalidate Change-Id: I2525acc9da786c0908bde5f8553258382f7cd45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit fc617677dedc2ee6f52149bac71195420bc351f3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96288 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-16implement Skia workaround for adjacent AA-ed polygons (tdf#133016)Luboš Luňák1-0/+18
Non-antialised adjacent polygons line up perfectly when drawn, and LO code assumes this is the case even when AA is enabled, which seems to work with Cairo, but not with Skia. So add a hack. Ideally LO code should not use such polygons. Change-Id: Ib46139db80f7bda78fde3aac4244da391133b7cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96369 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 094f8dfc3d349c34063bcee48d9b75328cf341b4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96415
2020-06-16tdf#133877 use optimal size for hamburger buttonJan-Marek Glogowski1-4/+4
This way it'll properly scale, instead of using the fixed 28 pixel dimension. This is a hack, which is used a few more times in VCL. Still this should not be needed, but done automatically. If there aren't any constraints, just return the optimal size! Change-Id: I8aa32645ea95cba28d0daf56f0be27c15153b6c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96390 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit eff34e639055701b1299c07e6cdc0ce07cfc0936) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96411 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-15fix skewed drawing in Skia's drawTransformedBitmap() (tdf#133925)Luboš Luňák1-9/+6
In debug builds this led to an assert with the bugdoc, in optimized builds it seems to cause drawing problems. Change-Id: Id52309f2e3d33f8b68952d988b927cea7546d131 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96206 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit fe78804b962a11a35b14ad6ec8afdd02ba40034a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96287
2020-06-09Resolves: tdf#132540 theme the unwanted popover into invisibilityCaolán McNamara1-0/+9
Change-Id: If18c5c1de40a4f93d062265d41a2bff72555d6c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95973 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09tdf#133412 replicate active entry to ComboBox replacementCaolán McNamara1-0/+4
Change-Id: Ifde87738710406fb9f28008fa96241d59c52f450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95818 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09tdf#129856 invalidate old internal border if we scrollCaolán McNamara1-1/+8
and will redraw a new one Change-Id: I2438af94e54f31c617cc183c61fbaaef31b5601f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09tdf#133822 mirror GtkSalObjectWidgetClip location for RTLCaolán McNamara1-1/+8
Change-Id: I4ab4a0fb8fc343ee9a4c66c58e20583482958f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95889 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-21 06:16:44 +0000