summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2020-10-25Related: tdf#137620 use existing SalEvent::SurroundingTextRequestCaolán McNamara1-19/+13
for signalIMRetrieveSurrounding Change-Id: Ic3280918283e2e1cf63a6d30767949d1c59cd1c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104780 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-25Related: tdf#137620 factor out working IMDeleteSurrounding hunkCaolán McNamara3-45/+54
Change-Id: I7504e8670fb464fe3e76a3d38f1cac39ba2e9208 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104779 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-24only sfxlo and svtlo still existCaolán McNamara1-5/+1
Change-Id: Id1138c2eb9f7c551d9d2855a68a364e3e21306cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-24crashtesting: avoid assert on loading tdf98681-3.docxCaolán McNamara1-1/+1
these limits are possibly totally archaic and maybe should be removed entirely given the number of freetype releases since their introduction. Just widen the range here. Change-Id: Ic6648bbcd0a996ab342ca4c310850cf81bd504eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104733 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-24Show animated GIFs in TotDHeiko Tietze1-0/+1
marchingants.gif added as an example Change-Id: I555aebc4a4e191b8afb4be06dfc1e5f3e6d1a911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104718 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-23log why a FreetypeFont was flagged as !mbFaceOkCaolán McNamara1-2/+10
Change-Id: I6f474c1761e7b0d77a0c5516dd77a60e98c75996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104732 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-23call gtk_im_context_focus_in only if its widget has focusCaolán McNamara1-1/+5
Change-Id: Ib69b43b5247f34ccf36591b49a35d701a3715f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104721 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-23Implement SalGenericInstance::getOSVersion() for FreeBSD.Gleb Popov1-2/+22
Change-Id: I01f565bdfc3c46a94485a62cd0f249ce2002fe21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104689 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara17-17/+17
and update the version mentioned in our min req in the readme.xrm follow up to commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 2 21:21:45 2020 +0100 raise min version of gtk to 3.20.0 Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22MenuToggleButton no longer needs to be in public headersCaolán McNamara4-1/+37
Change-Id: Ifc190ddc0c9b5eb33555dcec5ed14fd9b36134e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22fix welded editengine delete-surroundingCaolán McNamara2-2/+30
Change-Id: I71c2f8e2483c2ef8d7f5cfcfcd7849f64792022f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22weld backing windowCaolán McNamara1-0/+1
Change-Id: I250e46d3f1d558567bddbd4f0330470222e8fd4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22tdf#136915 correctly create QFont from Qt5FontFaceJan-Marek Glogowski2-9/+38
Store the origin of the Qt5FontFace and therefore the type of the font ID and use either QFont::fromString or QFontDatabase::font to generate the correct QFont instance. Interestingly the QFont::fromString worked with the minimal font string, ignoring the font style, but now fails with error messages when including the point size. Guess Qt supports partial font strings, as long as they match the segment types from the start. Change-Id: I6b30423a5ae9abd8ee50d6087a3ec61d85f6320f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104652 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-22Add __FreeBSD__ case to the #ifdef conditional.Gleb Popov1-1/+1
Change-Id: I77e69e7f82e7a24870a68d13abb365a7c2593564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104653 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-10-22for DisallowCycleFocusOut forward unused keyevents to InterimItemWindowCaolán McNamara3-15/+107
for ctrl+q etc Change-Id: Ie0ad94cf0e85693960428ffee5ae4a0ecffb7c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104635 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22Guard against bad stream in TypeSerializer::readGradientStephan Bergmann1-8/+8
...by defaulting to zero any values that fail to get read, in line with how other TypeSerializer::read* (vcl/source/gdi/TypeSerializer.cxx) and underlying GenericTypeSerializer::read* (tools/source/stream/GenericTypeSerializer.cxx) functions handle bad streams (though TypeSerializer::readGraphic does check mrStream's state, as a notable exception). I observed such failed reads with `VALGRIND=memcheck make CppunitTest_vcl_filters_test CPPUNIT_TEST_NAME=VclFiltersTest::testCVEs`: > Conditional jump or move depends on uninitialised value(s) > at 0x170EA438: TypeSerializer::readGradient(Gradient&) (/vcl/source/gdi/TypeSerializer.cxx:61) > by 0x16F00CEE: MetaFloatTransparentAction::Read(SvStream&, ImplMetaReadData*) (/vcl/source/gdi/metaact.cxx:3020) > by 0x16EF1704: MetaAction::ReadMetaAction(SvStream&, ImplMetaReadData*) (/vcl/source/gdi/metaact.cxx:269) > by 0x16E99C03: ReadGDIMetaFile(SvStream&, GDIMetaFile&, ImplMetaReadData*) (/vcl/source/gdi/gdimtf.cxx:2693) > by 0x16F00C91: MetaFloatTransparentAction::Read(SvStream&, ImplMetaReadData*) (/vcl/source/gdi/metaact.cxx:3016) > by 0x16EF1704: MetaAction::ReadMetaAction(SvStream&, ImplMetaReadData*) (/vcl/source/gdi/metaact.cxx:269) > by 0x16E99C03: ReadGDIMetaFile(SvStream&, GDIMetaFile&, ImplMetaReadData*) (/vcl/source/gdi/gdimtf.cxx:2693) > by 0x16F00C91: MetaFloatTransparentAction::Read(SvStream&, ImplMetaReadData*) (/vcl/source/gdi/metaact.cxx:3016) > by 0x16EF1704: MetaAction::ReadMetaAction(SvStream&, ImplMetaReadData*) (/vcl/source/gdi/metaact.cxx:269) > by 0x16E99C03: ReadGDIMetaFile(SvStream&, GDIMetaFile&, ImplMetaReadData*) (/vcl/source/gdi/gdimtf.cxx:2693) > Uninitialised value was created by a stack allocation > at 0x170EA274: TypeSerializer::readGradient(Gradient&) (/vcl/source/gdi/TypeSerializer.cxx:33) (The uninitialized sal_uInt16 nAngle had started to cause issues since 0fb58a1ff168ae122e9c8993a3136658e3b0e3f0 "new tools::Degree10 strong typedef", when e.g. <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/30821/> failed with > cppunittester: /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/include/o3tl/strong_int.hxx:94: constexpr o3tl::strong_int<UNDERLYING_TYPE, PHANTOM_TYPE>::strong_int(T, typename std::enable_if<std::is_integral<T>::value, int>::type) [with T = short unsigned int; UNDERLYING_TYPE = short int; PHANTOM_TYPE = Degree10Tag; typename std::enable_if<std::is_integral<T>::value, int>::type = int]: Assertion `detail::isInRange<UNDERLYING_TYPE>(value) && "out of range"' failed. apparently because nAngle happened to contain a value > std::limits<sal_Int32>::max(), so converting it to a tools::Degree10 based on sal_Int16 triggered the assert. 0e8e352cc78af9b8cee27a77b0ac8e2e8f98f8cc "clamp angle to valid value" tried to address the symptoms, but failed to identify the root cause which is now addressed in this commit. I'm not sure whether that clamping of nAngle from 0e8e352cc78af9b8cee27a77b0ac8e2e8f98f8cc is useful in itself, or whether nAngle should rather be of type sal_Int16 (or converted to such prior to being converted to Degree10). But that question of what input values (if they are actually read in from a non-broken stream) are invalid and need treatment is somewhat orthogonal to this fix, so I leave that as it currently is for now.) Change-Id: Iae74bad9e2543bf7ac8712adbf360d5e1076bdf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104650 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-22Qt5 forward the flat push button styleJan-Marek Glogowski2-0/+7
Change-Id: I0835f66b8ce478f645ca2e5c376bef9a0740c8c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104637 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-22tdf#137660 send some focus event for push buttonsJan-Marek Glogowski1-1/+3
With KDE breeze we don't get any focus indicator for the keyboard navigation in the start center, with either the kf5 or the gtk3 plugin using breeze. gtk3 with adwaita works fine, because it can handle the ControlPart::Focus of the push button. This behaviour was introduced in #i110915#. In the gen plugin you get a small focus rect inside the button, but kf5 and gtk3 set mbNoFocusRectsForFlatButtons, which was introduced by commit f485b2881794244409d71ead39715373e734ed04, so there isn't any indicator left for kf5 for the keyboard focus. So this sends focus updates for the flat buttons, if the focus rects are disabled and ControlPart::Focus is not supported, so kf5 can render a focus indicator. Change-Id: I1b587a7f9ec55b44369c4c8bc21039fe90aab9ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104582 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-22tdf#136866 VCL don't drop the control backgroundJan-Marek Glogowski1-1/+2
Since tdf#136094, we handle the background color for native controls. So we shouldn't set the control window to transparent, if a control background is set. I'm not sure, if this just papers over a more general bug, but even if we report a border in native painting, the original window shouldn't be painted anyway. Change-Id: I86267028214586d46ca9ba0b2288d4729abef16f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104621 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2020-10-22don't update IM focus-in if focus-in was in another widgetCaolán McNamara1-2/+10
Change-Id: Ifdb2bc6ac973a067ac3e27207f6d1cacfdf2c31d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22add some SolarMutexGuards for IMECaolán McNamara1-0/+10
Change-Id: I1bd2e3c34e400b597dec1b9b3933b7dc85d2b78f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22pdfium: add a wrapper for FPDFPage_HasTransparency()Miklos Vajna2-2/+3
Change-Id: Id0595e96a4de7fabe6613cf2df69684da6e8a6d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104648 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-22make mnemonic-activate do the right thing for a MenuToggleButtonCaolán McNamara1-0/+8
i.e. activate the toggle button part of it Change-Id: If9fee25c3487feab11bdf81f1483b5e0b67688e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22pdfium: add a wrapper for FPDF_SaveWithVersion()Miklos Vajna2-31/+50
And use it in getCompatibleStream(). Change-Id: I48ab2a17c0780b78c6af6dbff50dba81f8041f43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104642 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-22vcl: remove leftover debug printfMiklos Vajna1-1/+0
Change-Id: I57f166309952ff459586d8eae0e9d1e3b1d7c4ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104615 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-21clamp angle to valid valueNoel1-0/+5
fallout from commit 0fb58a1ff168ae122e9c8993a3136658e3b0e3f0 new tools::Degree10 strong typedef which caused failures in CppunitTest_vcl_filters_test Change-Id: Ief60aae62935137330118b1a8d8dd0c428430430 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104631 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-21don't trigger resize if size didn't changeCaolán McNamara1-0/+6
Change-Id: I504d1e3019fa2eb5963b522806526b20e5b4e0bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104568 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-21Revert "tdf#137468: Use the colour space of the main display"Tor Lillqvist1-2/+1
Sadly that commit made the CppunitTest_vcl_bitmap_render_test fail on many Macs, including my 2020 iMac. This reverts commit cb48b7205cc6cdcf6741bc430266481a8b6b4769. Change-Id: If1a9605c112904d253664cbc9749cf3987dff473 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104613 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-10-21new tools::Degree10 strong typedefNoel Grandin60-197/+204
partly to flush some use of "long" out the codebase, but also to make it obvious which units are being used for angle values. Change-Id: I1dc22494ca42c4677a63f685d5903f2b89886dc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104548 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-21Qt5 use base color for workspace tooJan-Marek Glogowski1-4/+1
This was uncovered by the fix for tdf#136555. The current color for the start center button bar is too dark. Regressed-by: a927e0964ba0442d53fffb22c577e54bcf183ed7 Change-Id: I36356117f03255cfbf1fa24a6391cb81cf1883db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104578 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-20remove motif from startcenterCaolán McNamara1-1/+1
the icon doesn't exist in the normal case since commit 60413c9800c27f53c1108015b50754b065bc98c6 Date: Wed Apr 18 12:22:07 2018 +0200 Replace Galaxy icon theme by Colibre through a theoretical route via installing a gallery icon extension still exists. Use a different existing icon for the vcldemo Change-Id: I81ab87742eaf2720877782a4425ef83719ee6ed9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104556 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20fix skia matrix rounding imprecisionLuboš Luňák1-5/+13
Change-Id: I9908eb5981317799c978e13c244e3e1ec2867016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104438 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-20add MenuToggleButton for split toggle/menu buttonCaolán McNamara7-24/+414
which is uniquely used in the start center Change-Id: I098e79ce34a9d99f8fb2eccb3dd04fa27e38427b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20tdf#137468: Use the colour space of the main displayLeo Wang1-1/+2
Change-Id: I301dcadcc469c1810e3b64e6fee6b982bebaf040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104477 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-10-20tdf#137468: Restrict window depth to 24 bit RGBLeo Wang1-0/+5
Change-Id: I65c168155092d89d0302043b4052fed2def18c63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104476 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-10-20tdf#133931 Qt5 set the themed AlternatingRowColorJan-Marek Glogowski2-0/+7
Change-Id: I6a4a0f90239686ff1c94e1a550540223324184e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104540 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-20xmlsecurity: handle MDP permission during PDF verifyMiklos Vajna2-10/+84
Change-Id: I626fca7c03079fb0374c577dcfe024e7db6ed5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104529 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-19clang-cl: Adapt Windows-specific code to extended loplugin:cstylecastStephan Bergmann1-1/+1
...after 1ebeacb20ad0165e399629fcfd7795ad0da3edf8 "Extend loplugin:cstylecast to certain function-style casts" Change-Id: I99bd383f5b3bee861d442d2e1be6ecd356b78315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104523 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-19use tools::Long in vclNoel319-4581/+4672
Change-Id: Ice1055021e8568634e9a66ba89d3bb4ef4e731df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19tdf#116675 vcl tree list: toggle by label click (e.g. in AutoFilter)Attila Szűcs1-0/+23
Checkboxes in a tree list could be toggled only by clicking on them, but not on the associated labels, despite UX guidelines and interoperability requirements especially for AutoFilter usage in the spreadsheet. Note: Implemented only for generic VCL plugin. Testing on Linux: SAL_USE_VCLPLUGIN=gen instdir/program/soffice Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ibc3d42271a1be53a54e11dedf4ab3ab506d680cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104414 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-19tdf#127047 fix printing very large font sizes to pdfNoel Grandin3-30/+5
The clamping of font sizes was done in #i47675 and #i95867 to deal with issues in the Windows font libraries which are presumably no longer a problem. Change-Id: I124a3ff746953ce4d7d934506e76e6d0cba48307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19Simplify single-wchar_t LPCWSTR argument to ExtTextOutWStephan Bergmann1-2/+2
Change-Id: I5c66408297ab03da29494d00ce222b3ef1e0ef13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104515 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-19fix possible SIGSEGVNoel1-1/+4
after commit 8f54136caa786523fd224f6c98fc8e7c45cd805d use std::unique_ptr for SalLayout Change-Id: If1a0af9924a185694489b7f31f9e71495f2cb77b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104513 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-18use SetControlFont instead of SetPointFont to get the right sizeCaolán McNamara1-2/+2
Change-Id: I3c3d2c11d7a1faba792162fa1a61c247949b6cc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104508 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-18pdfium: simplify point unit conversion to HMM for annotationsTomaž Vajngerl1-33/+28
Change-Id: Ied3721d58d49736c78a4fa5181b92beb1dff7728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104378 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-18sd: support line PDF annot. as custom markerTomaž Vajngerl1-1/+23
This renderes the line marker, but line start and end symbol is for now not supported. Change-Id: Ibf099f54b4bc047b22dae32c705982c8cb24388b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104377 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-18pdfium: add reading of line points to the wrapperTomaž Vajngerl2-0/+25
Change-Id: I3e596254b2e4ecc9f56ff09eeb63b66195ea6a2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104376 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-18sd: support text annotation PDF annot. as custom markerTomaž Vajngerl1-1/+44
This one is special as it annotates text. Normally the annotation would be present behind the text, but this is not possible in this case, so the best alternative is to use a transparent rectangle over the text. Change-Id: Ib115efa4a5994e17dcf9d7b02591ccae26800928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104369 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-18sd: support ink PDF annot. as custom markerTomaž Vajngerl1-1/+26
Ink PDF annotation is similar to a set of polylines (or freehand drawing), so we can again just reuse the polygon code paths. The difference to the polygon is that the polygon is closed. Change-Id: I99641dccc0b2f9f2d3ebf2c71d3e20f8b1d0a485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104367 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-18sd: support square and circle PDF annot. as custom markerTomaž Vajngerl1-1/+19
Use the existing polygon code paths, but convert a ellipse or the rectangle to the polygon, and add that as a custom marker for the annotation. Change-Id: I8f8657b868f2c410a3f604dcc1e609f4c6a12638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104366 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 15:13:59 +0000