summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2020-11-19pdfium: add signature and trailer end getter wrappersMiklos Vajna1-0/+16
So PDFiumDocument::getPointer() can be retired. Change-Id: I77c34c3e263bd6f39e06e50f621f2eaff804c716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106079 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-18Remove unused Manager::registerGraphic rsContext parameterStephan Bergmann2-11/+9
unused ever since the code was introduced in a2b53fece14f745853bcfe1a300c3dceb580e148 "vcl: Add a internal (memory) manager for Graphic objects" Change-Id: I0e16983e7f34cded77435ae12d8adf0c3eee5f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106048 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18tdf#138271 send value-changed on FormattedSpinButton losing focusCaolán McNamara1-1/+23
Change-Id: Iaa6882f41ee756b0645818694f6942d90243ba13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106049 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-18Remove unused SalGtkFilePicker::implAddFilterGroup _rFilter parameterStephan Bergmann2-3/+3
unused ever since at least e335eb1438ed99260a5ca050548b2693b5b22b1c "gtk3: move gtk+ file picker into vcl - a more sensible place for it" Change-Id: Ib8687b113f4a66e500a0787511125bac8c08e3fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106050 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18Remove unused GraphicObject::SetGraphic pCopyObj and rLink parametersStephan Bergmann1-6/+1
The defaulted pCopyObj parameter of the first SetGraphic overload became unused with ea3d755ac949c1b6dada5c341e018f8c23f5d395 "vcl: detach usage and remove GraphicManager and GraphicCache", and then the rLink parameter of the second overload became unused with e4eb416c3ef81d098ed61caabd2077cbbb2418bc "remove swapping and link from GraphicObject and Graphic" (removing the need to have two different overloads). Change-Id: I15a648845ed474ee302e2a9836776ba74b9c44a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106045 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18loplugin:stringviewparam: No good reason to exclude operator functionsStephan Bergmann1-1/+5
(at least not in general) Change-Id: I71337b53dc9735e90a37ee532d0a8a08797b518c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18vcl: clean up unused PDFDocument functionsMiklos Vajna1-67/+0
These are unused since the pdfium-based signature verification. Change-Id: Ie15369cbd0548febd03be3ac3475036e1f46cd16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106027 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-17tdf#137628 sc: fix white part in autofilterAttila Szűcs1-7/+12
Tracked the problem to bulk_insert_for_each, in an optimization case that use a fixed width instead of calculating the rows width. In that case vertical scrollbar is not supported. Replace the call of set_column_fixed_widths to instead set just the widths of the headerbar items if the treeview has them. The optimization (use the fixed width instead of calculating row width), happens since of setting pViewDataItem->mnWidth. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I2ceb89eed84baf347204841a01fad34974f5f5f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-17implement also axial gradient for skiaLuboš Luňák2-3/+16
Change-Id: Ie708250f970f2ce08c8c89e4bf001a5df23b99bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106015 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-17Don't use new/delete here when automatic variable is enoughMike Kaganski1-10/+9
Change-Id: Ia119da3b54fd957f3316637ddaa047cfd6a399fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105994 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-11-17tdf#138022 Skia don't recreate empty surfacesJan-Marek Glogowski2-9/+15
Skia can't create empty surfaces, so the recreation will hit the std::abort() in SkiaSalGraphicsImpl::createWindowSurface. Origin of the backtrace is some queued Resize event, which will hit this a few times via SkiaSalGraphicsImpl::checkSurface. This feels a bit like tdf#130831, where VCL tried to track damange for an empty Qt image... Change-Id: I75e22c987ba633e7a403541db8d580df33c68964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105963 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-17set Skia pixel geometry for every surfaceLuboš Luňák5-32/+35
Skia update chrome/m88 removed the possibility to call SkFontLCDConfig::SetSubpixelOrder() to set subpixel setup for all surfaces. So I guess now we have to explicitly pass SkSurfaceProps to every single SkSurface we create. Change-Id: I15be37ba9301c92d0cb109e88f3d1396a7223208 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105922 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-17update Skia to chrome/m88Luboš Luňák3-16/+29
Change-Id: I74c19597b07e9d07ee90e4191b75787241fdd845 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105829 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-17loplugin:stringviewparam check methods tooNoel14-64/+65
not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-17tdf#138183 sync pending clipboard assign on clipboard ownership-changeCaolán McNamara1-0/+13
Change-Id: I325add499fbd4d11a942ce550346dcbcb5343e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105928 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-16Instead of labs, use overloaded absStephan Bergmann7-11/+26
...more likely to pick an appropriate version for the involved integer types, esp. after the recent long -> tools::Long changes Change-Id: Ia91259ca35aaf74b0e907de6831fc926f30057f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-16avoid loplugin::toolslong warnings in qt5 vcl backendLuboš Luňák3-10/+13
Change-Id: Iddf3d86a51afd1315ac8b5bdafef00d40a9df591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105939 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-16fix loplugin indentation warningLuboš Luňák1-2/+2
Change-Id: Ib444bec4af79886c52979d3fbbb6b4a55b3cf3fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105938 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-16replace std::min(std::max()) with std::clampNoel2-2/+2
Change-Id: I76e34e8020d98292e8ffde387542b7029f85a42d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-16tdf#137898 Page count is not reset to 1 in the print preview dialogCaolán McNamara1-1/+1
Change-Id: Ib7c8695fd3e7156b86f4b4603fbaa5e2319cdc1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-16disable Vulkan for Windows 7 (tdf#138219)Luboš Luňák1-0/+3
The bugreport says the latest Intel drivers for Windows 7 are problematic, and since Windows 7 is EOL anyway, simply don't bother. Change-Id: Iee429d99ebf9b0e0a99a50c38ef77d06ab5b797b
2020-11-16tdf#113163 OOXML Fix transparency and alpha channel supportBartosz Kosiorek2-1/+3
In OOXML specification there is a:clrChange tag, which change color from image, to another colour and transparency: https://docs.microsoft.com/en-us/openspecs/office_standards/ms-oi29500/5860f816-13d3-4a83-9e63-bcd1e0808404 Unfortunately It was not working correctly. This patch is resolving that issue Change-Id: I85e3790f86382dca2c4798346021f480e50db6e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105258 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2020-11-16check TopLevelMenuHelper for existenceCaolán McNamara1-1/+2
Change-Id: I84e0893b1ca271cd7460e8fb0ce20b91bf3e58d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105903 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-16tools::Long->sal_uInt16 in ImpErrorQuadNoel1-15/+15
This class only wants about 12 bits of data per color component. Change-Id: I363ef085a302b3f1599b626e5cec92efe1c65026 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105909 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-16replace std::max(std::min()) with std::clampNoel1-2/+2
Change-Id: I890d19f5e2177294dc1175c90c98b964347f9e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15add <!-- n-columns=1 n-rows=1 --> before every GtkGridCaolán McNamara9-0/+22
for a in `git ls-files '*.ui'`; do sed -i 's/^\( *\)\(<object class="GtkGrid".*\)/\1<!-- n-columns=1 n-rows=1 -->\n\1\2/' $a; done so we get the same behavior in glade as before 3.38 in that the grid preview don't show any unoccupied grid squares replace all existing n-columns=X n-rows=Y lines because they are all wrong, except for cui/uiconfig/ui/additionsfragment.ui sw/uiconfig/swriter/ui/pageheaderpanel.ui sw/uiconfig/swriter/ui/pagefooterpanel.ui which are correct. Change-Id: I401bbe8e098c26e7f57d6a872d3b70fc1ce85a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105846 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-15add Menu::get_idCaolán McNamara3-0/+15
Change-Id: I608db63f700312f7d7ffc6bfbd0e03971bfb00e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-15loplugin:toolslong in Library_vclplug_osxStephan Bergmann18-150/+185
Change-Id: I63892376154893a97e6b205b93c1682f66fd3064 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105756 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15CGFloat appears to be a more suitable type hereStephan Bergmann1-24/+24
...interacting with NS data sructures and functions Change-Id: I16e155be33754a06fa2d6decb32be961f83255f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105752 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15Assumed UNOIDL long vs. C++ sal_Int32 confusionStephan Bergmann1-3/+3
UNOIDL css.accessibility.XAccessibleValue.getCurrentValue returning any is documented: "The exact return type is implementation dependent. Typical types are long and double." So assume that this code meant to extract a UNOIDL long, i.e., sal_Int32 in C++, value. (And similarly for getMinimum/MaximumValue. Also, the "TODO: Detect Type from Any" comments seem to imply that something more elaborate is asked for, anyway?) Change-Id: If01956eaf4ec186931414a4e1d55429e66901c55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105745 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15Extend loplugin:stringviewparen: subViewStephan Bergmann1-2/+3
Change-Id: Iee4833b148a5e17e09f84bdfbc8692aa5a956618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105777 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15-Werror,-Wdeprecated-anon-enum-enum-conversionStephan Bergmann1-2/+7
...even though CGBitmapContextCreate is documented to take a mixture of CGImageAlphaInfo and CGBitmapInfo flags; so convert all to the uint32_t CGBitmapContextCreate bitmapInfo parameter type Change-Id: Ic6630c68760fe29b6abf6053e80a852a31349839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105755 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15CGFloat appears to be a more suitable type for these AquaSalObject membersStephan Bergmann1-8/+8
...interacting with NS data structures and functions Change-Id: I0a8aa8b0d0a2a1218c060e1b92c7624fd176d43f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105753 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15DPI values are generally represented as sal_Int32 in VCLStephan Bergmann6-10/+11
cf. e.g. pure virtual SalGraphics::GetResolution (vcl/inc/salgdi.hxx) Change-Id: I77d54ad0a7b80cf8839b253c14ce468ac4e16c84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105748 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15UNOIDL long vs. C++ sal_Int32 confustionStephan Bergmann1-1/+1
UNOIDL css.awt.Point members x, y are of type long, i.e., sal_Int32 in C++ Change-Id: I3a8f087af2e282e6b82a8409a1202f3be18464ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105744 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15UNOIDL long vs. C++ sal_Int32 confustionStephan Bergmann1-1/+1
UNOIDL css.accessibility.XAccessibleText.getCaretPosition returns long, i.e., sal_Int32 in C++ Change-Id: Iaf6f6407f77a3d3fae7cd99e08c4cd43343a7af6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105742 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15UNOIDL long vs. C++ sal_Int32 confustionStephan Bergmann1-3/+3
UNOIDL css.accessibility.XAccessibleTextMarkup.getTextMarkupCount uses long, i.e., sal_Int32 in C++, for both its TextMarkupType parameter and its return type Change-Id: Ie4dbebf76c5a946f1954853d98c705baa301b060 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105743 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15uitest: Rename the "SET" to "TYPE" for Edit boxes + implement the real "SET".Jan Holesovsky1-1/+12
To be consistent with the other controls: "TYPE" actually enters the characters one by one, while "SET" sets it as a whole. Change-Id: I967dc270b1d92fe76107732a511cc3e70d3d65c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104435 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105739 Tested-by: Jenkins
2020-11-14enable vcl backendtest unittest for headless tooLuboš Luňák1-3/+2
This test would have caught the SalPoint mismatch from 3d90997fb6f232 causing gradient problems, if only this were enabled for headless too. So explicitly disable only the two invert() tests. Change-Id: Ib6f6a8c8cd9675ca6d20a761ebebdbc8ef0ebd45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105832 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-14remove SalPointNoel Grandin29-352/+352
<caolan> that "SalPoint" doesn't really seem to to have a purpose except to highlight that "Point" is assumed to use LONG under windows and can be passed unchanged to those windows drawing apis <caolan> so I guess remove SalPoint entirely, use Point instead, and convert to "POINT" under windows ? Change-Id: Ic15a7f4516e2075a228fa65cac4e8494d5b3abaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-14fix updates of Skia draw region for Windows widgets (tdf#137559)Luboš Luňák1-0/+3
Change-Id: I787c427dd17334095d5b2d90c6a9670d58ee9a4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105762 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-14allow F1<->F26 accelerators in .uiCaolán McNamara1-0/+6
Change-Id: I574a92839664643b1e42f3184471bc05e8b4da31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-14Related: tdf#131970 icon-switcher should be in single-selection modeCaolán McNamara2-0/+11
Change-Id: Ie5ac5ccf1273905832e934998f206425401b0f30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105763 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-13add set_accessible_descriptionCaolán McNamara3-0/+15
Change-Id: I18aebc4a127ff92f5d2606490e4f120d4b98b4ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105796 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-13fix some tools::Long falloutNoel Grandin1-2/+2
Change-Id: I8c15b0ee8400c3b540154bc38c51cbf04b6c3850 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105794 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-13block nvidia drivers for vulkan only for version<457.36.0 (tdf#138145)Luboš Luňák1-1/+1
Reportedly that one works fine, although the situation is somewhat unclear to me (tdf#135370 appears to have been worked around as a side effect of d18731f71c60cbb6c02cabb042004b1aa9454de8, and both tdf#136036 and tdf#136407 do not have confirmation from anybody else than the reporters). If things do not go well, the blocklist can get more fine-grained. Change-Id: I8cd5257d6391fe0604e7a95e1ed7edfc0143ec3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105642 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-13properly clip native VCL gradients (tdf#137563)Luboš Luňák1-1/+2
If I'm getting it right, OutputDevice::InitClipRegion() sets mbOutputClipped = true if the entire output would be clipped, and it doesn't call SalGraphics::SetClipRegion() at all, instead OutputDevice draw calls are supposed to avoid the drawing entirely. But while the polygon fallback in OutputDevice::DrawGradient() does so, the call to SalGraphics::DrawGradient() didn't. Change-Id: Ib93bcad98534a3a3d9be26cdea11def51c796f00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105759 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-13tdf#131970 enable tab-cycling between VerticalTabControl membersCaolán McNamara1-0/+1
Change-Id: I7d009c2345cc7b3a3c692bb8734d9939ce465db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-13Revert "remove BigInt::operator tools::Long()"Noel Grandin3-12/+12
This reverts commit 1397a1c8e4995b0dd336478e564880fe8ad91d1d. Reason for revert: Some discussion required Change-Id: Id39ee8260790e0722c5bf8338b0b76ca34da83d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105539 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-13remove unused #ifdefNoel1-13/+3
been this way since commit 8ab086b6cc054501bfbf7ef6fa509c393691e860 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: I878f45163fc0836c786acc12f11d9cd704e4cd64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 23:33:09 +0000