summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2020-02-20tdf#130187: Don't crash on exiting print preview with NotebookbarMike Kaganski1-7/+25
Crash caused by this sequence (tested in Writer): 1. Closing print preview, frame is attached to controller; 2. This calls SfxNotebookBar::StateMethod 3. There notebookbar's listener is added to list of the controller's context change event listeners 4. Then in SwPagePreview::~SwPagePreview, notebookbar's listener is added to that list again 5. ContextChangeEventMultiplexer::addContextChangeEventListener detects second addition, and throws an unhandled exception. I don't know why starting listening is needed in SwPagePreview dtor; unfortunately commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd doesn't say much about context and reasons. ControlListener is renamed to ControlListenerForCurrentController to emphasize that it operates on the current controller of notebookbar's frame; and its bListen parameter meaning was reverted: previously its "true" value awkwardly meant "stop listening". All direct operations with listener of notebookbar are replaced with calls to notebookbar's methods. In ContextChangeEventMultiplexer::addContextChangeEventListener, uno::UNO_QUERY_THROW was replaced with uno::UNO_QUERY, because not only chart controller may appear here, and it's not an error: e.g. SfxBaseController doesn't implement lang::XServiceInfo. Regression after commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd. Change-Id: Ief1aed188d8f02a6cfe3ea25f4d082dfdf449f32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86257 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87582 (cherry picked from commit fb2382ad4f33b885650ad5156ccaec4e90661806) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88229 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-19tdf#130462 call SetMinOutputSizePixel before SetOutputSizePixelCaolán McNamara1-1/+1
Change-Id: I04716e91b7c9b5f1e9db1fd175f5dcbe0600bf1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88116 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit c852f0e4ac4cee2a1b69ff8b1c5cab6633664098) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88237 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-12tdf#130555: Prevent negative aSelection.Min()Stephan Bergmann1-2/+7
...which would violate the the preconditions of the later call to maText.remove. When BreakIteratorImpl::previousWord (i18npool/source/breakiterator/breakiteratorImpl.cxx) is called to e.g. move back over a single space at the start of the text, at least for an en-US locale it will fall through to the call to BreakIterator_Unicode::previousWord (i18npool/source/breakiterator/breakiterator_unicode.cxx) at the bottom of the function. That in turn calls icu::BreakIterator::preceding, which is documented (workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) to return icu::BreakIterator::DONE (i.e., -1, see workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) in that case, which causes BreakIterator_Unicode::previousWord to return a Boundary with startPos == endPos == -1. The documentation of UNO method css.i18n.XBreakIterator::previousWord (offapi/com/sun/star/i18n/XBreakIterator.idl) is silent about the expected return value in such a case. But lets assume that returning such a [-1..-1] Boundary is as intended, and locally address this case in Edit::ImplDelete, making aSelection start at the start of the text. Change-Id: I40e17ba602088e72aa6962cb41dd8e1cdf6e2561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88431 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e8f26dc13b65b1a05d948d9c95110c86315e8f20) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88402 (cherry picked from commit d84eaea950f276e7ba0d155cdbed056bcc815255) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88490 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-04Place button text in tooltip if it doesn't fit into the buttonSamuel Mehrbrodt1-0/+5
Seen this happening in custom sidebars (from extensions). When the text is too long for the button, it will get cut off and there is no way to view the button text. Change-Id: I86ce72154e0371bdf24480be41517855dc3ce050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87692 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit dabb6176407067ef8d46bdde863b087457805c6a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87948 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-04Related: tdf#129933 assert on pasting over selection in editCaolán McNamara1-1/+5
when its selected right to left with cursor flashing at the start format->paragraph->area->color->pick, cursor into hex# edit, end to cursor at the end, shift + home to select all, right to left, ctrl+c, ctrl+v, assert Change-Id: I8e29108ddff94487c298bd5e6607b98f5f841afd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87885 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-03ofz#20422 reversed conditionCaolán McNamara1-1/+1
Change-Id: I5f880e24aee029e3560da986969d46500b5ed044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87805 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-31Adapt CPPUNIT_ASSERT to C++20 deleted ostream << for sal_Unicode (aka char16_t)Stephan Bergmann1-0/+3
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print an integer rather than a (presumably expected) character. But for simplicity (and to avoid issues with non-printing characters), keep printing an integer here. Change-Id: I751b99ee32d418eb488131ffa130d6f7d6d38dc7 Reviewed-on: https://gerrit.libreoffice.org/84348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 5d8f0fad50f90195a11873c70ddab4644f5839ea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87760 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29Resolves: tdf#130130 Insert menu, multiple hotkey never reaches 3rd itemCaolán McNamara1-6/+30
Change-Id: Ica70be71094229a12c16eee1d3ff6960b7e06734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87665 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-23Related tdf#126459: fix crash in presenter console using gen vclplugKatarina Behrens2-0/+4
A slide with video is needed to reproduce Regression from commit ac87cfdf263d2abd97b32857534d0f749b7c4479, 'toolkit' and 'platform' bits were never set (bc irrelevant) in gen vclplug but now if not set, values mapping to 0 (Gtk3, Wayland) will be used and things go down the drain in avmedia/gstplayer then Just between us girls, nobody in their right mind would use gen vclplug for presentation, but crash is not nice so let's fix this Change-Id: If318ab93897f9f4854f7316e630c35aaec2480fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87185 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 13bc1ec30c5adf05ff987c25634b845bab7bc4ae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87237 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-18Related: tdf#127782 call signal_expanded after expansion in gtk caseCaolán McNamara1-1/+2
which is the same as the gen one Change-Id: Ia93598bb88d5a3f93c62e7096f8bc4ca69698a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86564 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-08tdf#129879 Fix wrong order of buttonsTomáš Chvátal1-2/+2
Change-Id: I0cb135c5b8298fd7c5579673d0eaff7068a03842 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86426 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-07tdf#129004 Make shift+F6 cycle order reverse of F6Jim Raykowski1-17/+7
Change-Id: I52013b4c54ef5e457d9fa19210d08d9c042fed45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/83637 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 32b9d07baa0cf6907f14ccb9aa068b51d95eefaa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86342 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06tdf#129662 vcl: rtl: fix scrollbar in dropdownsMiklos Vajna6-10/+32
Regression from commit d4714b0fdb81e6e561ae526cc517ecc9a40a603e (tdf#101978 vcl combobox/listbox floating window: avoid flicker, 2019-06-17). High-level vcl double-buffering never set up RTL status of the virtual device correctly, but now that double-buffering is used at more places, this got noticed. (cherry picked from commit b0fa356eed82a0452e6bcb915f179f5e2d02943a) Conflicts: vcl/source/window/cursor.cxx Change-Id: Iba378cef3a693b0712389fab519f38ee222577d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86158 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-04tdf#125536 macOS native Carbon widgets reworkedThorsten Wagner2-917/+768
Change-Id: Id60895a48f59cb3c55db39d18cd27fed2108727e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86066 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9d31d8f1d8d3a73f8c07ca39f5ed45e2bb7b088c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86155 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-27tdf#83248: Use the right text color when printing fieldsArnaud Versini1-2/+1
Change-Id: I81167207a35d524660b9a1d6740cfce551489c4a Reviewed-on: https://gerrit.libreoffice.org/84707 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 10d345faa087fa49692f38bb2ece22560f423ba7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85848 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-27tdf#129490 Fix enter key in combo boxSamuel Mehrbrodt1-1/+1
Follow-up fix for 7de9417d5f65d35227c7f80f6d587c2a56bde4e0 Change-Id: I0b05f11b79d5fcd4e4823c1e31c087724ebc85f8 Reviewed-on: https://gerrit.libreoffice.org/85748 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 09c0dc8b80b91a4f2e7ad3569a59402ee131eaf4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85834 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-23ensure toolbar image widget is visibleCaolán McNamara1-0/+2
Change-Id: If9144ab5f3c32570fda1da38e3c5fd076293205f Reviewed-on: https://gerrit.libreoffice.org/85710 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-21tdf#127022 vcl: fix Windows RTL menu barMiklos Vajna4-1/+18
Regression from commit e8d5b8beb5958147235ff955ed38c47b51d860ff (tdf#113714 vcl menu bar window: avoid flicker, 2019-05-20), the problem was that while the original render context has RTL set up correctly, the intermediate virtual device had it disabled all the time. Change-Id: Ic063c4a6c0537891c0bfceb8927edb97cf1c6e86 Reviewed-on: https://gerrit.libreoffice.org/85624 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/85636 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-20tdf#127552 Make toolbox highlighting behave as intendedJim Raykowski1-3/+19
This patch provides intended highlight behavior to my understanding of comments found in the toolbox source code. *only highlight when the focus is not inside a child window of a toolbox eg, in an edit control *do not highlight when focus is in a different toolbox *only clear highlight when focus is not in toolbar Change-Id: Ia18d35c4255ed0940bce5f0c6d9448ed2c85c6fe Reviewed-on: https://gerrit.libreoffice.org/81356 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 800b6f095f95ccfb8a7ba9755292332bf97f97ad) Reviewed-on: https://gerrit.libreoffice.org/83446 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-19Resolves: tdf#129484 just install decimal key handler for spinbuttonsCaolán McNamara1-4/+9
as a simple interim fix Change-Id: I7e393fe20f4fb7ea277c423f9fc9789d658b1e18 Reviewed-on: https://gerrit.libreoffice.org/85506 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-19focus-in/out should return a valueCaolán McNamara1-2/+4
Change-Id: I82df9b24a5f08830eda1e511d6a7d45a1edcc08e Reviewed-on: https://gerrit.libreoffice.org/85498 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-17tdf#112989 reduce export to PDF timeNoel Grandin1-3/+9
reduces the time from 33s to 24s for me Change-Id: Ia70e1c4220ebedf0b686ed76c5704efa551591fe Reviewed-on: https://gerrit.libreoffice.org/85281 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 11c0effe3def917ec2002a30dbbcca1c5758ffa9) Reviewed-on: https://gerrit.libreoffice.org/85302 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-16tdf#127148 select-all on tabbing into version box in help->aboutCaolán McNamara2-1/+9
and allow select-all in readonly multiline edits too. Arguably this might be a universal settings, but just enable it for the about dialog for now. Change-Id: Ic2e64fe26593adf4ae630d1be1a7b196a5a0216c Reviewed-on: https://gerrit.libreoffice.org/85128 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-12tdf#123076 Get paper size for print previewGabor Kelemen1-0/+2
Initialize from current paper size which can be different from A4 Change-Id: Iae5e33d79c0783a32dad8635a66cc3fbe83dc568 Reviewed-on: https://gerrit.libreoffice.org/84920 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 562c30d5ad142fcdc77be6125fdac6d48b782fd7) Reviewed-on: https://gerrit.libreoffice.org/85053 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-12tdf#128824 Keep multiselection in style list on right clickSamuel Mehrbrodt1-1/+2
Change-Id: I196f8c7d3a1a0b3267498f6cde55069ba3a60523 Reviewed-on: https://gerrit.libreoffice.org/84882 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 13966121b49369950f2c214f3ab109fbad0386ad) Reviewed-on: https://gerrit.libreoffice.org/84947 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12Qt5 fix missing XCB_ICCCM_WM_HINT_WINDOW_GROUPJan-Marek Glogowski2-0/+73
This is the application level equivalent of the Qt5 fix for bug QTBUG-46626 / commit 0de4b32 ("xcb: fix issue with dialogs hidden by other windows"), which was broken since Qt 5.4 and is just fixed since Qt 5.12. It is needed for some window managers, which don't know about the WM_CLIENT_LEADER property. Both settings are the same, but just the latter is set by older Qt5 releases. This probably isn't a real problem, as GNOME or XFCE would use the gtk VCL plugin, but since I already wrote the code when debugging tdf#129071, there is also no reason to drop it (except: more code, more bugs...). This fix is optional and needs development headers for xcb-icccm, which can actually be compiled into Qt5. If missing configure will just print a warning, since it's a runtime requirement and we explicitly drop the linked Qt version symbol, so the potential build Qt version won't matter. Change-Id: Ifc5a8f8a40ee13779a911efb53e8b8b868614d0b Reviewed-on: https://gerrit.libreoffice.org/84299 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit fe2baf9e84e0ca9aeaa683e37076f57fa3f38dca) Reviewed-on: https://gerrit.libreoffice.org/84810
2019-12-11Resolves: tdf#128867 support LocalizedDecimalSep for native gtk dialogsCaolán McNamara1-0/+4
Change-Id: Idb883707fb89d1f76b24ea592c51e28fffd2322f Reviewed-on: https://gerrit.libreoffice.org/84953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09drawPixel() should still get 'true' for bXorModeAllowed.Jan Holesovsky1-2/+2
That part of 7b267be4b2c87b2c3987d4d751307977a7d3ad41 was not necessary. Change-Id: Ie085f635d4adb6f574f3eca37976f9aded505524 Reviewed-on: https://gerrit.libreoffice.org/84536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09tdf#129071 Qt5 set file picker parent widgetJan-Marek Glogowski2-28/+82
If the XInitialization::initialize has a parent option, use that system window ID to find the parent Qt5Frame and set this as the parent of the file picker. This way the file picker doesn't show up as a separate window in the KDE task bar and get the proper icon. Just setting it transient to the parent is not enough. This also includes the terminate listener handling, so an open file picker won't prevent LO to shut down gracefully (which is handled independent from the document modified state). Change-Id: I62aef532e739e7fea9fe8a4b4e6c0e205faae1d9 Reviewed-on: https://gerrit.libreoffice.org/74544 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit d79a41a02cd46c50cab08ba1a5d5b213b6843251) Reviewed-on: https://gerrit.libreoffice.org/84756
2019-12-09tdf#122706 Fix built-in HID on Print dialogs Help buttonKelemen Gábor1-1/+1
to open the general Print page. Change-Id: I1ffee4a9d72bb6a4840dec3800a397a878ed2eca Reviewed-on: https://gerrit.libreoffice.org/84628 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 46a07f2042a812fc552e26736183c7d06fe6aa35) Reviewed-on: https://gerrit.libreoffice.org/84735 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-06tdf#129071 Qt5 handle windows with parents as dialogsJan-Marek Glogowski3-8/+9
This is the main fix for this bug. Qt Xcb is a little picky here. It won't tell the window manager about the transient state, using WM_TRANSIENT_FOR, for all Qt::WindowTypes. The QPA internal list (see isTransient function) doesn't include the Qt::Window, which is qt5 VCL's primary used window type. This has two consequences: 1. LO dialogs show up in the plasma task manager as seperate windows. 2. LO has to handle the transient state itself, instead of relying on the window manager. This results in flickering, because LO can just push a transient window to the top again, after the parent window was activated and therefore drawn in front. So this just declares all windows with parents to be dialogs. Almost everything else should be a top-level window anyway. If not, there is SalFrameStyleFlags::DIALOG to create a parent-less dialog window. Change-Id: I89a6d46fd09e4f1d1d2904e152a26733eb266079 Reviewed-on: https://gerrit.libreoffice.org/84298 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit d8e3a08f06dcfea02c3f2f2a8578486381d77df7) Reviewed-on: https://gerrit.libreoffice.org/84619
2019-12-06KF5 drop KF5FilePicker::executeJan-Marek Glogowski3-29/+7
To prevent calls to Qt5FilePicker::updateAutomaticFileExtension, it is simply made virtual with an empty override. This is needed, because the KF5 file picker has its own automatic extension handling. The main motivation is the fix for tdf#129071, which will result in some major changes to XExecutableDialog::execute, so this will prevent larger code duplication later. Change-Id: I5f747f0828cb8a65b4e7043f3ee68ebd31973e6a Reviewed-on: https://gerrit.libreoffice.org/84297 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit c0cdb01ef33042be76251c4a353e0582a0838e0e) Reviewed-on: https://gerrit.libreoffice.org/84605 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-06Qt5 hide more Qt5FilePicker detailsJan-Marek Glogowski4-47/+32
* Make most members private * Drop some unused members * Rename some single-char variables for easier reading * Spread some constness * Finalize the KF5FilePicker class * Test the native picker setting of the QFilePicker, instead of an additional bool member This is just some refactoring. While not strictly needed, it helps keeping the following patches fixing tdf#129071 more compact. Change-Id: I15ffe4de848a9498d7f61f99bcf031257da7cb08 Reviewed-on: https://gerrit.libreoffice.org/84456 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit f33b6e915fdc29cff25cc93784a04df866ad6bc3) Reviewed-on: https://gerrit.libreoffice.org/84551 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-06handle unsetting ImageCaolán McNamara1-1/+4
Change-Id: If4a3ab94c268caeebdc42c664c568aa9004c50ad Reviewed-on: https://gerrit.libreoffice.org/84580 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06Resolves tdf#129140 - Wording in printer dialogHeiko Tietze1-3/+3
Wording improved Change-Id: I67fcee9bdae869eb57882b1944e8975d4c564735 Reviewed-on: https://gerrit.libreoffice.org/84572 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 291b1acd3b9664ed41954458648448d7799d4df9) Reviewed-on: https://gerrit.libreoffice.org/84590
2019-12-05headless: Don't leak the cairo context in drawPixel().Jan Holesovsky1-1/+4
Change-Id: If841f655ac634eee2dc7ca6e9445d2f204546545 Reviewed-on: https://gerrit.libreoffice.org/84445 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 5b607ae89de9494c01952852df30a6f77206eadc) Reviewed-on: https://gerrit.libreoffice.org/84470 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-04tdf#128992 Compressing PNG files with alpha channel get a black backgroundNoel Grandin1-1/+2
regression from commit d4442ac1ac9aae36dbc08fda8154d71ea0f81708 Date: Wed May 30 13:02:25 2018 +0200 drop Graphic::GetBitmap Change-Id: I937f89255eebc68dffc2987e628a30bc7d2eed7b Reviewed-on: https://gerrit.libreoffice.org/84412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 1187e2b35bb864808d9d158f0b10d83ce75dbaa7) Reviewed-on: https://gerrit.libreoffice.org/84428
2019-12-03tdf#129134 ApplicationColors Scrolled List moves too littleCaolán McNamara2-0/+22
Change-Id: I5cb6ac017f1d2a916297676724d523634afb2020 Reviewed-on: https://gerrit.libreoffice.org/84254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03tdf#129043 Correctly deliver combo box events when used with keyboardSamuel Mehrbrodt3-2/+6
Change-Id: I82186f999e74be4aebd59d77666390a7d5e8ad81 Reviewed-on: https://gerrit.libreoffice.org/83923 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 7de9417d5f65d35227c7f80f6d587c2a56bde4e0) Reviewed-on: https://gerrit.libreoffice.org/83982
2019-12-02tdf#129068 try dialog content area help before dialog itselfCaolán McNamara2-0/+38
we already check current notebook page before the dialog, now check the content area before the dialog Change-Id: Ieedb5727ddec6d24adc6e70144977b5c3063c0fd Reviewed-on: https://gerrit.libreoffice.org/84247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-28tdf#126043 use another bulk_insert_for_eachCaolán McNamara2-1/+13
Change-Id: I05c3fc6e708d000ba955981dbd8d11371ea99da2 Reviewed-on: https://gerrit.libreoffice.org/83686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 05734503ed36cff64cfaac8afb7c6df5eced8873) Reviewed-on: https://gerrit.libreoffice.org/83983
2019-11-28tdf#128337 clip the metafile Gradient drawingJan-Marek Glogowski2-8/+10
This basically reverts the patches for tdf#125670. Instead this just checks the mpGraphics in InitClipRegion() before using it, to prevent the crash from the tdf#125670 bug report. Additionally it drops the early mbOutputClipped return, as the output device doesn't matter for the metafile drawing and the preview of the tdf#125670 bugdoc and the Impress full screen view otherwise don't show the gradients. This patch works for me in the following tested scenarios: 1. Bugdoc tdf#125670 doesn't crash 2. Bugdoc tdf#125670 draws gradients in Impress full screen 3. Correct thumbnail pictures for both bug documents With all these side effects, I have no idea, if this is finally the correct fix and doesn't break anything else... Change-Id: I8c48210d4255e50339710fc14819d15686417c9c Reviewed-on: https://gerrit.libreoffice.org/83722 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit e021901b6c4f60735512c8d36b625be4f8edfd77) Reviewed-on: https://gerrit.libreoffice.org/83951 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-28get_active should be true when activated but menu not yet shownCaolán McNamara2-2/+14
Change-Id: Ia2a7cbf5b47eab6d09c78eb9d18233e18b628a3f Reviewed-on: https://gerrit.libreoffice.org/83906 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-27tdf#129042 factor the wizard buttons into the desired min widthCaolán McNamara1-4/+14
Change-Id: Ib89e8813c6f8e5203708952215156d3d5281ad17 Reviewed-on: https://gerrit.libreoffice.org/83914 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-27tdf#129042 set a min size for the wizard dialogsCaolán McNamara1-0/+1
Change-Id: I81264f98d122c81cf0c6e865bfbac81ea9fe8126 Reviewed-on: https://gerrit.libreoffice.org/83894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-27tdf#108642 load accessibility children fasterNoel Grandin1-24/+34
Reduces the cost of repeatedly iterating over the page objects, by adding a new XAccessibleContext3 interface to return accesibility children in one call. This takes the load time from 5.6s to 3.2s. Change-Id: Ifcc20fa7e7ab8ad50417073882c8c3a2405d1eaa Reviewed-on: https://gerrit.libreoffice.org/83850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 980c859480be431311ba803c5251694160dcb3d5) Reviewed-on: https://gerrit.libreoffice.org/83887
2019-11-27tdf#108642 rate-limit progress paintingNoel Grandin1-3/+11
this takes the load time from 9s to 6s for me Change-Id: I1a492b33106e43b1405238fe3a120a6447649f69 Reviewed-on: https://gerrit.libreoffice.org/83848 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 28ea418a3f1905d8a4a8e5813e8ed737960c62d2) Reviewed-on: https://gerrit.libreoffice.org/83885
2019-11-27tdf#126607 Qt5 activate window before setFocusJan-Marek Glogowski1-1/+5
.., and prevent Qt5MainWindow to take any focus. Our top level Qt5MainWindow shouldn't handle focus directly, as it's always completely drawn by the child Qt5Widget, which also handles input. So prevent any direct focus handling by setting the Qt5Widget as the focus proxy of the Qt5MainWindow. Also setting the focus of the child widget on its own seems to do nothing at all. At least I didn't see any difference after commenting the code block. But it at least has some effect, if you call setFocus on the real window, but that breaks Impress full screen mode, which somehow gets scroll bars?! Not that I understand why this is needed. At least the original X11 code just calls XSetInputFocus in this case. Change-Id: I591c031a17a7ae0b5486760cd1802522d4088678 Reviewed-on: https://gerrit.libreoffice.org/83689 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit ec554ac30236fa7949e9866d01319d4e3e88c983) Reviewed-on: https://gerrit.libreoffice.org/83838 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-11-27tdf#127403 Revert "VCL keep / return the original set TextEngine font"Jan-Marek Glogowski2-25/+56
This reverts commit cc223fa12a61ba0e580b884386a7f5d7efd0541f. All the other attenps to fix this seem to cause timeouts in the Jenkins clang_dbgutil build. I don't have one around and no time to investigate further, so let's see, if the revert passes. Change-Id: Ib915185eaf79073523351705baf28df3c62906f1 Reviewed-on: https://gerrit.libreoffice.org/83654 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit b1e73fd49661e07e6085310f3f6ecc6ade2a3762) Reviewed-on: https://gerrit.libreoffice.org/83827 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-26tdf#126043 fetch the command properties just onceCaolán McNamara5-34/+31
Change-Id: Iaf343e9858be36ca8772d9c12eee772d93b4c394 Reviewed-on: https://gerrit.libreoffice.org/83668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/83763
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 11:48:41 +0000