summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2017-08-11Correct icon size assignmentYousuf Philips1-6/+3
Change-Id: I9cefadba78688aebbf93e63f0bf29dbe96839fea Reviewed-on: https://gerrit.libreoffice.org/38408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-08-09send this MapMode scale thing back to where it came fromCaolán McNamara4-161/+0
Change-Id: Ic33f4b4bf7a0df35f04778e474f5a136f06be4a6 Reviewed-on: https://gerrit.libreoffice.org/40926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-09Resolves: tdf#99286 for jpeg dpi use apis that know about MapUnit::MapPixelCaolán McNamara2-14/+16
move the code which can do this from sw to vcl Change-Id: I9940fb80ecdbfe8f70afc500c691288ed0993701 Reviewed-on: https://gerrit.libreoffice.org/40925 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-09osl::Mutex::acquire can effectively only fail upon programming errorsStephan Bergmann3-18/+13
...so simplify the design a bit here (and there was no meaningful failure- handling code, anyway) Change-Id: I34bb3a7b5fc56f2213a4d22438f0733e1b65fe4b
2017-08-09Rephrase SchedulerMutex::acquire so it would work for nLockCount=0Stephan Bergmann1-2/+1
Change-Id: Ibd5f45b5829e51f872e90a4256ae875bc5d363d4
2017-08-09Remove unnecessary, broken check for mnLockDepth != 0Stephan Bergmann1-8/+5
If SchedulerMutex::release were ever called from a thread not having locked the mutex, mnLockDepth would have an arbitrary value, not necessarily zero. It is clear that SchedulerMutex::release must only be called by a thread that has the mutex locked, so the check was redundant. Change-Id: I4969b8e6543657602494e333a6a3ea07d83267d1
2017-08-09SchedulerMutex::release: don't read mnLockDepth with maMutex already unlockedStephan Bergmann1-13/+3
...another thread may already have called SchedulerMutex::acquire in between, whose effect would then be canceled Change-Id: Icddb6ea47144366c3a81bc83e3f9469b25a18c22
2017-08-08tdf#111497: fix leak in FindFontSubstitute with CFReleaseJulien Nabet1-0/+1
Change-Id: I9d7de52b4a1ee102b233b982e97ecbf731b476f2 Reviewed-on: https://gerrit.libreoffice.org/40895 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-08loplugin:constantparamNoel Grandin13-33/+21
Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-07tdf#111432: fix leaks in AddTempDevFont with CFReleaseJulien Nabet1-0/+2
Change-Id: I11183b7fd21d2398de9e5f5854763cef96963caa Reviewed-on: https://gerrit.libreoffice.org/40845 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-07tdf#39468: Translate some random German comments and termsJens Carl4-9/+9
Change-Id: I05912b89d059256b20233a0fac244630544d5b0a Reviewed-on: https://gerrit.libreoffice.org/40800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-07loplugin:casttovoidStephan Bergmann9-15/+3
Change-Id: Icda66259acf54e6771b926ce9d329287bd610e82
2017-08-07loplugin:oncevarStephan Bergmann3-4/+4
Change-Id: I678b1bf281ae4de4a75f8c83398ee19f75b4f278
2017-08-07loplugin:staticmethodsStephan Bergmann1-4/+4
Change-Id: I13fe0b5b77d8d43639afa035f2db6e904cd998be
2017-08-07loplugin:unnecessaryparenStephan Bergmann6-7/+7
Change-Id: I9496cafef840195e3934bf92600d4e8c8edb6c26
2017-08-06set LANGUAGE from SvtSysLocale().GetUILanguageTag()Caolán McNamara1-12/+9
Change-Id: I466576660bdc281c3332fa25f0fe0756cd356ab7 Reviewed-on: https://gerrit.libreoffice.org/40788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-06wrong qpw fftester attemptCaolán McNamara1-14/+0
the correct "qpw" effort was added later Change-Id: Iee2fb66b99759317ca9ba25c2c7b1956ee4bb48f Reviewed-on: https://gerrit.libreoffice.org/40809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-04Add VCL scheduler documentationJan-Marek Glogowski1-0/+156
Change-Id: Ifb2332b6d3c8bf472c684d3a79c861cc9035d246
2017-08-04Implement VCL Scheduler lockingJan-Marek Glogowski4-24/+126
Replces the SolarMutex scheduler locking by using a distinct mutex included in the scheduler context. It should also get rid of the spurious assert( !bAniIdle ) failures, as the test now holds the Scheduler lock for the whole time. This includes reverting the additional scheduler de-init from commit 2e29a518b04250b5f9cc9d0d77da3df076834d60, as I couldn't reproduce the bug running the unit test in valgrind. Change-Id: If33f815fe86c8f82175e96adceb1084b925319dd Reviewed-on: https://gerrit.libreoffice.org/40497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-08-04svl: move DecodeHexString from vclAshod Nakashian1-45/+1
Change-Id: I86da993050bde20f9ff0413ad5424673647a0e5c Reviewed-on: https://gerrit.libreoffice.org/40720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-03loplugin:checkunusedparams in variousNoel Grandin3-67/+41
Change-Id: I4f54940a9ebdcd47776b2a5f7bae6e49b633ee44 Reviewed-on: https://gerrit.libreoffice.org/40706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-03lok - add support for in place chart editingMarco Cecchetti2-0/+10
This commit add a minimal support for editing chart embedded in a spreadsheet or a text document or a presentation. Graphic objects can be moved and resized, text objects can be edited. Change-Id: I8e637dabf328a94bd6bb0e309a245302cff421d8 Reviewed-on: https://gerrit.libreoffice.org/39342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-08-02remove unnecessary use of 'this->'Noel Grandin4-4/+4
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02split out VclBuilder static methodsCaolán McNamara3-122/+124
Change-Id: Ic94b39351c9a6131fb61883a98ae9e3ee60ad119
2017-08-02uitest: detect real floating windows betterMarkus Mohrhard1-1/+5
We use the FloatingWindow base class also for some windows that are not independent. A good example is the hyperlink dialog. Change-Id: I067ac0465de9ff3c8f9bc0c1a5c817a5e09d96e5 Reviewed-on: https://gerrit.libreoffice.org/40650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-01tdf#109997 WIN don't post a callback event directlyJan-Marek Glogowski3-43/+20
I doesn't seem possible to post an event deterministically to the end of the Windows message queue and then process this queued events "in order". PeekMessage and now even DispatchMessage process events out of order - that's how this assert was hit. I was quite sure it would not hit, but a simple resize proved me wrong. And the assert just proved that all my assumptions were wrong :-( So this gives up the whole idea of a short-circuit message queue handling on Windows for busy processing of LO Idles and goes back to some kind of the original "always timer" implementation. Since the "parallel" processing of LO events after system messages during DoYield was dropped, this might be slower; or not. In the end this simplifies the main loop almost to the starting point, except for a little busy loop, if we wait for an Idle event timer - not so busy acually, as we just switch to another local thread, which hopefully is our idle timer waiting to fire. A short-circuit with a little detour. Change-Id: Id63a2a9e2a3b1501ad50a2c6f308a36efe55e68f
2017-08-01move resmgr to unotoolsCaolán McNamara8-10/+10
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-08-01loplugin:constparams in variousNoel Grandin7-10/+10
Change-Id: Id15f3562f42afa6c679cea3c839172557ead0395 Reviewed-on: https://gerrit.libreoffice.org/40624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-01loplugin:checkunusedparamsNoel Grandin1-3/+2
the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: https://gerrit.libreoffice.org/40613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31add CVE-2017-9614 testcaseCaolán McNamara1-0/+0
Change-Id: Ib29114642c898d1c73ee72ac368a19c56950dabd Reviewed-on: https://gerrit.libreoffice.org/40586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-31loplugin:oncevarNoel Grandin10-21/+19
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31vcl PDF tokenizer: indentation fixesMiklos Vajna1-1/+1
Change-Id: Ic8c652085c3132c0245c2629b71b0e2555d167cb
2017-07-28GEN fix timeout result handlingJan-Marek Glogowski1-3/+3
The GEN VCL backend simply ignored the result of the timeout. Change-Id: I0c1b34927ba97886cf11b2c2a203c3e82d851dc9
2017-07-28add calc rtf filter test hookCaolán McNamara1-0/+14
Change-Id: Ib15f1094929e1670537657b4c19cc1e0bfd39bbd Reviewed-on: https://gerrit.libreoffice.org/40537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-28loplugin:constparams handle constructorsNoel Grandin9-13/+13
had to change the structure of the plugin considerably, was too messy to structure it to do the calculations on a per-function basis Change-Id: I4edee7735f726101105c607368124a08dba21086 Reviewed-on: https://gerrit.libreoffice.org/40516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28add s[y]lk fuzzerCaolán McNamara4-0/+92
Change-Id: I46272f8a0b35776b9d14f72b1720e951458ab208
2017-07-28loplugin:checkunusedparams more part1Noel Grandin11-45/+30
seems I got one of the checks wrong, and was missing a bunch of stuff Change-Id: I2c662fc4e735f8d6cbe56c6f82906a60a580331b Reviewed-on: https://gerrit.libreoffice.org/40481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27make animation loop sal_uInt32 consistentlyCaolán McNamara4-7/+6
all this foo is ultimately animated gifs and the count there is limited to unsigned 16bit Change-Id: Ib6e6dde7355f3619bb7735743e686e6338a235ee
2017-07-27align ImpVclMEdit::SetMaxTextWidth arg with TextEngine::SetMaxTextWidthCaolán McNamara1-4/+4
Change-Id: I7cc7531d6a1770edd8b644c6958b91275a53dd84
2017-07-27Resolves: tdf#109289 add SvxColorListBox::IsValueChangedFromSavedCaolán McNamara1-1/+0
and remove PushButton::IsValueChangedFromSaved Change-Id: Ib1c51e27fd708c5d4811c90ef5659b4d55dd8860
2017-07-27gtk3: Resolves: tdf#109227 take modifier key into account for dndCaolán McNamara1-2/+26
Change-Id: Id0aa4ced8644ddbee9e1a0453887f07907547aae
2017-07-26Resolves: tdf#104141 CAIRO_FORMAT_A1 vs N1BitLsbPalCaolán McNamara1-16/+38
where vcl transparency is the opposite of cairo's so we've been switching the source color to the opposite for drawing on CAIRO_FORMAT_A1 and then sucking out the bits "as-is" to give the right results. Now instead use the right source color and toggle CAIRO_FORMAT_A1 bitmaps to N1BitLsbPal in getBitmap. Then additionally toggle all N1BitLsbPal bitmaps input to drawBitmap to CAIRO_FORMAT_A1 when making a cairo surface from them. Change-Id: I45c6d4f3894c6a22a07a3bd65950cd8070e8eaff Reviewed-on: https://gerrit.libreoffice.org/40453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-26Related: tdf#102909 gtk3: remove configure loophole of non-native menubarCaolán McNamara2-23/+9
the ENABLE_DBUS + ENABLE_GIO thing is to allow building against an old gtk2 baseline. If building against gtk3 then gio and dbus are available, and allowing the unusual configure path through gtk3 results in a non-supported cruddy build Change-Id: Ic6306fe2f9951714fd5875c24aedda1d7c6f2b93 Reviewed-on: https://gerrit.libreoffice.org/40420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-25tell msvc our source code is written using utf-8Caolán McNamara1-2/+1
Change-Id: I4fb364ceb34e0851f2d04c403333bf428e8cfa98 Reviewed-on: https://gerrit.libreoffice.org/40305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-25WIN don't process the SendMessage from DoYieldJan-Marek Glogowski2-2/+6
Actually we just want to remove the SAL_MSG_TIMER_CALLBACK messages, but this seems to be impossible using PeekMessage, without the side effect of processing some messages: "During this call, the system delivers pending, nonqueued messages... Then the first queued message that matches the specified filter is retrieved.". But it is actually enought to ignore the SAL_MSG_THREADYIELD message send using SendMessage from DoYield, which can be filtered by using PM_QS_POSTMESSAGE. Probably this should be resolved not using PeekMessage at all by using a variable to hold the time of the last posted SAL_MSG_TIMER_CALLBACK message, so we just run the callback once, if our time is <= MSG time and ignore the multiple queued messages. Same for mbOnIdleRunScheduler handling. Change-Id: Ifacb20aa38e6b5aca908e5411cf2e100f702ad1f
2017-07-25tdf#109281 add fallback to GDI back when we can't bind a DCTomaž Vajngerl1-0/+5
Change-Id: Ibaa0a86562cdeaff989c2a548efa03ea24933213 Reviewed-on: https://gerrit.libreoffice.org/40398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-07-25Related: tdf#102909 use menubar style for non-native menubarsCaolán McNamara1-2/+1
this code should typically not get used at all, as the menubar is a native one, but there is a possible configure route at the moment where this could be achieved. Change-Id: I23c7fa8ad05a378c7d64c75de5f895aa49001597
2017-07-25Resolves: tdf#104368 allow toolbars to have keyboard focusCaolán McNamara1-1/+1
note that there aren't any floating dockable toolbars available under wayland, just X so export GDK_BACKEND=x11 to get gtk's X backend under wayland Change-Id: I07e345a00f8fef4c40dcaf208e3438783f8f280e
2017-07-25fix some "deffer" spellingNoel Grandin5-8/+8
Change-Id: I8fa9782242e92d754eaa131d424eb0a26f04a319 Reviewed-on: https://gerrit.libreoffice.org/40394 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25loplugin:unusedmethodsNoel Grandin5-30/+0
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb Reviewed-on: https://gerrit.libreoffice.org/40391 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 07:31:35 +0000