summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2018-10-21pvs-studio: silence bogus V557Caolán McNamara1-14/+20
Change-Id: I5aa740afa1143adaf4e2afa5d5e1596497de8323 Reviewed-on: https://gerrit.libreoffice.org/62112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: silence bogus V656Caolán McNamara1-3/+4
Change-Id: Ib54677e4172b8d2b789cf49ab964fbcc112869f8 Reviewed-on: https://gerrit.libreoffice.org/62110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: Expression 'mnInterlaced == 0' is always true.Caolán McNamara1-4/+1
Change-Id: Ie7f62b8eabf12010aa8f1ab03ca2f65d9c6856ed Reviewed-on: https://gerrit.libreoffice.org/62069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21loplugin:redundantinlineStephan Bergmann5-6/+6
Change-Id: I5fb1c6ba516e2853b1826e20c6c21cccc1fe98fa Reviewed-on: https://gerrit.libreoffice.org/62074 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-21tdf#120703 (PVS): 920d4463f6e59b815852c173e2974ffc7b4bb284 follow-upMike Kaganski1-7/+4
V519 The 'o_rKeyLength' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1276, 1279. V519 The 'o_rRC4KeyLength' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1277, 1280. Change-Id: I1dc4ba9097996201d97ef323113ed0b11f3cb913 Reviewed-on: https://gerrit.libreoffice.org/62120 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): handle malloc/realloc failuresMike Kaganski1-2/+9
V769 The 'pTmpTarget' pointer in the 'pTmpTarget - pTarget' expression could be nullptr. In such case, resulting value will be senseless and it should not be used. Check lines: 81, 67. V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'pTarget' is lost. Consider assigning realloc() to a temporary pointer. V769 The 'pTarget' pointer in the 'pTarget + nOffset' expression could be nullptr. In such case, resulting value will be senseless and it should not be used. Check lines: 85, 82. Change-Id: I883ea42fca66467edfe26382c78636c1d48c5260 Reviewed-on: https://gerrit.libreoffice.org/62115 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-20use std::unique_ptrCaolán McNamara1-7/+4
Change-Id: I8645d1d0776f7b7f2cd6e6d18f387210c6e126d9 Reviewed-on: https://gerrit.libreoffice.org/62068 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20ImpDetectPCX 2nd arg always overwrittenCaolán McNamara1-49/+45
Change-Id: I0ec1e71d40c34f021003330c4dd0a8d5ee2b6ce2 Reviewed-on: https://gerrit.libreoffice.org/62018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20weld SchAttribTabDlgCaolán McNamara2-0/+39
Change-Id: Ia53547b7b42a3ff8848085ab8f8d214259d5cc7b Reviewed-on: https://gerrit.libreoffice.org/61959 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20wrong pointer checkCaolán McNamara1-1/+1
since... commit 2636ab883adbcb1f6593787934c6d6d3fff67c21 Date: Mon Sep 15 20:13:54 2014 +0200 vcl menu: Rename CloseStartedFrom() to ClosePopup() + adapt code. Change-Id: Ie30f6d907907551e23e592b8502107e75c333f2e Reviewed-on: https://gerrit.libreoffice.org/61997 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20when calling std::lower_boundNoel Grandin1-3/+2
it's not enough to compare != end(), you also need to compare the key against the iterator result Change-Id: Ide5f151ba2297a35e5546f47fbc3c53cbe5ab533 Reviewed-on: https://gerrit.libreoffice.org/62014 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19WIN fix CacheGlyphToAtlas resource handlingJan-Marek Glogowski1-13/+10
Use :comphelper::ScopeGuard to handle cleanup. And actually restore the original font on the correct DC. Change-Id: Ib59d430636b470486da2f8e5e34ed8d71b57aac2 Reviewed-on: https://gerrit.libreoffice.org/62010 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-19simplify comparisonCaolán McNamara1-2/+1
Change-Id: Ia298ee3e315e241ebc1c1664958d5a3a47820f28 Reviewed-on: https://gerrit.libreoffice.org/61999 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19tdf#120452: Just enough of SystemEnvData in Qt5ObjectKatarina Behrens3-4/+10
the video in the presentation still doesn't play but at least the crash is gone Change-Id: I78ab4ff9412998f235a4b44a23b0e9d3ef4143e0 Reviewed-on: https://gerrit.libreoffice.org/61944 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19Make repeated drag'n'drop possibleKatarina Behrens3-0/+36
Change-Id: If87ceeb8ddc4b2aada8ea0c963385a291622fef6 Reviewed-on: https://gerrit.libreoffice.org/61932 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19Now that initiating drag works, let's also accept dropsKatarina Behrens5-0/+37
Change-Id: Iab328edd799dd4ce04312db4e640f86a8f7fda77 Reviewed-on: https://gerrit.libreoffice.org/61897 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19Kick-start beginning of drag eventKatarina Behrens5-2/+63
Change-Id: Iaad25a7acdc7d64013bc3dd0d9410e7d2d5c6762 Reviewed-on: https://gerrit.libreoffice.org/61791 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19clang-tidy readability-container-size-emptyNoel Grandin16-29/+29
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy readability-misleading-indentationNoel Grandin4-16/+14
Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy modernize-redundant-void-argNoel Grandin1-1/+1
Change-Id: Ia25ac2e40f29e5b766a4c5c013fb53274196f656 Reviewed-on: https://gerrit.libreoffice.org/61934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19loplugin:staticvar in vclNoel Grandin10-86/+53
Change-Id: I2bdab84dc81e0545aa96542caec213db61765f68 Reviewed-on: https://gerrit.libreoffice.org/61922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18Implement drag'n'drop-related qt5 events, no-op so farKatarina Behrens2-2/+38
Change-Id: I67b8cecdc85ad77d7ab48d229459a79bc168072d Reviewed-on: https://gerrit.libreoffice.org/61721 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18Just enough of SystemEnvData for drag'n'dropKatarina Behrens3-4/+13
Change-Id: I18ef6cb58632898ddfcb28098b99447565bcfb99 Reviewed-on: https://gerrit.libreoffice.org/61720 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18Basic structures for qt5 drag'n'drop supportKatarina Behrens7-0/+351
put (so far) no-op UNO ifaces in place Change-Id: I95394cfe05b8e3db21ddce6dfed1c1bb1d0e6381 Reviewed-on: https://gerrit.libreoffice.org/61385 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18weld SdPresLayoutTemplateDlgCaolán McNamara1-1/+1
Change-Id: Ifc4c9a4631e92eee4b7f9b215c41d2bcc12a17d1 Reviewed-on: https://gerrit.libreoffice.org/61926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18tdf#119847 - Can now autoselect font size on first clickNickson1-2/+6
Change-Id: Id49f4d039f0eb7c4efccecda91bd656c1c31d497 Reviewed-on: https://gerrit.libreoffice.org/60784 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-18clang-tidy readability-simplify-boolean-exprNoel Grandin4-34/+12
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64 Reviewed-on: https://gerrit.libreoffice.org/61902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18Qt5AccessibleEventListener: Improve mappingSamuel Mehrbrodt1-2/+2
Change-Id: I8852b37b2c82f88b5feb5aa42775fbfeb3c9b187 Reviewed-on: https://gerrit.libreoffice.org/61886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-17fix buildRene Engelhard1-0/+1
Change-Id: I33451bd326697cfffb156f041dd1c2500da385da
2018-10-17tdf#120651 have to sort radiogroup by tab positionCaolán McNamara1-0/+3
Change-Id: I8fcf4c4b186d8292c85babaa90e98396a5fbc71b Reviewed-on: https://gerrit.libreoffice.org/61882 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17Implement Qt5AccessibleText::characterCountSamuel Mehrbrodt1-1/+5
Change-Id: I91135172bbfb34010f6c53833ac4b7c06b0f7d26 Reviewed-on: https://gerrit.libreoffice.org/61872 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-17qt5 a11y: Add event notificationsSamuel Mehrbrodt4-0/+223
Change-Id: Idb2fb2f880b4e848adc213a4e2cea33c5eb56f05 Reviewed-on: https://gerrit.libreoffice.org/61424 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin8-19/+16
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16coverity#1440242 silence Useless callCaolán McNamara1-1/+1
Change-Id: Idde46e74d15698e1665f3e439e3063ed5cb4f79a Reviewed-on: https://gerrit.libreoffice.org/61836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16coverity#1440300 rework to silence Using invalid iteratorCaolán McNamara1-9/+12
Change-Id: Icf887a54f0e999c633e4e3f514086c29842427fc Reviewed-on: https://gerrit.libreoffice.org/61835 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16loplugin:singlevalfields in vclNoel Grandin6-103/+56
Change-Id: I159f94fba64acc0e0599b64be02c7864b1ed02c3 Reviewed-on: https://gerrit.libreoffice.org/61813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16drop LazyDeletorCaolán McNamara8-65/+17
Change-Id: I7d2e00466f321994a46b0529d645e342f229c929 Reviewed-on: https://gerrit.libreoffice.org/61718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15weld ChartTypeDialog and SchLayoutTabPageCaolán McNamara1-0/+24
Change-Id: I101c56b855d0bdc43559ca4561d298fa4ad92572 Reviewed-on: https://gerrit.libreoffice.org/61797 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15loplugin:staticconstfield improvementsNoel Grandin4-25/+21
And fix ScXMLCachedRowAttrAccess::Cache which was never setting its mnTab field, and hence would never be hit. And fix oox::xls::CellBlockBuffer, which was never setting mnCurrRow. Change-Id: I2c46aa050b9ebe3c2dc2e52579555f97945dd61c Reviewed-on: https://gerrit.libreoffice.org/61772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15weld InsertErrorBarsDialog and ErrorBarsTabPageCaolán McNamara2-0/+15
Change-Id: I3fb2fb4d8010e43e59b4de5c488f137960bc6417 Reviewed-on: https://gerrit.libreoffice.org/61760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15loplugin:constantparamNoel Grandin3-16/+7
Change-Id: I895ceffa468d84d22e4a81b7a6b06eaed0bd839d Reviewed-on: https://gerrit.libreoffice.org/61776 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15clang-tidy misc-redundant-expressionNoel Grandin2-2/+2
Change-Id: I708b0b486a233071f95592ccdb97f27fc35a23c4 Reviewed-on: https://gerrit.libreoffice.org/61783 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15add SvStream::TellEndNoel Grandin13-51/+24
and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-14MoreButton is solely used by toolkitCaolán McNamara2-2/+2
Change-Id: Ieb436b49be3598e316d59a6d89cb211879d061c1 Reviewed-on: https://gerrit.libreoffice.org/61766 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14only vcl and toolkit need to use [G|S]etUnoWrapperCaolán McNamara5-10/+10
Change-Id: I47cdb47cceda32f0871fd2f713ea565852383ca7 Reviewed-on: https://gerrit.libreoffice.org/61765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14unowrap.hxx is also exposed for toolkit onlyCaolán McNamara12-12/+12
Change-Id: Ife3648c8ca84c942f02fb6eab2990ec3eb3eb3f9 Reviewed-on: https://gerrit.libreoffice.org/61764 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14split out vcl stuff used solely by toolkit moduleCaolán McNamara3-2/+4
Change-Id: Idb1dfcdaaefefa9a8d97ecdd22e39377cb31bc62 Reviewed-on: https://gerrit.libreoffice.org/61763 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14weld SwFrameAddPageCaolán McNamara3-0/+58
Change-Id: Ia63e22d01c6bcc08f50d3e1b12943094660c7fd0 Reviewed-on: https://gerrit.libreoffice.org/61758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14Simplify containers iterations in vclArkadiy Illarionov35-445/+268
Use range-based loop or replace with STL functions. Change-Id: Ide2f89194238ae6a1f21e8132e2297710d9e6dcd Reviewed-on: https://gerrit.libreoffice.org/61756 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-14Add some additional verification for LXQt as the desktop environment.Simon Quigley1-1/+3
ac9c14dbbd3a4341de0aa1b1dbc37ad2ce69398c added initial support for LXQt as a desktop environment under Linux, but this only works where a pure LXQt session is started and not when an LXQt distributor's session has been started. In upstream LXQt, $XDG_CURRENT_DESKTOP is always set to LXQt, so check that first. Change-Id: Ifaa1f85192dc7a943911846e1cb39cf49be03baf Reviewed-on: https://gerrit.libreoffice.org/61751 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-26 20:19:31 +0000