summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2018-11-17Resolves: tdf#121432 don't insert an extra page when parent is tabcontrolCaolán McNamara1-24/+28
but the new child is a toplevel widget Change-Id: Ib794e076e2626485b9d9231daf914db6dd9b5e2f Reviewed-on: https://gerrit.libreoffice.org/63439 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-15Resolves: tdf#121229 ignore internal children of VclScrolledWindowCaolán McNamara2-4/+8
Reviewed-on: https://gerrit.libreoffice.org/63357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 20b2903354138f8ab19261fab74658fcf6af70e3) Change-Id: Iecc474db8093520ba2d90aedfc5da66507f3033b Reviewed-on: https://gerrit.libreoffice.org/63359 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-12tdf#121276 gtk3_kde5: Don't prevent creating new filesMichael Weghorn1-0/+3
This takes over for gtk3_kde5 what was done for kde5 in commit c0f45c89063fa5c4334ff9e624d24d48638ffb4d. Change-Id: Ieca71498bd0cc00ca07b83f6e1178d983169d5be Reviewed-on: https://gerrit.libreoffice.org/63172 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit a6318cb430fd8f90b760f7dc36f4eacd3904e22e) Reviewed-on: https://gerrit.libreoffice.org/63193 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-12Resolves: tdf#121181 expand message boxes to show full titleCaolán McNamara2-0/+16
as MsgBox used to do Change-Id: I03d459b8c18f60a19ea5b0034a8d98f6aa4f5ce4 Reviewed-on: https://gerrit.libreoffice.org/63159 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-06tdf#118573: Acquire solar mutex when calling Application::RescheduleMike Kaganski1-0/+3
Change-Id: I252973ad5902738c2bb684f6bb70bc4c46500bae Reviewed-on: https://gerrit.libreoffice.org/62873 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 212ea275f21251903e449ba5a6b7c4fc2dc57642) Reviewed-on: https://gerrit.libreoffice.org/62930 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-31tdf#119020 always scale icons as 24bit RGBJan-Marek Glogowski2-1/+3
We don't really care for the palette or even lower bitness of the original icons, when scaling them. So just convert them to 24bit to get the best scaling quality. And also actually fail the OpenGL scaling for 8bit color icons, instead of handling them as a grayscale image, which results in "funny" luminance based color icons. Change-Id: I62ff9e7cd45dbffba81b0db5a0252737b6189059 Reviewed-on: https://gerrit.libreoffice.org/62505 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit b0c475a00ced9ec1e4ef1efb9d184ee8e2a3eaab) Reviewed-on: https://gerrit.libreoffice.org/62685 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31Resolves: tdf#120277 special character dialog not appearing in OnlineCaolán McNamara3-2/+40
the magic smoke connecting the dialog to the viewshell was in SfxModalDialog, so not inheriting from that drops the connection add a SfxDialogController to enable setting up the connection Change-Id: I29c45cd43e05295309fc647b039db0c6565ca0d1 Reviewed-on: https://gerrit.libreoffice.org/61311 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-30tdf#120764 Toolbar popups sometimes not showing under WaylandMaxim Monastirsky2-0/+16
This happens with gtk 3.24 if the toolbar button is clicked when the tooltip of that button is visible. The warning gtk emits is "Tried to map a popup with a non-top most parent". The solution is to hide the tooltip early on mouse button press event processing. (gtk does hiding too, but in a way which isn't useful here - see the code comment. We also have similar code for the non-native case in ImplHandleMouseEvent of winproc.cxx.) Note that it's likely a gtk bug, as this new tooltip behavior breaks some native cases too, e.g. combo boxes with tooltips. But we can't leave our toolbars broken until this is fixed upstream. Change-Id: I1ce8bffcd78a3bcbbfe2ffdd1bd006ae5dc79618 Reviewed-on: https://gerrit.libreoffice.org/62207 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit b8bf751f9f5e2cb718175c0f2c4b2be762dcf614) Reviewed-on: https://gerrit.libreoffice.org/62335 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-30Resolves: tdf#120988 mismatch of in/out locale formattingCaolán McNamara1-11/+7
Change-Id: I9def43c111adc877aeec9f1990f5dd76fabdbf8f Reviewed-on: https://gerrit.libreoffice.org/62486 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-26tdf#120807 check for valid ImplGetWindowImpl()Jan-Marek Glogowski1-1/+1
Change-Id: Ia1135d11990abc303849bd1b6a549c82008c79de Reviewed-on: https://gerrit.libreoffice.org/62260 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit db0051744330d82986e8f2629a027bc4a5dc1b4a) Reviewed-on: https://gerrit.libreoffice.org/62278 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-23wrong pointer checkCaolán McNamara1-1/+1
since... commit 2636ab883adbcb1f6593787934c6d6d3fff67c21 Date: Mon Sep 15 20:13:54 2014 +0200 vcl menu: Rename CloseStartedFrom() to ClosePopup() + adapt code. Change-Id: Ie30f6d907907551e23e592b8502107e75c333f2e Reviewed-on: https://gerrit.libreoffice.org/62045 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-22tdf#120651 have to sort radiogroup by tab positionCaolán McNamara1-0/+3
Change-Id: I8fcf4c4b186d8292c85babaa90e98396a5fbc71b Reviewed-on: https://gerrit.libreoffice.org/61883 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-19tdf#120204 drop simple glyph cacheJan-Marek Glogowski1-16/+0
Master has a new shared LRU glyph cache, but that is much more new code. So simply drop the current cache implementation. Change-Id: Ib73f3680f3d6357b1c9d2b07db521867b3742843 Reviewed-on: https://gerrit.libreoffice.org/61961 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-12Resolves: tdf#120031 skip min/max for empty string in GetSavedIntValueCaolán McNamara1-1/+6
so "" turns into 0, which is which we want for the single use case here in 6-1 Change-Id: I3e28b09e2ed99ab90583b087b4100efe4935414a Reviewed-on: https://gerrit.libreoffice.org/61378 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-11tdf#120261 gtk3_kde5: Leave event handling on gtk3 side to gtkMichael Weghorn2-41/+57
This introduces a new thread that takes care of handling the IPC command and result for executing the file picker ('Commands::Execute'), which is the only command in the file picker that may block for a longer time until it receives its result from the kde5 side (namely, when the dialog has been closed). While the file dialog is being executed, activate a dummy GTK dialog that also takes care of handling events in its main loop as long as the file dialog is shown. The dummy dialog is closed together with the KDE file dialog. (Since the actual KDE file dialog is run as a separate process, this one is mostly "transparent" to the soffice process from the point of view of a dialog.) This allows dropping the custom event processing previously done in 'Gtk3KDE5FilePickerIpc::readResponse()' that had the potential to cause all kinds of problems, e.g. when another event related to the file picker was triggered from a Java process via UNO. Change-Id: I3d663253f09320f7a8e0d9ec32a8fd6ec191c189 Reviewed-on: https://gerrit.libreoffice.org/61253 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 788716cebad012513cc2798589b817b86cbf1bbc) Reviewed-on: https://gerrit.libreoffice.org/61511 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11tdf#120261 gtk3_kde5: Read IPC cmds in own thread on kde5 sideMichael Weghorn2-61/+186
Move reading IPC commands and arguments to those commands to a separate thread and use the signal/slot mechanism to notify 'FilePickerIpc' whenever a new command and its arguments have been read. This allows to handle the events of other commands that have been received while the dialog is being executed. This will be needed by a subsequent change that will modify how IPC is handled on the gtk3 side. Change-Id: Ia77b21045b0196710cbe164fb640b36a128d5081 Reviewed-on: https://gerrit.libreoffice.org/61252 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 3b36855e48f6ef3f4e52e998c52c531fe5191477) Reviewed-on: https://gerrit.libreoffice.org/61510 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11tdf#118690 don't try to process all messagesJan-Marek Glogowski1-1/+6
Regression from commit 221b0ab1245b ("WIN use Reschedule instead of own dispatch loops"). This limit the maximum reschedule loops as the original code did. There is still a busy loop when opening the print dialog, as it was before the patch, but this at least gets printing started. Change-Id: If867329b82b13c898bb15b08584244084488a66c Reviewed-on: https://gerrit.libreoffice.org/60310 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 79cb9ef524c3a6b058019da5ca6acfad7a895bf2) Reviewed-on: https://gerrit.libreoffice.org/60941 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09filename may be nullCaolán McNamara1-7/+4
Change-Id: I373886d3613607b8ee8e96d8c0314865f3991a92 Reviewed-on: https://gerrit.libreoffice.org/61251 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-10-09listen to [leave|enter]-notify-event at event widget levelCaolán McNamara1-2/+3
rather than toplevel. This avoid the problem under wayland where with an initially maximized calc clicking in it will select all cells from 0,0 to the clicked cell until the mouse is released Change-Id: I138fe587c9cb7cfff0293847c00730593e3244e1 Reviewed-on: https://gerrit.libreoffice.org/61088 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-10-05Resolves: tdf#120175 normalize theme names to our naming schemeCaolán McNamara1-1/+3
So breeze-dark turns into breeze_dark Change-Id: Id5d06f73a79f099048b31fd16f9f9611236af392 Reviewed-on: https://gerrit.libreoffice.org/61321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f317a3de7473de5e6366ba4f2a4aa0ca25cdfdc1) Reviewed-on: https://gerrit.libreoffice.org/61404 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-21tdf#119302 WIN better font scale handlingJan-Marek Glogowski4-25/+46
Moves the scale factor into the LogicalFontInstance and uses the Glyphs font fallback level to use the correct font and scale. Probably the glyphs should be using a rtl::Reference to the LogcalFontInstance instead of the fallback level. I don't know if glyphs are evicted from the cache, if the fallback changes. There is now an assert and all places will use 1.0 as the default scaling factor, so LO should at least not crash. Reviewed-on: https://gerrit.libreoffice.org/60091 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit c177c305fc839e7a64d228ec56209d133588572b) Conflicts: vcl/inc/win/salgdi.h vcl/win/gdi/salfont.cxx Change-Id: I9dd4fc3a5b5924fc379b48a7f71c9eed26b4779d Reviewed-on: https://gerrit.libreoffice.org/60722 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-21tdf#119814 Fix UI freeze with gtk3_kde5 filepickerMichael Weghorn1-0/+3
Previously, the loop inside 'runCommands()' was triggered every time 'm_stdinNotifier' got activated. This could lead to both the soffice and the separate lo_kde5filepicker process blocking indefinitely, when during the execution of 'KDE5FilePicker::execute()', the processing of another event started which would then be blocked in the 'readCommand()' call; finally causing both processes to wait for input from stdin that would never appear (s. backtrace attached to tdf#119814). Since the loop inside 'runCommands()' runs until all commands have been processed, it's sufficient to start it once when 'm_stdinNotifier' is activated for the first time. Change-Id: Ie9180dbaf7e3f7ec033ad6d53fabe1b1ee363465 Reviewed-on: https://gerrit.libreoffice.org/60380 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit e95930d96459cc653342e78617db9498255569d0) Reviewed-on: https://gerrit.libreoffice.org/60407 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-20tdf#90376 revert the dock windows' Idles to TimersJan-Marek Glogowski1-19/+17
The dock windows' Timers were converted to Idles in commit eef25e0e7c03 ("changed timers to idles"). Since the Idles poll the mouse buttons, they starve all lower priority events. From the comment in ImplDockFloatWin2::Move, this is a hack to get the mouse release event from the window decorations in X11. Change-Id: Ibba3c58dd8b3d95dbd9296cc111ab32968bee230 Reviewed-on: https://gerrit.libreoffice.org/59590 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit afd49c198769b5e7fc01a68ce7a6847aa0d0ddd8) Reviewed-on: https://gerrit.libreoffice.org/60720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20tdf#119340 WIN don't always re-init the HFONTJan-Marek Glogowski1-8/+14
After all the LogicalFontInstance refactoring, its FontSelectData is now immutable, so the HFONT will never need to be changed. Therefore we can skip the HFONT lookup in WinSalGraphics::SetFont, if the WinFontInstance already has it set. All the HFONT handling (basically WinSalGraphics::ImplDoSetFont) should be moved to the WinFontInstance to further clean this up. Reviewed-on: https://gerrit.libreoffice.org/59988 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 7e7a1ff3926e86705199aa9814089e90f01c02ed) Conflicts: vcl/win/gdi/salfont.cxx Change-Id: I1c9a9e3414677d77f0f007d7ace653bb53b8474d Reviewed-on: https://gerrit.libreoffice.org/60721 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19emboss filter brokenCaolán McNamara1-1/+1
since... commit 4b183ae94821ed6d08708b43e4d719ffb4540843 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Fri Apr 20 21:00:46 2018 +1000 vcl: ImplEmbossGrey() -> BitmapEmbossGreyFilter Change-Id: I6e541e9ca9cf61dfa8df9638a4ba4b8bd1d3ad71 Reviewed-on: https://gerrit.libreoffice.org/53204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Change-Id: If1a96d2165a3c003b9f3cb5a922d08c12156fd29 Reviewed-on: https://gerrit.libreoffice.org/60670 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-18tdf#119929 ensure .ui translation domain is bound before translation attemptCaolán McNamara1-5/+31
Change-Id: Ib06b399f6c975c1c64594b0a294b10bc6a9f0a69 Reviewed-on: https://gerrit.libreoffice.org/60667 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-18tdf#119881: Check if Unity/Gnome is separated by colon in XDG_CURRENT_DESKTOPXisco Fauli1-5/+16
Change-Id: Ie29c2213d8efccd7750396325ce05b4909c09d02 Reviewed-on: https://gerrit.libreoffice.org/60592 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 79093cce6c3a65f84bbafd172b1e9e6702d3ce75) Reviewed-on: https://gerrit.libreoffice.org/60677 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-06tdf#119685 Fix infinite loop in gtk3_kde5 filepickerMichael Weghorn1-2/+2
Since 'string::find()' returns the position of the given character in the string and that was passed as the amount of characters to delete from the string, 'm_responseBuffer' would always be a string starting with a newline character afterwards, when this part of the code was reached. Subsequent calls to 'Gtk3KDE5FilePickerIpc::readResponseLine' therefore always returned an empty string and left 'm_responseBuffer' unchanged, resulting in the lambda function inside 'readResponse' in 'gtk3_kde5_filepicker_ipc.hxx' to loop infinitely. While at it, make a little more explicit that 'it' is of type 'size_t' here. Change-Id: I3b1c209f8307ab71465d9538a82616dff8656415 Reviewed-on: https://gerrit.libreoffice.org/60047 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 1f5698ba8b62e62999b0efb363916a91bdd54c94) Reviewed-on: https://gerrit.libreoffice.org/60067 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-08-29tdf#119477 fix list box focused text colorJan-Marek Glogowski1-6/+4
This ignores the rollover state for text colors if the list box has the focus and just uses the highlight text color. The normal text color is a result from commit 9897fd1c4715 ("Fix list box focused text color"), which makes the highlighted list box text "invisible" (black on dark blue) in the "gen" VCL plugin and on Windows, e.g. when the focus is in the Math symbol list box. Reviewed-on: https://gerrit.libreoffice.org/59488 Reviewed-on: https://gerrit.libreoffice.org/59549 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 7a14326fea2cc317b8be57d45be7ca57aebd8bdd) (cherry picked from commit 9897fd1c4715e7dbbe99fae2b82c2eda1d2b6f7e) Change-Id: I751a811f2e2bbca112b8f9e0de2fffb04c437ba4 Reviewed-on: https://gerrit.libreoffice.org/59564 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#119458 reorganize sw background Idle handlingJan-Marek Glogowski1-0/+5
This is the squashed version of the following commits: - ce68889678bc tdf#119458 always start the SwDocIdle - 107f0e6dba57 tdf#119458 fix sw background Idle state handling - 771544544ee1 tdf#119458 fix sw background Idle unblocking - 3bd8316718fd tdf#119458 just wakeup Scheduler on active Idle While the first commit was really wrong, the third is just an optimization to prevent unnecessary wakeups and Idle task interrups from new calls to StartIdling(). The 4th one contains the reset of the Idle state on run, which was probably the main origin of the problem and allows to wake up the Scheduler without moving the Task to the end of the queue. Starting the SwDocIdle in StartIdeling() just reintroduces the bug fixed in commit 401cba4c20fb ("tdf#116370 cleanup Writer idle job handing"), so trading one bug for the other. For the real solution we have to handle two states: 1. The SwDocIdle being active 2. The SwDocIdle being blocked For the first state we can just use the active state of the Idle itself. Since it's not a AutoIdle, it will be turned of, if invoked. Either some Idle handler will want to be run it again or some other thread might start it again, if needed. Since we're now tracking the wanted Idle state via the active task flag, we can drop the explicit mbStartIdleTimer handling. As a result of the first change, we can't stop the Idle anymore when blocking it. But the Idle itself checks its ready state via IsDocIdle() in its UpdateMinPeriod function, so we have to add the blocking state to IsDocIdle(). But we can't handle the correct state when blocking via a tasks mbActive bool, as this also schedules the task and starts the scheduler timer. So reintroduce a bool for the unblock state. This should prevent fdo#73165, which I couldn't reproduce, but just to be sure. More importantly this patch resets the m_bStartOnUnblock when the Idle job actually runs. This run should already determinates if more Idle work needs to be done, and others can still call BeginIdling() to ensure further processing. Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/59536 (cherry picked from commit ce68889678bca3b51c258452f7bfdd21982e4a0d) Reviewed-on: https://gerrit.libreoffice.org/59586 (cherry picked from commit 107f0e6dba57a5b27366a35a5cdb184079546df0) Reviewed-on: https://gerrit.libreoffice.org/59692 (cherry picked from commit 771544544ee13ec98961f93b5313a7d2e29429cd) Reviewed-on: https://gerrit.libreoffice.org/59730 (cherry picked from commit 3bd8316718fdfed454c01a9c4ae6af6beb34437d) Change-Id: I2d4328f31644017b09786ff4cba45cf7643f0a4b (cherry picked from commit f1fb30cf43eda45137ab96177238a29c3725789d) Reviewed-on: https://gerrit.libreoffice.org/59757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#109353 - Base: Listbox doesn't show a value.Alex McMurchy19171-1/+1
This is because text in box is same colour as the background. This is only an issue for Linux/KDE. This change fixes this issue. Change-Id: Icb908ace25c69fd2fb51f8f44082ca6b00f55c43 Reviewed-on: https://gerrit.libreoffice.org/55660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 3f31455fdd10309ab85fc3d324096698d3f38e5b) Reviewed-on: https://gerrit.libreoffice.org/59563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28tdf#119556 Sync "Use only paper size from printer preferences"Michael Weghorn3-2/+12
Since commit ee6dad51150fd53d19f882edfefa879e18f9897d, the "Use only paper size from printer settings" is shown at two places in the print dialog 1) in the "Options" tab 2) in the "Properties" -> "Paper" tab This makes the setting being correctly updated in the UI in 1) as well if changed in 2). The other way around was already working previously. Change-Id: I41d29a11b4e1695a4b2f676b8d7a9c01e4abde3e Reviewed-on: https://gerrit.libreoffice.org/59581 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 571df3ede6f09c945c4cdfd37f34ef760b6b1af2) Reviewed-on: https://gerrit.libreoffice.org/59729 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-28tdf#112166 need to check if glXCreateContextAttribsARB really existsCaolán McNamara1-1/+3
checking the glXCreateContextAttribsARB function pointer will just return the epoxy_glXCreateContextAttribsARB stub which always exists. Change-Id: I740cc680082102c1f9712cf5cc083e92b26f8865 Reviewed-on: https://gerrit.libreoffice.org/59301 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-25tdf#118786 WIN just assert in YieldJan-Marek Glogowski2-13/+11
This reminds me - again - that Jenkins doesn't run make check. It turns out InSendMessage() also returns true, if you process a nested SendMessage in the same thread. Therefore we have to remove the SalComWndProc assert and just keep the one in the Yield call. Why? Because there seem to be no way to get the information ReplyMessage has access to, so we could detect the caller / origin of the send message and implement proper nested call checks. The alternative would be to change all call sites of SendMessage to: if ( !pSalData->mpInstance->IsMainThread() ) SendMessage(...) else SalComWndProc(...) which is the same SendMessage already does. Change-Id: I991d68a64952dc5d47ba51edd8635c9e8c46614c Reviewed-on: https://gerrit.libreoffice.org/59538 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit bf0a63dc93a746a008fb1656457c77de8df693ba) Reviewed-on: https://gerrit.libreoffice.org/59565
2018-08-25tdf#119454 don't advance PS glyphsJan-Marek Glogowski5-25/+12
The glyphs from SalLayout already have the correct position, so one doesn't have to advance them. This is why PS glyphs were positioned "off-by-one", which is especially visible, if your test document has words with spaces. "dm d" was almost rendered / printed as "d md". This is a regression from commit 2325f9ac789c ("fix bug in GlyphSet::DrawGlyph"), which assumed the dead / unused code was a bug, introduced by commit b157b82a6d92 ("Use GlyphItem in more places"), which out of luck, seem to have been correct. Since nobody uses the advance anywhere, just drop the parameter. Change-Id: I40e8f99a98f84d48446a9190566af8cfe441cd88 Reviewed-on: https://gerrit.libreoffice.org/59510 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit b0a5a564c359adc55f953c7545f52740e90a6e2e) Reviewed-on: https://gerrit.libreoffice.org/59545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-25iRelated rhbz#1618703: Properly handle failure en-/decoding PDF fileStephan Bergmann1-18/+28
...when e.g. FIPS mode makes the various calls to rtl_cipher_initARCFOUR fail. Change-Id: Id1b2222249c151470e233ab814b21228f3a8b561 Reviewed-on: https://gerrit.libreoffice.org/59543 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 185a14525f114e58b48236284ed8e8644bc40e48) Reviewed-on: https://gerrit.libreoffice.org/59573 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24tdf#118994 JAWS has no access to accessibility objectsIlhan Yesil1-3/+6
According to the MSDN, lParam must be cast to DWORD when examining WM_GETOBJECT messages on 64-bit Windows. The MSDN example also casts wParam, so in this solution, lParam and wParam are cast to the appropriate types sal_Int32 and sal_uInt32. Change-Id: I1edc00778c7da91d2baf5784e4c3f8c441e42eab Reviewed-on: https://gerrit.libreoffice.org/58312 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 200fafc341c9ac5cedb0e3e8a38fcc4e88fce77c) Reviewed-on: https://gerrit.libreoffice.org/59341 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-23Resolves: tdf#118659 eps not shownCaolán McNamara1-3/+2
since... commit 7b355669c6ddeab2e6cec692d6afdff41c61d0fb Date: Sat Apr 14 15:13:05 2018 +0900 Function to load graphic swapped out (loaded on demand) new function doesn't load the eps, so supposed to fall back to the old function, but the new function didn't leave the stream at its original position on failing to attempt the load Change-Id: I960574722687cf5ad8c78be7339d2ce6b74397a9 Reviewed-on: https://gerrit.libreoffice.org/59504 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-23tdf#119282 Area tab, Pattern color changeNoel Grandin1-0/+65
regression from commit ccd316d1cb310734848bd20244f509024b549b8c use VirtualDevice in createHistorical8x8FromArray Move the code inside vcl so we don't need to expose BitmapWriteAccess. I tried to detect this thing by counting the number of independent colors in the bitmap, but that didn't work. It is used from more than one place, and appears to be very determined that it needs a 2-color palette to work properly. Change-Id: Id11dd9ea78e5e522a6083d6a799e801cac81fd5b Reviewed-on: https://gerrit.libreoffice.org/59331 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins (cherry picked from commit cd8dd48bf89d800c012afb04b16281ed8b261de9) Reviewed-on: https://gerrit.libreoffice.org/59416 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-23tdf#119357 add the glyph, if the lookup failedJan-Marek Glogowski1-2/+2
Regression from commit de8f6b25de6f ("loplugin:unused-returns in vcl") changing the logic in hunk: - return LookupGlyphID (nGlyph, nOutGlyphID, nOutGlyphSetID) - || AddGlyphID (nGlyph, nOutGlyphID, nOutGlyphSetID); + if (LookupGlyphID(nGlyph, nOutGlyphID, nOutGlyphSetID)) + AddGlyphID(nGlyph, nOutGlyphID, nOutGlyphSetID); Change-Id: Id643120e1cf5e26b3ffda933d07893048493f089 Reviewed-on: https://gerrit.libreoffice.org/59493 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 4a58fd0e81b0375c71f6182233f0ec9390942cd1) Reviewed-on: https://gerrit.libreoffice.org/59502 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-23tdf#118786 WIN allow nested SendMessage callsJan-Marek Glogowski2-16/+34
This bug trips "assert( !pInst->mbNoYieldLock )". There is already a special case, introduced in commit 4baec725e0dc ("WIN run main thread redirects ignoring SolarMutex"), to prevent tripping the assert for a nested SendMessage call. So this implements a general solution for nested SendMessage calls. We just have to prevent yielding in a call from an other thread, as the sending thread still owns the SolarMutex. This way we can also drop the special handling in WinSalFrame::ReleaseFrameGraphicsDC. Change-Id: I7024b081b26f3545af12a3a3a038fe5e5671af3c Reviewed-on: https://gerrit.libreoffice.org/59275 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 35a254750392dcd738481f5d6e8719cee9fb41b3) Reviewed-on: https://gerrit.libreoffice.org/59318 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22tdf#117797 guard access to mpSwapFile as it may not be setTomaž Vajngerl1-1/+2
Change-Id: If45257293e997bc4540b97fbbe5f1f4b77a48b69 Reviewed-on: https://gerrit.libreoffice.org/59202 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3cd264bb09c6c14bf9eb769d508d7015c4bdc83b) Reviewed-on: https://gerrit.libreoffice.org/59235 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21Resolves: tdf#115937 virtual device leakCaolán McNamara1-1/+1
windows runs out much sooner than the other platforms Change-Id: I8ffbe32babf8854580150edfe741b03fd43e4326 Reviewed-on: https://gerrit.libreoffice.org/59407 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16tdf#119276 Fix loading of images with internal LO URLsTomaž Vajngerl1-3/+2
Change-Id: I30556aba4490bef7f4a6e6b3899cc05f4b6a06d4 Reviewed-on: https://gerrit.libreoffice.org/59104 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 43b7aa5133ce3bfb44c5203aea37fa4474bc3a61) Reviewed-on: https://gerrit.libreoffice.org/59144 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-08-14Resolves: tdf#119251 parse non-default units in user inputted valuesCaolán McNamara3-6/+17
Change-Id: I28f8338f5c318f2228b742e2e171d53820cb0cc8 Reviewed-on: https://gerrit.libreoffice.org/58985 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-14Use harfbuzz and graphite, needed after GenericSalLayout refactoringKatarina Behrens1-0/+2
Change-Id: I21c221715c4e6b4e692c8b5ea4d9c9eb5d073980 (cherry picked from commit c5b8b1a3c0247773bd613cba1a183fc8961d38fc) Reviewed-on: https://gerrit.libreoffice.org/57710 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-08-14tdf#119133: Fix initial file and folder selectionKatarina Behrens1-2/+5
what d7fc00e1f7ab7a44e6102a and 1af4ab72e2488515fcaede already does for kde5 Change-Id: I924bdc5cfd6a12ff7bdbeef36d606c03307cb99b Reviewed-on: https://gerrit.libreoffice.org/58832 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 87a4623a8dd5c9efed8335bb56145b9ea9dcce36) Reviewed-on: https://gerrit.libreoffice.org/58905 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-08-08tdf#118453 Reactivate navitagor submenu drag mode and displaySalimHabchi3-0/+18
I add a function to get the data from the submenu Change-Id: If8aedc72abfc7ca967377f0e588167f9f62fe137 Reviewed-on: https://gerrit.libreoffice.org/57269 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 7cc85bfd54645d3786828816972a2f039cb134e9) Reviewed-on: https://gerrit.libreoffice.org/58685 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-07Resolves: rhbz#1610692 rectangles ctor takes topleft, bottomright pointsCaolán McNamara1-4/+4
so pass arguments in the topleft, bottomright order to avoid eventual... Gtk-CRITICAL **: 09:43:33.896: gtk_widget_queue_draw_area: assertion 'height >= 0' failed Change-Id: I2396f49470274331c49275a5e6d707f59277be4a Reviewed-on: https://gerrit.libreoffice.org/58392 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-07forcepoint#71 sanity check when copying pieces of imported pdfCaolán McNamara3-3/+25
Change-Id: I7e340e15c95cdfa8b185f61fad7e14bd00babf21 Reviewed-on: https://gerrit.libreoffice.org/58579 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-15 06:32:59 +0000