summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2014-02-26fdo#64957: #i124233# prevent the accumulation of rounding errorsHerbert Dürr1-4/+12
in CTLayout::FillDXArry() Change-Id: Ifb4f16fb76f67d5b5c96fdb0545c64eb8316aa3c Reviewed-on: https://gerrit.libreoffice.org/8359 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/8366 Reviewed-by: David Tardon <dtardon@redhat.com>
2014-02-25fdo#41524: CUPS printing: use "collate" option when PDF is availableMichael Stahl3-10/+23
Assume that the CUPS printer is able to handle collating by itself, don't send multiple print jobs (except if user clicks on "Create single print jobs for collated output" of course...). To enable collating with PDF based printers, add the "collate" option; legacy PS based printers still get the weird stuff read from the PPD (not sure what the risks of changing that are). Change-Id: Ia12dc69f9083bba94f2ed633ecbd153aac7e40ab (cherry picked from commit c76cd71fe9bdefaef3f33f8ca193c32e3ab112ed) Reviewed-on: https://gerrit.libreoffice.org/8116 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 138f41fd408b120d52e3d6c185940ace065512af) Reviewed-on: https://gerrit.libreoffice.org/8158 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-02-21fdo#74584: These tags should be lowercase for correct clipboard handling.Kohei Yoshida1-4/+4
Change-Id: I323b96cecbf7158919fad534a202f158965ca99f (cherry picked from commit 88c6cbda921f1e3627910f9028ff2e29f26160e7) Reviewed-on: https://gerrit.libreoffice.org/8154 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3ba02e9ec03df980803f35c4b16ce8b8ce90cb66) Reviewed-on: https://gerrit.libreoffice.org/8157 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-21Resolves: fdo#74284 use AccessibleRole::PANEL for VclBoxes under windowsCaolán McNamara1-0/+6
(cherry picked from commit 685ec1899435037205d98a102a32ca8b6a4836d0) Change-Id: Ic8c743c2646c8610b3d90425024413b40dfdab13 Reviewed-on: https://gerrit.libreoffice.org/8105 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 47ff82608b065c3c0d98557583bb822b20fb4081)
2014-02-06fdo#72187 Implement KDE4 picker notificationsJan-Marek Glogowski2-0/+26
This notifies the XFilePickerListener of filter changes and file selection changes. Change-Id: I749c5f7420f020a3a2fbb764acb5c45d40972cf1 (cherry picked from commit a8d102c2406b8c027afb32d61271e0a2c301f133) Reviewed-on: https://gerrit.libreoffice.org/7907 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04fdo#74104 fdo#73904 backport Message dialog creation from message stringsCaolán McNamara1-1/+18
Original title: "allow simple MessageDialogs to be created from just message strings" Commit 9b6b03542df7f6b0feecf60a13bab7e885ef3587 upgraded sd/source/ui/view/Outliner.cxx to use a MessageDialog created from just a message string, but was done before the existence of this commit -- it's presumably safest to backport this commit to ensure that any other such changed dialogs will work as expected. (cherry picked from commit 257d1f4ff3094a42952663d620d7c49e3e7c747f) Conflicts: basctl/source/basicide/moduldl2.cxx Change-Id: I9f8324d1c61bd55ccc78e67699ebdfa946e48af6 Reviewed-on: https://gerrit.libreoffice.org/7859 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04vcl: try to fix sizes in ImplBlendToBitmap (related: fdo#74226)Michael Stahl1-1/+2
Since commit 2f84b420e0428693fb2d45b68afdc9023dfc08bc, sw_unoapi test sw.SwAccessibleEndnoteView crashes while trying to blend a 1107x8 Bitmap into a 97x8 Bitmap; it's not obvious that any of the parameters passed in is wrong and it's odd that ImplBlendToBitmap() would use rSrcBuffer.mnHeight and rDstBuffer.mnWidth; presumably it should use both height and width of the same buffer. This backport has an additional std::min added for safety; on master we can try without to see if it's really needed. (cherry picked from commit 2ca79052d0fab159b017cacd3d7145d8012de850) Change-Id: I40b98ba56e703323df91f6fd7773addcfd69a402 Reviewed-on: https://gerrit.libreoffice.org/7841 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04fdo#44270: vcl: GTK+ file picker: fix non-grouped filter patternsMichael Stahl1-1/+2
lcl_CreateAutoMarkFileDlg calls appendFilter() with "... (*.sdi)" and the GTK+ file picker then strips off the (*.sdi) in the string given to GTK+ and then doesn't compare result properly with its stored filters; only filters added with appendFilterGroup() work but not appendFilter() ones. Change-Id: I0ac9272b5606ff8b81f0c14160fc6972789bb1ea (cherry picked from commit ff5ad7e379315faa3f4afa009d23f34c7d231d9a) Reviewed-on: https://gerrit.libreoffice.org/7835 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-29fdo#73487, fdo#73886: Overhaul cell borders to make them look sane.Kohei Yoshida1-12/+39
Change-Id: Ie563f272b60ec8b6b8a4ff0df7256902997610c1 Reviewed-on: https://gerrit.libreoffice.org/7597 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-01-28Resolves: fdo#74051 support 8430x11700 jpegsCaolán McNamara1-3/+3
Change-Id: I1ca95a496bca80e5e2787af2ccbf0f6cd42455a5 (cherry picked from commit 53c803004554a3a0fff26501357a183bba008a26) Reviewed-on: https://gerrit.libreoffice.org/7696 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-27fdo#74124: Scale the pictures before calling ImplDrawAlpha().Jan Holesovsky1-1/+22
When the source and destination bitmap do not have the same size, ImplDrawAlpha() does not use direct paint, but instead it gets the image from the screen, blends it with the provided bitmap, and again draws it. Unfortunately, the blending uses the most trivial (and ugly) way of scaling; so to produce much better results, let's scale to the destination size before even calling ImplDrawAlpha(). The sideeffect is that we use the direct paint in most cases now; so hopefully it pays off to do the (a bit more expensive) scale first. Change-Id: I3b6b275710220910709ae4345ad6be3d6e4bf79c Reviewed-on: https://gerrit.libreoffice.org/7701 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann1-9/+9
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. (cherry picked from commit a3f32769fc4bb23c64168b412dd10ec769a3854d) Conflicts: sc/source/ui/unoobj/nameuno.cxx sc/source/ui/unoobj/styleuno.cxx sfx2/source/appl/sfxhelp.cxx stoc/source/security/permissions.cxx sw/source/core/unocore/unocrsrhelper.cxx (None of those bogus startsWith calls seem problematic enough to warrant backporting also to libreoffice-4-2-0.) Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21 Reviewed-on: https://gerrit.libreoffice.org/7578 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21fdo#73764 partially revert 3998d1abb291Andras Timar1-1/+1
Change-Id: Ie9b6d6a318fad256f3f0999fe9c0810a4323f10d Reviewed-on: https://gerrit.libreoffice.org/7537 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-16fdo#72397: vcl: do not enable A11y in Win32 message handlerMichael Stahl1-6/+1
On the libreoffice-4-2 branch, IA2 is experimental so it must be enabled by user explicitly; the automatic enabling when a WM_GETOBJECT is received will effectively enable the JAB which can be annoying. Change-Id: I16bd8d77657567ad29f3538cd3ab1de8145d531e Reviewed-on: https://gerrit.libreoffice.org/7443 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-16fdo#72521 fdo#73103 Fix editable combo-boxes behavior under KDE4Maxim Monastirsky1-1/+5
Change-Id: I92a781a1e0f0adcb779155f8c477595e0dd762b1 Reviewed-on: https://gerrit.libreoffice.org/7287 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-on: https://gerrit.libreoffice.org/7462 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-13Keep in sync with desktop_strings[] in salplug.cxxMaxim Monastirsky1-2/+2
Items should have the same order. Only that way KDE4 will get the correct icon theme. (A regression of commit cea7cca5c8db3f273ed2c14efde45ff0e73dee7a) Change-Id: Id8ba6fadd312d5ff782de7011694fc58cdfae312 Reviewed-on: https://gerrit.libreoffice.org/7288 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1b00be2ed1f911aec07ab2ef9432168cfa333c6d)
2014-01-09stop condition reversed, sighCaolán McNamara1-6/+6
Change-Id: If96d982bf4377eab29a2dfb94b0a453e12450786 (cherry picked from commit 03e0781145bceebca84e5d891ed0df72c75389da)
2014-01-06EMF/WMF: parse line cap and line joinAndras Timar1-1/+27
Change-Id: I081ae9c24e48912631dcfe4aba8a06ff2680aaf5
2014-01-04fdo#73280 - always advance the iterator to avoid an infinite loop.Michael Meeks1-0/+2
Change-Id: I62f2d8ec5d6d62f1dbe9657cfbbbc90c56cce812
2014-01-02fdo#39007: blind fix for renamed OS X restore-state fileMichael Meeks1-0/+1
Remove also a potential restorecount.txt file (as reported in the bug) in addition to a potential restorecount.plist. Change-Id: I96fb688e9dda804f240cad8f2109c5880b544302 Reviewed-on: https://gerrit.libreoffice.org/7239 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Signed-off-by: Tor Lillqvist <tml@collabora.com>
2013-12-29Resolves: fdo#72961 Crash when you open ODFver.1.0/1.1 created by LibO-3.5/3.6Julien Nabet1-6/+8
It seems pAction may be NULL so let's keep on to check it. Change-Id: Ie1a48c96bfa930364053c7c3ad0c940559544e33 Reviewed-on: https://gerrit.libreoffice.org/7228 Reviewed-by: Andrzej Hunt <andrzej.hunt@collabora.com> Tested-by: Andrzej Hunt <andrzej.hunt@collabora.com>
2013-12-16initial install-package-foo target for partial installsBjoern Michaelsen1-1/+1
make packageinfo target add uiconfig file translations add missing l10n config files add missing help files in packageinfo Reviewed-on: https://gerrit.libreoffice.org/6754 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Conflicts: helpcontent2 translations a2498a118e729276a78ef3a4eb43b5d0b302d326 9bb39bdd677af4be0da621370c51eb9e22ecc33f a7e654cdeffd832f51016ff51aa180fe3924ff4e 4ee41fdb600cb3a89da387dffe64e6a30192761c 349fb24a388775c58be7a326832b3fc0ec38180f 8a2ca73c02fd6b04ce60e7701c51d2362ef7ec06 Change-Id: Id5f6f5c1f3e46df2d9033ccd5bbf2af6ab38a9e8 Reviewed-on: https://gerrit.libreoffice.org/6982 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-12-13Targetted text updates, with seasonable changes before l10n freeze.Michael Meeks2-2/+2
Change-Id: If37ef9f68711da3a0aa9a3ba59b111a8a23421df
2013-12-12fdo#67011: Run Display::Yield through KDEXLib::Yield.Jan-Marek Glogowski1-6/+16
Drag'n'Drop is handled in a second thread, which tries to "yield the display" while the main Qt thread probably is already yielding. Both need the YieldMutex, which freezes the application until the D'n'D thread times out. Trying to yield the display throught the application yield results in a recursive loop. So this catches and breaks the recursion, but just inside the Qt thread, so other processes can "yield on the display", instead of simply disabling the Display::Yield. Change-Id: Ifba91aa89fe5b0a89cc94820935dc996a065112f Reviewed-on: https://gerrit.libreoffice.org/6750 Tested-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2013-12-09fix equalsAscii conversion. Noticed in fdo#72391Noel Grandin1-5/+5
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 "convert equalsAsciiL calls to startWith calls where possible" I incorrectly converted equalsAsciiL calls to startsWith calls. This commit fixes those places to use the == OUString operator. Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6 Reviewed-on: https://gerrit.libreoffice.org/7008 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-09Zip .ui translations per UIConfig target.Matúš Kukan1-6/+29
Fix installer / scp2 to not ignore directory prefix in 'Name'. Change-Id: Ib319363c8be73a72029f1ba3833e518e15c55e29 Reviewed-on: https://gerrit.libreoffice.org/6915 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-12-06fdo#60705 Don't discard valid printing options.Andrzej Hunt1-1/+1
PPDValue::m_aValue is simply an optional parameter description, whereas m_aOption is the actual option being passed to cups. For example, for the key "PageSize" (which was previously passed without problem), a typical PPDValue could be: m_aOption = "A4" m_aValue = "<</PageSize[595.3 841.9]/ImagingBBox null>>setpagedevice" However for the key "InputSlot" (which was previously not passed to the printer), a typical PPDValue could be: m_aOption = "RearPaperFeedSlot" m_aValue = "" Change-Id: I7959317c9f9d67bfafd911e710927a70edfa8792 (cherry picked from commit 4c160e3d54ec1c6c04bc80c6cec7ee58e20af3bb)
2013-12-05EMF+: force canvas if EMF+ comments are used.Andrzej J.R. Hunt1-0/+7
Without this the drawinglayer renderer is used, whereas only the canvas renderer supports EMF+. Change-Id: Id8a10e400e08c1913e7d6864a51f7b73fc9be437 (cherry picked from commit be7d87bea2611eb316b9b379aebc031179d4f794)
2013-12-03vcl: check if AT is running before loading the libraryMichael Stahl2-10/+33
... which should result in faster startup if it's disabled. Change-Id: I39774b0a56f186d08270c2f17b2b20a823f21dc2 (cherry picked from commit b44ed4c408d92f7a1a3f2390c056d518c137ddd0)
2013-12-03vcl: fix crashes when retrieving objects for MSAAMichael Stahl1-4/+6
The ImplHandleGetObject() function modifies the Application Settings and must take the SolarMutex for this; otherwise we get crashes when another thread calls StyleSettings::GetPersonaHeader() during some unoapi test. Also fix another HWND to long cast; use LRESULT which is Win32 for intptr_t. Change-Id: I5580f88ed0a8e9955697655ace94584e2307982d (cherry picked from commit db214684057e3ff2fa32d57c00507309dd6c24d6)
2013-12-02Resolves: #i123765# reset buffered DropTarget when undockingArmin Le Grand1-0/+5
(cherry picked from commit 8d679227fafe9108c4dc6e8adff85a727e4ef3af) Change-Id: Ia6fba705d91157afea30693fa7078aabc96f02ac (cherry picked from commit 032a4f6b2d771dd4e1b4a1ceee7c3ef15ca356eb)
2013-12-02Resolves: #i74854# fix buttons in MsgBox with info iconHerbert Dürr1-0/+8
Patch by: hanya.runo@gmail.com Found by: ooo@catcons.co.uk Tested by: hdu@apache.org (cherry picked from commit 02cc651a1b45cbfbdab0aca6b57bff7bdf9e4f2c) Conflicts: basic/source/runtime/methods.cxx vcl/inc/vcl/msgbox.hxx Change-Id: I1656263e189f1a6cfa58436741bfa74ae0e6fffa (cherry picked from commit 3a437baee23d45ab64d557fed75e2e1b14aa5541)
2013-12-01upload libeot-0.01David Tardon2-5/+5
Change-Id: I877cab5e13ebb52911b2e238a0f4ebb87cda73e9 (cherry picked from commit 0f4be588622379388650d8fc451829d17d16a7bf)
2013-11-29typo: seperator -> separatorAndras Timar1-1/+1
Change-Id: Ifad806a4a846656f4b81439c596aa34d898d021a
2013-11-26EMF: More useful debugging output.Jan Holesovsky3-99/+51
Change-Id: I2aa0e97878db62275d794be43a7d351e5ae25f1c
2013-11-26Resolves: fdo#41169 fix MacOSX non-Latin keyboard layout with Latin shortcutsCaolán McNamara1-0/+37
Change-Id: I168de52d6185d5df9c41fd2d7a68c0ff3f733852 (cherry picked from commit 82b5172954261e030a42bd6b3f4acc99807d0ee5) Reviewed-on: https://gerrit.libreoffice.org/6797 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2013-11-25fdo#61272: Do the mapping correctly both for WMF and EMF.Jan Holesovsky1-1/+1
Turns out that for the WMF, we already had everything set up correctly, we were just overwriting the right settings with default data again :-) - fix that. Change-Id: I14b0c12b10f58eb7031f9da712dee76344c75159
2013-11-25Related fdo#61272: Revert "wmf-mm-text.diff: Fix WMF rendering, n#417818"Jan Holesovsky3-25/+0
This approach to WMF breaks EMF reading, need to revert it, and fix a different way. This reverts commit db1b08d217ebbdd1b0296e1da260bf314a77acf5. Conflicts: vcl/source/filter/wmf/winmtf.cxx vcl/source/filter/wmf/winmtf.hxx Change-Id: I8f779791153f2e1faa086c91b82b3e8b93304f3b
2013-11-25Related fdo#61272: Revert "wmf-mm-text-1.diff: Fix WMF rendering, n#417818"Jan Holesovsky1-14/+4
This approach to WMF breaks EMF reading, need to revert it, and fix a different way. This reverts commit 16eaa5e7c1208034bb3244fea9e6d9491ccb5501. Conflicts: vcl/source/filter/wmf/winmtf.cxx Change-Id: I59076d0a65d91ba3a1f3ebb48d8f7a542859d351
2013-11-23Correctly check getFileURLFromSystemPath() successKhaled Hosny1-1/+1
Change-Id: Iadc34171235fec2d6aafd601f62a0bff8ed5b3ee
2013-11-23Make TTC fonts work againKhaled Hosny1-1/+1
osl::File::getFileURLFromSystemPath() does not return a boolean. I wonder how this worked before, if it worked at all. Change-Id: Iadc0e06236f43c24cbcd42e4fd79ac9116a58c13
2013-11-23Simplify this code a bitKhaled Hosny1-9/+3
Change-Id: I591484788c5bcb9b9cde9696b149ede7298015a5
2013-11-22fdo#67802: Fix PS printing of non-CTL text with ligaturesKhaled Hosny1-7/+5
The GlyphSet::AddGlyphID() was messing with glyphs of characters that can be converted to Windows-1252 encoding, discarding whatever glyph it was asked to use and using a random glyph that is supposed to belong to the converted character. For ligatures this means the ligature glyphs was discarded and the glyphs for its component was used, but this broken for just any glyph substitution. The code makes no sense at all, apart from the fact that it is verbatim copy of GlyphSet::AddCharID() since 9754ad8d979557ea03cbfe04708b62b698d1276c and just happened to work because we did not enable ligatures and other typographic features for non-CTL text before. Change-Id: I764f0b40f8acf61eae38a9038b0666d711c04a9d
2013-11-22Related: fdo#41169 fix GTK non-Latin keyboard layout with Latin shortcutsCaolán McNamara1-22/+45
See also rhbz#958300 Change-Id: I5c3cf9652adb7b1c9ec53a32ed39f231a09ae1d7 (cherry picked from commit 8cef6c7ec67aec88b339ca647e784afbabf190f8)
2013-11-21Simplify css.accessibility.MSAAService and corresponding XMSAAServiceStephan Bergmann1-5/+12
Change-Id: I96c69e871aa7b20cdac9751a64faa5e436f31a1f (cherry picked from commit f3f4d9ec0f0eaa1aebdfebe831021a9d96e63f58)
2013-11-20Elide utl::ConfigItem_ImplStephan Bergmann2-32/+19
...and utl::ConfigItem::IsValidConfigMgr is always true. Change-Id: I37e295729c3d0ae12719f0ae6f5a5628c58d0b9f
2013-11-20Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"Noel Grandin2-10/+10
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295. I mistakenly converted OUString::equalsL calls to OUString::startsWith calls.
2013-11-20Revert "Simplify KDE4 yielding."Michael Meeks1-8/+12
This reverts commit 20f029c653abbd7578ceee968065f4c5d66f375f. The native X11 and gtk+ backends both have this functionality, and both with a hard-coded 100, and the gtk+ one has had active maintenance and testing. I'd like to leave that there, I suspect it is used in some obscure multi-threaded corner-case where we want to process events but only a few of them.
2013-11-20Simplify KDE4 yielding.Jan-Marek Glogowski1-12/+8
QAbstractEventDispatcher::processEvents always processes all pending events, so we can ignore the the second Yield parameter (bHandleAllCurrentEvents). Change-Id: I49a70ed13d0215b89f48eed93d78eef2f083dc0d Reviewed-on: https://gerrit.libreoffice.org/6686 Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20Rewrite Qt4 based nested yield mutex locking.Jan-Marek Glogowski2-26/+24
The Qt event loop may start a nested event loop, when checking for clipboard and Drag'n'Drop events. Previously this was handled by running this nested yield loop inside the main glib loop using qApp->clipboard()->property( "useEventLoopWhenWaiting" ); But this results in nested paint events which crash LO: QWidget::repaint: Recursive repaint detected To prevend yield mutex deadlocks, check for nested event loops and always release the yield lock before starting the nested Yield event loop. This fixes fdo#69002. Change-Id: I7e827abd3489783053ec7123372742a32555875d Reviewed-on: https://gerrit.libreoffice.org/6685 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-09 02:25:57 +0000