summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2015-10-17tdf#95096 avoid invalid cursor position exceptionJustin Luth1-2/+5
Somehow, accessible text can lose focus and so when attempting to set the cursor, the string we were just working with may no longer be available, so verify that the cursor position is still valid before setting it. If the text can just disappear like that, then potentially we are still forcing the cursor into the wrong place (since the string is different than expected). However we can at least make sure the program doesn't crash/exit without saving... Change-Id: I8dcaf4625d187cb75008bdc0af0e3a546090a018 Reviewed-on: https://gerrit.libreoffice.org/19414 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2015-10-16afl-eventtesting: add a realistic impress workoutCaolán McNamara4-4/+16
Change-Id: Ie40071dd91e28131ddb62c03834fda097a1d90ea
2015-10-16afl-eventtesting: tweak key event injectionCaolán McNamara2-17/+35
lowest idles have a minimum time out associated with them. So just post events and use higher idle time priority as launcher for min-wait-for-opportune time to start inserting Change-Id: I8088e142199e880b198da11473558b4bd972a8d9
2015-10-16convert Link<> to typedNoel Grandin1-2/+2
Change-Id: I48893ac7130ad671864faa5eb55409b21cdda77e
2015-10-16convert Link<> to typedNoel Grandin7-37/+31
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15vcl: aAlphaBitmap.ImplGetImpBitmap() seen as 0Miklos Vajna1-4/+7
Change-Id: I3f34f0315045d33ff6e498e24c0dacb0aabb0ff9
2015-10-15tdf#94495 - protect lstbox usage post-dispose, and fix ItemWin focus.Michael Meeks1-1/+19
Change-Id: I2e4d1c79f57ec048d66111ed393491b7803ee3b9
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin3-9/+5
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15loplugin:vclwidgetsStephan Bergmann1-1/+1
Change-Id: I2e73a85a3d8cab0a73c8c776d7406d99411d95d0
2015-10-15vcl: Initial NotebookBar implementation.Jan Holesovsky8-14/+510
See https://wiki.documentfoundation.org/Development/NotebookBar Change-Id: I91535c13d68261f7195989ec78bd305cf572c87c
2015-10-15convert Link<> to typedNoel Grandin2-8/+13
Change-Id: I2ef1e5fe5c6dc65c254b3a16b0b12fca5caba16e
2015-10-15convert Link<> to typedNoel Grandin1-8/+8
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-15cppcheck:variableScopeNoel Grandin18-95/+66
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884 Reviewed-on: https://gerrit.libreoffice.org/19364 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-14WaE: loplugin:staticmethodsTor Lillqvist1-0/+2
Change-Id: I2dd4ace6d884ba59820814e23a8e55d9b0e60ef6
2015-10-14fix build against glib < 2.36 (w/o gmenu) againBjoern Michaelsen1-1/+2
Change-Id: I01a76e0cf19e11609a2f414bf754f3034b298b2d
2015-10-14fix build against glib < 2.36 (w/o gmenu)Bjoern Michaelsen1-8/+2
Change-Id: Ia60195d48717dc87c8a8a5753477604cbdd0c79e
2015-10-14bring Unity menues to gtk3 tooBjoern Michaelsen4-1/+32
Change-Id: I4eb9f4bf423febce89635654c0cf1199b79d6fb8
2015-10-14Bump gtk+ version to 2.18Riccardo Magliocchetti6-48/+16
2.18 is the version available in RHEL 6 released in 2010. Change-Id: I4cd4fc89f6b51e6f58ca72b8182f80316b1f4f88 Reviewed-on: https://gerrit.libreoffice.org/19330 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-14vcl: Free memory by appropriate deleteTakeshi Abe2-2/+2
Change-Id: Id39940563952a6791c63cc5c4621a28401ad5ebe Reviewed-on: https://gerrit.libreoffice.org/19343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-14convert Link<> to typedNoel Grandin1-4/+4
Change-Id: I1876f327607e0e23292950741df348d4ec31fde1
2015-10-14Revert "Unused code removal DrawGradientWallpaper"Samuel Mehrbrodt1-10/+47
Seems to be used, since IsGradient() actually can be true. This reverts commit fe4412c8850bd1212dce786510dd61ddd6c43b36.
2015-10-14Allow non ASCII chars as accelerator part 2Niklas Johansson1-0/+6
This is a follow up patch to the commit: b80be50268f534e215d36d69b93d3f51d9410ace This takes care of exposing non ascii characters to atk so that the orca screen reader has a chance to present these characters to it's users. I was considering removing the KeyCode bits all toghether and rely on what we get from KeyChar but got cold feet in the end. Change-Id: I7a3e78c47b81f8b36763c56e0298e8bbf226dccf Reviewed-on: https://gerrit.libreoffice.org/19105 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-14Unused code removal DrawGradientWallpaperBryan Quigley1-47/+10
Doesn't appear needed on Linux and tests have shown it isn't needed on Windows or Mac either. Change-Id: Iaaba6dcc4783557a4165d635b57a256402b0b4d2 Reviewed-on: https://gerrit.libreoffice.org/19259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-13remove some useless commentsNoel Grandin1-1/+1
found with git grep '// /' Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann185-2181/+2181
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann21-48/+48
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12convert Link<> to typedNoel Grandin7-33/+26
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12loplugin:loopvartoosmallStephan Bergmann1-2/+2
Change-Id: Ic3667c0daeeeb5b09eeaae66899affda65e2e9a5
2015-10-12opengl: convert to RGB buffer, use unique_ptrTomaž Vajngerl1-6/+5
User RGB buffer rather then RGBA when converting an unsupported bitmap buffer for reading into a texture. Also use unique_ptr rather then manually deleting ImplPixelFormat instance. Change-Id: I4c94c22b7e185c176e45a1b9c4db6443fe6c4234
2015-10-12opengl: Extract calculation - bytes per row into its own functionTomaž Vajngerl1-14/+18
Change-Id: I24864df3e698704d84f62be25daa3dd54b4dd356
2015-10-12opengl: improve VCL_GL_INFO reporting in OpenGLSalBitmapTomaž Vajngerl1-6/+14
Change-Id: I00d695e11f4df140482bba7d8909216515e330be
2015-10-12opengl: remove code duplication when rendering a texture comboTomaž Vajngerl2-19/+20
Change-Id: Ic184e0e96103bb63322c8aaf8758c4c8f423e0b9
2015-10-12tdf#94384 fix black icons with OpenGL enabled on WindowsTomaž Vajngerl1-20/+3
Looks like the Windows specific code in ImplUpdateDisplayBmp is not needed anymore and causes problems with OpenGL. The icons after the change still seem to be drawn correctly with OpenGL enabled or disabled. Change-Id: I3ae1a0ceb947254aaadbc3d772f0d662b291b594
2015-10-12vcl: recolor images (icons) to be more visible in a dark themeTomaž Vajngerl3-0/+66
This adds recoloring of images/icons (suited for breeze and sifr) so they are more visible when a dark theme is used (for example gtk3 can switch to a dark theme). LO must be started with environment variable VCL_ICONS_FOR_DARK_THEME set to 1. open issues - currently all images/icons are recolored but not all images should get recolored. Change-Id: Ibc42e30af79bb4c4f04c67b760019311b97b2cc6
2015-10-12remove unused BitmapExTomaž Vajngerl1-2/+0
Change-Id: I787be4f2da514017fd14100f56ed323d30dbe99d
2015-10-12convert Link<> to typedNoel Grandin1-1/+1
Change-Id: Ib9a493af0f64c5f3eb50f392805c3278ed2164a0 Reviewed-on: https://gerrit.libreoffice.org/19304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-11Moggi thinks this mutex is unnecessary and I trust himTor Lillqvist1-3/+0
"Is the mutex really necessary? Normally outside of the chart OpenGL only the thread that has taken the SolarMutex should access the OpenGL code. In general we have bigger problems if several threads start rendering in parallel." Change-Id: I5f8fa8c771d5e2e0df4cfe903b15d00e5cc162b1
2015-10-11valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara1-4/+5
Change-Id: Ia9b95232f14b2a6f5c06c0720a91f44217f5c80c
2015-10-10Fix FTBFS with TDE integration due to recent SalFrame changesSlávek Banko1-2/+2
Change-Id: I00297726c1fc5ee8fd88f12f96befe2b2a4cf954 Reviewed-on: https://gerrit.libreoffice.org/19295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-10-10afl-eventtesting: there is no focused/active window in headless modeCaolán McNamara1-3/+10
so close all open frames, not just the active one and send events to the first discovered visible window and not the focus window Change-Id: I7339bc6743cd3106ceddea049136796121819eb3
2015-10-10valgrind: zero padding bytesCaolán McNamara1-2/+4
uninitialized memory warnings on --convert-to pdf of ooo115771-3.doc Change-Id: I2dac6fe29d23d6e25c2f1d1511886d8b585e498c
2015-10-09malloc + memset(0,..) -> callocCaolán McNamara1-2/+1
Change-Id: Ic7c496259258bf36cd885ed68912b43117f348f0
2015-10-09Move SolarMutex down from tools to comphelper/ to make life easier.Michael Meeks3-11/+8
Change-Id: I7dd21f30daa27e5de2848eb16aee9a610dd629d5 Reviewed-on: https://gerrit.libreoffice.org/19271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann1-4/+0
Change-Id: I54691786167fd17b115460f3329573f0c2f023ed
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann1-1/+0
Change-Id: I97db1e22a42e25186be0d7304b9f2a5204fc1c83
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann1-4/+0
Change-Id: I9329233a85df26dcfd83002e50604a6ea4fb50f9
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann1-1/+1
Change-Id: Ic3464a466302b87fae70a63f2723d1355eccab6f
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann1-14/+8
Change-Id: I11b99fca91b266bdf6c29dc142511bf01dbd4bed
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann1-2/+0
Change-Id: Ib9eae95b8ace37d31e905bc098c67de97b7816e3
2015-10-09Abstract out repeated code into lambdasStephan Bergmann1-43/+29
...to silence a clang-analyzer-deadcode.DeadStores on the last update of nLeft and nRight, each. Also, adding a gap of 3 to nRight in case no further buttons will be layed out next to maDockRect resp. maHideRect is irrelevant, as nRight will not be used for any further layout computations in those cases. Change-Id: I251d4470099b1f98782ebdfd0c776d881bb7fae5