summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2016-11-11tdf#103803 change from BGRA to RGBA color arrangement on WindowsTomaž Vajngerl2-42/+63
BGRA is native color arrangement on Windows however some intel drivers have problems with large textures if they read from a BGRA buffer. So with this commit we switch to RGBA color arrangement. This shouldn't cause much performance differences, but we need to convert from RGBA to BGRA when printing. + fix: wrong GL format for RGBA image buffers commit: ed42212f53b2e52238346e64dae31a931d6c90a1 Reviewed-on: https://gerrit.libreoffice.org/30544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 6b571ae4608ac15256eb7582f442ce69975370f3) Change-Id: Ic112dc6a6c5d8b70e96041d0de15a03bbbdc406f Reviewed-on: https://gerrit.libreoffice.org/30763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-11tdf#103804 reduced register areaScale shader and detection for intelTomaž Vajngerl4-22/+122
Some intel drivers crash when areaScale shader with "large" array is used. This adds a "reduced register" version of the areaScale shader. We still use the first version of the shader for other drivers and switch between the 2 implementations with a runtime detection. Change-Id: I1860f898c03b40a600eb1b41f7262719382a7171 Reviewed-on: https://gerrit.libreoffice.org/30571 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit d115a235bf3ff5366d992d01fb418a3eacb9d125) Reviewed-on: https://gerrit.libreoffice.org/30764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-03tdf#93825: Missing accessibility events when selecting/deselecting cellsTamás Zolnai1-0/+3
Change-Id: I407f585354e78fb47a76561455ac67bb567c2771 (cherry picked from commit 2a818a0aafac218ca09bb079d7f2cf0879385e4a) Reviewed-on: https://gerrit.libreoffice.org/30541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-31tdf#103514: Always ignore bitmap fonts on WindowsKhaled Hosny1-61/+49
We should never see any bitmap fonts now, so all the Courier stuff can go away. Since we never list the bitmap fonts in the first place, the old code for replacing some of them with scalable equivalents never kicks in. We instead implement PreMatchFontSubstitution hook for the same effect. Reviewed-on: https://gerrit.libreoffice.org/30345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 8f0f5e0c709d01555a4069f8665889924ed181c7) Change-Id: I54f3c068bcd64554ed3498f4ba5b0f76bbd38589 Reviewed-on: https://gerrit.libreoffice.org/30356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-27tdf#99723: target ratio must be reachedJulien Nabet1-1/+5
to be sure we can avoid decompressing/recompressing Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=76ec54e8c9f3580450bca85236a4f5af0c328588 Change-Id: Iacd7b2419ea85756f936b17f04c4e495d15e5b81 Reviewed-on: https://gerrit.libreoffice.org/30163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> (cherry picked from commit 88fb9d8f0aae0030fac75156f78818affae4298f) Reviewed-on: https://gerrit.libreoffice.org/30265 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-25Related: tdf#98831 backport gtk3 clipboard fixesCaolán McNamara1-87/+104
Resolves: rhbz#1326304 cannot detect loss of wayland clipboard ownership gtk_clipboard_get_owner always returns what you set with gtk_clipboard_set_with_owner and that doesn't change if some other application takes over the clipboard The "owner-change" signal doesn't contain any useful data under wayland, and doesn't fire when you'd expect either, just when the app becomes active or gets focus or something like that. So you get it when you do have the clipboard and when you don't, so that's no use either to detect loss of clipboard ownership So, forget about clipboard ownership, and always take the data to be pasted from the system clipboard, so when we are pasting from ourselves its "paste"->m_aSystemContents->gtk->"copy"->m_aOurContents Resolves: rhbz#1350478 identify that we own the selection with a unique target so we can tell that we own the selection in the absence of reliable selection ownership notifications under wayland Note that gnome#768177 means that requests for CLIPBOARD targets after requests for PRIMARY targets can time out, which is why my attempts at doing this before giving up with commit 88cd9dd591d7921e5bce33c170b457ae5aa871bb Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jun 24 15:06:36 2016 +0100 Resolves: rhbz#1326304 cannot detect loss of wayland clipboard ownership didn't work. (cherry picked from commit 88f7aae022bedd61588424a11bbc033217ba4e43) Resolves: rhbz#1352965 gtk3 infinite clipboard recursion with clipit installed Related: rhbz#1351369 gtk3 clipboards have to live to end once created like the other platforms do Change-Id: I32f2e1a2cc3310687f61a094fdfa940fa0cfcc39 1154899e478b6e0cc6f70aa0c90c26663299072c b67afaf532b8409e05fffbf1b8312d664460567d 31340254573d13dc808d1e3038e3a36ae97f6c22 d9c12b7ce6458348890d7c7ff7fdb2cd37c4601c Related: rhbz#1362451 avoid recursive ownerchanged handling during ownerchange Reviewed-on: https://gerrit.libreoffice.org/30019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-25Resolves: tdf#101457 gtk3 clipboards have to live to end once createdCaolán McNamara2-1/+11
was Related: rhbz#1351369 gtk3 clipboards have to live to end once created like the other platforms do (cherry picked from commit 962e0bb4b31265b046fe4fb57d3087e20f5fe4ef) Change-Id: I31340254573d13dc808d1e3038e3a36ae97f6c22 Reviewed-on: https://gerrit.libreoffice.org/30010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-18Resolves: tdf#97065 gtk3: Date field displayed incompleteCaolán McNamara1-1/+3
a spinfield with a dropdown is sort of weird, we should probably revisit this and see if SPIN and DROPDOWN are mutually exclusive and for DROPDOWN use ComboBox styles (cherry picked from commit 276732f3068cac65dd607b4f78abdcd918ed30ad) Change-Id: Id7f5c54974dc2dfd63ab30df18e14f6a67a8ea90 Reviewed-on: https://gerrit.libreoffice.org/30005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-18Resolves: tdf#103051 pdf export assumed 1bit bitmaps were N1BitMsbPalCaolán McNamara1-3/+33
Change-Id: I2268d8b74f187d07f161f42cc9530be3ebbc86d0 (cherry picked from commit 1c9096dad7dc2ee25d9ebe16ab02d5caba5f8a79) Reviewed-on: https://gerrit.libreoffice.org/29794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-13Resolves: tdf#102999 get_selected_printer is transfer noneCaolán McNamara1-2/+5
gtk_print_unix_dialog_get_settings returns a new GObject we have to unref, but gtk_print_unix_dialog_get_selected_printer doesn't add a ref so dies along with its parent dialog. Change-Id: Ie5f8ecd83f5cc2c13e4a8c3ba292ffa381f9bdf5 (cherry picked from commit c12e14d19f86be8555f6262d138cf0776f2c9b56) Reviewed-on: https://gerrit.libreoffice.org/29773 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-12tdf#103103: Many Arabic fonts dont render correctlyKhaled Hosny1-19/+11
Revert the remaining bits of 1da9b4c24e806ad2447b4a656e2a7192755bb6a8, the rest was reverted in 6323e6628668849438e6e19ba7ad2c6598263261. This break many assumptions made by GenericSalLayout::ApplyDXArray(). (cherry picked from commit f48cbaac0a2a7278f366a3b0118b399c0a938a44) Change-Id: I25fbafe06032ab1e8860df6c5932a7157575aa32 Reviewed-on: https://gerrit.libreoffice.org/29698 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-10-06Resolves: tdf#102177 focus not restored from context menusCaolán McNamara6-57/+49
this is a bunch of squashed together commits, much easier to read commit by commit the problem being that the attempt to restore the focus in the document in the floatingwindow tear down is blocked because the menus have set that window as modal so the focus isn't set. The attempt to set the focus in the floatingwindow teardown causes the SavedFocus in the menufloatingwindow to be dropped, so the extra layer of code to restore focus after modality is removed doesn't do anything this is fallout from... commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves: tdf#87120 no keyboard navigation inside floating windows which allows the focus to "truly" enter the menus, triggering the floatingwindow attempt, which fails but blocks the menufloatingwindow attempt easiest thing seems to make the restoring modality, and then restore focus, something that MenuFloatingWindow does before it finishes (cherry picked from commit 4da7971812b0a53ba80f7d9c29851c527488067d) the only place the default xFocusId arg isn't used... the argument is (effectively) equal to the default (cherry picked from commit 95a6d24ed7a231c42ccd608fb93cbed989a62e3a) EndSaveFocus return value is unused (cherry picked from commit 98da362f1691734437cb37f902fb1cdab613ac0a) EndSaveFocus does nothing on the !bRestore case (cherry picked from commit 9b7dfb10641ba7978ffcbd1db0507163411ae027) detangle code that now looks silly since... commit 9b7dfb10641ba7978ffcbd1db0507163411ae027 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jun 9 16:52:21 2016 +0100 EndSaveFocus does nothing on the !bRestore case removed the code that made it look like it made sense (cherry picked from commit 0d56cc15803965a1be6991a3630076f7ccf67817) Change-Id: I97a4ac71419dcb04709e4667586d8343e89ddbeb 26fcd43d2bc8e37e6887c244f728e3231328e34e 746e47b118a8b8c687c435371e2bdf2dc22cbf88 8e199535803faf364469f9b9df46f339febe25c6 2e7280fd6643e86d65cba04c8302be099d6f3d0e Reviewed-on: https://gerrit.libreoffice.org/29326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-06Resolves: tdf#102347 configure size/expose might never come...Caolán McNamara4-22/+2
if you request a size you might not get it. This attempt dating through... commit 6dc1d2706f519d91617ac1a12fc2051d97ef98c0 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jun 15 10:56:33 2015 +0100 another stab at tdf#91393 block paints only if the new requested size is larger than the original and unblock on explicit expose events as well as configure ones ... commit 8f324aebfb94c4b2023894121b954ad4f35eb395 Author: Caolán McNamara <caolanm@redhat.com> Date: Sun Jun 14 15:49:56 2015 +0100 Resolves: tdf#91393 autotext (etc) not fully drawn ... commit e6a1956034c98204e30b0ca40330249d6f6f8155 Author: Jan Holesovsky <kendy@collabora.com> Date: Fri Jun 12 15:36:03 2015 +0200 tdf#91301: Don't cache incomplete tabs. After introduction of the Idle processing, something has changed so that the underlying GetGdkWindow() does not update its size fast enough; even though the gtk_window_resize() is called before the Window::Erase() (that actually paints the background) etc. is all junk. I don't see the original problem of tdf#91393 or tdf#91301 anymore under gtk2 after reverting this yet anyway to see if they need another fix. Change-Id: Ide071eba279de726a9c6a80884bc9021c8914d9d (cherry picked from commit 99ee7deaf0a7a61bc74e8cb2d8a654fb675f50bb) Reviewed-on: https://gerrit.libreoffice.org/29189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-26tdf#91043 - vcl: gtk file picker should tolerate empty filter list.Michael Meeks1-41/+47
Apparently LibreLex creates a dialog through UNO and sets no filters. Change-Id: I518beef6f9c6ebab0d2e49bda78a33a283ad93d3 Reviewed-on: https://gerrit.libreoffice.org/29238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 3be5deadcb46e09d84d99b2b108b65b06ff356e9) Reviewed-on: https://gerrit.libreoffice.org/29291 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-20tdf#102295: remove mutex - use atomic for watchdog timingsTomaž Vajngerl2-47/+35
Change-Id: I6587bad8b7906faeae39735343278b10be78c05b Reviewed-on: https://gerrit.libreoffice.org/29082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-09-20tdf#102295: relax timeout timings for the GL watchdogTomaž Vajngerl3-13/+79
Some OS/GPU combinations need more relaxed watchdog timeout timings as the shader compilation takes too long to complete. Contains also the following commits: tdf#102295: The relaxed values were actually too pessimistic. tdf#102295: AMD actually has two vendor id's. Change-Id: Ifd9ff7ecfa4b004d5411d6d364dd01a389a3fcec (cherry picked from commit e5c3c69423c0f32bf4bee147936e58ba4d3be181) Reviewed-on: https://gerrit.libreoffice.org/29041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-20Resolves: rhbz#1373933 gtk 3.21 emits a lot more "style-set" signalsCaolán McNamara5-15/+60
also deb#837356 since gtk3 commit of... commit 0f116135f4a5033ce4e9dfa19f10624701fa615c Author: Matthias Clasen <mclasen@redhat.com> Date: Fri May 6 10:12:14 2016 -0400 Avoid emitting ::style-set by name GtkStyle is deprecated, but we still emit ::style-set quite a bit, so lets at least not be slow while doing it. docs say... 'GtkWidget::style-set has been deprecated since version 3.0 and should not be used in newly-written code. Use the “style-updated” signal' and this code just came over from gtk2 without any thought about it at the time, so change it over to the "style-updated" which makes everything happy again gtk3 still emits a lot of style-updateds signals so also don't throw away font settings every time, check if the font settings changed and only emit FontChanged if they differ from the last seen settings. (cherry picked from commit ef7abe81df10cb8a8c04afbb1fbe700f94e73f04) Change-Id: I9e920d2fb2d820ff1b1b5a9ecb228484df3d6146 Reviewed-on: https://gerrit.libreoffice.org/28944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-15Resolves: tdf#101879 explicitly put menubars at the start of task listsCaolán McNamara1-1/+1
Change-Id: Ia6a36b08f84960b01472833504cd65bfbad473eb (cherry picked from commit 830ac71eca425caf04764076e3064b5f1ad05c52) Reviewed-on: https://gerrit.libreoffice.org/28878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-11Resolves: tdf#101881 gtk3 3.18 menubar doesn't grab keyboard...Caolán McNamara2-0/+9
the same way gtk3 3.20 does with gtk_grab_add, so on gtk_menu_shell_deselect the keyboard focus doesn't remain in the menubar. bisecting gtk itself I find... commit 5cbbb90e311d95192d1b68ba89c3190cdb652868 Author: Carlos Garnacho <carlosg@gnome.org> Date: Thu Nov 26 19:54:31 2015 +0100 GtkCellRendererAccel: Use gdk_seat_grab() https://bugzilla.gnome.org/show_bug.cgi?id=759309 is the commit that makes it do what I want, so add an extra gtk_grab_add/gtk_grab_remove around our entry and exit of the menubar Change-Id: I5bf09834b4e1a14d30403208d03b3abd28a382a8 (cherry picked from commit d45d8ae3c51606eb1d9e63396a0eab13c8742907) Reviewed-on: https://gerrit.libreoffice.org/28759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-09-09Fix not-so-newly introduced perf regression in vclKhaled Hosny1-22/+1
Reverts f688acfdae00ebdd891737e533d54368810185e1 and the cluster boundaries part of 1da9b4c24e806ad2447b4a656e2a7192755bb6a8, checking the user of the GlyphItem::IS_IN_CLUSTER flag again, I think the old code provides what they expect. (cherry picked from commit 6323e6628668849438e6e19ba7ad2c6598263261) Change-Id: I74bcca3a203164028a0be8fe75fde73e54faba1b Reviewed-on: https://gerrit.libreoffice.org/28726 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-06tdf#101779 Allow multiline tooltips in template managerMaxim Monastirsky1-1/+2
Based on 0c3a9aa403c209e522dc5c32258c33381677c91e Also includes: Related: tdf#101779 TipStyleBalloon for ShowQuickHelp too 681294d55b6b4edcdef08982596cb4bcee32e635 converted TableDataWindow::RequestHelp to use ShowQuickHelp, but it wants to set TipStyleBalloon to be able to use line break. Also I want to do the same in the template manager dialog, in the following commit. (cherry picked from commit 331d3a8b23cdbff0e1434aa5a553efdcc2c7c822) Change-Id: Ie2569a5ab29620a5f4474dafd2309513c08bd7d2 Reviewed-on: https://gerrit.libreoffice.org/28701 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-06tdf#101471 Unity: make sure vcl menu is hiddenMaxim Monastirsky1-0/+1
MenuBar::SetDisplayable happens to be called before GtkSalMenu::EnableUnity(true) under gtk2, which leaves the vcl menu visible (but not painted completely). Solve this by calling SetDisplayable from inside EnableUnity, as it was before 800704e0c46f6f86f6a18a477ba4b6f313c5693a. Note that calling SetDisplayable has a side effect of disabling of menubar keyboard events, but we don't care about that, because Unity menu is outside the application anyway. Change-Id: I3948d5b57b1df480cee4fb962a5dc6b63a849b15 Reviewed-on: https://gerrit.libreoffice.org/28676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-05Resolves: tdf#101795 restore hiding on end of Gtk fpicker executeCaolán McNamara3-5/+2
but don't hide it at the end of every RunDialog::run so that the dialog still exists and is visible if the "sure you want to overwrite" dialog needs to be displayed and restore the cui options stuff to its original state as well, undoing the earlier efforts of... commit c1bd3156cf66318023f36d81ce809a38072588e4 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 21 21:44:06 2016 +0100 Resolves: tdf#101054 crash on options->path with non-native file picker and commit 3bbc0574d78d129359638b74612de2f93419eeb0 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jul 5 10:16:51 2016 +0100 Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker Change-Id: I5d6bcee9fb0a73a95cc29e8f3f2ee2aea91a135a (cherry picked from commit 696e83b663d4f3e00f23947613f9f3916a4dd14d) Reviewed-on: https://gerrit.libreoffice.org/28642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-08-19Resolves: tdf#91533 (rhbz#1364335) Tooltips are truncatedrpmbuild2-0/+12
Change-Id: Id9ec91ed9652f491e4e2a0556eeed27bf6517002 (cherry picked from commit e527edf06f8befb45b76ee8ebabe62e6dc885e45) Reviewed-on: https://gerrit.libreoffice.org/28219 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-08-18Resolves: tdf#100250 scrollbar has no bgCaolán McNamara1-0/+5
Change-Id: I48e26b775337809759f8a76be7a9c457c94cd5c9 (cherry picked from commit 176111160ddfbe4b6b36b300062bab156d46b211) Reviewed-on: https://gerrit.libreoffice.org/28059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-08-18tdf#100965: Restart on initialisation-time OpenCL crashTor Lillqvist1-0/+8
Add a flag to the OpenCLZone indicating whether we are performing the first-start OpenCL functionality verification, so that if we run into a crash that is caught by the VCL VCLExceptionSignal_impl() handler, we terminate the process with the EXITHELPER_NORMAL_RESTART status after first having disabled OpenCL use. The wrapper process will then restart soffice.bin. This is for Windows only so far. This matches what we do if OpenGL fails early during start of LibreOffice. Also, the enter() and leave() functions are not used anywhere (cherry picked from commit 32881f01833dbcefd5600e1135dd8743178bfd96) (cherry picked from commit b9898f03eb05411c508b1b02588812074d40417a) Change-Id: Ibb9bf3a86b7521bf16728de2a118ad4323be674b Reviewed-on: https://gerrit.libreoffice.org/28138 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-09Resolves: tdf#101213 drop use of CAIRO_OPERATOR_DIFFERENCECaolán McNamara1-14/+9
for tdf#99446 and rhbz#1283420 there is a hackaround which ended up in 5.1.5, which is not in 5.1.4, for corrupt glyphs under X. I can still reproduce the problem if I drop the CAIRO_OPERATOR_DIFFERENCE usage here with master and gtk2. This alternative hackaround to force a read of the underlying surface works just as well (help->license information is the reproducer) but reportedly solves the performance regression. (cherry picked from commit 705d7597480b2307d7e4929ce9386d80ce2a0f16) Change-Id: Ie3c5b07409537a1734226b4ce034620351297e25 Reviewed-on: https://gerrit.libreoffice.org/27983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-09Resolves: tdf#97120 printing controls uses wrong font and font sizesCaolán McNamara3-7/+7
regression apparently since commit 825b3df7f1d987021ec4a08ff8e7ed78e5772c97 Date: Thu Oct 22 19:03:01 2015 +0200 tdf#94138 fix printing of edit form fields revert the GetDrawPixelFont part of that so the font is pulled from the control and not the device its printed to, this makes tdf#97120 and tdf#97120 work properly again then revert commit 6c41727484a04ab89005ffb052937dae5d7dc223 Date: Tue Dec 1 17:44:23 2015 +0100 tdf#94138 Use correct fonts for multiline edit when printing because that replicates the original GetDrawPixelFont behaviour so its not needed after the other revert. Then, to solve the original tdf#94138, in the edit StateChanged handler call ApplySettings(*this); like FixedText::StateChanged does to merge in the controlfont setting to the underlying OutputDevice of the control, which presumably is what is then retrieved from GetDrawPixelFont Change-Id: I992a0e2011ffce7748d39f7f2bc49fbf6b8eaa79 (cherry picked from commit 5a5db03acc605a02c76c0f2977079b3dcf48de22) Reviewed-on: https://gerrit.libreoffice.org/27879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-08tdf#101008 fix XOR renderingTomaž Vajngerl1-24/+69
Change-Id: Ied73966633e5ffd56faccea7ec1408bd83642b58 Reviewed-on: https://gerrit.libreoffice.org/27862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/27922 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-08tdf#100915 draw antialiased line just for polygon outlineTomaž Vajngerl1-13/+24
To get the anti-aliased polygon we draw a anti-aliased line around every trapezoid. This works fine until we draw a transparent polygon where the lines become visible because of blending. A much better and faster way is to just draw the polygon outline with anti-aliased lines. This is done with this commit. Same fix as aeb0c407a620ea8c28903f61d9d53e6d9ae7c53a in master, but the code differs in 5.2 from master so much that it is generally a separate implementation. Change-Id: I95f98cc930caa7138a59048af68d4015046334d4 Reviewed-on: https://gerrit.libreoffice.org/27923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-08don't try to memcpy from and to a nullptrMarkus Mohrhard1-0/+4
See e.g. http://crashreport.libreoffice.org/stats/crash_details/2218a489-b64c-4193-a7d4-cd01c6a607cb Change-Id: I6c123d3e9e5c6dbcb7756a686503904cbfd944a4 Reviewed-on: https://gerrit.libreoffice.org/27948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 855df248c8a380e253a35feefec21ebc1dee1aca) Reviewed-on: https://gerrit.libreoffice.org/27978 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-02Related: tdf#92516 make menu accelerators always work even if...Caolán McNamara1-11/+2
keyboard not used yet. The gtk2/3 menus appear to work this way. (And when not in gtk2/3 it shouldn't disable the accelerators for other platforms anyway) (cherry picked from commit f6d0d92a5e249413df99a7f3677a28efe6d45426) Change-Id: Ib7a99bd9039cd07120b3b77380f810b5b028fd57 Reviewed-on: https://gerrit.libreoffice.org/27794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-28Resolves: tdf#101132 a11y crash in hyperlinkCaolán McNamara1-0/+2
regression from... commit aa6c54f337a616c9ca6a39cfc8708657018d8613 Date: Mon Jan 18 09:01:15 2016 +0200 loplugin:unusedfields Change-Id: Ic2b7fe5f2d49a447a9936c4fb04bafcc7349ecf9 (cherry picked from commit 4fc3c8a3df485f6dccdcb2c51c6266fbd0dace3e) Reviewed-on: https://gerrit.libreoffice.org/27609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-26tdf#101138 opengl: blacklist intel drivers for Win 7Tomaž Vajngerl1-0/+3
Change-Id: I1b3db15b2fbdd948dcc9bacf7891f8429f066150 Reviewed-on: https://gerrit.libreoffice.org/27549 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-25Resolves: tdf#100838 no transparency support on using original jpg data pathCaolán McNamara1-1/+10
This became a problem since... commit 76ec54e8c9f3580450bca85236a4f5af0c328588 Author: Michael Meeks <michael.meeks@collabora.com> Date: Mon Feb 8 14:24:15 2016 +0000 tdf#97662 - Try to preserve original compressed JPEGs harder. Avoiding de-compressing and re-compressing them saves lots of time too. for the default JPEG Compress + Reduce Image resolution case but appears to always be a problem with the Lossless - Reduce Image resolution case. Change-Id: I24c69a59a16d69817e402cd87f84e744ee146a66 (cherry picked from commit c72db36c7c791b1f92d3dd29fbc40c8ef168c609) Reviewed-on: https://gerrit.libreoffice.org/27446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-25Resolves: tdf#100558 last 'section' of date field not incrementedCaolán McNamara1-1/+1
presumably a regression from... commit 3cad6c806e5247ce20b78eb688551aa5d872b934 Author: Chr. Rossmanith <ChrRossmanith@gmx.de> Date: Fri Mar 1 21:47:10 2013 +0100 Replace (Xub)String with OUString in vcl(field) where UniString::Search returned a max short on not-found while OUString::indexOf returns a -1 Change-Id: Ia3ef80dd318375ccdb3bdcee9bed7b70bf67cae1 (cherry picked from commit 82913e694a4169f9ddeef399e659aec78cc9c8d6) Reviewed-on: https://gerrit.libreoffice.org/27374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-21Resolves: tdf#101011 atk needs a value for accessible-table-column-headerCaolán McNamara1-1/+15
This presumably became a problem after... commit 76c549eb01dcb7b5bf28a271ce00e386f3d388ba Author: Steve Yin <steve_y@apache.org> Date: Fri Nov 29 13:03:27 2013 +0000 Integrate branch of IAccessible2 added a TABLE_COLUMN_HEADER_CHANGED usage which triggered it. Change-Id: If54b7a39a170566cf7def3548ba385fa5d99bb1c (cherry picked from commit 9b47a8b21f87fa77d2d61ac4a2c2bbc7c0d67a19) Reviewed-on: https://gerrit.libreoffice.org/27368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-21use CAIRO_FILL_RULE_EVEN_ODD by defaultCaolán McNamara1-0/+1
as seen in tdf#100909 with gtk3 backend Change-Id: I67a270a96df980489cd2cb37461b3bf88de4df03 (cherry picked from commit 0d2a328ab0ecac9e07dbb59762e571958fcc33d9) Reviewed-on: https://gerrit.libreoffice.org/27314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-21Resolves: tdf#100731 include palette in checksumCaolán McNamara1-1/+2
Change-Id: I084d840b9fa078ebea3ff1471d8c8bc88171abc7 (cherry picked from commit 8624d2c8e3be89c794d3cfcfb72685fcb18e4d24) Reviewed-on: https://gerrit.libreoffice.org/27291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-20Resolves: tdf#100903 Calc hangs when preediting Japanese with GTK pluginTakeshi Abe2-0/+4
... + Mozc. This issue shares a common root with tdf#56937. Change-Id: Ic5720c19f22f7e6b047e1251b34f90d04ce7eee7 Reviewed-on: https://gerrit.libreoffice.org/27305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1c81af2c1814e8bd12701f85e09cebf5fe206647) Reviewed-on: https://gerrit.libreoffice.org/27330
2016-07-18vcl: This seems a missing returnTakeshi Abe2-2/+2
Change-Id: I99c3be904e9ee2ad8f76d09d1d8998a6898fb81e Reviewed-on: https://gerrit.libreoffice.org/27283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0789b66353f75f4791754727629f553aa717be67)
2016-07-18tdf#100600 sfx2 classification: never replace the control with labelMiklos Vajna1-0/+6
Thanks to Caolán McNamara for pointing out where is the condition of the replacement in VCL. (cherry picked from commit 8192da8e4de7a058ef95253f992f4143f83fa0f1) Change-Id: I7e1ef4a016a37b25e084c4c6467a42ca557069a4 Reviewed-on: https://gerrit.libreoffice.org/27214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-15Related: rhbz#1343766 a11y queries during dispose trigger listbox crashesCaolán McNamara1-0/+2
though not able to reproduce, I have an in-house complaint similar to commit f120abb446bf3f5230ed06a3b148654dde36bb94 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jun 8 11:35:15 2016 +0100 Resolves: rhbz#1343766 a11y queries during dispose trigger combobox crashes except with a listbox in the bt Change-Id: Id31561e009a1f0ec9272a0e7216296e4017e5688 (cherry picked from commit c615943bda57eadfa73c14a7314938aabe0bd16f) Reviewed-on: https://gerrit.libreoffice.org/27188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-15Resolves: rhbz#1349501 gtk3: smooth scrolling events can be disabled...Caolán McNamara1-30/+65
by the user with GDK_CORE_DEVICE_EVENTS=1, and so manage to disable their wheel scrolling Change-Id: I7df63f738983c90dea75b9f43a36133910446aba (cherry picked from commit 7dfd50f947671d79b9119f10259857700d5728d8) Resolves: rhbz#1349501 gtk3: smooth scrolling events can be disabled... better fix, if we listen to the eventbox we get either SMOOTH scrolling or not smooth events, not both. We get SMOOTH when supported, and not if not supported so no need to reintroduce the miserable hack, which doesn't work under wayland anyway Change-Id: I993e71d3553322425a506cd93d812efe081bf3c9 Reviewed-on: https://gerrit.libreoffice.org/26645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-12opencl: OpenCLZone, detect CL device change and disable CL on crashTomaž Vajngerl2-0/+6
Guard OpenCL calls with OpenCLZone, so if a OpenCL call crashes we detect this and disable OpenCL so next time the user doesn't encounter the crash at the same calculation because he has a broken OpenCL drivers. Similar has been implemented for OpenGL with good results. Additionaly we persistently remember a known good OpenCL device ID and driver version so we can match this and perform calculation tests when they change. This is to ensure that the selected OpenCL device performs as we expect. In this commit the calculation tests aren't included yet. Remove complex static initializer in opencl wrapper library. Change-Id: I1a8b81ee31298731efcf63dc6a476955afc035e9 Reviewed-on: https://gerrit.libreoffice.org/27064 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit f41eb66302208f384a475fb20c98b6d1b0676cb6) Reviewed-on: https://gerrit.libreoffice.org/27099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-11Resolves: rhbz#1342823 toolbar menus popdown immediatelyCaolán McNamara3-3/+10
Change-Id: I9cecf50fb85d84e108ccc23d22bf97d2ac510a9b (cherry picked from commit f7c888994db744396c69aa1be720c2089ada5798) Reviewed-on: https://gerrit.libreoffice.org/26698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-07-11Resolves: tdf#100463 tolerence in contour editor doesn't workCaolán McNamara1-18/+18
probably since commit f51f03a46102333bac6a7fe06bc8538492f413a5 Author: Stephan Bergmann <sbergman@redhat.com> Date: Wed Mar 5 12:24:14 2014 +0100 Do not needlessly truncate MinMax argument before comparison with bounds Change-Id: I5c92f0af3e05ad68ed88fa860b36e8426e160bf9 (cherry picked from commit d5bd18ecac5806b7b4e39a1919b6b56df0f94ce3) Reviewed-on: https://gerrit.libreoffice.org/27101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-07-09if mpCurrentProgram and pProgram are NULL this crashesMarkus Mohrhard1-1/+1
See http://crashreport.libreoffice.org/stats/signature/OpenGLProgram::Reuse%28%29 Change-Id: I2d1c9d9faff05d0d57a2c217a9ee594b1c22b61d Reviewed-on: https://gerrit.libreoffice.org/27043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 5d1865293a66eb902237e70877226b7cec31105c) Reviewed-on: https://gerrit.libreoffice.org/27046 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-08Resolves: tdf#100574 Crash when selecting and applying border style...Caolán McNamara1-1/+1
when a first torn off instance was opened just before the second one and then the second one sends focus back to the first when its popped down. The second one listens to losing the focus and disposes itself which leads to dereferencing deleted stuff. So add a reference count to the places these tear offs call popdown so its still gets disposed but not deleted during the popdown and then protect against members being disposed with a enough checks to get back to safely Change-Id: Id5f8eb4771df36305e308a2a9a5035018948f121 (cherry picked from commit 886637d355e77cd61d85279f145c06b07385fecd) Reviewed-on: https://gerrit.libreoffice.org/26751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-07g_warning->SAL_WARNCaolán McNamara2-2/+2
Change-Id: If2a1fa3514069f5a5dc4ab9a6b853833e39bab01 (cherry picked from commit 2ab9dd333406327532a106f2d20256a2d1e96bb9) OSL_TRACE->SAL_INFO for the Invalidate all children output Change-Id: Ib5db114502ebf86ab1581104b914c84eceb50829 (cherry picked from commit 246eca3e5a698671e4ce7e078d994ffd317c2a68)
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-18 00:31:35 +0000