summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2013-05-06[harfbuzz] Support Unicode variation selectorsKhaled Hosny3-18/+21
Change-Id: I8c56f45505327857613c39b28da3ae7cc3ad201c
2013-05-06Revert "#i103131# in doubt treat unicode variation selectors as ↵Khaled Hosny1-5/+0
invisible(cherry picked from commit 179f88dfe5a1eb2ebd051d73b50f1e0af9c12fd9)" This reverts commit 6840ba613cc46ee65d58612ecabe748d539de9f5. We don't want this since we can now support variation selectors with HarfBuzz.
2013-05-05[harfbuzz] Fix vertical text layoutKhaled Hosny1-0/+9
"Fixed" in the sense that it works exactly like the non-HarfBuzz case, but that is already a bit broken. Need to get rid if the little OpenType layout engine in ServerFont::ApplyGSUB() and use HarfBuzz's vertical text layout capabilities. Change-Id: I32abe385575bd5d1b66e573dfe2fc7f412d02254
2013-05-05fdo#39468 Translate German Comments - rest of vcl/source/edit/...Christian M. Heller5-170/+108
Change-Id: I6cb657853cf3e8d4e35c0dc09be6a4a15ba3a336
2013-05-04extract correct widget id for responsesCaolán McNamara1-0/+3
Change-Id: I5ce14e346b8ee609fdad4deae9929a90cbadd84e
2013-05-03[harfbuzz] Fix placement of multi-glyph clustersKhaled Hosny1-1/+16
Calculate the delta based on the whole cluster width no just the first glyph. This whole ApplyDXArray() business is completely flawed, it is just trying to second guess information we already had, and then workaround all bugs it is introducing. Change-Id: I5f719d7addcb89c9d5662b48ca7cf55cd388b41e
2013-05-03unneeded using directiveEike Rathke1-1/+0
Change-Id: I8696f876e8ab51e3ceab6ac597e9c339d40182b3
2013-05-03implemented IcuFontFromServerFont::getFontTable(LETag,size_t&)Eike Rathke1-3/+11
so that ICU versions trying to call LEFontInstance::getFontTable(LETag,size_t&) actually call it instead of IcuFontFromServerFont::getFontTable(LETag) See http://site.icu-project.org/download/51#TOC-Known-Issues "NOTE: Applications must implement LEFontInstance::getFontTable(LETag, size_t &length) in their LEFontInstance subclasses, so that ICU can properly bounds-check font tables." See also https://ssl.icu-project.org/trac/ticket/10107 Change-Id: Ic20b7e8dda4e84734eb6de0ccba82b0dea481d55
2013-05-03do not call LayoutEngine::reset()Eike Rathke1-1/+0
Calling reset() disposes everything the LayoutEngine knows in its current state. While this may have prevented some obscure crash during exit in the past (call was added 2003-03-27), it definitely leads to a crash if the updated LayoutEngine "patch" http://download.icu-project.org/files/icu4c/51.1/icu-51-layout-fix-10107.tgz is applied as that sets fGlyphStorage=NULL (it doesn't delete LEGlyphStorage though and thus may leak, but that patch is in the wild now) and a later call to mpIcuLE->layoutChars() tries to access fGlyphStorage->...() if mpIcuLE is reused. For the patch mentioned see http://site.icu-project.org/download/51#TOC-Known-Issues and http://bugs.icu-project.org/trac/ticket/10107 Change-Id: I1b8f5c446c174d7d12b896b3ecd2a266645e8abc
2013-05-03unset WB_GROUP on non-initial buttons in groupsCaolán McNamara2-4/+23
Change-Id: I8846318e8d7fef862bb105af878b2df17045d7ff
2013-05-03implement native button order for messageboxesCaolán McNamara1-0/+110
Change-Id: I85d0991da3d2a1efa9d5c15569164d8bd2194356
2013-05-02allow custom pushbutton subclasses to set images via builderCaolán McNamara1-2/+2
Change-Id: I639120393fec6fc0c5aa58cbefffe511742383f9
2013-05-02rather nutso, just drop the XubString variantCaolán McNamara1-7/+2
Change-Id: Iebff2bc517e3b6422a6b410f44d78cee1b6d971d
2013-05-02[harfbuzz] Fix shaping across text runs, take 2Khaled Hosny1-9/+1
The 3rd parameter of hb_buffer_add_utf() should be the length of the whole text not the current run, so that HarfBuzz can take the context into account when shaping. Change-Id: I369deb27176cbb136de12872b8a70453d5721bea
2013-05-02Revert "[harfbuzz] Fix shaping across text runs"Khaled Hosny1-6/+2
This reverts commit ca0b580e2a21999d75bcd39ae5b6f81e9e42897b.
2013-05-01[harfbuzz] Simplify cluster detectionKhaled Hosny1-9/+5
Change-Id: I48c11fad175fe40f48baaa47238f6087b91e6a37
2013-05-01Resoves: fdo#31849 ensure more button text remains vertically centeredCaolán McNamara1-0/+1
Is seems very bizarre that in Button::ImplDrawAlignedImage if there is no image, that we still add padding for the image separator to the text position. Why we have the concept of an Image *and* a Symbol escapes me. Anyway, setting the "Image" align to the right to match the "Symbol" align stops the button text getting displaced downwards. Change-Id: I67b80b2ff5cc960f5394cb7d69cab7a4c14513bf
2013-05-01create a HIG compliant MessageDialog and map to GtkMessageDialogCaolán McNamara3-9/+275
Change-Id: If86387619ff00a652ea418292fbb0026b867a431
2013-05-01convert message box return types to an enumCaolán McNamara1-15/+15
Change-Id: I20889dc94aac1119c1ee9da873ce911887c1c335
2013-04-30Blind fix for MSVCStephan Bergmann1-1/+1
...preventing full instantiation of boost::ptr_map<OUString,osl::Module> (which fails because osl::Module is not copy-constructible) which MSVC thinks is necessary if that template instantiation inherits the VCL_DLLPUBLIC from the VclBuilder class that uses it. Change-Id: I8cd5608c80d7ce9b12ba678430f5ef283a427e93
2013-04-30retain references to loaded modules for builders lifetimeCaolán McNamara1-7/+14
Change-Id: Iab8b53dc50d69ba781978e1e7fd9b9c5a19c6d59
2013-04-30Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks5-94/+21
2013-04-30fdo#62815 - tolerate crazy / out-of-bound ScreenNumbers for FullScreenMichael Meeks2-0/+23
Thus making the gtk+ backend more similar to the generic backend in this regard; also be more strict about invalid monitors -> empty screens. Change-Id: Ia4f2e1205cb1d309fb1bb01f9631167339a3478e
2013-04-30Fixup German translation.Thorsten Behrens2-8/+9
This touches up lightly on e986d3e396174096abb46075bf7488677b9a35f9 Change-Id: If4d940433b27abec63a85c5975f5e9ebf672b79a
2013-04-29[harfbuzz] Don't crash when closing LibreOfficeKhaled Hosny1-1/+1
We shouldn't be trying to free the font table buffer when destroying the blob, so pass NULL for destroy function instead of free(), and also use HB_MEMORY_MODE_READONLY just to be safe. Change-Id: I85b5a575249b4efc0f5799db205ee17cbeb66d22
2013-04-29There is no images*_brand.zip filesStephan Bergmann1-41/+13
Change-Id: I6ddeff7ae72693fd0951d71bd7b5444938bc7286
2013-04-29Fix indentationStephan Bergmann1-4/+3
Change-Id: Iaec745dc1c8eb0614cc2fe1d70a94a00d18cc934
2013-04-29[harfbuzz] Re-enable text justificationKhaled Hosny2-5/+78
It turned out that ApplyDXArray() is need to apply advance width adjustments after justification, so we can't just bypass it. So I just copied GenericSalLayout::ApplyDXArray() and stripped it of ICUism so it does not break with HarfBuzz, but I had to make m_GlyphItems non-private, so I'm not sure this is the right approach. Change-Id: I66d647c3590fdf912c39d0cf23ac72bcc7ca72c9
2013-04-29[harfbuzz] Fix shaping across text runsKhaled Hosny1-2/+6
The 3rd parameter to hb_buffer_add_utf() should be the length of the whole text not the current run, so that HarfBuzz can take the context into account when shaping. Change-Id: I9e4e928d40078c3e3667cfdb6d8f24bf6e58263d
2013-04-29[harfbuzz] Fix text width calculation for realKhaled Hosny3-34/+8
No more second guessing if text width, we know that information already, so pass it around instead of trying to re-create it. Change-Id: I19faacbc309d38753c3c9f7214dfa0bf59cc66b5
2013-04-29[harfbuzz] Follow variable naming conventionsKhaled Hosny1-71/+75
Not that I'm a fan of Hungarian notation, but for the sake of consistency. Fix some placement of opening braces along the way. Change-Id: Id6ea758fd438a4040e7451430a0f3a166efdec43
2013-04-29[harfbuzz] Check for SAL_USE_HARFBUZZ in one placeKhaled Hosny2-16/+20
Change-Id: I78efebb576dffa8d39e98283feb9aab2186b5a39
2013-04-29[harfbuzz] Fix text width calculationKhaled Hosny3-0/+37
GenericSalLayout::GetTextWidth() uses GlyphItem's mnNewWidth when calculating text width, and though this seems logical (it is after all the actual with the glyph is contributing to the all over advance width), it results in shorter width calculation whenever glyph width adjustment is involved, no idea why! The #ifdef is there so that the ICU code path is not changed in anyway, but all of this should be merged into GenericSalLayout when ICU is gone. Change-Id: I7cbde1675b78e87c142513eb52a13ee5fdc60617
2013-04-29[harfbuzz] Don't change the returned positionsKhaled Hosny1-8/+8
Use local variables instead of altering the returned glyph positions array, looks more cleaner this way. Change-Id: Ibbcced57777010bd045668a99d7beb0618abe226
2013-04-29[harfbuzz] Correctly apply glyph positionsKhaled Hosny1-4/+4
X and Y offsets should only affect the position of the current glyph, not any subsequent ones. Change-Id: I9dd1576cbdbb36b70f1898dc52702c02c4e851af
2013-04-29[harfbuzz] Correctly apply RTL width adjustmentsKhaled Hosny2-8/+14
It turns out it is GenericSalLayout::ApplyDXArray() that is messing with glyph advance widths trying to recalculate them. It is very old code (it has been there since ICU were introduced back in 2002), but whatever issue it is fixing, HarfBuzz does not need it. Change-Id: I5c896d3f318e2f17d135f9eea599b917e04ed592
2013-04-29Remove residue of undocumented "edition" featureStephan Bergmann3-19/+2
...whereby some branding could be orverridden with information from a program/edition/ directory. Change-Id: I7f9324678b09bc8069775dfcbda97be8e0618a91
2013-04-29fdo#39468 Translation and cleanupChris Sherlock12-355/+129
Cleanup of source code: - translated German to English - removed useless comment decorations - removed commented out code - some reformatting of code Change-Id: I71d5fdab8226d61bda9ac906bb82176dc11cafd2 Reviewed-on: https://gerrit.libreoffice.org/3643 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-28fdo#63197: convert osxresJulien Nabet2-3/+5
Change-Id: I969217263fdda3e61b38dc16f0a9251b745de885 Reviewed-on: https://gerrit.libreoffice.org/3652 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-28fdo#35320 A fix for Arabic justification problem caused by kashidasAhmad H. Al Harthi1-1/+1
Change-Id: I512e6332a632acf90e4f995fbc7fd19e7ef094ec Reviewed-on: https://gerrit.libreoffice.org/3644 Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa> Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
2013-04-27convert input field dialog to .ui formatCaolán McNamara3-0/+8
Change-Id: I1c6c43b73b22120b2f2985256896af214012f0ad
2013-04-26Better text for "Insert as Link" CheckboxSamuel Mehrbrodt1-1/+1
This Checkbox is shown in the File picker dialog and does not embed the file in the document, if checked. Change-Id: I84fbc182cc9b432cd38ccb044c0479ced119d97f Reviewed-on: https://gerrit.libreoffice.org/3602 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-04-25drop duplicated warningCaolán McNamara1-3/+2
Change-Id: Ied358faaf6ba1aecae4f61ff56e639752a2de664
2013-04-25Related: fdo#63802Caolán McNamara1-9/+12
let si-phonetic-dynamic survive libreoffice losing focus and regain it cycle and still use surrounding text. It should be safe to report that we can provide surrounding text but there isn't any during the time window when there is no focus window, because the focus in event was received but it hasn't arrived yet because that happens on a postuserevent. Change-Id: I0481c42208953f2a0618aaed7b0d9e9f3e7bda07
2013-04-25Resolves: fdo#63802 return true if we have known empty contextCaolán McNamara1-7/+5
i.e. false for "we can't provide context", and true for "we can provide context, even if there isn't any" Still looks to me that there's a bug in the si-phonetic-dynamic im (or something in the stack) that assumes that returning false once means it will always return false and give up for ever fix indent while I'm at it Change-Id: I6df7f2689101250c33318db1fac5ec1b3e340566
2013-04-25use LanguageTag fallbackEike Rathke1-17/+6
Change-Id: I34c532dc7d1c71724a5c0e29c113f2d6510cc2d7
2013-04-25Fix KEY_SHIFT clashTor Lillqvist1-100/+103
Since 360d6bf4fd1241af47f55648b7597fda3120390a the precompiled header for vcl includes <rsc/rsc-vcl-shared-types.hxx> , so the KEY_SHIFT from there interfered with the KEY_SHIFT here. These magic values apparently are the "known" return values from MapVirtualKey() called to translate (fixed) virtual key codes to scan codes, suitably shifted and ORed with some flag bit(s). Whether such scan code values really are constant in all Windows installations I have no idea, it does sound a bit scary to me to assume they are. (If they are, why does <windows.h> then not provide symbolic names for them?) Change-Id: Ic18a8e1a8b7a95bb6b018382662944f6912e4734
2013-04-25update pchThomas Arnhold1-0/+1
Change-Id: I67e73438312f2a672e71762ee6707ec5d425bb47
2013-04-24vcl: rename WinResTarget target to match source fileMichael Stahl2-5/+6
makedepend relies on that Change-Id: I6a166f65d25c2750c24bc7831d074c32f6524722
2013-04-24More places where we can suppress output.Jan Holesovsky1-5/+4
Change-Id: Ib316bf40bb9b9afeb5fbdf9281f2d3b9539e346f