summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2019-12-18lok: vcl: fix multiple floatwin removal case more robustly.Michael Meeks1-9/+15
Instead of this over-clever approach of recursively removing items which can easily fail, build a list, then iterate it in-line while disabling recursion. Change-Id: I846a0d44401500d60dcc2a7f16f222324c6c621b Reviewed-on: https://gerrit.libreoffice.org/85335 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-12-16desktop: unit-test to check SpellDialog works in multiple viewsAshod Nakashian1-0/+5
Unfortunately, this isn't fully functional, but didn't want to lose the effort. The problem is that there is no proper config for languages in the unit-tests. So even when we set the language explicitly, it still doesn't apply to the SpellCheckerDispatcher, which is where it matters. This seems to be because the config is not properly propagated and broadcast. Below is the stacktrace as works on desktop. During the unittest the Broadcaster has no change listener for LngSvcMgr, so SpellCheckerDispatcher::SetServiceList doesn't get called. #0 0x00007f47f3fed7e6 in SpellCheckerDispatcher::SetServiceList(com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<rtl::OUString> const&) (this=0x5589de40e7a0, rLocale=..., rSvcImplNames=uno::Sequence of length 1 = {...}) at /home/ash/prj/master/linguistic/source/spelldsp.cxx:795 #1 0x00007f47f3fcc0ad in LngSvcMgr::Notify(com::sun::star::uno::Sequence<rtl::OUString> const&) (this=0x5589de43b4e0, rPropertyNames=uno::Sequence of length 4 = {...}) at /home/ash/prj/master/linguistic/source/lngsvcmgr.cxx:826 #2 0x00007f47fa2d3c8d in utl::ConfigItem::CallNotify(com::sun::star::uno::Sequence<rtl::OUString> const&) (this=0x5589de43b530, rPropertyNames=uno::Sequence of length 4 = {...}) at /home/ash/prj/master/unotools/source/config/configitem.cxx:181 #3 0x00007f47fa2d3946 in utl::ConfigChangeListener_Impl::changesOccurred(com::sun::star::util::ChangesEvent const&) (this=0x5589de464b90, rEvent=...) at /home/ash/prj/master/unotools/source/config/configitem.cxx:143 #4 0x00007f47e273bb61 in configmgr::Broadcaster::send() (this=0x7ffcc604c5b0) at /home/ash/prj/master/configmgr/source/broadcaster.cxx:182 #5 0x00007f47e277f002 in configmgr::RootAccess::commitChanges() (this=0x5589dd557400) at /home/ash/prj/master/configmgr/source/rootaccess.cxx:171 #6 0x00007f47fa2d80e3 in utl::ConfigItem::ReplaceSetProperties(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x5589dd5571b0, rNode="ServiceManager/SpellCheckerList", rValues=uno::Sequence of length 4 = {...}) at /home/ash/prj/master/unotools/source/config/configitem.cxx:1025 #7 0x00007f47fa339983 in SvtLinguConfig::ReplaceSetProperties(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x7ffcc604cb40, rNode="ServiceManager/SpellCheckerList", rValues=uno::Sequence of length 4 = {...}) at /home/ash/prj/master/unotools/source/config/lingucfg.cxx:847 #8 0x00007f47f3fcb88f in LngSvcMgr::UpdateAll() (this=0x5589de43b4e0) at /home/ash/prj/master/linguistic/source/lngsvcmgr.cxx:765 #9 0x00007f47f3fc9caa in LngSvcMgr::LngSvcMgr() (this=0x5589de43b4e0) at /home/ash/prj/master/linguistic/source/lngsvcmgr.cxx:438 #10 0x00007f47f3fd3baf in LngSvcMgr_CreateInstance(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory> const&) () at /home/ash/prj/master/linguistic/source/lngsvcmgr.cxx:1967 #11 0x00007f4800e9656b in cppu::OSingleFactoryHelper::createInstanceEveryTime(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x5589de3ccfc8, xContext= uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630) at /home/ash/prj/master/cppuhelper/source/factory.cxx:149 #12 0x00007f4800e96790 in cppu::OSingleFactoryHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x5589de3ccfc8, xContext=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630) at /home/ash/prj/master/cppuhelper/source/factory.cxx:175 #13 0x00007f4800e97107 in cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x5589de3ccf60, xContext=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630) at /home/ash/prj/master/cppuhelper/source/factory.cxx:374 #14 0x00007f4800eebc8f in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) (this=0x5589dbd2f030, context=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630, singletonRequest=false) at /home/ash/prj/master/cppuhelper/source/servicemanager.cxx:667 #15 0x00007f4800eee587 in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x5589dbcbaaf0, aServiceSpecifier="com.sun.star.linguistic2.LinguServiceManager", Context=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630) at /home/ash/prj/master/cppuhelper/source/servicemanager.cxx:991 #16 0x00007f4800776778 in com::sun::star::linguistic2::LinguServiceManager::create(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (the_context=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630) at /home/ash/prj/master/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/linguistic2/LinguServiceManager.hpp:38 #17 0x00007f4800772d51 in GetLngSvcMgr_Impl() () at /home/ash/prj/master/editeng/source/misc/unolingu.cxx:66 #18 0x00007f4800773449 in SpellDummy_Impl::GetSpell_Impl() (this=0x5589dd82f420) at /home/ash/prj/master/editeng/source/misc/unolingu.cxx:217 #19 0x00007f4800773614 in SpellDummy_Impl::isValid(rtl::OUString const&, short, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x5589dd82f420, rWord="a", nLanguage=1033, rProperties=empty uno::Sequence) at /home/ash/prj/master/editeng/source/misc/unolingu.cxx:249 #20 0x00007f48006ae4c2 in ImpEditEngine::DoOnlineSpelling(ContentNode*, bool, bool) (this=0x5589de195060, pThisNodeOnly=0x0, bSpellAtCursorPos=false, bInterruptible=true) at /home/ash/prj/master/editeng/source/editeng/impedit4.cxx:2306 #21 0x00007f480067d0d2 in ImpEditEngine::OnlineSpellHdl(Timer*) (this=0x5589de195060) at /home/ash/prj/master/editeng/source/editeng/impedit3.cxx:322 Change-Id: Iffef03502c78311427aa8883739678120cc84931 (cherry picked from commit 4f77bd94028a140133814d735c0425bbd0de4839) Reviewed-on: https://gerrit.libreoffice.org/85007 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-12iOS theme: set spinbox orientation to "decrease-edit-increase"CODE-4.2.0-1Tomaž Vajngerl1-1/+6
iOS theme was designed to have spinbox orientation set to "decrease-edit-increase", but this was not explicitly set in the theme definition as it was also the default. The defualt was changed recently to "stacked" and it broke the iOS theme. Change-Id: If43fa46c04415dda1efe0855c4901b5aede7eb32 (cherry picked from commit ab9ac0fc697f57f0804dea03812dd2adfd99794b)
2019-12-12lok: vcl: fix multiple floatwin removal case.Michael Meeks1-3/+6
We need to progress in our while loop to remove children, even if they are currently not in popup-mode; fixes infinite loop with two popups present concurrently. Change-Id: I4926ef8c88152dbf532ccd3fdb8e28ca2d0c62d3 Reviewed-on: https://gerrit.libreoffice.org/85000 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-12-12lok: avoid crash cleaning up help-windows with multiple views.Michael Meeks1-6/+13
Change-Id: Ic57018396de7730d9fa4fb3b4803a221cb9678da Reviewed-on: https://gerrit.libreoffice.org/84999 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-11vcl: sfx2: LOK: Support per-view popup windowsAshod Nakashian32-376/+444
While we do support multiple views, there is only one state for popup/floating windows, that also includes the dialogs open and related windows/data. This adds support to allow each view to have its own popups and state, thus allowing multiple users to interact with the dialogs independently of one another. (cherry picked from commit b50c341a53911f1d725947a4d8d3d2f782c94079) Change-Id: I3786a561ca6ca113ad12425bdb491e5a30bd1a28 Reviewed-on: https://gerrit.libreoffice.org/82440 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-11android: add abstraction to allow us to DetachThread sensibly.Michael Meeks4-0/+28
If we fail to do this after runLoop - some Android VMs can get really upset if we quit a thread without doing this, also ensure that we AttachThread to new polling loop threads as we come in for good measure - duplicate Attach's are NOPs. Change-Id: I32454773af4e02c97df0b6c02f61b1dc74df80b0 Reviewed-on: https://gerrit.libreoffice.org/84956 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-12-11lok: dialog: check if exists a LOK Window NotifierHenry Castro1-10/+18
When the dialog is about to show, it requires to send to client side the "created" message. However, in the constructor has already assigned a notifier from the parent window. Change-Id: I1120ad1c1c70449048d6739b8564d1c1f6b1c7e3 Reviewed-on: https://gerrit.libreoffice.org/84908 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-12-10lok: fix welded dialogsHenry Castro1-0/+6
In the tiled rendering case the dialogs, run asynchronous due to multiple user access. In order to send the messages to the client side, the dialog has to hook a LOKNotifier in the constructor of the SfxViewShell. However, the new weld wrapper classes use the Frame Window, (i.e. Window::GetFarmeWeld()), as a parent of the dialogs. On the other hand, in order to avoid getting the interface implementation inside implementation classes, it has been created a new method Window::GetFrameWindow(), otherwise I have to do a bureaucratic conversion between Interfaces to Implementations ( i.e. UnoWrapperBase::GetUnoWrapper() ) Change-Id: I32c34d82a89211a025250e65a05ce47d30efa0b8 Reviewed-on: https://gerrit.libreoffice.org/84117 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-12-10lok: evaluate assertion if LOK Windows container is emptyHenry Castro3-3/+10
It has defined a map container for every LOK windows assigned a notifier to the client side. However the map container has elements with VclPtr (reference counter) and it is a global data, so when global data are disposing, the VclPtr will destroy the Window when the VCL framework was destroyed that will lead to undefined behavior. So this commit adds an assert inside DeInitVCL to ensure, if someone forgot to Release the LOK Notifier. Change-Id: Ib7f20751af2931f7b0ba3e3d526e734ffc33f171 Reviewed-on: https://gerrit.libreoffice.org/84792 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-12-10ImplSVHelpData is a structTor Lillqvist1-1/+1
Avoid warning: class 'ImplSVHelpData' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]. Change-Id: I60cee7e5dad77dc8447acb7c333fb8f7c3919b3b Reviewed-on: https://gerrit.libreoffice.org/84796 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-12-09lok: Support per-view help dataTamás Zolnai8-79/+169
Used for showing tooltip windows in LO online. Change-Id: I8b6a7272c75025e717923c839fa8fd9f4cab2903 Reviewed-on: https://gerrit.libreoffice.org/84717 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-12-09lok: don't show tooltip for popup menus inside dialogsTamás Zolnai1-0/+10
Check Character Properties dialog -> Font Effects -> Font Color popup button. Moving the mouse above the colors, a tooltip is shown with the color name. However when the tooltip window is displayed LO online closes the popup window unexpectedly. Change-Id: I4bb8611640e122fc8187271c8c843c9f29fc0ce0 Reviewed-on: https://gerrit.libreoffice.org/84716 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-12-09lok: show tooltips on dialogsTamás Zolnai2-4/+5
Change-Id: I40fca6ff13cc41ec9e1ec6bba48dce207e364c79 Reviewed-on: https://gerrit.libreoffice.org/84715 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-12-05drawPixel() should still get 'true' for bXorModeAllowed.co-6.2-1Jan Holesovsky1-2/+2
That part of 7b267be4b2c87b2c3987d4d751307977a7d3ad41 was not necessary. Change-Id: Ie085f635d4adb6f574f3eca37976f9aded505524 Reviewed-on: https://gerrit.libreoffice.org/84535 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-12-04headless: Don't leak the cairo context in drawPixel().Jan Holesovsky1-1/+4
Change-Id: If841f655ac634eee2dc7ca6e9445d2f204546545 Reviewed-on: https://gerrit.libreoffice.org/84445 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-11-30tdf#124391 Fix doubled menu in global menuSamuel Mehrbrodt1-2/+6
Regression from 3bedbfd9b3cee5a8d2da6ee0486859bd725979ba Change-Id: I56473a2b0620f90f23b1bcde3ae1290801021038 Reviewed-on: https://gerrit.libreoffice.org/80465 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-26lok: calc formula bar tunnelingMarco Cecchetti1-2/+2
Change-Id: I92026098222e04a163796225a048c6d7dc1b37c5
2019-11-25android: Introduce --enable-android-lok configure switch to fix RGB vs. BGR.Jan Holesovsky2-2/+6
This indicates that the build targets the Online-based Android app, for which we need to avoid various tweaks that are needed for the 'old' Android app present in the android/ subdir of core.git. In particular, the switch used in this patch fixes a RGBA vs. BGRA confusion that caused yellow <-> cyan switch in the Online-based Android app. Change-Id: I5f394868f51ce87013677834cfafb967b9bb333e Reviewed-on: https://gerrit.libreoffice.org/83342 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-11-25widget theme: add new settings to ios themeTomaž Vajngerl1-9/+38
Change-Id: I98b4632501bb8e7f826a9dd2664a6663f4a7a208 Reviewed-on: https://gerrit.libreoffice.org/83592 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 738a11f20ef5b9bcfcc71cca6b0fbea9d06c438b) Reviewed-on: https://gerrit.libreoffice.org/83625 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-11-25widget theme: add additional settings to the theme definitionTomaž Vajngerl5-9/+65
Change-Id: Ib50ebadf73979068d3595f09de113aa8745eccb9 Reviewed-on: https://gerrit.libreoffice.org/83591 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit cb7a4428679428066d56eba4370154c667b7d4c5) Reviewed-on: https://gerrit.libreoffice.org/83624 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-11-22Revert "lok: custom widgets: render editbox borders"Ashod Nakashian1-13/+2
Looks like this is no longer needed to correctly render editbox borders. Not clear what fixed the issue. This reverts commit 7484f1691cbe9513dabf084effe8a0366b737a80. Change-Id: Ieb3b8d6f60ab762d0baccb341ed6a39ae2771e79 Reviewed-on: https://gerrit.libreoffice.org/66774 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 4305d9a4b97a660fec54d2796f7e5cb502d4fba0) Reviewed-on: https://gerrit.libreoffice.org/83438 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-21sizing button wrong in ListBox::ResizeNoel Grandin1-2/+1
Passing a right edge co-ordinate to a width param, ever since commit 4849fb6d668f6cf8fa7e6bf33c15db4696355001 Date: Mon May 10 14:47:20 2004 +0000 INTEGRATION: CWS nwf (1.25.36); FILE MERGED Probably only works because the button is on the right edge, and consequently the width will be clamped to the widget area. Change-Id: I28a88cd298bc5beb20162f457c7cc125e1d0303a Reviewed-on: https://gerrit.libreoffice.org/72231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3841143d9abf6b1c2ccf4839e9a1168dbaaf0568) Reviewed-on: https://gerrit.libreoffice.org/83400 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-20hide help buttons when LibreOfficeKit::isActive and local help unavailableCaolán McNamara2-10/+30
Change-Id: Ia263f9f7c78dbf48143678fc2f577402fb1ce998 Reviewed-on: https://gerrit.libreoffice.org/83309 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-11-19-[NSWindow setRestorable:] is present since 10.7Tor Lillqvist1-4/+1
No need to use objc_msgSend(). Change-Id: I56c824e3206c37be4b60fb7d82b65c9d5e89958b
2019-11-19widget theme: add centeredTabs setting to theme definition fileTomaž Vajngerl8-3/+93
Change-Id: I714a44d40a99e0bb5ff48e3d36ded73db60af5a0 Reviewed-on: https://gerrit.libreoffice.org/83133 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit b234743dd26e0be4be272d2d2c82f90c67e192b7) Reviewed-on: https://gerrit.libreoffice.org/83155 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-11-18widget theme: correct sizes of combobox/listboxTomaž Vajngerl1-3/+3
Combobox/listbox was clipped on the right side. Fixed this by increasing the size of the widget by one and moving the button to the right by one pixel. Change-Id: If73e93d0c99c1daff9c0bab095169dba3c619450 Reviewed-on: https://gerrit.libreoffice.org/83043 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 9e7a0fc1573a95a1542207ac86a18e630c1fc835) Reviewed-on: https://gerrit.libreoffice.org/83055 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-11-18widget theme: allow for default "stacked" spinbuttonsTomaž Vajngerl1-1/+6
Change-Id: I2943616a641de72a615f57784e8a9927c12edcf7 Reviewed-on: https://gerrit.libreoffice.org/82979 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 9aab980711f82471b012b1691699d9a28ef836f5) Reviewed-on: https://gerrit.libreoffice.org/83054 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-11-14widget theme: add missing actionButtonTextColor style to iOS themeTomaž Vajngerl1-1/+1
Forgot to add "actionButtonTextColor" to the iOS theme definition. Change-Id: I29207512a04068759021d4ae6a30824b56498de6 Reviewed-on: https://gerrit.libreoffice.org/82394 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 6ed8c8ab84cc344f5388056da20996dd5266aadf) Reviewed-on: https://gerrit.libreoffice.org/82639 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-11-14widget theme: add new action button stylesettings to xml def.Tomaž Vajngerl4-0/+12
This adds new action button stylesettings to the xml def. parser and adds the defeinitions to iOS theme. Change-Id: If500d0a7a4633b3c7b90b14b6f62c320ef4b1c12 Reviewed-on: https://gerrit.libreoffice.org/82381 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ec7374ff84c71edfbb30d6e4dc5b486b6df7107f) Reviewed-on: https://gerrit.libreoffice.org/82638 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-11-13custom widgets: support custom action button text colorsAshod Nakashian9-3/+84
Reviewed-on: https://gerrit.libreoffice.org/82276 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 8a425fbd9c6b75b09672e0ce18f43162d9eda360) Change-Id: I314183a1d6434c043183a600740c786e22a67503 Reviewed-on: https://gerrit.libreoffice.org/82383 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-13widget theme: Gradient support when drawing widgetsTomaž Vajngerl6-0/+132
Reviewed-on: https://gerrit.libreoffice.org/82207 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 389c8239c93663fa5546b2f0227a118a3ad091bf) Change-Id: I29239348e36e4963d9708a22ac649b2b1d68bf02 Reviewed-on: https://gerrit.libreoffice.org/82382 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-13tdf#128465: Enable pasting also JPEG images in presentation documentsTor Lillqvist1-1/+10
Change-Id: I0f3254ad536c26c975452f800a464f5498e66a78 Reviewed-on: https://gerrit.libreoffice.org/82507 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82587 Tested-by: Jenkins (cherry picked from commit 9c40a13144cdbb31791ee3e2e7340461a2520af2)
2019-11-13Fix copy/paste error that probably has had no ill effectTor Lillqvist1-1/+1
Change-Id: I062fef5f2316a3aa7560ecb42799496cd38362e9 (cherry picked from commit 6df7989dacd75e8750ddc1b53049d79311feb0d8)
2019-11-10sidebar: check for valid current deck before closingAshod Nakashian1-2/+2
Also, cleanup unused/unnecessary LOKNotifier logic from Deck.cxx and use emplace_back where possible. Change-Id: I300c5158b12593e8130f5b6273c1ea3bcbefea7f Reviewed-on: https://gerrit.libreoffice.org/82402 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-10Resolves: tdf#125198 modeless dialog not appearing in onlineCaolán McNamara1-5/+8
Change-Id: I01916000ba2300a3905fe606301abd8ddadd3770 Reviewed-on: https://gerrit.libreoffice.org/72113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9a78a4a16ff7b9a9d8f22809c5127f6389ec4805)
2019-11-07Drawing calc grid misses pixels on bottom and right; fix.Michael Meeks1-4/+5
Don't attempt to offset empty rectangles causing serious problems. Change-Id: I6fcac11f5f5e03f7edc0662cf4e06e7f8a109f00 Reviewed-on: https://gerrit.libreoffice.org/82220 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06Drawing calc grid misses pixels on bottom and right.Michael Meeks1-0/+4
Change-Id: I2ac7911b35d942b7167a3243d04e1b5710ed367d Reviewed-on: https://gerrit.libreoffice.org/82097 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-04Remove useless bool manipulation.Tamás Zolnai1-2/+0
Must be a left over of sal_Bool -> bool conversion. Change-Id: I8b37e513dc1f36b015b29ce3dad4ade2df7807d9 Reviewed-on: https://gerrit.libreoffice.org/81898 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit f875aca60c46f070e72f61836b33c39b62adcda3) Reviewed-on: https://gerrit.libreoffice.org/82029
2019-11-04Update listbox after scrollSzymon Kłos1-0/+2
To show updated content in the Online after scroll. Change-Id: Ieb58c2a24bfcd76495d7046a0721db789b5c141a Reviewed-on: https://gerrit.libreoffice.org/81967 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit d13cda5236596386cfd3ddaf90b0c5a1ae4cc60d) Reviewed-on: https://gerrit.libreoffice.org/81990 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-10-30tdf#126966: Use larger buttons for the colours in the sidebar on iOS - 2Marco Cecchetti1-0/+3
Attempt to merge this with Noel's re-work of the color picker. Change-Id: I9687546889bc20ef95a50aeafbc6f40e939d57a9 Reviewed-on: https://gerrit.libreoffice.org/81755 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-28headless: optimize DrawWaveLine / drawPixel.Michael Meeks1-14/+6
ImplDrawWaveLine - used to render colored lines under mis-spelled and/or grammatically interesting sections uses (for better or worse) 'drawPixel' to draw the line. Implementing drawPixel with a tiny B2DPolyPolygon is easy reading but triggers the unbelievably expensive SystemDependentDataHolder paths as well as some big chunks of logic for very large numbers of pixels (if you have lots of mis-spelling this can make typing visibly slower.). Change-Id: Ie6ad513e27f820bcad5030579428374c8d22fb3d
2019-10-23jsdilogs: send data for font name & size toolitemsSzymon Kłos1-11/+15
Change-Id: Ia5ea058ba44b3a511a0bdbfc132a7de2d68f2e6b Reviewed-on: https://gerrit.libreoffice.org/81380 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit c7b97f2e4b8f47107bc91ded0295dcfffd0c71b6) Reviewed-on: https://gerrit.libreoffice.org/81395 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-10-22pdfium: Switch the condition for better readibility.Jan Holesovsky1-4/+4
Change-Id: I8acf1e98f032f6943b2e7d09ac276f0f1ac4b120 Reviewed-on: https://gerrit.libreoffice.org/81061 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-10-15jsdialogs: send units for numeric fieldsSzymon Kłos1-0/+85
Change-Id: I63b984856926a613e38319d6d769cab64601c504 Reviewed-on: https://gerrit.libreoffice.org/80692 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 5b08e2023db64741dbe54e36b0fed16395adf98e) Reviewed-on: https://gerrit.libreoffice.org/80783 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-10-11lok: ensure that dialog windows are focused before emitting events.Michael Meeks1-0/+8
Otherwise, we can emit events on a different view's window, causing problems, and cross-user interference. Also emit the key-event on the focused sub-window so event bubbling works. Change-Id: I9dd16c2a256bae58d754f94c6d94a1f3fcdb800b Reviewed-on: https://gerrit.libreoffice.org/80661 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-09lok: Fix the font previews in eg. Format -> Character... dialog.Jan Holesovsky1-1/+3
Change-Id: I5d25249c58f55c501e3e5610419753a68423b0f2 Reviewed-on: https://gerrit.libreoffice.org/67613 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/80261 Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-10-08warning C4245: conversion from 'int' to 'sal_uInt16', signed/unsigned mismatchMike Kaganski1-1/+1
Change-Id: Iafbb9a012dea23edfbf1795f6935d2da23e20f0d Reviewed-on: https://gerrit.libreoffice.org/80501 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-07lok preload: Some symbols are in-process when we need them.Jan Holesovsky1-5/+20
But OTOH in the preload case, the libraries we'd otherwise load are not there. An example was libcuilo.so where the instantiation of the spell checking dialog was failing, because it was impossible to find the makeSentenceEditWindow symbol. Change-Id: Ifc0bc5d8b295912728505fe3ce11fa4a0d198124 Reviewed-on: https://gerrit.libreoffice.org/80230 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-10-07Revert "jsdialogs: send images for toolbox items"Szymon Kłos1-15/+0
We use svg icons from online resources - no need for sending this. This reverts commit 657b73d6be7c0efbbe838b3d3b90276bda702d58. Change-Id: Id98a9704ee88857a0231514b741e63a8a7929e1a Reviewed-on: https://gerrit.libreoffice.org/80212 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 15:46:16 +0000