summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2014-04-02init a few more stream-read svm elementsCaolán McNamara1-18/+21
(cherry picked from commit 67c6ea0c426c2796fc1b80cbe2cb0347686db90d) Conflicts: vcl/source/gdi/metaact.cxx Change-Id: I3dfa2485afbe66131b86764374d53181b55c2346 (cherry picked from commit 21212a65c5653bdc38cea426710e68ed40c66eb8)
2014-04-01valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara1-1/+1
(cherry picked from commit e3dad060929de9beeeed2978f1b1427a91152073) Conflicts: vcl/source/gdi/metaact.cxx Change-Id: Ia0b22f7c394d1c2387d1cad7e3d99c79eaeca81a (cherry picked from commit a37f474a2272c505778774cd1d92897d8a744863)
2014-03-28Related: #i124516# handle bad surrogate pairs gracefully on WindowsHerbert Dürr1-5/+12
When running into invalid Unicode surrogate pairs the text layout code on Windows ran into massive problems like crashes. This change detects the situation of an invalid surrogate pair and falls back to treat it as a simple character instead of requesting a complex glyph fallback. (cherry picked from commit 913f1fc4b1362f6e91595af5ae10c4cba79fd355) Change-Id: I2988f4b64061d0a5df211f6f0f04b1f235fcd6a5 (cherry picked from commit 67688d3118b1a361d5dbdaa78e918815c163d75c)
2014-03-24coverity#705969 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: Icb19931bb529e6c2b98621a603cdb86011d68a9e (cherry picked from commit 51452b7afe858139076010decbe04758321a8396) Reviewed-on: https://gerrit.libreoffice.org/8733 Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2014-03-21coverity#705966 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: I74507ce67f928bdeb626d4070dbd2a45cc126521 (cherry picked from commit 511d8bbbec6bc95d92a3ac6bbac4c68622738706) Reviewed-on: https://gerrit.libreoffice.org/8697 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-12Resolves: fdo#50855 Nimbus Sans L missing stylesCaolán McNamara1-1/+6
Change-Id: Ie8cdcf4ad0ffe52024fd5cfe33073abfc6aadca8 (cherry picked from commit 1e539dbf0fe3894bbf6bf1a0851163b56e37f090) Reviewed-on: https://gerrit.libreoffice.org/8557 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-05fdo#59329 Fix docked window border linesAhmad H. Al Harthi1-14/+38
This patch completes the missing border lines. This is intended for versions 4.1 and 4.2 only. Change-Id: Ib15cb3b01dca4631f643a0036475cf684793d256 Reviewed-on: https://gerrit.libreoffice.org/8413 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-05fdo#59329 fix docked panels bordersAhmad H. Al Harthi1-37/+12
Change-Id: Ia918d644fb57d6fbaeef90c8c1a6806a8d7e589c Reviewed-on: https://gerrit.libreoffice.org/8412 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03Resolves: rhbz#1007697 Update on a Window triggering delete on windowCaolán McNamara1-0/+5
Reviewed-on: https://gerrit.libreoffice.org/8396 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1ec2880679d88c89901ce00fe30dd78e584f6960) Conflicts: svx/source/svdraw/sdrpaintwindow.cxx vcl/source/window/window.cxx Change-Id: Ic6374ce45e3a3ba97217ae77e91f9143f46e277b Reviewed-on: https://gerrit.libreoffice.org/8400 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-01-28Resolves: fdo#74051 support 8430x11700 jpegsCaolán McNamara1-3/+3
Change-Id: I1ca95a496bca80e5e2787af2ccbf0f6cd42455a5 (cherry picked from commit 53c803004554a3a0fff26501357a183bba008a26) Reviewed-on: https://gerrit.libreoffice.org/7697 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-10Use SAL_WNODEPRECATED_DECLARATIONS_PUSH/POP part2Julien Nabet2-0/+4
Change-Id: Id3691ab81af466dd21cc86592c5ac0c2c7a1c8f7 Reviewed-on: https://gerrit.libreoffice.org/6244 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2f8757e961d6156d529c2ab9131747071236f085) Reviewed-on: https://gerrit.libreoffice.org/7362 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-02fdo#39007: blind fix for renamed OS X restore-state fileMichael Meeks1-0/+1
Remove also a potential restorecount.txt file (as reported in the bug) in addition to a potential restorecount.plist. Change-Id: I96fb688e9dda804f240cad8f2109c5880b544302 Reviewed-on: https://gerrit.libreoffice.org/7239 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Signed-off-by: Tor Lillqvist <tml@collabora.com>
2013-12-29Resolves: fdo#72961 Crash when you open ODFver.1.0/1.1 created by LibO-3.5/3.6Julien Nabet1-6/+8
It seems pAction may be NULL so let's keep on to check it. Change-Id: Ie1a48c96bfa930364053c7c3ad0c940559544e33 Reviewed-on: https://gerrit.libreoffice.org/7228 Reviewed-by: Andrzej Hunt <andrzej.hunt@collabora.com> Tested-by: Andrzej Hunt <andrzej.hunt@collabora.com> (cherry picked from commit 6cc888babdc3e6414e55f57c0df65135f2ef4804)
2013-12-19fdo#60705 Don't discard valid printing options.Andrzej Hunt1-1/+1
PPDValue::m_aValue is simply an optional parameter description, whereas m_aOption is the actual option being passed to cups. For example, for the key "PageSize" (which was previously passed without problem), a typical PPDValue could be: m_aOption = "A4" m_aValue = "<</PageSize[595.3 841.9]/ImagingBBox null>>setpagedevice" However for the key "InputSlot" (which was previously not passed to the printer), a typical PPDValue could be: m_aOption = "RearPaperFeedSlot" m_aValue = "" (cherry picked from commit 4c160e3d54ec1c6c04bc80c6cec7ee58e20af3bb) Conflicts: vcl/unx/generic/printer/cupsmgr.cxx Change-Id: I7959317c9f9d67bfafd911e710927a70edfa8792 Reviewed-on: https://gerrit.libreoffice.org/6963 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-05EMF+: force canvas if EMF+ comments are used.Andrzej J.R. Hunt1-0/+7
Without this the drawinglayer renderer is used, whereas only the canvas renderer supports EMF+. Change-Id: Id8a10e400e08c1913e7d6864a51f7b73fc9be437 (cherry picked from commit be7d87bea2611eb316b9b379aebc031179d4f794) Reviewed-on: https://gerrit.libreoffice.org/6940 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-27fdo#61272: Do the mapping correctly both for WMF and EMF.Jan Holesovsky3-34/+1
Turns out that for the WMF, we already had everything set up correctly, we were just overwriting the right settings with default data again :-) - fix that. Includes the following commits: * Revert "wmf-mm-text-1.diff: Fix WMF rendering, n#417818" * Revert "wmf-mm-text.diff: Fix WMF rendering, n#417818" * fdo#56886 EMF: Fixes some scaling problems of clipped regions, Twips Change-Id: I7ff859246dbaea3868438d3632f9adc60fc4ee37 Reviewed-on: https://gerrit.libreoffice.org/6829 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2013-11-26Resolves: fdo#41169 fix MacOSX non-Latin keyboard layout with Latin shortcutsCaolán McNamara1-0/+37
Change-Id: I168de52d6185d5df9c41fd2d7a68c0ff3f733852 (cherry picked from commit 82b5172954261e030a42bd6b3f4acc99807d0ee5) Reviewed-on: https://gerrit.libreoffice.org/6798 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2013-11-25Related: fdo#41169 fix GTK non-Latin keyboard layout with Latin shortcutsCaolán McNamara1-22/+45
See also rhbz#958300 Change-Id: I5c3cf9652adb7b1c9ec53a32ed39f231a09ae1d7 (cherry picked from commit 8cef6c7ec67aec88b339ca647e784afbabf190f8) Reviewed-on: https://gerrit.libreoffice.org/6759 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2013-11-25fdo#67802: Fix PS printing of non-CTL text with ligaturesKhaled Hosny1-7/+5
The GlyphSet::AddGlyphID() was messing with glyphs of characters that can be converted to Windows-1252 encoding, discarding whatever glyph it was asked to use and using a random glyph that is supposed to belong to the converted character. For ligatures this means the ligature glyphs was discarded and the glyphs for its component was used, but this broken for just any glyph substitution. The code makes no sense at all, apart from the fact that it is verbatim copy of GlyphSet::AddCharID() since 9754ad8d979557ea03cbfe04708b62b698d1276c and just happened to work because we did not enable ligatures and other typographic features for non-CTL text before. Change-Id: I764f0b40f8acf61eae38a9038b0666d711c04a9d Reviewed-on: https://gerrit.libreoffice.org/6762 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-25Correctly check getFileURLFromSystemPath() successKhaled Hosny1-1/+1
Change-Id: Iadc34171235fec2d6aafd601f62a0bff8ed5b3ee Reviewed-on: https://gerrit.libreoffice.org/6770 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-25Make TTC fonts work againKhaled Hosny1-10/+4
osl::File::getFileURLFromSystemPath() does not return a boolean. I wonder how this worked before, if it worked at all. Change-Id: Iadc0e06236f43c24cbcd42e4fd79ac9116a58c13 Reviewed-on: https://gerrit.libreoffice.org/6769 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-18Related: rhbz#1014990 valgrind reports uninitialized variableCaolán McNamara1-11/+8
(cherry picked from commit f3660062ce8a2c65d483b83c2800d9b958d12f08) Conflicts: sd/source/filter/eppt/epptbase.hxx Change-Id: Ibaa2ed0ee2f1f3f00bceec91ccced968e4913e47 Related: rhbz#1014990 valgrind reports uninitialized another variable Change-Id: I77f082ea145b0f20daa93c3ee04067ecb6c3b108 (cherry picked from commit b7069ad07dc651f5326cd3a671588d8c1ecf2534) Related: rhbz#1014990 valgrind reports yet another uninitialized variable Change-Id: Idf15ee825a34aa7788c422475aa6cea8ff802581 (cherry picked from commit e0840f70565062b712e544f952640ee35cfb6a27) Related: rhbz#1014990 valgrind reports yet another unint variable Change-Id: Idf6a0a1e12fffee6c090add41247723f1d9cf576 (cherry picked from commit b211b8b2e14bd961a7b32033468a94cbff52b5c4) Reviewed-on: https://gerrit.libreoffice.org/6712 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-11-13Resolves: fdo#71307 out polygons are limited to 16bit point countCaolán McNamara2-0/+5
Change-Id: I4dbe9145466d6d93ebd3dea7f4fe434c9ee3de19 (cherry picked from commit cdd351b1487a8a97f481a9165d9cd361aaee2ca4) Reviewed-on: https://gerrit.libreoffice.org/6655 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-11-08vcl: WORDS_BIGENDIAN is never defined, use OSL_BIGENDIANMichael Stahl2-2/+2
Change-Id: I5186904b9703d6c9c49ca4c3b4a62f83423b1ae1 (cherry picked from commit 94d31d9ad1513504bb1415f0cfe70be380e18b9a) Reviewed-on: https://gerrit.libreoffice.org/6612 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-11-05Resolves: fdo#70588 MultiLineEdits don't need WB_WORDBREAK setNiklas Johansson2-2/+2
and inherits from Edit which reuses that same bit for password Change-Id: I8add146fdbc1b3402b5409f01f75c620da25a313 Reviewed-on: https://gerrit.libreoffice.org/6579 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit af93243d06d81e996c1fae92190bc9622503e25b) Reviewed-on: https://gerrit.libreoffice.org/6589 Reviewed-by: Niklas Johansson <sleeping.pillow@gmail.com>
2013-11-01fdo#70968: Incorrect rendering of Devanagari short 'i' vowelKhaled Hosny2-5/+42
It seems that some Indic fonts assign 'mark' glyph class to combining spacing marks (spacing not non spacing) so my reliance on the glyph class to set the IS_DIACRITIC flags broke those fonts. This is a bandaid to get around the issue, plus some long rant! (at this rate, I'll be writing "The VCL haters handbook" pretty soon). Change-Id: I3ff892acf746d50182573f94e7e8c3c6f9464ae0 Reviewed-on: https://gerrit.libreoffice.org/6485 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-29swap if the host endianness doesn't match the file formatsCaolán McNamara1-18/+27
Change-Id: I0b4c2ba6679c8d2754f2a7cd8b8f693db335e004 Reviewed-on: https://gerrit.libreoffice.org/6408 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-10-29fdo#57659: fix exif processingJulien Nabet2-10/+41
Change-Id: I93bd132b1d536843d4d8627230bfa9ef22cd623b Reviewed-on: https://gerrit.libreoffice.org/6245 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/6407
2013-10-24fdo#70741 fdo#66042 rhbz#968892: force render full grapheme with fallback fontCaolán McNamara3-24/+89
Related: rhbz#968892 discard impossible languages for oriya script fallback Related: rhbz#968892 discard impossible languages for glyph fallback Resolves: fdo#66042 get the bounds of the current grapheme (also includes Change-Id: I14f1bab09eb0be9c2c896a1dde45913b99aab6df) (also includes Change-Id: I5b1808d74f0a1dd0d8b6ea22136e574c0a6e8e2a) (also includes Change-Id: I5bb98c61d047e69d74666261b2c489d80f344502) Change-Id: I46d8cacba2b8ca0f24e1c4ba836839387d74e1a4 Reviewed-on: https://gerrit.libreoffice.org/6398 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-10-18Fix build against the 10.8 SDKTor Lillqvist1-0/+6
Change-Id: I74adcca901e9a7c31d02779b1ee853731a55ea43 Reviewed-on: https://gerrit.libreoffice.org/6253 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-10-15CID#736943 clamp no of ttc entries to physical maxCaolán McNamara1-0/+33
Change-Id: Ic63defe9c14c6ee2b86bd5b7730a570238ca3981 (cherry picked from commit 225539ab08043b6937fdd67d9ae308ebd4104646) Reviewed-on: https://gerrit.libreoffice.org/6150 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-10Prevent out-of-bounds arguments to OUString::copyStephan Bergmann1-1/+3
...which would somewhat unhelpfully result in returning "!!br0ken!!" (partial backport of 34e951bd7284d2e771c279e3adc3899d191fdad0 "More OUString::copy out-of-bounds fixes") Change-Id: Ibf66d218fe5f0d7b6216795a3b991705d4afda73 Reviewed-on: https://gerrit.libreoffice.org/6183 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-04Resolves: #i123417# handle subsetting of empty ttf compound glyphs gracefullyHerbert Dürr1-2/+5
(cherry picked from commit d519b07ecd4b67cedf1fe3e1860ef33a48a01ae4) Signed-off-by: Caolán McNamara <caolanm@redhat.com> Conflicts: vcl/source/fontsubset/sft.cxx Change-Id: I51d4a97f1f01be49cb5ab058019cd153e23437bd (cherry picked from commit 6489f97fc428446c53c17f885963776cdcc21490) Signed-off-by: Caolán McNamara <caolanm@redhat.com>
2013-10-04rhbz#1001768: AtkListener::disposing(): delay notificationMichael Meeks1-5/+20
Frame #10 in libatk-bridge.so calls atk_misc_threads_enter(), and having a look at the RHEL 6.5 at-spi package in ./at-spi-1.28.1/atk-bridge/bridge.c there is always the same call pattern: bridge_threads_leave (); [one function call] bridge_threads_enter (); ... so the bridge_threads_leave() has called the VCL gtk-plug function GtkHookedYieldMutex::ThreadsLeave() which releases the SolarMutex. This is of course not a good idea while there is a Window being deleted, and is the reason why the same Window is being deleted in thread 1 and thread 2: 31 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 16 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 Try to avoid the problem by delaying the atk_object_notify_state_change() that will release SolarMutex until idle, when deletion of the Window is finished. Thread 2 (Thread 0xfff4cbcf110 (LWP 17011)): 2 0x0000008013c6e718 in .pthread_mutex_lock () from /lib64/libc.so.6 3 0x000000801576e4fc in osl_acquireMutex (Mutex=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/sal/osl/unx/mutex.c:114 4 0x00000fff963a7908 in acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/osl/mutex.hxx:58 5 ClearableGuard (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/osl/mutex.hxx:177 6 cppu::WeakAggComponentImplHelperBase::dispose (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/implbase.cxx:392 7 0x00000fff5f1b3444 in comphelper::disposeComponent<com::sun::star::accessibility::XAccessible> (_rxComp=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/comphelper/types.hxx:114 8 0x00000fff5f273ba8 in VCLXAccessibleToolBox::implReleaseToolboxItem (this=<value optimized out>, _rMapPos=<value optimized out>, _bNotifyRemoval=<value optimized out>, _bDispose=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:326 9 0x00000fff5f2747e4 in VCLXAccessibleToolBox::ProcessWindowEvent (this=0xfff5f8b8fe0, rVclWindowEvent=...) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:612 10 0x00000fff951e4ad4 in VCLXAccessibleComponent::WindowEventListener (this=0xfff5f8b8fe0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:136 11 0x00000fff951e4b20 in VCLXAccessibleComponent::LinkStubWindowEventListener (pThis=<value optimized out>, pCaller=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:121 12 0x00000fff946dd420 in Call (this=0xfff702b32a0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/tools/link.hxx:123 13 VclEventListeners::Call (this=0xfff702b32a0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/vclevent.cxx:66 14 0x00000fff94a4bab0 in Window::CallEventListeners (this=0xfff702b2d30, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5272 15 0x00000fff94a4bc80 in Window::ImplCallEventListeners (this=<value optimized out>, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5255 16 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 17 0x00000fff94a61138 in Window::~Window (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4683 18 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff6801f010) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56 19 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff6801f010) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957 20 0x00000fff953c5f28 in UnoWrapper::WindowDestroyed (this=<value optimized out>, pWindow=0xfff70115a80) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/helper/unowrapper.cxx:263 21 0x00000fff94a60130 in Window::~Window (this=0xfff70115a80, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4334 22 0x00000fff949cc8b4 in DockingAreaWindow::~DockingAreaWindow (this=0xfff70115a80, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockingarea.cxx:96 23 0x00000fff949cc918 in DockingAreaWindow::~DockingAreaWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockingarea.cxx:96 24 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff6801c310) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56 25 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff6801c310) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957 26 0x00000fff953c5f28 in UnoWrapper::WindowDestroyed (this=<value optimized out>, pWindow=0xfff7001a320) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/helper/unowrapper.cxx:263 27 0x00000fff94a60130 in Window::~Window (this=0xfff7001a320, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4334 28 0x00000fff94a1f7fc in SystemWindow::~SystemWindow (this=0xfff7001a320, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/syswin.cxx:89 29 0x00000fff94a6c744 in WorkWindow::~WorkWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/wrkwin.cxx:150 30 0x00000fff94a6c7e8 in WorkWindow::~WorkWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/wrkwin.cxx:150 31 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff8c486f48) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56 32 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff8c486f48) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957 33 0x00000fff88258ec0 in framework::Frame::impl_disposeContainerWindow (this=<value optimized out>, xWindow=...) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:2689 34 0x00000fff8826d71c in framework::Frame::dispose (this=0xfff8c308a08) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:1887 35 0x00000fff88263018 in framework::Frame::close (this=0xfff8c308a08, bDeliverOwnerShip=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:1650 36 0x00000fff88255908 in framework::Desktop::impl_closeFrames (this=<value optimized out>, bAllowUI=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/desktop.cxx:1928 37 0x00000fff88256120 in framework::Desktop::terminate (this=0xfff8b3de388) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/desktop.cxx:292 Thread 1 (Thread 0xfff930e82a0 (LWP 16956)): 2 0x0000008013c6e718 in .pthread_mutex_lock () from /lib64/libc.so.6 3 0x000000801576e4fc in osl_acquireMutex (Mutex=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/sal/osl/unx/mutex.c:114 4 0x00000fff946cd114 in vcl::SolarMutexObject::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/solarmutex.cxx:35 5 0x00000fff94a6ecb8 in SalYieldMutex::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/generic/app/geninst.cxx:49 6 0x00000fff8c24cb90 in GtkHookedYieldMutex::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/app/gtkinst.cxx:91 7 0x00000fff8c24cd2c in GtkHookedYieldMutex::ThreadsEnter (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/app/gtkinst.cxx:64 8 0x00000fff8b6dfabc in ?? () from /usr/lib64/gtk-2.0/modules/libgail.so 9 0x00000fff8b9f333c in .atk_misc_threads_enter () from /usr/lib64/libatk-1.0.so.0 10 0x00000fff8c1d534c in ?? () from /usr/lib64/gtk-2.0/modules/libatk-bridge.so 11 0x00000fff8c1d65fc in ?? () from /usr/lib64/gtk-2.0/modules/libatk-bridge.so 12 0x00000fff936af4e0 in ?? () from /lib64/libgobject-2.0.so.0 13 0x00000fff936b13d0 in .g_signal_emit_valist () from /lib64/libgobject-2.0.so.0 14 0x00000fff936b18f8 in .g_signal_emit () from /lib64/libgobject-2.0.so.0 15 0x00000fff8b9e5f3c in .atk_object_notify_state_change () from /usr/lib64/libatk-1.0.so.0 16 0x00000fff8c23083c in AtkListener::disposing (this=0xfff5f98dbc8) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/a11y/atklistener.cxx:81 17 0x00000fff963aee2c in cppu::OInterfaceContainerHelper::disposeAndClear (this=<value optimized out>, rEvt=...) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/interfacecontainer.cxx:316 18 0x00000fff9659d944 in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing (_nClient=<value optimized out>, _rxEventSource=...) at /usr/src/debug/libreoffice-4.0.4.2/comphelper/source/misc/accessibleeventnotifier.cxx:162 19 0x00000fff9659b20c in comphelper::OAccessibleContextHelper::disposing (this=0xfff5f8bb7e0) at /usr/src/debug/libreoffice-4.0.4.2/comphelper/source/misc/accessiblecontexthelper.cxx:130 20 0x00000fff5f275898 in VCLXAccessibleToolBoxItem::disposing (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolboxitem.cxx:265 21 0x00000fff963a79fc in cppu::WeakAggComponentImplHelperBase::dispose (this=0xfff5f8bb7e0) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/implbase.cxx:404 22 0x00000fff5f1b3444 in comphelper::disposeComponent<com::sun::star::accessibility::XAccessible> (_rxComp=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/comphelper/types.hxx:114 23 0x00000fff5f273ba8 in VCLXAccessibleToolBox::implReleaseToolboxItem (this=<value optimized out>, _rMapPos=<value optimized out>, _bNotifyRemoval=<value optimized out>, _bDispose=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:326 24 0x00000fff5f2747e4 in VCLXAccessibleToolBox::ProcessWindowEvent (this=0xfff5f8b8fe0, rVclWindowEvent=...) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:612 25 0x00000fff951e4ad4 in VCLXAccessibleComponent::WindowEventListener (this=0xfff5f8b8fe0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:136 26 0x00000fff951e4b20 in VCLXAccessibleComponent::LinkStubWindowEventListener (pThis=<value optimized out>, pCaller=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:121 27 0x00000fff946dd420 in Call (this=0xfff702b32a0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/tools/link.hxx:123 28 VclEventListeners::Call (this=0xfff702b32a0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/vclevent.cxx:66 29 0x00000fff94a4bab0 in Window::CallEventListeners (this=0xfff702b2d30, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5272 30 0x00000fff94a4bc80 in Window::ImplCallEventListeners (this=<value optimized out>, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5255 31 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 32 0x00000fff949d41c4 in DockingWindow::~DockingWindow (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockwin.cxx:473 33 0x00000fff94a35944 in ToolBox::~ToolBox (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/toolbox.cxx:1698 34 0x00000fff88343e40 in framework::ToolBar::~ToolBar (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/uielement/toolbar.cxx:35 35 0x00000fff88343e88 in framework::ToolBar::~ToolBar (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/uielement/toolbar.cxx:35 36 0x00000fff94a66a00 in ~LazyDeletor (this=0xfff40007720, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/vcl/lazydelete.hxx:162 37 vcl::LazyDeletor<Window>::~LazyDeletor (this=0xfff40007720, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/vcl/lazydelete.hxx:164 38 0x00000fff94998868 in vcl::LazyDelete::flush () at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/helper/lazydelete.cxx:54 39 0x00000fff946d2294 in ImplYield (i_bAllEvents=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:434 40 Application::Yield (i_bAllEvents=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:463 41 0x00000fff946d22f8 in Application::Execute () at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:408 Change-Id: Ic742442dd6ffeba59655c2e66df8dbabc906f061 (cherry picked from commit c3ef735fd5d8866c8ce28b89744150e733087427) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2013-09-17Fix fdo#69381 by skipping empty option groupsArnaud Versini1-0/+5
Change-Id: Idaf0f0a3f5430a5aea6f77a003e205116a87cc67 Reviewed-on: https://gerrit.libreoffice.org/5949 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/5972
2013-09-06fdo#68313 fix combining diacritics problem with Graphite fontsLászló Németh1-3/+3
Change-Id: Ied29f864dc5fc21fc55aaa5ddd40b02b53a564f8
2013-09-06Resolves: fdo#68081 why would I want a spinner that doesn't repeatCaolán McNamara1-1/+1
surely WB_SPIN should imply repeat in the first place, *shrug* Change-Id: I1e4cb5a01d473cd0f8d907d566cd26d51a81da93 (cherry picked from commit f96771165ea145a759f1bab76cd34bb70def04f6) Reviewed-on: https://gerrit.libreoffice.org/5839 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-09-06Fix misspelled text with VoiceOver on 10.9Boris Dušek1-0/+1
More in Apple's docs (Application Kit Release Notes for OS X v10.9, section "New Accessibility constants"). Change-Id: I92fb6d552e86997bfc789723f32626d908d11419 Reviewed-on: https://gerrit.libreoffice.org/5833 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2013-09-05Consistently use rtl_getAppCommandArg hereStephan Bergmann1-1/+1
...2a9c1d1a75b7d4e79dfbc6be3dada1a1e959e58e "Make dialogs fail with an exception in headless tests" missed one of the osl_getCommandArg calls, which can lead to problems when there are any -env: arguments preceeding the --display argument. Reported by renduly on IRC. Change-Id: I98dd24be840d561dce51034088f3e44adff9f2ff (cherry picked from commit 379a53017447fbf2a459f82ae8905b6683e80e8d) Reviewed-on: https://gerrit.libreoffice.org/5821 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-04fdo#68731: vcl: fix path for bundled fonts on WindowsMichael Stahl1-1/+1
WinSalGraphics::GetDevFontList(): remove the obsolete "Basis" from the search path to find the bundled fonts. (cherry picked from commit c91f7082180d1ca90467891f3b7ca9a3e845d9e7) Conflicts: vcl/win/source/gdi/salgdi3.cxx Change-Id: I7d7d650243592944e3339dd75caf29f2b2fe6670 Reviewed-on: https://gerrit.libreoffice.org/5796 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-09-03always call setDeferredProperties for dialog get/set titleCaolán McNamara2-2/+15
so we always get the correct up to date title even if we have been holding off on setting some properties to ensure that virtual method aren't called during construction e.g. insert/edit index marks is always "Insert Index Mark" (cherry picked from commit 31fc0b74425253589b2ac0dcecb9e8a2714954b4) Change-Id: I57f9cc8fbdb9d2a304c346e03893fa55d6a61bd5 Reviewed-on: https://gerrit.libreoffice.org/5762 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-09-03Resolves: rhbz#993963 NULL m_pWindow on firefox deleted pluginCaolán McNamara1-1/+1
Change-Id: Idb12b12e4313668bf3390a97551c688ee0dcde67 (cherry picked from commit 4a4ed52e57b540167c3ca45e6e762b9e21e874de) Reviewed-on: https://gerrit.libreoffice.org/5773 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-09-03stop annoying temp full screen windows appearing on insert->index entryCaolán McNamara1-0/+8
Change-Id: I730617f5ce28149f79d1d22efbfb7eab22e5840d (cherry picked from commit 8f6b90a80c7b6e1c19422e944ca49657581e1042) Reviewed-on: https://gerrit.libreoffice.org/5761 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-09-01cppcheck: Array index is used before limits checkJulien Nabet1-1/+1
Change-Id: I531430ce4bc0937a023d3e2849ae07d8f94e3e70 Reviewed-on: https://gerrit.libreoffice.org/5723 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-30Resolves: fdo#68396 Yield allowed layout timer to run during init layoutCaolán McNamara1-1/+1
There are multiple pages getting generated in the styles dialog because the dropcaps preview window calls "Yield" sometimes and sometimes the layout timer gets a chance to activate *during* the creation of the dialog so there ends up with two consecutive activations of some tabpages which has wonderful eventual know on effects resulting in that crash later on. Easiest thing is to disable the layout timer during the initial size calculation Change-Id: I7fb0a7ff89aa2c6013c5d8014deface107610000 (cherry picked from commit fe1cbda3b7513e0d3686d347aa991e7231067384) Reviewed-on: https://gerrit.libreoffice.org/5696 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-29Resolves: fdo#68192 always recode from trad symbol to apple symbolCaolán McNamara1-10/+11
Even if the symbol font bit isn't set, the oox import route lacks the ability to state that the bullet font is a font of symbol encoding. If the font is not available on the system we go into fallback logic to state that famous symbol fonts are in symbol encoding. But there is a symbol font on mac so its not unknown and that doesn't happen. And the mac symbol font is not actually in symbol encoding (seeing as it's all rearranged into the correct unicode positions) so the recode logic is skipped in this special case to map the microsoft/adobe private use area chars to the modern code points where they were moved in the apple font. I guess one alternative possible solution is to lookup all the fonts used in a openxml doc using the fonttable stream where the charset info is available. But seeing as it should only affect one particular font lets just move the encoder test outside the issymbol block. Change-Id: Ic5bd3ec15c8d8d99e2cab0fb67cc4bc33081c756 (cherry picked from commit b129867306ce918f4f8fbf9ec5f7dce86e52c9d2) Reviewed-on: https://gerrit.libreoffice.org/5669 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-27Related: fdo#68192 register bundled fontsCaolán McNamara1-28/+28
We have to register them one at a time, like windows, this means we detect our bundled opensymbol which makes the "format->bullets and numbering" preview work again. Doesn't however fix fdo#68192 yet, more magic smoke required. (cherry picked from commit 8efbafaf8681d39c8c3674368e02ddd572ba5d32) Conflicts: vcl/coretext/salgdi2.cxx Change-Id: I430c91b48d96fb8d62e3b073898b72cf2b8ddea6 Reviewed-on: https://gerrit.libreoffice.org/5647 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-08-26rhbz#1000150: Do not call exit upon XIOErrorStephan Bergmann2-21/+16
...as done in _XIOError (libX11-1.6.0/src/XlibInt.c) after calling the XIOError handler function (either the one supplied with XSetIOErrorHandler or _XDefaultIOError), as that calls the atexit handlers, which can wreak havoc in unrelated threads that happen to be running in parallel, leading to arbitrary crashes. So avoid that by always calling _exit already from our XIOError handler. The old code was careful to /not/ call _exit when the XIOError happened on any thread but the main one, but I do not see the sense of that---after all, _XIOError will inevitably call exit afterwards, so this cannot be a way to "ignore" XIOErrors from special threads (that are set up say for the sole purpose of trying out "known-shaky" activities without affecting the stability of the whole process). And findings like comment 12 to <https://bugzilla.redhat.com/show_bug.cgi?id=831628#c12> "[abrt] libreoffice-core-3.5.4.2-1.fc17: ICEConnectionWorker thread still running during exit" ("it is very likely that this is not a normal exit from reaching the end of main, but rather some explicit call to exit from some error handling code") make it clear that we apparenly do suffer from such calls to _XIOError -> exit on non-main threads. I have no idea why vcl/unx/gtk has its own XIOErrorHdl that is substantially different from the vcl/unx/generic one, though. cherry picked from commit ffea65915b9cc6d4f3c01f829552702654a040f9, plus follow-up b240a1c188b58e3e717335339bfc3f5e20bb2bf4: rhbz#1000150: Do not call exit upon XIOError, take two The _XDefaultIOError handler (libX11-1.6.0/src/XlibInt.c) already calls exit (even though _XIOError calling _XDefaultIOError would call exit afterwards, too), so our XIOError handler must not call aOrigXIOErrorHandler. Change-Id: Ida7d407cf5f0fa4e719118cab5e725144ceb3a35 Reviewed-on: https://gerrit.libreoffice.org/5593 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-24Fix build with compiler from OS X 10.6 SDK (hopefully)Boris Dušek1-4/+4
The compiler in 10.6 SDK probably still requires methods to be defined in such an order that one should not reference a method from a line of code that precedes the one where the method is defined. Compilers in newer SDKs support arbitrary order, as long as the requested method is defined anywhere. This is consistent with other methods in the same file that are not declared anywhere (just defined and used apparently in the order I wrote above). Change-Id: I14ba699056b6cdd2e804dbc87cfedaef47663664 Reviewed-on: https://gerrit.libreoffice.org/5577 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-24Don't re-create Unicode and font functions for every text runKhaled Hosny1-2/+11
Change-Id: I35ba21d753adfc619656d4473b214485dc00faba Reviewed-on: https://gerrit.libreoffice.org/5599 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
generated by cgit v1.2.1 (git 2.18.0) at 2023-11-30 10:13:21 +0000