summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2016-07-28opengl: improve logging when no context is availableTomaž Vajngerl1-1/+1
Change-Id: Ie747db5f46b0a83bda44d211b0ac69bc19092fbc Reviewed-on: https://gerrit.libreoffice.org/27615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28opengl: don't initialize MSAA when we create VCL contextTomaž Vajngerl1-2/+7
Change-Id: Ic8060ebdabb86d8b724ee419fdfcc1f58e8a0316 Reviewed-on: https://gerrit.libreoffice.org/27614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28opengl: improve context creation, temp window creation on windowsTomaž Vajngerl1-15/+37
If anything fails at context creation then don't forget to deallocate resources. Temp window creation is written C like, as it was copy/pasted from an C example. Change-Id: Ia9d704e42206b1d4c37db2954bba4f165e3c8389 Reviewed-on: https://gerrit.libreoffice.org/27613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28tdf#100915 draw antialiased line just for polygon outlineTomaž Vajngerl1-11/+4
To get the anti-aliased polygon we draw a anti-aliased line around every trapezoid. This works fine until we draw a transparent polygon where the lines become visible because of blending. A much better and faster way is to just draw the polygon outline with anti-aliased lines. This is done with this commit. Change-Id: Ice50e5eb3343f2c5d51ade8ad0e170043541f0ff Reviewed-on: https://gerrit.libreoffice.org/27611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28add rtf to fftesterCaolán McNamara1-0/+13
Change-Id: If00b1de1e1be16214df78d15554d95847e3239e7
2016-07-28tdf#101026 Create more correct replacement control vectorArmin Le Grand3-13/+16
Change-Id: I909adaab3dca3c1bac4331b164343cdbc1205df2 Reviewed-on: https://gerrit.libreoffice.org/27365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-07-28vcl: remove Application::InsertIdleHdl() and ImplIdleMgrMichael Stahl5-200/+0
This is obsolete since 5.0 introduced the new Idle scheduler. Change-Id: I8555fe35e2befb0cc2a4c39ae469a5c32a32fcb9 Reviewed-on: https://gerrit.libreoffice.org/27598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-07-28Resolves: tdf#101132 a11y crash in hyperlinkCaolán McNamara1-0/+2
regression from... commit aa6c54f337a616c9ca6a39cfc8708657018d8613 Date: Mon Jan 18 09:01:15 2016 +0200 loplugin:unusedfields Change-Id: Ic2b7fe5f2d49a447a9936c4fb04bafcc7349ecf9
2016-07-28vcl: Guard against invalid statesSamuel Mehrbrodt3-1/+4
Got crashes here in 5.0, seem to be gone in master, but better be safe than sorry Change-Id: I434800f0e4a465233024b6a1ae1f48b010319f5c Reviewed-on: https://gerrit.libreoffice.org/27594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-27cppcheck: noExplicitConstructorCaolán McNamara2-2/+2
Change-Id: Id0a6cd461b2ba56e3b9b944514f3b0d0eb75cc44
2016-07-27loplugin:defaultparamsTor Lillqvist1-1/+1
Change-Id: Ib9a838b9d840baff62f1a0453eb370b6f665326d
2016-07-27improve passstuffbyref return analysisNoel Grandin18-25/+25
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27Don't Update() and Flush() status bar drawsJan-Marek Glogowski1-10/+2
From reading the code of vcl::Window::Update, this already calls Invalidate and Flush in case of top-level widgets and also handles child windows. And there is no need to invalidate the progress bar text, if we just update the progress value. Change-Id: Ie296c6ffe5db5a927ad69104ce8ffe3d0d29034a Reviewed-on: https://gerrit.libreoffice.org/27285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27loplugin:countusersofdefaultparams in tools..xmlsecurityNoel Grandin22-35/+35
find methods with default params with only zero or one call site Change-Id: Ie5b30f60e9fe00ba1acf0dfc79b005ded46f05a0 Reviewed-on: https://gerrit.libreoffice.org/27512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26tdf#101138 opengl: blacklist intel drivers for Win 7Tomaž Vajngerl1-0/+3
Change-Id: I1b3db15b2fbdd948dcc9bacf7891f8429f066150
2016-07-26tdf#75757 Remove inheritance to std::vectorTakeshi Abe2-11/+77
Change-Id: I2ddaaf52f27b5297bda58a045946e87a24b66a83 Reviewed-on: https://gerrit.libreoffice.org/27536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-26loplugin:overrideparamCaolán McNamara1-1/+1
Change-Id: I5d6c249875e4dcebc63e8d0fcdddfcb48e8df18a
2016-07-25opengl: log device/driver info, remove unneeded info messagesTomaž Vajngerl2-3/+21
Change-Id: Ica3698d0dbff1ee7a1e822d2765eb4019ccef224 Reviewed-on: https://gerrit.libreoffice.org/27498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-25opengl: check supported texture size on first GL initTomaž Vajngerl1-0/+31
Change-Id: I27ef828a8d47d50adbbcc3fb0fd152f4f6ffc446 Reviewed-on: https://gerrit.libreoffice.org/27497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-25opengl: add VCL_GL_WARN to write warnings into api trace fileTomaž Vajngerl1-4/+15
Change-Id: I416de926a769dccdf1c53072c1f7dda817c5402a Reviewed-on: https://gerrit.libreoffice.org/27496 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-25new loplugin overrideparamNoel Grandin10-15/+15
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-24don't use AA in SVP backend when getAntiAliasB2DDraw is falseTomaž Vajngerl1-1/+5
Change-Id: Icea880a824f57ca74eb9e22820893faf6cbf7945
2016-07-24For a failing image load, indicate themeJulien Nabet1-0/+3
(only in case OSL_DEBUG_LEVEL>0) Change-Id: I31217c72c9bddaa748a5980252b40d025c76b730 Reviewed-on: https://gerrit.libreoffice.org/27473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-07-22Resolves: tdf#100838 no transparency support on using original jpg data pathCaolán McNamara1-1/+10
This became a problem since... commit 76ec54e8c9f3580450bca85236a4f5af0c328588 Author: Michael Meeks <michael.meeks@collabora.com> Date: Mon Feb 8 14:24:15 2016 +0000 tdf#97662 - Try to preserve original compressed JPEGs harder. Avoiding de-compressing and re-compressing them saves lots of time too. for the default JPEG Compress + Reduce Image resolution case but appears to always be a problem with the Lossless - Reduce Image resolution case. Change-Id: I24c69a59a16d69817e402cd87f84e744ee146a66
2016-07-22GSoC notebookbar: better default page handlingSzymon Kłos1-1/+16
+ selected default tab page in the Impress + the default tab page is set when context isn't supported + switching between unsupported contexts is not causing switch to default tab to avoid closing of tab which was recently used by user Change-Id: Ieeda8a79e6c67708551351f9bb49d8b006c0e74f Reviewed-on: https://gerrit.libreoffice.org/27432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-22GSoC notebookbar: file menuSzymon Kłos4-5/+46
+ added icon to the notebookbar, after click the file menu will appear Change-Id: I30e1ed7e2c4a194e150c7196652904fd4e5c9e8e Reviewed-on: https://gerrit.libreoffice.org/27347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-21These fixes aren't needed after all.Caolán McNamara2-8/+0
The root problem was instead fixed by... commit 144e73f50c49333f61c6f27b882be9dbc232ceb4 Author: Noel Grandin <noel@peralex.com> Date: Tue Dec 22 09:05:32 2015 +0200 fix Link::operator< so that it is consistent with operator== Revert "Related: rhbz#1343766 a11y queries during dispose trigger listbox crashes" This reverts commit c615943bda57eadfa73c14a7314938aabe0bd16f. Revert "Resolves: rhbz#1343766 a11y queries during dispose trigger combobox crashes" This reverts commit f120abb446bf3f5230ed06a3b148654dde36bb94.
2016-07-21memset hammer for -Werror=missing-field-initializersCaolán McNamara1-1/+2
Change-Id: I025bc48edad9fd0275f264a71e13dacd4c5bcc96
2016-07-21Resolves: tdf#100558 last 'section' of date field not incrementedCaolán McNamara1-1/+1
presumably a regression from... commit 3cad6c806e5247ce20b78eb688551aa5d872b934 Author: Chr. Rossmanith <ChrRossmanith@gmx.de> Date: Fri Mar 1 21:47:10 2013 +0100 Replace (Xub)String with OUString in vcl(field) where UniString::Search returned a max short on not-found while OUString::indexOf returns a -1 Change-Id: Ia3ef80dd318375ccdb3bdcee9bed7b70bf67cae1
2016-07-21gtk3-a11y: our eventbox is inside a grid nowCaolán McNamara1-1/+5
Change-Id: Icb49d6274b09fb426ab6c0f9f67b7c71c4ef9a31
2016-07-21Resolves: tdf#101011 atk needs a value for accessible-table-column-headerCaolán McNamara1-1/+14
This presumably became a problem after... commit 76c549eb01dcb7b5bf28a271ce00e386f3d388ba Author: Steve Yin <steve_y@apache.org> Date: Fri Nov 29 13:03:27 2013 +0000 Integrate branch of IAccessible2 added a TABLE_COLUMN_HEADER_CHANGED usage which triggered it. Change-Id: If54b7a39a170566cf7def3548ba385fa5d99bb1c
2016-07-20vcl: don't use the faster cairo code path when using OpenGLTomaž Vajngerl2-4/+6
Change-Id: Ia5f2fbf8765db4828338df4eb1f6d7405004e738
2016-07-20Resolves: tdf#100903 Calc hangs when preediting Japanese with GTK pluginTakeshi Abe2-0/+4
... + Mozc. This issue shares a common root with tdf#56937. Change-Id: Ic5720c19f22f7e6b047e1251b34f90d04ce7eee7 Reviewed-on: https://gerrit.libreoffice.org/27305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-19Revert "hack for now"Caolán McNamara3-2/+209
This reverts commit f5792667cafef77cc4c142f4261f8b64280bc0fe. it turns out it was the use of an intermediate GtkGrid which made a11y work a little differently under gtk3. Clearly not intended to be pushed. Change-Id: I6931163e07ea413acdd45ba1353f357d317fdfbd
2016-07-19hack for nowCaolán McNamara3-209/+2
Change-Id: I62673e60ac8785c74fc4f97ad76bcb02c7e28941
2016-07-19use CAIRO_FILL_RULE_EVEN_ODD by defaultCaolán McNamara1-0/+1
as seen in tdf#100909 with gtk3 backend Change-Id: I67a270a96df980489cd2cb37461b3bf88de4df03
2016-07-19clang-tidy performance-unnecessary-value-param in vclStephan Bergmann11-20/+20
Change-Id: I0b53c4bf5b4619cde357cf4eb432b153b1f7e6b5
2016-07-18Resolves: tdf#100731 include palette in checksumCaolán McNamara1-1/+2
Change-Id: I084d840b9fa078ebea3ff1471d8c8bc88171abc7
2016-07-18vcl: This seems a missing returnTakeshi Abe2-2/+2
Change-Id: I99c3be904e9ee2ad8f76d09d1d8998a6898fb81e Reviewed-on: https://gerrit.libreoffice.org/27283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-18GSoC notebookbar: don't show empty space for hidden tabsSzymon Kłos3-72/+418
Change-Id: Ia00f64c1cb5d990e852cc297b6b7bd76df4b1b05 Reviewed-on: https://gerrit.libreoffice.org/27191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-18add tagging to ThreadTasks so we don't need more one poolNoel Grandin1-3/+5
If more than one place in the code submits tasks to the shared pool, then waitTillDone() becomes unreliable. Add a tagging mechanism, so different callsites can wait on different sets of tasks. Also try to protect our worker threads against exceptions from the thread tasks code. Change-Id: Idde664ab50008d31a2dd73910bb22f50e62ae22f Reviewed-on: https://gerrit.libreoffice.org/27042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-17uitest: recognize function keys in keycodesMarkus Mohrhard1-1/+34
Change-Id: I0246b21d88aa43e36728c556b22372a8c04299fe
2016-07-17uitest: add 2 more properties for listboxesMarkus Mohrhard1-0/+2
Change-Id: Id8fb7973f868c12f920051ef3719ed0ff0712828
2016-07-15loplugin:nullptrStephan Bergmann1-1/+1
Change-Id: I35e2ee930d29cc8547a0fcf39d199727d7815748
2016-07-15new loplugin unnecessary overrideNoel Grandin9-50/+0
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-14vcl headless: ignore visibility in GetClientSize()Miklos Vajna2-14/+2
This fixes the missing-invalidation problem outlined in commit 22023b104cd1e024aecc28a6161bea519a584407 (vcl lok: fix missing paints due to zero-sized windows, 2016-07-12) also in Writer, not only in Impress. Starting text edit, doing a change, and ending text edit now results in the expected invalidations. Ignoring visibility seems to be a better fix for the missing paints. This way the headless case doesn't hit the corner cases of 0x0-sized windows. Also, the gtk vclplug's GetClientSize() only returns 0x0 in case the underlying window is disposed or it's minimized, but it does hand out the size before Show() is called, so now the headless backend is in sync with that. Change-Id: I78698cbfce954c8c593d279ab057a87cfbe87260 Reviewed-on: https://gerrit.libreoffice.org/27224 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-13Related: rhbz#1343766 a11y queries during dispose trigger listbox crashesCaolán McNamara1-0/+2
though not able to reproduce, I have an in-house complaint similar to commit f120abb446bf3f5230ed06a3b148654dde36bb94 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jun 8 11:35:15 2016 +0100 Resolves: rhbz#1343766 a11y queries during dispose trigger combobox crashes except with a listbox in the bt Change-Id: Id31561e009a1f0ec9272a0e7216296e4017e5688
2016-07-13Remove __cplusplus-checks from apparently-C++-only filesStephan Bergmann2-8/+0
Change-Id: I87e9ce45cf945e75e8140a9d4608da8abcddada6 Reviewed-on: https://gerrit.libreoffice.org/27187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-13Make TooltipLabel default to PopupLabelSamuel Mehrbrodt1-2/+8
Because we often have similiar tooltip and menu names. Change-Id: I0ab66269b0b1f2985f23cf92289b3da69b6ddfd3 Reviewed-on: https://gerrit.libreoffice.org/27186 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-13no need to create temporary OUString for comparisonNoel Grandin1-3/+3
Change-Id: I0a321e8ffbe379588a288084ec2e74e1a8c296b2 Reviewed-on: https://gerrit.libreoffice.org/27171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>