summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2021-04-16tdf#140639 cache FcPattern for font optionsCaolán McNamara4-22/+117
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> also includes... getFontOptions is always called with pitch of PITCH_DONTKNOW getFontOptions is called from only one location and there the pitch value is left at its default PITCH_DONTKNOW which is suspicious but that's the way it currently is Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> use original FontAttributes instead of an intermediate FastPrintFontInfo Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> hintstyle is unused left behind after... commit 561a02ec72cf963d7cd59cfb9a183c1032f0861b Date: Thu Jun 15 15:28:46 2017 +0200 loplugin:unusedfields in vcl part3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Change-Id: Ibb1b1e06630e505924e05ea4b5b454e58738d743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114140 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 365df37004630b68afafdc676e26f2599c2194a9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114011 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-14tdf#141623 Qt5+cairo init surface with widget sizeJan-Marek Glogowski1-4/+4
The QFont based rendering path directly uses the widgets size to initialize the QImage buffer image, so do the same for the Cairo surface, instead of the arbitrarily size of 640x480. Change-Id: I91326dab67cbbb5e75b78b02c34eaca61ad26482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113955 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 91c883e75436210ca8af95df1ca597caeeda8703) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113869 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 3f204ca2fed7614e1e12180af5ce5bfd88249eb7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113870 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-12Related tdf#117750: fix "Solarization" and "Aging"Julien Nabet2-2/+2
For solarization, regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=c38485279cd36da96ac81107d567ea4e779b2b96 author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:27:41 +1000 committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:11 +0200 commit c38485279cd36da96ac81107d567ea4e779b2b96 (patch) tree ad9843a17f87271f9e0cf89643e2e6c3ee8a8de1 parent bcbf767bcfc024e2be839e0c0886f942dd068e4f (diff) vcl: ImplSolarize() to BitmapSolarizeFilter For aging, regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1ab12471f3a69c4d502e6271e84ddf8a981f507f author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:32:23 +1000 committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:39 +0200 commit 1ab12471f3a69c4d502e6271e84ddf8a981f507f (patch) tree 6652276229ad1c3ffca48f7a31e1b77d2ea04b07 parent c38485279cd36da96ac81107d567ea4e779b2b96 (diff) vcl: ImplSepia -> BitmapSepiaFilter Change-Id: I4f350aa8b494caf55c9c810ac7fa9ed8db349725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113926 (cherry picked from commit f3151e62bcc7cb66313df70a2ec8eed8ca8f2c88) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d41693f2eb48fce3d808f1719bbd60f2d2041203) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113868 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-12Related tdf#117750: fix UnsharpenFilterJulien Nabet1-1/+1
Change-Id: I372bb6baae747adb3b2d2a2b8fd39d1631b074ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113927 (cherry picked from commit 3d32e6a6ccfae56f379cb1dec6dcadf9aa8fa85f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8a75c591ef0cb017c58a7f068d1ae6571f87bd90) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113867 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-22tdf#141166 widget with id "tabcontrol" might not be a TabControlCaolán McNamara1-3/+15
it might be a VerticalTabControl or any other type Change-Id: I9f46f7e64a9be2487d400cc4a066575c0d45c19e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112802 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-15tdf#127217: Fix buttons in forms not working in Adobe ReaderJulien Nabet1-3/+1
Regression from 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb: author Thorsten Behrens <Thorsten.Behrens@CIB.de> 2019-04-09 02:19:14 +0200 committer Katarina Behrens <Katarina.Behrens@cib.de> 2019-07-03 14:48:45 +0200 commit 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb (patch) tree e778dad33073a228eb61ab62ce5f38e2a26d07ca parent 1e8a9c19a6f7b82c9e0c481aee0c04c0780f4433 (diff) tdf#113448 don't export any font for radio buttons Don't let only color value in m_aDAString since it'll go here: if( !rWidget.m_aDAString.isEmpty() ) { if( !rWidget.m_aDRDict.isEmpty() ) { aLine.append( "/DR<<" ); aLine.append( rWidget.m_aDRDict ); aLine.append( ">>\n" ); } else { aLine.append( "/DR<</Font<<" ); appendBuildinFontsToDict( aLine ); aLine.append( ">>>>\n" ); } aLine.append( "/DA" ); appendLiteralStringEncrypt( rWidget.m_aDAString, rWidget.m_nObject, aLine ); aLine.append( "\n" ); if( rWidget.m_nTextStyle & DrawTextFlags::Center ) aLine.append( "/Q 1\n" ); else if( rWidget.m_nTextStyle & DrawTextFlags::Right ) aLine.append( "/Q 2\n" ); } But if we shouldn't have /DR at all since we don't want fonts for radiobutton, it also means we don't want /DA too. Indeed at the end of 12.7.3.3 https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf: The default appearance string (DA) contains any graphics state or text state operators needed to establish the graphics state parameters, such as text size and colour, for displaying the field’s variable text. Only operators that are allowed within text objects shall occur in this string (see Figure 9). At a minimum, the string shall include a Tf (text font) operator along with its two operands, font and size. The specified font value shall match a resource name in the Font entry of the default resource dictionary (referenced from the DR entry of the interactive form dictionary; see Table 218). Change-Id: Ib350495d7fc5a7a4fba88d710614a0f67a0b1553 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111724 (cherry picked from commit a0d63ee5df921e5f1ac915ada783fdef0dbbb057) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112306 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-03generic Skia workaround for VCL sending empty size (tdf#140288)Luboš Luňák4-15/+26
There have already been commits to handle this, but the case of getting the wrong size the first was still broken (or was fixed in the past and got broken again). Try to be generic by forcing these to be always considered to be offscreen and force non-zero size there. Change-Id: Ie366a296f7f6645333630fa31e9fe18d54c7fba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111528 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 9d8c04d2d5529626d649af3fcebb6d4b65193b28) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111711 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 21305ff47a1bee1fa4787bf792fb3ecdb10d4863) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111782 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16tdf#140207 Qt downscale the ExtTextInputPosJan-Marek Glogowski1-2/+3
Qt reports the unscaled pixel values to the IM, so simply divide all values reported by SalEvent::ExtTextInputPos by the window's scale factor. This correctly positions the IM window on a scaled LO window. Change-Id: Ia639ee3e5fc0e47f7017896b34730bbda7f06a16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110945 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 41cffc379259fec626a282ca243a9750d96d1c63) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110915 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 61bf6b4d90aa1d37009b397e44fe39c9c5b06afd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110920 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-12always optimize bitmap transform to translate+scale if possible (tdf#138068)Luboš Luňák1-24/+3
Commit 828504974d70111e make OutputDevice::DrawTransformedBitmapEx() always call DrawTransformBitmapExDirect() in preference to explicitly converting to DrawBitmapEx() if the transformation wanted was at most translate+scale, in the hopes that these days the backend implementations work well enough. But it turns out only the Skia backend handles that without loss of performance. So always do the conversion to DrawBitmapEx() if possible. It's so simple that it possibly makes sense to always do this, regardless of the backend. Change-Id: I6eba68e672334c38433f53980f49400499f5d8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110716 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 9d89d98d3349502b56da4bdd6ea287ac4cde9ce5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110781 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-28drop RadioButton arg defaultsCaolán McNamara2-3/+3
the nBits arg in builder.cxx was in the wrong place Change-Id: Id4d0dd6919444cb39cf0d9e593f46d324f343a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109718 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-27tdf#129180 Fix default paper size in the dropdownGabor Kelemen1-3/+4
Seems like a few calls to getJobPageSize() are necessary before the Page size list can get a correct value. This is why the problem appeared only on opening the dialog but opening/closing the printers Properties dialog fixed it. Thanks to Justin Luth for the idea! Note: for testing, change among paper sizes supported by the printer, e.g. A4, Legal and Letter. See also tdf#134646 Change-Id: I792139e274886c1b232ef97a4f1e800e6b32cf71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109655 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 3c85bf2af5ae2f7b180db8f8abf2d4e997491bb9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109979 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fdb2b760d9fd3b65ad54bad14a62f3c47374731e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109987
2021-01-27Fix crash in ProcessEventsToIdle debug codeJan-Marek Glogowski1-2/+4
... and that code formatting is from clang-format. Change-Id: Ia73780f5f756a8c3493d27263347190289e4c953 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109999 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 0c7e8ef07fe9ba7ebc95fdeb5f58275decb4f0fc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109976 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 9e9abb0263851e691dfe5b245e1dc6df790cb467) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109980 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26Resolves: tdf#106484 Print Properties Device tab dropdown change not detectedCaolán McNamara2-0/+10
probably since... commit 07602e5a8b869be1c45158cf71d6015d17a5f797 Date: Wed Jun 24 17:31:32 2015 +0200 tdf#91362: Don't override printer page autodetection if printer settings haven't been modified Change-Id: I6a7cb7c7ae00d7d31defe7bc1d191a6bff3ff31c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109889 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-26RadioButton tick in a different place than CheckBox tickCaolán McNamara1-2/+2
since... commit 302a00a3190743f5e6d2b61e5b40e493c4744b7e Date: Thu Jun 6 17:14:53 2019 +0900 tdf#124947 fix hit area of the radio buttons, size in ios theme so under gen in tools, options, load/save, microsoft office the radio in export as: shading is much higher than the create mso lock file checkmark Change-Id: Ib057c0725352f6a178df006e92024fedf9b82b79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109684 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-22Fix handling of the OBJECTDESCRIPTOR clipboard (pasteboard) type on macOSTor Lillqvist1-34/+45
This fixes a demonstrable problem, and affects only macOS. This is also on the path towards fixing https://github.com/CollaboraOnline/online/issues/849 , even if the code touched here is for macOS only. The iOS pasteboard handling code is based on the macOS one. We need the pasteboard to have the OBJECTDESCRIPTOR type as a MIME type that includes the typename attribute, because the code in sc checks for that when it decides whether it is a proper OBJECTDESCRIPTOR. Simplify the data in the flavorMap array. No need to duplicate the same MIME type string as both the pasteboard type and MIME type, for those cases where the MIME type is used diretly as pasteboard type. We also know that for those types, the MIME type might have additional parameters, so be more lenient in checking. With this change, and my recent change to sot, this now works: Start LibreOffice. Open a spreadsheet. Select a cell range. (It can include formulas.) Edit > Copy. Quit LibreOffice. Start LibreOffice again. Open a spreadsheet. Edit > Paste. You get the very same cells that you pasted as such (with relative cell addresses in formulas properly adjusted, as expected). Previously, it would paste an image of the copied cell range, which is fairly pointless. There is still lots of opportunity for cleanup in the clipboard code for macOS and iOS. It is presumably rather pointless to put images on the pasteboard in Windows bitmap format, for instance. Just PNG should be enough. No idea why the code provides the TIFF pasteboard type for images. Ditto for Windows metafiles (WMF and EMF). It is also unclear how useful the EMBED_SOURCE or LINK_SOURCE types are on macOS, for instance. Change-Id: I573648480b03972b506203b4f470d513bcb81212 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109297 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109361 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-21rhbz#1918152 fix FTBFSCaolán McNamara1-2/+0
Change-Id: I5c03c810d3b2572b0e58c62293add49bd7025e70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109717 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-18Related: rhbz#1889257 spurious debugging outputCaolán McNamara1-1/+0
Change-Id: I5d8f5d5673a59c42c2da90e57aae98654b432da2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109482 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-18tdf#138829 don't grab focus to roadmap label when sync timer firesCaolán McNamara4-6/+7
Change-Id: Icc8a03a2ce5d63f3a2c477671a9aa52aefd1df96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109392 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-18tdf#137695 shrink widget height below natural min within data browserCaolán McNamara3-4/+14
Change-Id: Iba3c12376200b7ce800b48155a4b84ca2e47d63f Change-Id: Iba3c12376200b7ce800b48155a4b84ca2e47d63f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109382 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-17set small button provider at screen instead of at each widgetCaolán McNamara3-31/+37
and make the small close button in the menubar use that same provider add a small-button pattern to match buttons in toolbars on its own this commit doesn't change anything, but a follow up commit depends on it Change-Id: I13623519d6fa51d9bd474589fa00e2fcc0c1e599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102013 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 09601f9470cb342ccfd8a513e4a2460adf047b63) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109381 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-17tdf#139643: fix missing PDF/UA flagJulien Nabet1-1/+1
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/vcl/source/gdi/pdfwriter_impl.cxx?id=a795886762a6a4aabd601183598c4e6c819bcb1f author Arnaud Versini <arnaud.versini@libreoffice.org> 2019-09-20 19:01:34 +0200 committer Arnaud Versini <arnaud.versini@libreoffice.org> 2020-02-08 15:03:07 +0100 commit a795886762a6a4aabd601183598c4e6c819bcb1f (patch) tree 93a58d738bf27a0c5f75f80dc7e651763916ee5f /vcl/source/gdi/pdfwriter_impl.cxx parent a2f62a861ba7036e689070c47f72214b1bdd49d4 (diff) Add minimum support for PDF/A3 here: sal_Int32 PDFWriterImpl::emitDocumentMetadata() { - if (!m_bIsPDF_A1 && !m_bIsPDF_A2 && !m_bIsPDF_UA) + if( !m_bIsPDF_A1 && !m_bIsPDF_A2 && !m_bIsPDF_A3 ) Change-Id: Id4b3b9a74ccf5a5abd9e7149cb09b3475dd4ffee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109400 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2021-01-07ofz#29113 short readCaolán McNamara1-0/+7
Change-Id: I107d8abeac419ba4e70a5880054c9195c60464ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108351 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-04tdf#138801 vcl: fix lazy-loading of GIF images with logic sizeMiklos Vajna7-3/+110
Regression from commit edda1e5fc8113aa4744e32f97c96a3cc311485ca (DOCX import: lazy-read images without external headers, 2018-04-20), the immediate problem is that GIF images from docx are now lazy-loaded. The deeper problem is that GIF images normally only have pixel size and can have an optional logic size as well (LO-specific extension). The bugdoc in question is a DOCX file, which contains a .png stream, which is in fact a GIF image, with that STARDIV extension in it. Now the initial parsing (that only extracts the metadata) didn't read the logic size, so the preferred map mode was pixels, but later when the actual read happened, the preferred map mode changed to mm100. Thid does not play nicely with writerfilter/ code that sets a different wrap polygon depending on if the (assumed to be final) map mode is pixels or not. Fix the problem by reusing the "is this an animation" GIF parser to also extract the logic size of the GIF image, if it has one. This way we still lazy-load the GIF image, but the preferred map mode won't hange from pixels to mm100 during the real read. Change-Id: Ia6c66e1c4fa0cb23a1daf537e7179b081ef90def Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108125 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit c24d9447b809416575972585a5ad48e14f8d9ad9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108182 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108664
2020-12-17tdf#138950 allow up to one short read to not trigger cancelling importCaolán McNamara3-4/+5
Change-Id: Iedbfc344c311c40244ba2f58c56c62ac47584028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107794 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-17tdf#138661 don't emit value-changed when not changed by userCaolán McNamara1-0/+12
in the FormattedSpinButton which is the standard mode for these signals and what the SpinButton does, and in this case the FormattedSpinButton is considered "modified" when it shouldn't be Change-Id: I26865e099c02fdd2745c41b347b7006d8560fb20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107711 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-11tdf#76644 extended tips not shown for 'gen' menu itemsCaolán McNamara1-2/+5
since... commit d7fe5ab30ca9df722eec33d428baedd258075eac Date: Thu Aug 1 11:23:58 2013 +0200 convert vcl/menu.hxx from XubString to OUString (second attempt) probably currently only useful with HELP_DEBUG=1 Change-Id: I66e94e57e117d4e1d83f132a82377b28d3674d86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107548 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-12-10leaked_storageCaolán McNamara1-1/+1
Change-Id: I462636907a7f16a69d2fae2529c6ffbbf925774b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107392 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-10unref pSubMenuModel at the end of the scopeCaolán McNamara1-1/+3
Change-Id: Ia427c736f989de38f30c455aeed0f43811a456b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107475 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-25tdf#131970 enable tab-cycling between VerticalTabControl membersCaolán McNamara1-0/+2
Related: tdf#131970 icon-switcher should be in single-selection mode Change-Id: I7d009c2345cc7b3a3c692bb8734d9939ce465db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105764 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-24tdf#137662 ignore focus in dropdown if dropdown is hiddenCaolán McNamara1-3/+11
Change-Id: I0263fb832f31c6926ac63cab79ce8fd0b9548581 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106245 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-24Avoid warning about deprecation in macOS 11.0Tor Lillqvist1-0/+3
Change-Id: Ie1a7e19093b439eb133632ee881e1e3dbe58132d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98176 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106459 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24There is no QuickTime frameworkTor Lillqvist1-1/+0
The reference was a leftover from 32-bit times. Change-Id: Ie453a4c644787a49f8742eab4b4ea9d49cddf32d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98175 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106456 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-23avoid Skia floating point position fixups for rectangles (tdf#137329)Luboš Luňák1-16/+36
Avoid to toSkX()/toSkY() tweaks for rectangular areas, so with AA enabled it leads to fuzzy edges, and rectangles should line up perfectly with all pixels even without tweaks. Change-Id: I45bf5a57a9f2d941eb7ec224992fc452481a2f98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106060 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 5b292e878703ebc32e875406f4116cba145a9042) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106434 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-19tdf#113163 OOXML Fix transparency and alpha channel supportBartosz Kosiorek2-1/+3
In OOXML specification there is a:clrChange tag, which change color from image, to another colour and transparency: https://docs.microsoft.com/en-us/openspecs/office_standards/ms-oi29500/5860f816-13d3-4a83-9e63-bcd1e0808404 Unfortunately It was not working correctly. This patch is resolving that issue Change-Id: I85e3790f86382dca2c4798346021f480e50db6e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105258 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 4a288c136c66b4dfbb75764602520d48c39fee81) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105990 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-17tdf#138022 Skia don't recreate empty surfacesJan-Marek Glogowski2-10/+16
Skia can't create empty surfaces, so the recreation will hit the std::abort() in SkiaSalGraphicsImpl::createWindowSurface. Origin of the backtrace is some queued Resize event, which will hit this a few times via SkiaSalGraphicsImpl::checkSurface. This feels a bit like tdf#130831, where VCL tried to track damange for an empty Qt image... This also includes commit 6a3a17c8dcd860506781b28b14c3df7036eaaaba ("createSurface() should be enough if the surface doesn't exist yet"), reviewed on https://gerrit.libreoffice.org/c/core/+/103184 Change-Id: I75e22c987ba633e7a403541db8d580df33c68964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105963 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 42e30c24615402c49351f80cc8a47d61d47267c6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105992
2020-11-17tdf#137898 Page count is not reset to 1 in the print preview dialogCaolán McNamara1-1/+1
Change-Id: Ib7c8695fd3e7156b86f4b4603fbaa5e2319cdc1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105861 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-17disable Vulkan for Windows 7 (tdf#138219)Luboš Luňák1-0/+3
The bugreport says the latest Intel drivers for Windows 7 are problematic, and since Windows 7 is EOL anyway, simply don't bother. Change-Id: Iee429d99ebf9b0e0a99a50c38ef77d06ab5b797b Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105930 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-17tdf#138183 sync pending clipboard assign on clipboard ownership-changeCaolán McNamara1-0/+13
Change-Id: I325add499fbd4d11a942ce550346dcbcb5343e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105862 Reviewed-by: Kevin Suo <suokunlong@126.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-11-16tdf#136962 only do implicit SetUpdateMode optimization if the widget is hiddenCaolán McNamara1-6/+9
callers can always opt-in with freeze/thaw for the lesser optimization available if shown Change-Id: Ib9317451a3059cc33f70d0c23543d8024bd21ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105515 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-16Resolves: tdf#137786 allow 'toggling' GtkToolButtonsCaolán McNamara1-8/+6
even if they are not GtkToggleToolButtons We already allow this for GtkMenuToolButton, we shouldn't need to allow it for a GtkToolButton because a GtkToggleToolButton should be used. But we have inconsistency where some of these 'align' features are considered toggleable by some apps or modes within an app and not by others. So when this inconsistency arises reuse the pseudo-toggle support for GtkMenuToolButton for GtkToolButton. Change-Id: I78b625b206bf6187e36fc39f876d4828ada10a7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e1e662065c911e55aeb85a67664dea9d5ed12313) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105463 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-14xmlsecurity: handle MDP permission during PDF verifyMiklos Vajna2-10/+84
(cherry picked from commit 586f6abee92af3cdabdce034b607b9a046ed3946) Conflicts: include/vcl/filter/PDFiumLibrary.hxx vcl/source/pdf/PDFiumLibrary.cxx xmlsecurity/source/helper/pdfsignaturehelper.cxx Change-Id: I626fca7c03079fb0374c577dcfe024e7db6ed5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105785 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-12vcl pdf tokenizer: fix handling of dict -> array -> dict tokensMiklos Vajna5-2/+189
Needed to be able to parse the /Reference key of signatures. (cherry picked from commit 056c1284d6a68525002c54bef10834cc135385db) Conflicts: vcl/qa/cppunit/filter/ipdf/ipdf.cxx Change-Id: I6b81089a3f58a2de461ad92ca5a891c284f8686a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-11lock print dialog height so expanders don't expand the dialogCaolán McNamara3-1/+8
but instead can make use of the scrolledwindow Change-Id: I9a820e077dce8090e6c5d876874dc1babbbd6808 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105565 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c44155d3f8bc2037a41d221463d460138b3ecdf9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105534
2020-11-10Speed improments1919193-11/+46
Improve drawing performance on 10-bit displays by avoiding multiple color space conversions. Make all drawing context bitmaps have the colour space and byte order of the host window. Fix serious CoreGraphics-related memory leak (existed no later than version 7.0) when changing the window size. Change-Id: Ia7b7e88d47b728bd1d10dedc1ca222215de41e73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105497
2020-11-06Resolves: tdf#137181 set the clipboard asynchronouslyCaolán McNamara1-5/+29
because apparently hitting the wayland compositor repeatedly with clipboard changes without a chance of reply triggers a "Lost connection to Wayland compositor" failure, so make it happen on the next event loop and have only one event pending Related: tdf#137181 factor out the piece that triggers the problem Change-Id: I24d22e70f5f614fa0c9d3d1672e064d9c57be57e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-05resource leakCaolán McNamara1-0/+1
Change-Id: I1abd8acef55d5bdb4744ecf1a62d8e1396de0e3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105218 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-04vclplug_qt5 doesn't appear to need to link to vclplug_x11Caolán McNamara1-1/+0
Change-Id: I7f4c3fb210996c0ce66d3d9448a3954ce1aaa525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105215 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-10-30tdf#137643 alternative solution to activate embedded fonts in one batchCaolán McNamara2-19/+27
Change-Id: Ib5ffb2b8a31f237d5d2e465bf3f777590e0bfade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104957 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-30ofz#26708: Direct-leakCaolán McNamara1-1/+1
since... commit cd8dd48bf89d800c012afb04b16281ed8b261de9 Date: Tue Aug 21 16:07:55 2018 +0200 tdf#119282 Area tab, Pattern color change Change-Id: If0c988f7532786a4089edef39929f924d8e2ec2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104953 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-29fix --disable-pdfium buildCaolán McNamara1-1/+1
Change-Id: I580972220bc39abe16288fa62c717e4ab25833d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105015 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-23 13:10:32 +0000