Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: Ic8bc3f2d5d96506590d35138089ead2eac984314
|
|
Change-Id: Iee8089fc3bfbea60adee95dfb2c229f3efea28f8
|
|
Change-Id: Ib402395f5523a980c9ca098dcd2d8e1ecbbfa7c0
|
|
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
|
|
Change-Id: Ib820326fdc752d0893840bad3eb7f1369469f796
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Change-Id: I6b694659077abce4ca7c67cf0298c9b882a2b964
|
|
Change-Id: Ib101d2605e5e739bb1d063fa7019e4e5930462a0
|
|
Basically, they were working around issues with XmbTextListToTextProperty
returning garbage characters, which showed on window titles.
The comment in the code is far more informative than the bug report:
/* #i64273# there are some weird cases when using IIIMP on Solaris
where for unknown reasons XmbTextListToTextProperty results in
garbage. Test one string once to ensure safety.
FIXME: This must be a bug in xiiimp.so.2 somewhere. However
it was not possible to recreate this in a small sample program.
This reeks of memory corruption somehow.
*/
Now I did a bit of research (aka "Google search") and discovered #i6759#
which was logged in 2002. This shows that the codebase was using __XOpenIM
in xiimp.so.2, which probably caused this issue. From the bug:
I've tried to look into this problem and have found out, that
apparently the
use of the '__XOpenIM' subroutine from the
/usr/openwin/lib/locale/common/xiiimp.so.2
shared library causes this problem. When running on Solaris, OO tries to
dlopen() the above mentioned shared library, looks up the '__XOpenIM'
symbol in it and calls this function ( function XvaOpenIM() in file
vcl/unx/source/app/i18n_wrp.cxx ).
There's alternate code in OO that just calls the X11 documented function
'XOpenIM()' instead. This is enabled by running OO 1.0.x with the
environment variable USE_XOPENIM defined to some value. When running
OO with
env USE_XOPENIM=1 ~/OpenOffice.org1.0.1/soffice
the problem does *not* occur any more and xprop for the same two windows
mentioned in the initial bug report shows:
% xprop |egrep '_NAME|_LOCALE'
WM_LOCALE_NAME(STRING) = "de_DE..ISO8859-15"
WM_ICON_NAME(STRING) = "unbenannt1 - OpenOffice.org 1.0.1 "
WM_NAME(STRING) = "unbenannt1 - OpenOffice.org 1.0.1 "
% xprop | egrep '_NAME|_LOCALE'
WM_LOCALE_NAME(STRING) = "de_DE..ISO8859-15"
WM_ICON_NAME(STRING) = "Umbruch einfÿ77777774gen"
WM_NAME(STRING) = "Umbruch einfÿ77777774gen"
As far as I can tell, the use of '__XOpenIM' frees some memory inside the
Solaris X11 shared library that is still in use by the X11 character set
conversion routines. Or in other words: the X11 character set conversion
routines operate on freed memory, after __XOpenIM was called.
These character set conversion routines are used by
XmbTextListToTextProperty
( in WMAdaptor::setWMName() in file vcl/unx/source/app/wmadaptor.cxx ) and
it seems they still access memory that was freed by the use of
'__XOpenIM'.
Now later on, Caolan removed XvaOpenIM() in commit
4d6dab2cde759551ceee7e6aaec89fa5235b1ecc and then later committed a patch that
removed the ability to use the environment variable USE_XOPENIM as it wasn't
necessary anymore (commit: 8b0287543d87659fd4bfde5edb6725ee5da5f80e). I'd say
that this was probably fixed in one of these changes.
Change-Id: I20effd77e0cdcde26d1be756cc6231f30f35118e
|
|
Change-Id: I4b2bedb9ac641fcb96d09afb2e60fa2c6186fd6b
|
|
Change-Id: I03c8629bf27a43d6f4cc08bb8f64ed71b9055fdc
|
|
Change-Id: I7aa824578b14999d0ef667a5bcfccd731f1d3b64
|
|
Change-Id: I101afd11394d3d024d38519afd61d700114702ac
|
|
Conflicts:
vcl/unx/kde/salnativewidgets-kde.cxx
Change-Id: I662a05d988f5989fc2ac0d06003851c56105e184
|
|
Conflicts:
vcl/unx/generic/gdi/gdiimpl.cxx
vcl/unx/generic/gdi/salgdi2.cxx
Change-Id: I2cb960d194ee5bc38beece97e8b21cc6fa3b3fbc
|
|
Change-Id: Ie538049aa8c4c0812d28b5c1bf91425822c55617
|
|
Change-Id: Ib35d4a007c276aba45925ac281fff160bf07f9fe
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ia69bb21080ab7a42a0b9f9871f72ab696b6098ed
|
|
Change-Id: Ieab948d11da7f56b2273637ff3caaefec86030d1
|
|
Change-Id: Ic6f287b5ee4f4ac3a9674d67b8c15a589405c951
|
|
Change-Id: Iba4d5223a7fc92f4ef6ec6be660f496cc94f5565
|
|
Change-Id: I2022c25f821473240a5ff3998249e933ea7fb74d
|
|
Change-Id: Id5aa4c1e843d286026a7bcd1297670db467dcbbc
|
|
Change-Id: I832dd6f3647fbb423975fa928a5ec32447225e85
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I142e1b34e54a3cbe149e5af9adeba1250a4ca9a9
|
|
Change-Id: Icc3fd75533a6173f1cb051f3cd7a47d63e523652
|
|
Change-Id: Ibf260ab97cc397b72d81ad4cc08f43d8d2128cef
|
|
Change-Id: I7784fa81cb6f9a3d6437b2b628c37e7895c84733
|
|
not on those belonging to gdk shoe-horned in via
mpPixmap = GDK_PIXMAP_XID( mpGdkPixmap );
in GdkX11Pixmap::GdkX11Pixmap
This stops file->new->presentation crashing on second invocation
Change-Id: Iec673497f900b0ddabd439369b9ffe554800d425
|
|
Change-Id: Icebf3c7d2911b27e29d2259b780a04048b293b3c
|
|
Change-Id: Iffa82b96610dd1fe5900ca796af413a116d2dd28
|
|
Change-Id: Ib9b108c034181c0f94cbf86634447ba2d4afbaa5
|
|
Change-Id: I174553768fa12d7b05367498e3755b8e94dfeb47
|
|
Change-Id: I33927305351b6e84721c11e3a1814266b41db8da
|
|
Change-Id: Ia35c1b529d51882b48779d8e13afbe17ae66e937
|
|
Change-Id: I692d2011902f46d2ca48b4d1d0a2516026e5cae3
|
|
Change-Id: I44a7e9bec213514708e4c971479660574508ad1b
|
|
Change-Id: Ib1246f361d5efd13a7e36d568641c6360495604d
|
|
Change-Id: I8b244a5bdd12a64a65ca1bab14dfe6917a175ccf
|
|
Change-Id: I007408885b5752f3abf55075ef025aa6dacbabde
|
|
Change-Id: I8fff04f561d57083c65a87ad5bd0e04cb9b9ed2c
|
|
Change-Id: I6397708f164be68bd6561a382115654f90ecd471
|
|
Change-Id: I1c45ff7ba09972c20af0c28a5c3e1514171504ff
|
|
Change-Id: I307a83e1b5564f0bb91dcb6c30a78f2bd560a911
|
|
Change-Id: Ie40850916359637b983f2c303e875bc5bf041cb1
|
|
The text rendering is now abstracted into the TextRender abstract class.
Additionally we have now an abstracted cairo rendering class
CairoTextRender which is a subclass of the TextRender class. The
CairoTextRender class is still platform independent and needs to be
subclassed to implement the few platform dependent methods.
You can reuse the cairo based text rendering now by subclassing
CairoTextRender for the platform that you need.
Conflicts:
vcl/unx/generic/gdi/salgdi.cxx
Change-Id: I8b07e3fe646a81563d308971d30e14a00fd921ad
|
|
Change-Id: Id8cea87391835694e20aa703b7fdb3f13434d47b
|
|
Change-Id: Icdf691e7e9e83d039e33d2095270290dc31f2efa
|