summaryrefslogtreecommitdiff
path: root/vcl/unx
AgeCommit message (Collapse)AuthorFilesLines
2013-09-05Consistently use rtl_getAppCommandArg hereStephan Bergmann1-1/+1
...2a9c1d1a75b7d4e79dfbc6be3dada1a1e959e58e "Make dialogs fail with an exception in headless tests" missed one of the osl_getCommandArg calls, which can lead to problems when there are any -env: arguments preceeding the --display argument. Reported by renduly on IRC. Change-Id: I98dd24be840d561dce51034088f3e44adff9f2ff (cherry picked from commit 379a53017447fbf2a459f82ae8905b6683e80e8d) Reviewed-on: https://gerrit.libreoffice.org/5822 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-03Resolves: rhbz#993963 NULL m_pWindow on firefox deleted pluginCaolán McNamara1-1/+1
(cherry picked from commit 4a4ed52e57b540167c3ca45e6e762b9e21e874de) Conflicts: vcl/unx/gtk/window/gtksalframe.cxx Change-Id: Idb12b12e4313668bf3390a97551c688ee0dcde67 Reviewed-on: https://gerrit.libreoffice.org/5774 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-08-26rhbz#1000150: Do not call exit upon XIOErrorStephan Bergmann2-21/+16
...as done in _XIOError (libX11-1.6.0/src/XlibInt.c) after calling the XIOError handler function (either the one supplied with XSetIOErrorHandler or _XDefaultIOError), as that calls the atexit handlers, which can wreak havoc in unrelated threads that happen to be running in parallel, leading to arbitrary crashes. So avoid that by always calling _exit already from our XIOError handler. The old code was careful to /not/ call _exit when the XIOError happened on any thread but the main one, but I do not see the sense of that---after all, _XIOError will inevitably call exit afterwards, so this cannot be a way to "ignore" XIOErrors from special threads (that are set up say for the sole purpose of trying out "known-shaky" activities without affecting the stability of the whole process). And findings like comment 12 to <https://bugzilla.redhat.com/show_bug.cgi?id=831628#c12> "[abrt] libreoffice-core-3.5.4.2-1.fc17: ICEConnectionWorker thread still running during exit" ("it is very likely that this is not a normal exit from reaching the end of main, but rather some explicit call to exit from some error handling code") make it clear that we apparenly do suffer from such calls to _XIOError -> exit on non-main threads. I have no idea why vcl/unx/gtk has its own XIOErrorHdl that is substantially different from the vcl/unx/generic one, though. cherry picked from commit ffea65915b9cc6d4f3c01f829552702654a040f9, plus follow-up b240a1c188b58e3e717335339bfc3f5e20bb2bf4: rhbz#1000150: Do not call exit upon XIOError, take two The _XDefaultIOError handler (libX11-1.6.0/src/XlibInt.c) already calls exit (even though _XIOError calling _XDefaultIOError would call exit afterwards, too), so our XIOError handler must not call aOrigXIOErrorHandler. Change-Id: Ida7d407cf5f0fa4e719118cab5e725144ceb3a35 Reviewed-on: https://gerrit.libreoffice.org/5596 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-11rhbz#980387 fix filter selection from file ext.David Tardon1-1/+21
... for filters that have more than one extension associated with them (e.g., JPEG). (cherry picked from commit 70376f610a7eb876739829e1f362bc94b21cb82f) Signed-off-by: David Tardon <dtardon@redhat.com> Conflicts: vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx Change-Id: Ic6b16d3b4aa17580404d02a9fb7b087b9aa52fc2 Reviewed-on: https://gerrit.libreoffice.org/4824 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-08fdo#66335: fix fdo#44582 and fdo#63254 differentlyIvan Timofeev1-7/+1
This combines the following cherry picked commits: 1) fdo#66335: gtk: Revert hacks for RTL scrollbars returning false here in getNativeControlRegion results in a fallback to square buttons in vcl scrollbar code. But there is no problem in gtk+ backend in this case, let's fix the problem differently. This reverts commits 898a3e84807bccbb876e3f5583728f6d24e05e9a and e8e82bd2109b82ddd535cdac30303249c6b62942. (cherry picked from commit 48e1d9c7afe5c2a39d9a08d7a38f7c8ff39d8c84) 2) fdo#44582: fix scrollbars in RTL UI (cherry picked from commit e3a801e2454eed2e61202bbacca01fe3fcc20c1d) 3) fdo#63254: correct re-mirroring formula This patch fixes horizontal scrollbar in Calc when a sheet is RTL and UI is LTR. When a particular window (horizontal scrollbar in this case) is RTL and a whole UI is LTR this code used for mirroring and re-mirroring back coordinates. AFAICS mirroring is correct, but re-mirroring is not. The used formula comes from commit 69b684b12e42bf1396bdffca88ca880ac3c2e00b, and the same formula appears in the other variant of overloaded function "mirror": mirror(sal_uInt32, const SalPoint*, SalPoint*, const OutputDevice*, bool), but it does not affect the bug. (cherry picked from commit a08f579e3704fbd97590f9b050d250ae445725a7) Conflicts: vcl/source/control/scrbar.cxx Change-Id: I0ccaa8998fe87403b3606828eaf3f5bd1dbe6bb4 Reviewed-on: https://gerrit.libreoffice.org/4622 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Reviewed-by: Abdulaziz A Alayed <aalayed@kacst.edu.sa> Tested-by: Abdulaziz A Alayed <aalayed@kacst.edu.sa> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-20fdo#60565 - re-read font data on GtkSettings fontconfig-timestamp notify.Michael Meeks1-6/+31
Change-Id: If1c4d3a7754cc35208e40494828a799f94f26afc Reviewed-on: https://gerrit.libreoffice.org/4347 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com> Reviewed-on: https://gerrit.libreoffice.org/4376
2013-06-03fdo#56583 - avoid setting user time on unrealized windows.Michael Meeks1-2/+10
Change-Id: Iab776088b1d168295d636069e1a92ba948241653 Reviewed-on: https://gerrit.libreoffice.org/4143 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-05-28fdo#63254 UI:Horizontal scroll bar isn't displayed when RTL tabAbdulaziz A Alayed1-2/+3
opened with LTR UI. Change-Id: Iff6899539fe0b1788df7b09f91f850b91bcdb811 Reviewed-on: https://gerrit.libreoffice.org/4024 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> Signed-off-by: Petr Mladek <pmladek@suse.cz>
2013-05-16Resolves: rhbz#963276 rhbz#761009 lp#766153 lp#892904 HandleFontOptions crashCaolán McNamara1-4/+4
The mpServerFont member of a ImplServerFontEntry must not be deleted while the ImplServerFontEntry still exists see also 39cbce553da1834f78b77f48b2f1be9578d6cc05 for another reason a crash in the same place can happen. Its impossible from traces in crashes before 39cbce553da1834f78b77f48b2f1be9578d6cc05 was fixed to distinguish those crashes from this crash. This crash is a regression due to 7a416820ab5e03f8b988656e0f6a592cb1e81d07 where we went from modifying pServerFont in X11SalGraphics::setFont directly to modifying it/a-different-one indirectly via ImplServerFontEntry The various font caches and font thing lifecycles of LibreOffice are somewhat confusing. This crash had eluded me for years, to reproduce: insert->special chars->select a font with loads of glyphs, i.e. "AR PL UKai CN" click on the first row of glyphs and hold down page-down until you hit the bottom, then page-up until you hit the top. Pre patch it won't survive the whole down+up (and valgrind will moan quite a bit) (cherry picked from commit 3d6424a752902bba513102834966868f609d91e6) Change-Id: Ifde0cb375f487c556b04a640d77765a7dc2f0913 Reviewed-on: https://gerrit.libreoffice.org/3922 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-13fdo#64311 - don't encourage the fpicker to give us URLs we can't handle.Michael Meeks2-0/+4
(cherry picked from commit 8659ca5c350b9b08fb5f343c68955cdd6d361c96) Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch> Conflicts: config_host/config_vclplug.h.in Change-Id: Ide7d833801e96a3375909238d036687082f34605 Reviewed-on: https://gerrit.libreoffice.org/3881 Reviewed-by: Michael Meeks <michael.meeks@suse.com> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-30fdo#62815 - tolerate crazy / out-of-bound ScreenNumbers for FullScreenMichael Meeks2-0/+23
Thus making the gtk+ backend more similar to the generic backend in this regard; also be more strict about invalid monitors -> empty screens. Change-Id: Ia4f2e1205cb1d309fb1bb01f9631167339a3478e Signed-off-by: Petr Mladek <pmladek@suse.cz>
2013-04-26Resolves: fdo#63802 return true if we have known empty contextCaolán McNamara1-19/+19
i.e. false for "we can't provide context", and true for "we can provide context, even if there isn't any" Still looks to me that there's a bug in the si-phonetic-dynamic im (or something in the stack) that assumes that returning false once means it will always return false and give up for ever fix indent while I'm at it also let si-phonetic-dynamic survive libreoffice losing focus and regain it cycle and still use surrounding text. It should be safe to report that we can provide surrounding text but there isn't any during the time window when there is no focus window, because the focus in event was received but it hasn't arrived yet because that happens on a postuserevent. (cherry picked from commit 21fb092398fb21256b0e546e7f38c5e6de4654f2) Change-Id: I0481c42208953f2a0618aaed7b0d9e9f3e7bda07 Reviewed-on: https://gerrit.libreoffice.org/3608 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-04-22rhbz#954991 Avoid static data (causing trouble at exit)Stephan Bergmann1-2/+0
(cherry picked from commit aa1aedb2a0ef97cb6110f18a1de86abc8dbcd304) Conflicts: vcl/inc/unx/salinst.h vcl/unx/generic/dtrans/X11_service.cxx Change-Id: Ifc8275276811ba24b62f93096e7cb98a5dbf658c Reviewed-on: https://gerrit.libreoffice.org/3556 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-04-04fdo#58807 bring Beep() for basic backThomas Arnhold3-0/+17
The functionality was removed by fdo#48549. This partially reverts 0f6101cfef4c2e45d9f1f1b3a61ef94799e4526b 0bdf6fc7c71c4c49e6d6f83d56ac953272ad16d5 85cb9084533605657aca0394afe4516058a8e4ef I changed the behavior to always beep, because only the basic macro function is using Beep(). Looks like the Beep macro function didn't even work correctly before the removal, because the default was to not beep for most platforms. So I set the volume from disable (0) to 50% for XBell(). Reviewed-on: https://gerrit.libreoffice.org/3124 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com> (cherry picked from commit 47664d3f2e12649d324b031ca6ffd5589fe3d197) Conflicts: vcl/inc/headless/svpframe.hxx Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a Reviewed-on: https://gerrit.libreoffice.org/3185 Tested-by: Thomas Arnhold <thomas@arnhold.org> Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
2013-03-16Fix buildFridrich Štrba1-0/+1
Change-Id: I2d203f8fb585b37524e63b94a6d1e15881a11882 Reviewed-on: https://gerrit.libreoffice.org/2767 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-03-15Related: rhbz#906137 g_module_symbol returned nothingCaolán McNamara1-6/+2
for gdk_screen_get_primary_monitor but osl_getAsciiFunctionSymbol does the right thing Change-Id: Ibf1a17724a9393d95c4fbe0d26aa82148eea33a9 Reviewed-on: https://gerrit.libreoffice.org/2744 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-15Resolves: rhbz#906137 slide show inverts outputsCaolán McNamara1-4/+4
we go to some effort to determine the right value of ret and then throw it away and return 0 regression since 4a7e3482912c90b73d6e12c82bcd9ce31975e3f1 Change-Id: I652cfbe44fdab6560c1c8dc8fe25d6211b5357cb (cherry picked from commit 67aae198f80195e77bd62e7675a372312075b126) Reviewed-on: https://gerrit.libreoffice.org/2743 Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-02-16Resolves: rhbz#910176 cannot select directory with gnome folder pickerCaolán McNamara1-2/+11
<< gtk documentation gtk_file_chooser_get_current_folder_uri () Gets the current folder of chooser as an URI. Note that this is the folder that the file chooser is currently displaying ... which is not the same as the currently-selected folder if the chooser is in GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER mode ... to get the currently-selected folder in that mode, use gtk_file_chooser_get_uri() as the usual way to get the selection. >> << offapi documentation XFolderPicker getDisplayDirectory: Returns the root directory that the FolderPicker is showing. getDirectory Returns the selected directory >> so getDisplayDirectory <-> gtk_file_chooser_get_current_folder_uri and getDirectory <-> gtk_file_chooser_get_uri Change-Id: Iaa5ab16a250cd59fe5e8bd02149298eef6d1dec2 (cherry picked from commit 914de32b27c7fe164b21f9247275ee3117c0864b) Reviewed-on: https://gerrit.libreoffice.org/2170 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-01-30fdo#44582 fixing horizontal scroll bar in sub windowsAbdulaziz A Alayed1-1/+6
Change-Id: Ifea57dec77c5b23771684a1e46267f8431478075 Reviewed-on: https://gerrit.libreoffice.org/1806 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/1908 Tested-by: Lior Kaplan <kaplanlior@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-22Translate keyboard shortcuts also for LinuxMartin Srebotnjak1-0/+36
Change-Id: I4d2f85106045a22be61c6b42fad941e4d4cf88d5 Signed-off-by: Petr Mladek <pmladek@suse.cz>
2013-01-14export cleaned up dotted version in environment and GtkWindow user-data.Michael Meeks2-5/+5
Change-Id: If865127a9a5560f4b3636fb870699e2f3bac0e83 Signed-off-by: Noel Power <noel.power@suse.com>
2013-01-10Resolves: fdo#59131 resolve default backend on printer->setupCaolán McNamara1-1/+7
For setting permanent defaults via spadmin we don't want to resolve the default backend on saving "default", this happens during the print initialization stuff. But when we tweak the printer settings for a single print job and reset back to default, we need to resolve that to what backend we want Change-Id: Iac2370624b6d248c9658fb0fbc2f2d449849d81a (cherry picked from commit 9c4d77f22d58f5b500c95f65a431628a8d8d6e6e) Reviewed-on: https://gerrit.libreoffice.org/1609 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-04fdo#50415: Add Catalan translations of keyboard shortcutsJesús Corrius1-0/+31
Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517 Reviewed-on: https://gerrit.libreoffice.org/1544 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2012-12-19fix KDE file dialog setting checkboxes to trueLuboš Luňák1-1/+1
No idea how long this has been broken, or if it ever worked, but inserting a picture sets the 'link' and 'preview' checkboxes to true for the next time (as getValue() returns void*, which gets silently converted to bool *sigh*). Change-Id: I6af0e09ac5e475fc9ff04cd7f937af0bc7aeea77
2012-12-05Bye bye ODMATor Lillqvist1-1/+1
SUSE has no interest in it any longer, and I doubt anybody else has either.
2012-12-03fdo#45651: fix drop down listbox text color with dark gtk themeIvan Timofeev1-0/+2
Change-Id: I9ba0b27924d1698bad2c34da75fff57f75a737f0
2012-11-30avoid circular dep between vcl and frameworkDavid Tardon1-4/+6
Change-Id: Ibcb547b2b911d382eafa1fd8a9adb2e8b6efbfe2
2012-11-30c++ API: use css alias in generated headers, adds global css declThorsten Behrens2-12/+0
This changes all generated API headers (.hpp and .hdl) to use a namespace alias 'css' instead of the pointlessly long com::sun::star Makes the change in cppumaker & associated tools, adds a global namespace alias definition in sal/types.h, and removes a kiloton of local, now pointless-to-harmful versions of that alias from all over the code. Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-29API CHANGE a11y unpublishing and add/removeListener rename.Thorsten Behrens2-3/+3
The a11y API has never really been picked up by tools vendors, let's not tie ourselves up here for no good reason. This unpublishes all css::accessibility, and dependend API. With that, we can change the rather unfortunately-named add/ removeEventListener to be add/removeAccessibleEventListener, thus not conflicting with the XComponent methods of the same name. Change-Id: I595598c3a8e46415f80b2780f333333174865fe4
2012-11-29Resolves: fdo#44664 Provide a way to set the default print job format.Caolán McNamara2-5/+13
a) In the print dialog you can temporarily override the default print job format for a single print job b) In the printer options dialog you can override the default print job format for a single printer c) Under tools->options->print you can override the default print job format for all printers. Tidy up the restart dialog in passing Change-Id: Ibea94bab6a79c3590dbf34583013db4e2ac06f45
2012-11-28get vcl building on RHEL-5Caolán McNamara1-0/+6
Change-Id: I01dc490d09fbe4bd0cce34b7e93afd36dd517f25
2012-11-28Remove useless method SetBackgroundBitmapMarcos Paulo de Souza2-84/+0
Thomas Arnhold asked me to take a look at the method SetBackgroundBitmap. In my XFCE, removing this method didn't chnage anything. So this needs more tests in Windows and other WM's. Change-Id: I3e10bea4eac114326ff981fb21ba0d292818b1da Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2012-11-27Make python3 work with custom VALGRIND_CFLAGSStephan Bergmann1-6/+6
Change-Id: Ia4b08a1b20bf46af4d06c0478ed8e795ee543703
2012-11-27fdo#46808: Missing adaptions to XFolderPicker2Stephan Bergmann3-11/+5
c988da288ec473a28f61ebb53aa3ff82bab11ef4 "fdo#46808, Adapt ui::dialogs::FolderPicker UNO service to new style" had left some FolderPicker implementations at XFolderPicker, so creating them caused DeploymentExceptions. Change-Id: I3463161f9bb87a69a2777c331eb5b93d487790b0
2012-11-25cppCheck: remove dead assignment and dead variablesjailletc361-1/+0
Change-Id: I3f0eae93be7f362ff70f8a544c46cd500d2ca50c Signed-off-by: jailletc36 <christophe.jaillet@wanadoo.fr> Reviewed-on: https://gerrit.libreoffice.org/1153 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2012-11-22Use ENABLE_GMENU_INTEGRATION consistentlyStephan Bergmann1-3/+5
Change-Id: I576bfa41b0dce0cba8c92c123f8747cf619fcffb
2012-11-22add version string to GtkWindow's to help theme authors.Michael Meeks1-1/+8
Change-Id: I3b03dc67de563e5d87fb85c0566fc411e372c690
2012-11-22Adapt some GetUILocale leftoversStephan Bergmann3-10/+10
Change-Id: I0400858249d4722a3b5583febd82200e62a64b20
2012-11-22AllSettings with LanguageTagEike Rathke4-4/+5
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-21KDESalGraphics: fix CTRL_LISTNODE drawing in expanded stateIvan Timofeev1-1/+1
Change-Id: Ia70f1b3e2afb459bf91748f9e4ba0a0cbde74260
2012-11-21KDESalGraphics: transparent background for some widgets, fdo#55952Ivan Timofeev1-0/+5
Change-Id: Iea8537b0d69efaa7323c739c614272f6525435dd
2012-11-21UnityMenu: ensure ENABLE_GMENU_INTEGRATION is actually ever setThorsten Behrens4-5/+12
Change-Id: I6b7dfd5dd80f45c216c9ec240a390b6434a12672
2012-11-21UnityMenu: don't build when ENABLE_GMENU_INTEGRATION is not onThorsten Behrens4-1/+18
Change-Id: Iba9e6c3d2483a20ed3ec33b85b4c5f78830fd2f6
2012-11-19SalColormap: -Werror=conversion-nullMichael Stahl1-1/+1
That is actually XID, not a pointer. Change-Id: I9fa807fc4f33c07b2b4ebbb5e1b7163eb53411c3
2012-11-19Drop ILLEGAL_POINTER sillynessTor Lillqvist2-5/+5
Change-Id: I19316f0fd04f75d980719676c928c3455e0f07b7
2012-11-18gtk: don't make editboxes taller than neededIvan Timofeev1-1/+1
Change-Id: I248d6668d1e9c5ec834cd8268d853ec03a2f859b
2012-11-15glib / dbus version checks strangely ommitted from the merge.Michael Meeks1-4/+5
2012-11-15gtk-a11y: unwind re-enterancy / lifecycle hazard at least a little.Michael Meeks1-7/+14
2012-11-14Turn some memmove into memcpy when it is safe to do so.jailletc361-1/+1
Most of the changes are related to newly allocated memory, so we are sure it can not overlap with the source of the copy. Change-Id: Ie6ccf1bbb07b792fb18601a38dfaa55755d14b7d Signed-off-by: jailletc36 <christophe.jaillet@wanadoo.fr> Reviewed-on: https://gerrit.libreoffice.org/1033 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2012-11-14hud_activated here surely should have been hud_activeCaolán McNamara1-1/+1
Change-Id: Id324a31295b0c6836a1e9516ac070d4042c5c3f2