summaryrefslogtreecommitdiff
path: root/vcl/unx/kde4
AgeCommit message (Collapse)AuthorFilesLines
2016-05-19Resolve: "TODO(Q1): Make GetSystemData method virtual"Caolán McNamara1-1/+1
and remove the casting silliness, allowing the removal of cairo_cairo.?xx If anything is to go wrong I'd guess it'll be the windows directx stuff. Change-Id: I3e22c07b9c26ade9b27a245fdd8408de540643f4
2016-05-19rename to two GetSystemData methods to find all call-sitesCaolán McNamara1-1/+1
anyplace calling GetSystemChildSystemData on a SystemChildWindow is definitely right anyplace calling GetWindowSystemData on a Window *might* have intended to call GetSystemChildSystemData on a Window casted back to an underlying SystemChildWindow. Change-Id: I7dcf3a50d0b7ed29bc08cfdb15cc0dcb86be8fa7 Reviewed-on: https://gerrit.libreoffice.org/25158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-19GetSystemData: this cast achieves nothingCaolán McNamara1-1/+1
SystemChildWindow has the dubious GetSystemData non-override, but this is a SystemWindow and the case is a static_cast, so just drop this meaningless cast here Change-Id: Ib11b522eff2646f39deb1152bf3e3096dd654db5
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann1-0/+1
Change-Id: I796ec3b79d7c26d9efe275b4232ae85cac80b578
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann1-0/+1
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-03-19tdf#97973 - cleanup spinbuttons theming logic.Gurkaran1-11/+0
vcl/unx/kde4/KDESalGraphics.cxx had a special case to build the widgetRect for spin-buttons which is cleaned up. vcl/unx/gtk/salnativewidgets-gtk.cxx had a wrong comment and special case regarding CTRL_SPINBUTTONS which is cleaned up. vcl/win/gdi/salnativewidgets-luna.cxx had a wrong comment regarding spinbutton which is cleaned up. Change-Id: I3c2797800221e150be165666bf71b65302724444 Signed-off-by: Gurkaran Singh <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23345 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-02-26-Werror=shadowStephan Bergmann1-17/+17
Change-Id: I0966b87cdc04f6f7cc7d9b4bed3a8046df3547e6
2016-02-25-Werror,-WshadowStephan Bergmann1-2/+2
Change-Id: I5e4cec5f9ac5b6d92214533251f97fb73c62434f
2016-02-18Resolves: tdf#97904 opengl stuff isn't implemented for gtk3Caolán McNamara2-1/+9
Change-Id: I1abbceebadf320f28955f54058b2d0ebfc79b9bc
2016-02-05Fix typosAndrea Gelmini1-3/+3
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-18Fix --enable-kde4 againStephan Bergmann2-6/+5
...after c88165dfb46c771eba6324ec061bf4455732194e "loplugin: unused return values in vcl/" Change-Id: Ia9acead013d80f5747e2cb7f18d46cd163890eda
2016-01-14vcl: fontmanager.hxx is a private Unix headerChris Sherlock1-1/+1
Change-Id: I06f3e941bfb1af861298d4fbf666d270c5bac051
2016-01-11vcl: move vcl/generic/app/ files to vcl/unx/generic/appChris Sherlock1-1/+1
These source files as all specific to Unix environments (not, however, OS X) and are not "generic" (i.e. used across all platforms). Change-Id: Idba1e9bbe14d8a4bb8e5dd2c2ad1dc75458da53c Reviewed-on: https://gerrit.libreoffice.org/21335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-02tdf#84263 KDE4: unify includesJan-Marek Glogowski12-44/+43
Use Qt submodule notation for Qt includes and also "correct" some KDE headers AKA use <> notation for external headers. Change-Id: I9457f75baae56514989800b016a11348a72a242b
2015-11-24vcl: fix for kde4.Michael Meeks2-7/+10
Change-Id: If68e58a5b1d6dfe7d7851513eed73ec20d1cd912
2015-11-18com::sun::star->css in vcl/Noel Grandin6-84/+80
Change-Id: Ifad76177673cf93746ba221838be80ff76fed228 Reviewed-on: https://gerrit.libreoffice.org/20032 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann1-1/+2
Change-Id: I3266bb049be3a9b558b68b40d741efdcab2eb759
2015-11-17vcl: fix the kde4 buildMichael Stahl4-12/+18
... after eca4c54e52363f80db26e228e586aeb7732c7100 - not sure if it's correct but at least it builds for me. Change-Id: I36083fac98c830560cdc799923d309f96e8cdd6d
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann6-19/+19
Change-Id: I05e89f9896170d4df3d1377549ea074f06b884a0
2015-10-20loplugin:defaultparamsStephan Bergmann1-1/+1
Change-Id: I3e5ee77b51eb8e1207d3f95e6a1d9d8272532ba6
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann9-50/+50
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-2/+2
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-05fix KDE4 buildNoel Grandin2-2/+2
Change-Id: I1be5448074bd763dd6a68d33dc2c6a1b1adc57d9
2015-10-05fix KDE4 buildNoel Grandin2-2/+2
Change-Id: Idb101b5b5d40b6a1a54acda81be5a5f2c09722bb
2015-10-05convert SAL_FRAME_STYLE to scoped enumNoel Grandin1-1/+1
Change-Id: Ic3f7fddcea36c18ffe43c4c633d415f596a58cbc Reviewed-on: https://gerrit.libreoffice.org/19094 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-15[API CHANGE] XFilePicker2/3 changes for multiselectionJulien Nabet1-3/+1
In order to use GetSelectedFiles (in XFilePicker2) instead of GetFiles (in XFilePicker), here are some api changes before: XFilePicker3 inherits from XFilePicker XFilePicker2 is not a published interface after: XFilePicker3 inherits from XFilePicker2 XFilePicker2 is a published interface + adapt Uno Implementations Change-Id: If44afaa7236f08bc2b814f91eda5bfad333dd799 Reviewed-on: https://gerrit.libreoffice.org/17068 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-11vcl: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe1-2/+2
with the variadic variants. Change-Id: I4499569f73b04cc7444787d51bf804c090a5c951 Reviewed-on: https://gerrit.libreoffice.org/18478 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-09tdf#92649: Converted pointers to unique_ptr's in vcl/unx/kde4Ryan McCoskrie6-94/+78
Change-Id: I1bab95a9a3db765d3b3bd34345dc006ccd33caf0
2015-08-26KDE4: don't ignore write(2) return valueJan-Marek Glogowski1-1/+2
Silence the glibc compile warning and actually handle a wrong return value. Change-Id: Icdbc8e655d4b8ad20699dfd0abdbf3405a49f898
2015-08-26tdf#80512 KDE4: fix RTL scrollbar handlingJan-Marek Glogowski1-0/+2
Just invert the scrollbar the same way gtk+ does by checking the button positions and adjust the drawing style accordingly. Change-Id: I3475c33e074c1509a73da618a4efa44dc61a1a77
2015-07-31tdf#92903 KDE4: fix listbox regression from 92115Jan-Marek Glogowski1-11/+9
So at least in case of the CTRL_LISTBOX, getNativeControlRegion is called for a type and part unsupported by IsNativeControlSupported. For whatever reason, this results in broken listboxes drawn in Base's "Table Design" dialog, when selecting "field type", which draws the listbox on top of the cell. To make it worse, it seems the listbox is actually drawn to a smaller space then the actual requirement. Appearently it seems to use the content rect, instead of the bounding rect. So in addition to fixing the drawing, this patch increases the listbox bounding rect, which looks too large in normal dialogs, but makes the Base's listbox better readable. Change-Id: I112ec038fd20ad33facd260d16b5d68b508d2bd0 Reviewed-on: https://gerrit.libreoffice.org/17438 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-07-15getFiles refactoring: kde4 partJulien Nabet1-9/+7
before: getFiles retrieves all files with their url getSelectedFiles just returns getFiles result after: getSelectedFiles retrieves all files with their url getFiles uses getSelectedFiles and truncates to 1 entry if necessary See http://nabble.documentfoundation.org/Dev-f1639786.html for discussion Conflicts: vcl/unx/kde4/KDE4FilePicker.cxx Change-Id: I56a0e2bc877f93e28f08d5ebaafd1826a92cef8b Reviewed-on: https://gerrit.libreoffice.org/17025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-13Broken codeStephan Bergmann1-1/+1
...from d11b244bf9b9115f5384d6ff43bdffc7f1289d71 "getFiles: truncate to 1 file only" Change-Id: I149489212db943f79dfda7f1012d22809f090851
2015-07-13getFiles: truncate to 1 file onlyJulien Nabet1-3/+6
See http://nabble.documentfoundation.org/Multiselection-needs-work-td4153207.html for details Change-Id: I7f855a067349381e2567bd15a8daa56aad412774 Reviewed-on: https://gerrit.libreoffice.org/16959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10vcl: forward declare boost::optional in settings.hxxMichael Stahl1-0/+3
... for 1134 fewer uses of optional.hpp and a saving of 673 MB of preprocessor input. Change-Id: I9e8020f3e1ae968db403174c1bc0c1eba1139ecb
2015-07-09tdf#92115 KDE4: better listbox themingJan-Marek Glogowski1-19/+41
This is not a final fix to apply full theming, but it makes the listboxes at least usable again. Change-Id: Ic83b8209208fddafe34e04f4e5e531f0d28e62bd
2015-07-09tdf#92110 KDE4: cleanup IsNativeControlSupportedJan-Marek Glogowski1-43/+34
Be (more) correct about the widgets and parts, we actually can draw natively in KDE4. Also add an assert, so drawNativeControl won't be called with values not supported by IsNativeControlSupported. Change-Id: Iac6c78194191a9cd059ace560c285263ce7c1045
2015-07-09tdf#92517 KDE4-FileDialog: "Save as" has wrong FilterJuergen Funk2-3/+8
Fixing follow - The order of calling: first should be set the filter, after that can be set the current filter - change the function from "setCurrentFilter" to "setCurrentItem" When you set the filter over "setCurrentFilter" you need the full search string "extention|description" e.g. "*.docx|Microsoft Word.." - Not need the escape of slash (with that can not find "Microsoft Word 2007/2010 XML (.docx))" Change-Id: Ie4f7d6fd619b391487ee944c3e745c855600ee54 Reviewed-on: https://gerrit.libreoffice.org/16721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-06-29tdf#92353 FileSave: Not confirmed for overwrite a file (unix)Juergen Funk1-1/+1
The setConfimOverwrite function must be set after setOperationMode function Change-Id: Id5ab54be502e9c96eba3d7ab600b5e06e241c8fd Reviewed-on: https://gerrit.libreoffice.org/16517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin1-5/+2
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann1-2/+2
Change-Id: I07bf1403e6b992807541a499b786d47f835b2f81
2015-06-02loplugin:loopvartoosmallStephan Bergmann1-1/+1
Change-Id: Iaa82f5e3180024db747a52d699aa77c16781afa0
2015-05-25cppcheck: noExplicitConstructorCaolán McNamara4-4/+4
Change-Id: I62076450ab77472bfd09b3fb9824f54b6ea1e0f7
2015-05-23Remove include stdio (part6)Julien Nabet3-10/+0
Change-Id: I4dde46c81b36b318710e32c8f420dff8d9c2e655 Reviewed-on: https://gerrit.libreoffice.org/15879 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-22convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin1-1/+1
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-15gtk3: render native menubar and menubaritemsCaolán McNamara1-0/+1
this needs the addition of a new MenuBarHighlightTextColor which defaults to MenuHighlightTextColor on other platforms Change-Id: Id0550294f1778229cbbe154857ba16c629dc5a87
2015-05-13Make it more obvious that the value combines DrawFrameFlags|DrawFrameStyleStephan Bergmann1-1/+2
Change-Id: I60b92fe2f9120b03293e5f880bb94a6c85e5a7ab
2015-05-13Fix kde4Stephan Bergmann1-1/+1
Change-Id: Id34bc6fbdbdc3c1f0b99ef9807fb7d27a00aec50
2015-05-13convert FRAME_DRAW constants to scoped enumNoel Grandin1-1/+1
Change-Id: I98e52aa56ec063ecc8f3d10baef65eb293c726bf
2015-05-12vcl: kde4: loplugin:staticmethodsMichael Stahl1-1/+1
Change-Id: Ie51eaa11e1ed1e811c9b671c1284f81e1459151d
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-22 09:51:41 +0000