summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)AuthorFilesLines
2017-04-06tdf#104686: do not crash if Menu has been somehow disposedAron Budea4-30/+56
The rare crashes in MenuFloatingWindow::ImplGetStartY() and MenuFloatingWindow::ImplScroll(bool) likely happen because of a disposed Menu. Let's guard against invalid accesses. Change-Id: Ie31240abbc48c06edd40d0a95f319725cdb3db16 Reviewed-on: https://gerrit.libreoffice.org/36026 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/36151 Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/36228 Tested-by: Aron Budea <aron.budea@collabora.com>
2017-03-24lok: Unit test for setting of the language during load of the document.Jan Holesovsky1-0/+9
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
2017-03-06ofz: Z_NEED_DICT is unsupportedCaolán McNamara1-2/+3
Change-Id: Ib0945d5a4606915aff9ee3019203caaf2a3cc7c5 (cherry picked from commit aacaacc16938b030a1341d8dbaf56c6a2efeb1dc) Reviewed-on: https://gerrit.libreoffice.org/34744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 92fcd775ef67df1c96a417151a60a94530379b8f)
2017-02-27Resolves: tdf#101972 skip invalidating labels on alt if autoaccel is disabledCaolán McNamara2-2/+2
so no Invalidate will be called if auto accelerators are not enabled so there should be no blinking under windows (cherry picked from commit f67dc04cfdd9e63a45ec6c8bc00829bce8f17d4b) Change-Id: Iccc5dad7af41f39ac02d3be93e935f2d926a82a6 Reviewed-on: https://gerrit.libreoffice.org/34077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 0d8746c091ce3e70340c431da8d35d453d2b3b2c)
2017-02-10ofz#574 sanitize png palette indexesCaolán McNamara1-5/+38
clarify we're not setting a pal index in the mask no logic changed intended, SetPixelIndex expands to this, just want to clarify that this is an alpha value, not an index into a palette (cherry picked from commit e5b23d924d60e7a0fb67c44c6dad3f4cb3bd5ddc) e9bb188b116adf3eab4e2bb1d6da8badbaead88b crashtesting: fix tdf95481-1.odg reexport to odg failure revealed since commit 81e3ca4f60e6ac0823c1233841c22a759cfe937f Author: Tor Lillqvist <tml@collabora.com> Date: Tue Jun 21 10:34:21 2016 +0300 Use real assert() instead of DBG_ASSERT() sanitize invalid palette entry indexes at the outer perimeter on initial load to try and avoid having to do it in all sort of places in the interior. png spec says that the palette has to appear before the first IDAT so we should always know the palette size here (cherry picked from commit 9d2fa0bfdc93fa9bfed7dea89d603b1611d7a6e0) Reviewed-on: https://gerrit.libreoffice.org/34036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 38f0a87ba8d840f7a79f6d466d833518470d337c) Change-Id: I006ffdf5c8c751e7e07b133716022e2a9b154478 6e04223adce1c88d037f9cf34862e6f54e381bb0
2017-02-08tdf#105461 PDF export: handle text fill colorMiklos Vajna1-0/+23
Text portion level background in Writer text was working already, as Writer paints its background explicitly, and then uses no text fill color in the metafile (that is turned into a PDF later). However, text fill color is used for Writer shape text and also in Impress. The rectangle is not just the text itself, but also the ascent / descent region, this matches the desktop rendering result. (cherry picked from commit ee32c7d8083ae1449d6b379034be92995c142da9) Change-Id: I644007ade43a8b9e663890643b826ae12c427ea5 Reviewed-on: https://gerrit.libreoffice.org/33795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 264f2265884b3d50103a5315c6bd46df3be04451)
2017-02-08ofz#502 negative indexCaolán McNamara1-1/+1
Change-Id: I4dd7bbc0b40e7ec648a5b5f4c45e13e8d8b330a5
2017-02-08Resolves: ofz#424 guard against broken dxary lengthCaolán McNamara1-25/+39
ofz#424 vcl: reset nLen too (cherry picked from commit 7f5a10a3aaf8b48156aeab168afb7648dae1e020) Change-Id: Ia2569e963edd75cd6c27399d33e73bafe8b3f073 Reviewed-on: https://gerrit.libreoffice.org/33321 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-08Resolves: tdf#94457 our EmfPlusSetPageTransform is malformedCaolán McNamara1-1/+0
we write a single short, resulting in a record of 0x000C in length MS-EMFPLUS spec has EmfPlusSetPageTransform as 0x0010 in length because we're not writing the 4 byte PageScale value. the previous pageunit unit we are writing is of value 1, which is UnitTypeDisplay, the same spec says... "The unit of measure for page space coordinates, from the UnitType enumeration. This value SHOULD NOT be UnitTypeDisplay or UnitTypeWorld" and footnotes that with... "Windows never writes those values to the PageUnit field, but they are accepted with undefined results." Reviewed-on: https://gerrit.libreoffice.org/33560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit cf730cae337d06ac4efa72c9248b194d60d91c88) Change-Id: Ic8b5ec463b59aab28ae9897947dfcdbd35b22048
2017-02-08ofz#439 protect against 0 len textCaolán McNamara1-2/+2
Change-Id: Ib67284636235b0d43df626a4aeed67f2bc64b491 Reviewed-on: https://gerrit.libreoffice.org/33376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 4f8205659a810e4f89ff1fc0148393aefec53f97)
2017-02-08ofz#463 unable to mmapCaolán McNamara2-1/+10
Reviewed-on: https://gerrit.libreoffice.org/33519 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f6c465bc8e7583a8321f5c881cb008b980e0e3fa) Change-Id: I509faeda019f42bbe7cdc5fc249f2ea2076bb702 Reviewed-on: https://gerrit.libreoffice.org/33522 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-02-08ofz: reduce scope, check stream, validate nActionsCaolán McNamara1-10/+25
(cherry picked from commit bd78b28a1233e26c023a52df6b119d60a61d53ad) Change-Id: Ie420ad40b0d852708828620cd26c2f746398f5a8 Reviewed-on: https://gerrit.libreoffice.org/33260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-08ofz#419 same problem as wmf and emfCaolán McNamara1-2/+5
Change-Id: If2063563ace56f285f332b9e85ef81ea8f671859
2017-02-08ofz: ensure all not explicitly set indexes are zeroCaolán McNamara1-1/+3
Change-Id: Idbe6ceeb61d3dfe26f281349181e7a60f7e59000 (cherry picked from commit 14d9b3519adac8543b52ddb84e49eecbdd1d9eb2) Reviewed-on: https://gerrit.libreoffice.org/33036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit fc342c44c46287bbeb8bfb76d93fe601c87b8c5f)
2017-02-08ofz#394 xbm ParseDefine problemCaolán McNamara1-2/+2
Change-Id: I75fb761d23fdb3780088a9d209200429edb57a26 Reviewed-on: https://gerrit.libreoffice.org/32878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 864e59042bf4475428e182aa93256aaef2ac4e2e)
2017-02-08Resolves: ofz#313 cbBmiSrc > getDIBV5HeaderSizeCaolán McNamara1-4/+13
Change-Id: I67fb67dc0a4cb609b8f1391c1eb6dd395755a933 (cherry picked from commit 7485fc2a1484f31631f62f97e5c64c0ae74c6416) (cherry picked from commit 371f0f6770add78ae81e0f769d0490874bca353c) Reviewed-on: https://gerrit.libreoffice.org/32338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit f84516a348ea8e05bbf89816505a6041e711ebfd)
2017-02-08Related: rhbz#1405521 abrt reported crash in dndCaolán McNamara1-1/+1
Change-Id: I8d8f9379d36dd3dd1a8973cd9f9c14860765630b Reviewed-on: https://gerrit.libreoffice.org/32178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit a6eecb4ee85148d8a6a1697d794f9f8acc3d1562)
2017-02-08valgrind: stick 0 at end of successfully read dataCaolán McNamara1-2/+3
(cherry picked from commit 0dfc6f70ab53a773ee05664235d7c8927ab20f2c) (cherry picked from commit 3ea598f65bed096dbf4bda5fe4105b57c58b5310) Reviewed-on: https://gerrit.libreoffice.org/32335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 03b6eff8ba1d7102608221e6bf94f581aba2ee9d) Change-Id: Id79f68c9095ab313ac05d2c8b55df71788df81d3
2017-02-08Resolves: ofz#310: Sanitize 1 bit bitmap palette indexes tooCaolán McNamara1-17/+49
(cherry picked from commit b08e48166310ab8a53f06f4fee227a948416cf4a) (cherry picked from commit 3bff2da31ed580817f6b5b653f48727e38078af5) crashtesting: fix bmp->odg failure... id:000178,src:000000,op:havoc,rep:16.bmp id:000383,src:000047,op:flip2,pos:18,+cov.bmp id:000403,src:000047,op:arith32,pos:22,val:-33.bmp id:000317,src:000025,op:havoc,rep:8.bmp id:000119,src:000000,op:havoc,rep:16.bmp id:000167,src:000000,op:havoc,rep:8.bmp revealed since commit 81e3ca4f60e6ac0823c1233841c22a759cfe937f Author: Tor Lillqvist <tml@collabora.com> Date: Tue Jun 21 10:34:21 2016 +0300 Use real assert() instead of DBG_ASSERT() sanitize invalid palette entry indexes at the outer perimeter on initial load to try and avoid having to do it in all sort of places in the interior. we load the palette before getting here, so we should always know the palette size here (cherry picked from commit 92cee94a262a3a2f43c87bb940c50cb90a2ebd89) Reviewed-on: https://gerrit.libreoffice.org/32333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 18c7f4fbb156455f74564d16ff807c2242ffe761) Change-Id: Ied2b71eb1c9088bbbff5fed97f7a04b43f4b4827
2017-02-08fix tdf#101832 and tdf#100617Thorsten Behrens1-0/+3
OutDev mapmode takes shortcuts for 'simple' mappings, so clear that flag once we set scale/origin away from defaults. Change-Id: I00321e27322d9cb8b86e6cc8400f6396d03328cc Reviewed-on: https://gerrit.libreoffice.org/30855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 5d1a788468ef94cd1de4400d3c1e38d768f7bf8d) Reviewed-on: https://gerrit.libreoffice.org/30876 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit cbac26485f1456b70c51969a1df11bf08643d894)
2017-02-08Resolves: tdf#97065 gtk3: Date field displayed incompleteCaolán McNamara1-1/+3
a spinfield with a dropdown is sort of weird, we should probably revisit this and see if SPIN and DROPDOWN are mutually exclusive and for DROPDOWN use ComboBox styles (cherry picked from commit 276732f3068cac65dd607b4f78abdcd918ed30ad) Change-Id: Id7f5c54974dc2dfd63ab30df18e14f6a67a8ea90 Reviewed-on: https://gerrit.libreoffice.org/30005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 1b1a2703aeea3c81e2153b04e2f4685f9840819a)
2017-01-07tdf#105151 - be more conservative about EndTracking / Tracking calls.Michael Meeks1-1/+5
We really shouldn't be emitting these into widgets after they are disposed - it serves only to confuse things. Restore behaviour to how it was before the VclPtr change for this. Change-Id: Ife666929f8aac0e4431a5e43970769692c11888c Reviewed-on: https://gerrit.libreoffice.org/32785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d788d37a16d382d7ff32a19e8d65e5c605ac55dd) Reviewed-on: https://gerrit.libreoffice.org/32790 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-12-19lok: refill font list if emptyHenry Castro1-0/+5
After preinit stage the font list is empty when creating documents. Change-Id: Ia6938d521626f4b4022f0f993e77c017e4932415 Reviewed-on: https://gerrit.libreoffice.org/32108 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-12-09tdf#100337 Message boxes showup empty with white backgroundNoel Grandin1-1/+2
the bug here was that we had, on the stack, going into the scheduler THREE times. Two of those were idles. The original code would end up always picking the first idle from inside ImplSchedulerData::GetMostImportantTask and then ImplSchedulerData::Invoke would just return because we were still inside that Idle, and the second Idle would never get executed Since the second Idle was responsible for painting the dialog in the bug, sometimes the dialog would never get painted. Reviewed-on: https://gerrit.libreoffice.org/31785 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 19a4eaab9a55a2ecb33b727bad6307c5a2badc23) Reviewed-on: https://gerrit.libreoffice.org/31798 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 3be163c72925824eeadf5e75f6e0cf6229d8ceab) Change-Id: Ia15b98a06e231c8e1c29450e05a76ad427e41e36
2016-11-30tdf#103747: Don't re-position images when re-playing a metafile.Jan Holesovsky1-3/+3
I am not sure it's a good idea to re-position them at all; but for the moment don't do that only with the metafiles, as I am not sure what the other consequences could be. (cherry picked from commit be5369e7aa426be8b88776f58aaaba1ae926229c) Change-Id: I50e50663149f7879ddc86149d92d44cf2d5df40d Reviewed-on: https://gerrit.libreoffice.org/31434 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-26tdf#101327 - tolerate exceptions during window construction better.Michael Meeks1-3/+13
It appears we can end up being a frame window, which is not added into the list of frames; so tolerate that. Change-Id: I7696e79636f7794f327027f0ca73363eef1937e5 Reviewed-on: https://gerrit.libreoffice.org/31235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-24tdf#100965: Restart on initialisation-time OpenCL crashTor Lillqvist1-0/+8
Add a flag to the OpenCLZone indicating whether we are performing the first-start OpenCL functionality verification, so that if we run into a crash that is caught by the VCL VCLExceptionSignal_impl() handler, we terminate the process with the EXITHELPER_NORMAL_RESTART status after first having disabled OpenCL use. The wrapper process will then restart soffice.bin. This is for Windows only so far. This matches what we do if OpenGL fails early during start of LibreOffice. Also, the enter() and leave() functions are not used anywhere (cherry picked from commit 32881f01833dbcefd5600e1135dd8743178bfd96) (cherry picked from commit b9898f03eb05411c508b1b02588812074d40417a) Reviewed-on: https://gerrit.libreoffice.org/28138 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e2d5eec6ad49bab6aac2295a1882bf75184aa50c) Change-Id: Ibb9bf3a86b7521bf16728de2a118ad4323be674b
2016-10-25tdf#103185: Add VCL backend being used to About dialogAshod Nakashian2-0/+12
The VCL backend is now shown on the About dialog. Reviewed-on: https://gerrit.libreoffice.org/29798 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 6b5b773488a4ab77b5c18d82e663e68692f14b33) Change-Id: I331960ec5352d8a7274870713a554c3fe4044db4 Reviewed-on: https://gerrit.libreoffice.org/30273 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-10-23Resolves: tdf#103051 pdf export assumed 1bit bitmaps were N1BitMsbPalCaolán McNamara1-3/+33
(cherry picked from commit 1c9096dad7dc2ee25d9ebe16ab02d5caba5f8a79) Change-Id: I2268d8b74f187d07f161f42cc9530be3ebbc86d0 Reviewed-on: https://gerrit.libreoffice.org/29796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 112f4bbea029d71ad35873d7e3585c8e1c01460d)
2016-09-20Resolves: tdf#91533 (rhbz#1364335) Tooltips are truncatedrpmbuild1-0/+11
Change-Id: Id9ec91ed9652f491e4e2a0556eeed27bf6517002 (cherry picked from commit e527edf06f8befb45b76ee8ebabe62e6dc885e45) Reviewed-on: https://gerrit.libreoffice.org/28220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 02b6a8ae5a0ad4ebb0c929ebf079e01eb76762f8)
2016-09-16LOK: tile rendering regression fixAshod Nakashian1-2/+2
Calc fast rendering requires us to offset the are being rendered and shift all bitmaps accordingly. This however is breaking Impress rendering since the offseting logic is common (in svx and vcl). This adds new API to enable or disable this local rendering (as opposed to rendering a full document as was previously done. The new flag is then set by Calc to enable the offseting logic in isolation without affecting other applications. In one case isolation was achieved by checking the MapModeUnit. Change-Id: Ia0aadfc3f6df7c1a891b97dc731f5897414c9420 Reviewed-on: https://gerrit.libreoffice.org/26367 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 60fdcda65bad242f99895cb453182578250fbdea) Reviewed-on: https://gerrit.libreoffice.org/26378 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c337011d2052ec3ddb80e61bcc4b0574b4e898ba)
2016-09-16LOK: fast tile rendering (graphics and buttons)Ashod Nakashian1-1/+13
Since embedded graphics and buttons use absolute coordinates, we set the origin to be the top-left corner of the tile. This includes the origin + ScrPos (see previous patch). Then, the coordinates of the graphic is shifted by this amount to make sure it renders in its relative position to the tile. This renders embedded graphics and buttons at their correct position, with some limitations. Tiles large enough to cover a graphic object show the graphic object where it should be. However, rendering a relatively small tile doesn't render the graphic. This seems to be an issue with moving the graphic's coordinate at a later stage than the 2D Processor decides what objects intersect with the 'view area' that is rendered. Another issue is that graphs don't render. What they seem to suffer is incorrect scale and a fix coordinates (they show up as tiny thumbnails at the top-left corner and grow in proportion to the real graph when resized). These shall be addressed in a separate patch. Reviewed-on: https://gerrit.libreoffice.org/26204 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 5f01d80f75dc86b393cc2fdb66b94aece964c674) Change-Id: I4b71bf5f2e357d1114d46022bc00905ceed0c2f9
2016-08-15Related: tdf#92516 make menu accelerators always work even if...Caolán McNamara1-11/+2
keyboard not used yet. The gtk2/3 menus appear to work this way. (And when not in gtk2/3 it shouldn't disable the accelerators for other platforms anyway) (cherry picked from commit f6d0d92a5e249413df99a7f3677a28efe6d45426) Change-Id: Ib7a99bd9039cd07120b3b77380f810b5b028fd57 Reviewed-on: https://gerrit.libreoffice.org/27795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 1288a0682ab4c960915722d2bb52a200e75580a3)
2016-08-02svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna1-1/+1
Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 4cbaa49c0ee707a2e1e1d842279b32473e8c8a28) Conflicts: sc/source/ui/view/viewfun3.cxx Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab
2016-07-22Resolves: tdf#100558 last 'section' of date field not incrementedCaolán McNamara1-1/+1
presumably a regression from... commit 3cad6c806e5247ce20b78eb688551aa5d872b934 Author: Chr. Rossmanith <ChrRossmanith@gmx.de> Date: Fri Mar 1 21:47:10 2013 +0100 Replace (Xub)String with OUString in vcl(field) where UniString::Search returned a max short on not-found while OUString::indexOf returns a -1 Change-Id: Ia3ef80dd318375ccdb3bdcee9bed7b70bf67cae1 (cherry picked from commit 82913e694a4169f9ddeef399e659aec78cc9c8d6) Reviewed-on: https://gerrit.libreoffice.org/27375 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 836a7634b2042de4f08fcc2296fc33ca2d040a60)
2016-07-21vcl headless: ignore visibility in GetClientSize()Miklos Vajna1-7/+0
This fixes the missing-invalidation problem outlined in commit 22023b104cd1e024aecc28a6161bea519a584407 (vcl lok: fix missing paints due to zero-sized windows, 2016-07-12) also in Writer, not only in Impress. Starting text edit, doing a change, and ending text edit now results in the expected invalidations. Ignoring visibility seems to be a better fix for the missing paints. This way the headless case doesn't hit the corner cases of 0x0-sized windows. Also, the gtk vclplug's GetClientSize() only returns 0x0 in case the underlying window is disposed or it's minimized, but it does hand out the size before Show() is called, so now the headless backend is in sync with that. Change-Id: I78698cbfce954c8c593d279ab057a87cfbe87260 Reviewed-on: https://gerrit.libreoffice.org/27224 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit ac0b3b05ab52d0ac06137cf93d71187c7957ec99)
2016-07-21vcl lok: fix missing paints due to zero-sized windowsMiklos Vajna1-0/+8
How to reproduce the problem: open an Impress presentation in gtktiledviewer, create two views. Start editing the text of a shape in one view -> nothing happens in the other view. There is no invalidation in the other view, as sdr::contact::ViewContact::AddViewObjectContact() is not called for either of the views. Editing with a single view only worked as when clicking into the shape, the ViewObjectContact is created. On the desktop, those ViewObjectContacts are created on the first paint of the slide, but in the LOK case the vcl::Window instances had a 0x0 size, so an invalidation didn't result in a paint -> no ViewObjectContact was created -> no LOK invalidation was sent. No testcase, as I didn't manage to write code that actually triggers the failure under cppunit with the fix reverted. Change-Id: If29fcea4258a45f3d6d9aab284445756609fa13c Reviewed-on: https://gerrit.libreoffice.org/27159 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 22023b104cd1e024aecc28a6161bea519a584407)
2016-07-21tdf#100600 sfx2 classification: never replace the control with labelMiklos Vajna1-0/+6
Thanks to Caolán McNamara for pointing out where is the condition of the replacement in VCL. Change-Id: I7e1ef4a016a37b25e084c4c6467a42ca557069a4 Reviewed-on: https://gerrit.libreoffice.org/27133 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 8192da8e4de7a058ef95253f992f4143f83fa0f1)
2016-07-20convert more DBG_ASSERT(false to SAL_WARNNoel Grandin6-9/+9
Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 272a8afa60fe9a6b497c69a58b0054ad5b880690) Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55
2016-07-20convert DBG_ASSERT(false, to SAL_WARN(Noel Grandin1-1/+1
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c Reviewed-on: https://gerrit.libreoffice.org/26187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit ab10f9fc11948ca0f463aa8c0c784a574c89f8f7)
2016-07-20remove some unnecessary castingNoel Grandin1-1/+1
Change-Id: I451df09db58256fed68ce8537b2d8eb4b6ab6942 Reviewed-on: https://gerrit.libreoffice.org/26184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 2ed5fa14f0e7624db241fde26e10fdd1009adfc7)
2016-07-20Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann9-21/+29
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. (cherry picked from commit 14cd5182c5f64c43581c82db8c958369152226ac) Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-07-20use Any constructor instead of temporariesNoel Grandin1-13/+5
(cherry picked from commit 58a32075ca4f457f570af75aef368dd6c389aca7) Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-07-20tdf#99352 - Some VclPtrs leak past DeInitVCLNoel Grandin1-0/+1
Change-Id: I74b27b1d8b662a644df580ae128643b8495355f8 Reviewed-on: https://gerrit.libreoffice.org/24204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 67d333c608a662621c1069aacdec75e45e33a183)
2016-07-20tdf#97087 Give comprehensible names to timersMuhammet Kara4-4/+4
Timers and idles should have programmer comprehensible, unique names Change-Id: I837d1890c687936f8a31278c0102391e6f87212d Reviewed-on: https://gerrit.libreoffice.org/23917 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c03a11b8f0c93b1c55d9abc9aa224aeb298d1976)
2016-07-20tdf#95857 Sort out German plurals ...danielt9981-2/+2
Made a start in removing the incorrect 'Infos' German plural Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 2b31daf74e33b988c849cb26e88fa7657a4015af) Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60
2016-07-20vcl: bmpacc.hxx -> bitmapaccess.hxxChris Sherlock40-40/+40
(cherry picked from commit 88730cdae3520b18fc073dc59bd0ed660e15d6b4) Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-07-20Fix typosAndrea Gelmini4-5/+5
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 534b2a4b58ba765dbc256d6297e33453524915e2)
2016-07-20vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock11-19/+19
Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> (cherry picked from commit 28c96fc2553a5c3dee108f1e2060d7bc081a7e7e) Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f
2016-07-20Fix typosAndrea Gelmini26-33/+33
Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 64d624b65124ac02d8ee59b135593fd9d8eb9067) Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 21:31:43 +0000