summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)AuthorFilesLines
2017-11-24don't worry about dangling timers at fuzzer exitCaolán McNamara1-1/+2
Change-Id: I9e18257f7e6e0438c6ce2801c0c2f8885b060870 Reviewed-on: https://gerrit.libreoffice.org/45214 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-24Modernize pdfwriter_impl by using for-range loops (vcl)Julien Nabet1-155/+143
Change-Id: I82354a03b94b126a7aed460d9cd46d37b8f38ada Reviewed-on: https://gerrit.libreoffice.org/45173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23tdf#111782: fix Wrong rendering of image radiobutton on Split Cells dialogG??bor Koruhely1-0/+5
The radio button icon was too big and there weren't enough space to render the bottom border, so I reduced the size of the radio button icon. Change-Id: Ie93f21ca730329716d0d209726e4d41c5d235b88 Reviewed-on: https://gerrit.libreoffice.org/45097 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann5-20/+20
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23Replace list by vector for m_aJPGs pdfwriter_impl (vcl)Julien Nabet2-7/+7
+use for range loop just for the loop containing "std::list" Change-Id: Ie30dc016e9a001d0bb4ecd31a75749093326e2f6 Reviewed-on: https://gerrit.libreoffice.org/45112 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin5-6/+6
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann1-2/+2
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22replace check of eof and GetError with goodCaolán McNamara3-9/+8
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291 Reviewed-on: https://gerrit.libreoffice.org/45076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara7-29/+29
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin1-1/+1
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21silence warningCaolán McNamara1-1/+1
Change-Id: I22e37ed4be19a39c061015f81938ab2d854db9b5 Reviewed-on: https://gerrit.libreoffice.org/45042 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-21assert that mnPngDepth can only be 16 hereStephan Bergmann1-0/+4
...due to how PNGReaderImpl::ImplReadHeader sets up the various PNGReaderImpl data members. Shows that the "(and, TODO, also in the mbAlphaChannel case)?" from bb11e1283e3d49ec1bfe14c4271edbd49af3e3c1 "ASan heap-buffer-overflow" does not need any further fixes. Change-Id: Ie942e22dc67b2704c7c74b7b70e474b34173e9d1
2017-11-21loplugin:unnecessaryparenStephan Bergmann1-1/+1
...with a Clang build with <https://reviews.llvm.org/D40167> "In stdbool.h, define bool, false, true only in gnu++98" locally fixed Change-Id: Ib85111cf8d058b6d7be6460af5266dfccb28c951
2017-11-21ASan heap-buffer-overflowStephan Bergmann1-0/+16
e.g. during CppunitTest_sd_misc_tests (see <https://ci.libreoffice.org/job/lo_ubsan/735/console>) after 66dbd4da3afcadb1393daf9be9cecff71b86509a "tdf#113918: Workaround: Load 1bpp indexed PNG as 8bpp indexed Bitmap". Looks like PNGReaderImpl::ImplDrawScanline also needs to special-case mnPngDepth == 1 in the mbTransparent case (and, TODO, also in the mbAlphaChannel case)? Change-Id: Ie6a0230ec606f7cc5aaf174b9c0075a3b4cb5b1d
2017-11-20tdf#113918: Workaround: Load 1bpp indexed PNG as 8bpp indexed BitmapTor Lillqvist1-3/+28
The alternative, to fix the X11 disaster area used by the gen, gtk, and kde4 VCL plugins, seemed more difficult. Somebody else with more time, feel free to revert and do that instead. Change-Id: I068ea27224ba98be25e01671546137ddd70691a7 Reviewed-on: https://gerrit.libreoffice.org/44957 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-11-20tdf#95656 vcl: correct offset for vkrn positionMark Hung1-3/+2
For Bopomofo tone marks to attach to anchor points. Change-Id: I66373790cb80515f4ab0ca9c166f78634eb4081c Reviewed-on: https://gerrit.libreoffice.org/44922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin1-1/+1
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-18silence some coverity warningsCaolán McNamara1-1/+1
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d Reviewed-on: https://gerrit.libreoffice.org/44875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-17tdf#111717 consider CJK vertical writing for underline offsetMark Hung1-1/+4
Textline offset was based on horizontal font metrics. In vertical writing for CJK fonts, use descent as its underline offset so that the line is drawn at the edge of the bounding box to prevent overlap the CJK glyphs. Change-Id: Iaa01bdf3cbb694dcf925975cde3f0f7ba7b97dac Reviewed-on: https://gerrit.libreoffice.org/44720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-11-17tdf#111967 translate offsets so it is relative to v originMark Hung1-0/+7
The offsets were 0 in HarfBuzz 1.3.3 but the value became something else and made text offsets toward upper-right after upgrading to HarfBuzz 1.4.8. Those values are offsets relative to the horizontal origin. But underlying renderer expect positionos relative to the vertical origin. Translate them back by adding the horizontal origin. Change-Id: If58d2c082b198bfd8789efb3df2be49869a04bf9 Reviewed-on: https://gerrit.libreoffice.org/44556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-11-17ofz#4291 Direct-leakCaolán McNamara1-60/+70
can't reproduce this, but throw a guess at it Change-Id: Iff6198c463bbab4e3ef87ec62eaa13e88d016a23 Reviewed-on: https://gerrit.libreoffice.org/44890 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-17ofz#4076 bad palette READCaolán McNamara1-2/+6
Change-Id: I54943d96baa6e2309bbf2cd3b6d8bcada2b76952 Reviewed-on: https://gerrit.libreoffice.org/44351 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-17Resolves: tdf#112943 don't close popups on resize if size didn't changeCaolán McNamara1-2/+3
Change-Id: If5331248f69098570c87da060595f5a85721c2d2 Reviewed-on: https://gerrit.libreoffice.org/44882 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-17loplugin:casttovoid (--disable-pdfium)Stephan Bergmann1-7/+2
Change-Id: I38017e3b191ef210facf46323c9a3bb5f54bf0a3
2017-11-17vcl: clean ImplFontMetricData::ImplInitTextLineSize a little bit.Mark Hung2-15/+19
Move initialization of FullstopCenteredFlag out of ImplFontMetricData::ImplInitTextLineSize since it has nothing to do with text lines. Change-Id: I1c2e383d980514c8727d736a3158325c1e0ccfda Reviewed-on: https://gerrit.libreoffice.org/44712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-11-17loplugin:useuniqueptr in MultiSalLayoutNoel Grandin1-6/+4
Change-Id: I57ac9cf988dfccfcb38c69ca9c66c2ad77bbdada Reviewed-on: https://gerrit.libreoffice.org/44819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-16vcl: StyleSettings - start to unwind code duplication.Michael Meeks1-1/+18
This should be a pure re-factor, plus: switch from Serif -> Sans font default for the UI (wow). enable larger font size for LOK only that avoids a hard to debug svx junit test failure. Change-Id: Id438026064983ea4907819bab55c4be740954605 Reviewed-on: https://gerrit.libreoffice.org/44625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-16ofz#3002 set a limit to how broken a jpeg is to give up recoveringCaolán McNamara1-0/+20
take ImageMagicks 1000 warnings as the starting point Change-Id: Id685764404d27b151daf031a4860055f64dd0915 Reviewed-on: https://gerrit.libreoffice.org/44818 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16tdf#113875: Properly export 1bpp greylevel (but not B&W) PNG images to PDFTor Lillqvist1-4/+23
No idea whether 1bpp non-greylevel (i.e. with two palette entries that aren't shades of grey) PNG images are mishandled. Change-Id: I72173c7398db7f0e93c19679e3e392949bf1f4d2
2017-11-15lokdialog: Expose cursor visible statusPranav Kant2-16/+47
Change the notifyDialog API a bit. Use a std::vector to keep track of each payload item that needs to be fed to the resulting JSON. Change-Id: If3229a88d2df5368e14290a0e80ebe6206780639 Reviewed-on: https://gerrit.libreoffice.org/44722 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-15lokdialog: Callback for dialog cursor invalidationPranav Kant2-0/+24
Change-Id: Iecadb68737ed7b1a425d9ea633976fb24d1055c6 Reviewed-on: https://gerrit.libreoffice.org/44721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-15loplugin:flatten in vclNoel Grandin25-2124/+2162
Change-Id: I3527477277a9ae96eaf9fd068232f672da7c28c3 Reviewed-on: https://gerrit.libreoffice.org/44753 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15Related tdf#113652: fix crash when closing Data providerJulien Nabet1-1/+1
Test also mpScrollBar to know if should keep on with RecalcAll bt: 5 0x00007fffec06b6f0 in vcl::Window::Hide() (this=0x0) at /home/julien/lo/libreoffice/include/vcl/window.hxx:948 6 0x00007fffec2eb344 in ListControl::RecalcAll() (this=0x555558b25090) at /home/julien/lo/libreoffice/vcl/source/control/listctrl.cxx:76 7 0x00007fffec2eb6ec in ListControl::queue_resize(StateChangedType) (this=0x555558b25090, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/control/listctrl.cxx:110 8 0x00007fffec24c6b0 in vcl::(anonymous namespace)::queue_ungrouped_resize(vcl::Window const*) (pOrigWindow=0x555558b06620) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1343 9 0x00007fffec24c799 in vcl::Window::queue_resize(StateChangedType) (this=0x555558b06620, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1362 10 0x00007fffec14a701 in VclContainer::queue_resize(StateChangedType) (this=0x555558b06620, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/window/layout.cxx:179 11 0x00007fffec24c6b0 in vcl::(anonymous namespace)::queue_ungrouped_resize(vcl::Window const*) (pOrigWindow=0x555558b287b0) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1343 12 0x00007fffec24c799 in vcl::Window::queue_resize(StateChangedType) (this=0x555558b287b0, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1362 13 0x00007fffec14a701 in VclContainer::queue_resize(StateChangedType) (this=0x555558b287b0, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/window/layout.cxx:179 14 0x00007fffec24c6b0 in vcl::(anonymous namespace)::queue_ungrouped_resize(vcl::Window const*) (pOrigWindow=0x555558b26fd0) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1343 15 0x00007fffec24c799 in vcl::Window::queue_resize(StateChangedType) (this=0x555558b26fd0, eReason=StateChangedType::Visible) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1362 16 0x00007fffec25f2d5 in vcl::Window::StateChanged(StateChangedType) (this=0x555558b26fd0, eType=StateChangedType::Visible) at /home/julien/lo/libreoffice/vcl/source/window/window.cxx:1940 17 0x00007fffec2675ae in vcl::Window::CompatStateChanged(StateChangedType) (this=0x555558b26fd0, nStateChange=StateChangedType::Visible) at /home/julien/lo/libreoffice/vcl/source/window/window.cxx:3696 18 0x00007fffec260548 in vcl::Window::Show(bool, ShowFlags) (this=0x555558b26fd0, bVisible=false, nFlags=ShowFlags::NONE) at /home/julien/lo/libreoffice/vcl/source/window/window.cxx:2200 19 0x00007fffec06b6f0 in vcl::Window::Hide() (this=0x555558b26fd0) at /home/julien/lo/libreoffice/include/vcl/window.hxx:948 20 0x00007fffec256f11 in vcl::Window::dispose() (this=0x555558b26fd0) at /home/julien/lo/libreoffice/vcl/source/window/window.cxx:394 21 0x00007fffec2b1395 in Control::dispose() (this=0x555558b26fd0) at /home/julien/lo/libreoffice/vcl/source/control/ctrl.cxx:68 22 0x00007fffec289da8 in Button::dispose() (this=0x555558b26fd0) at /home/julien/lo/libreoffice/vcl/source/control/button.cxx:109 23 0x00007fffec3ef640 in VclReferenceBase::disposeOnce() (this=0x555558b27240) at /home/julien/lo/libreoffice/vcl/source/outdev/vclreferencebase.cxx:42 24 0x00007fffca047c8a in VclPtr<PushButton>::disposeAndClear() (this=0x555558b068c0) at /home/julien/lo/libreoffice/include/vcl/vclptr.hxx:208 25 0x00007fffca0432a6 in ScDataProviderBaseControl::dispose() (this=0x555558b06620) at /home/julien/lo/libreoffice/sc/source/ui/miscdlgs/dataproviderdlg.cxx:104 Change-Id: Ie1f2b156a5743354f39e95048e50bb0709095fd0 Reviewed-on: https://gerrit.libreoffice.org/44697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-14ofz: if parsing failed we keep reparsing itCaolán McNamara1-1/+4
Change-Id: I656eb1144a652addbc4a0b07b5d5dd435b68bf2c Reviewed-on: https://gerrit.libreoffice.org/44714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-14Fix typosAndrea Gelmini1-1/+1
Change-Id: I53b47cab5cbc603bf11adcda8ac2a8373eef26a8 Reviewed-on: https://gerrit.libreoffice.org/44695 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-14use std::unique_ptr for SalLayoutNoel Grandin7-77/+45
to make the ownership passing around more obvious Change-Id: I147ec6d9cfe7566cf3600685e0730ed741c2d90d Reviewed-on: https://gerrit.libreoffice.org/43454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-13Resolves: tdf#113366 Contour editor does not openCaolán McNamara1-0/+5
reportedly This reverts commit 15869ea2dcd8a6b33044d08eef6fcaf8ca54579d. Change-Id: I930567f8dd9701a14ab02f42f89a629949453f22 Reviewed-on: https://gerrit.libreoffice.org/44671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-13Fix typosAndrea Gelmini1-1/+1
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-11ofz: XPMReader::ImplGetColKey short readCaolán McNamara1-0/+3
like commit 10a2388558df957b30136ba32ecc97ddef43fb57 Date: Tue Jan 17 12:35:24 2017 +0000 ofz#411: XPMReader::ImplGetColKey short read Change-Id: Iffc7ddb00b2849b2f9fad17314086b87d3097660 Reviewed-on: https://gerrit.libreoffice.org/44628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-11vcl: StyleSettings - start to unwind code duplication.Michael Meeks1-0/+13
This should be a pure re-factor, plus headless tweak. Change-Id: Iad7f524ea76625601b3f85cc13a50311ed1de171 Reviewed-on: https://gerrit.libreoffice.org/44624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-10loplugin:unusedmethodsNoel Grandin2-26/+0
Change-Id: I543b0943f0bc918d59debc8ee051f88c29d18454 Reviewed-on: https://gerrit.libreoffice.org/44553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-09loplugin:unusedvariable add some more std:: typesNoel Grandin1-3/+0
Change-Id: Ib15931e415990b56367fe3e1c7cf3f22cc4826d5 Reviewed-on: https://gerrit.libreoffice.org/44529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-09lokdialog: Invalidate-all when size is changedPranav Kant1-0/+11
Change-Id: Ic96fab62c1525154a60c0fa84e2a12ccfad15ae2
2017-11-09tdf#113428: Fix glyph positions in PDF exportKhaled Hosny1-4/+10
Not sure what is going on, but PDF export is the only place we call GetNextGlyphs() with nLen > 1 and it seems I broke something here in b894104a0b02a9b074c76feb925389d7bee6a493. Instead of trying to figure out what the old code was trying to do, lets just calculate glyph positions for the extra glyphs as GetNextGlyphs() does for the first one, making PDF export closer to how the rendering on screen works. Change-Id: I3f516e954ccfbe38abcf6985efe3bb1f998e967f Reviewed-on: https://gerrit.libreoffice.org/44514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-11-09lokdialog: Support painting parts of the dialogPranav Kant2-4/+6
Pass the dimensions of the region to the paintDialog call to paint only that much of the region in the dialog. The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in the payload that tells the region of the dialog invalidated. It can be used in combination with the new paintDialog call then to paint only the invalidated region in the dialog. Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906 Reviewed-on: https://gerrit.libreoffice.org/44472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-09Resolves: tdf#113562 desired window didn't get the inputCaolán McNamara1-3/+4
Change-Id: I4a2089a715dc67783bfd18d2ee0e55193c4ed741 Reviewed-on: https://gerrit.libreoffice.org/44500 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-09rename AvoidConfig to FuzzingCaolán McNamara7-20/+20
cause that's what its really used for and a couple of cases are not specifically about avoiding config but avoiding uninteresting disk acccess and what not Change-Id: I4c6454f98388579fcd0bf9798321d30408ab65ee Reviewed-on: https://gerrit.libreoffice.org/44491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08Retrofit "KeepEmptyLinesAtTheStartOfBlocks: false" into .clang-formatStephan Bergmann1-43/+120
...even if that can cause reformatting of already formatted code. The problem I came across is that without this something like > namespace { > > void f1(); > > void f2(); > > } (which is quite a common style in the current code base) would be changed to > namespace > { > > void f1(); > > void f2(); > } instead of > namespace > { > void f1(); > > void f2(); > } and I found no other clang-format style option that would result in the presence or absence of an empty line be identical at the start and end of the namespace block. vmiklos asked to reformat the existing new (i.e., non-blacklisted) files at the same time, so this commit includes that. Some of those new files had not been formatted at all, so this commit includes their full reformatting changes. Change-Id: I54daf0c11098d07d02c802104cf7f56372e61f7c Reviewed-on: https://gerrit.libreoffice.org/44450 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-07Fix harfbuzz font lifecycle in CommonSalLayoutJan-Marek Glogowski1-35/+53
The harfbuzz font is attached to the system font face and therefore inherits its lifecycle. This means it can be used in multiple CommonSalLayout objects, so the user data parameter of hb_face_create_for_tables can't be the layout, but must be the font. This moves the special Qt5Font handling into it's own function, so accessing the switching parameter mbUseQt5 is not needed. Regression from commit b66a7cbd8491fe436126e11975c360f47ae346ed. Change-Id: Ic34cc5b60e401562c73b239a58176a59fe4bf9be Reviewed-on: https://gerrit.libreoffice.org/44398 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-07fix !HAVE_FEATURE_PDFIUM buildCaolán McNamara1-1/+1
Change-Id: Ied661aafbaf9d85b01ef57e83bbacd9f9a828f2b