summaryrefslogtreecommitdiff
path: root/vcl/source/window
AgeCommit message (Collapse)AuthorFilesLines
2015-11-17loplugin:unnecessaryvirtualNoel Grandin3-28/+4
update the plugin with lessons learned from the mergeclasses plugin and re-run it Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711 Reviewed-on: https://gerrit.libreoffice.org/20015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann1-1/+2
Change-Id: I7a741130689721c69fd2879be6bda27fc6ec3646
2015-11-16Move functionality to retrieve command image to CommandInfoProviderSamuel Mehrbrodt2-84/+2
Change-Id: I79c22e0507c5eba8b5e28721de3279131aececc9
2015-11-16Move CommandInfoProvider to vcl and use it from thereSamuel Mehrbrodt2-39/+6
Change-Id: If7e3ef81cad8974bc54f359096e3ecc700fa62d6 Reviewed-on: https://gerrit.libreoffice.org/19984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-4/+2
performed using: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f Reviewed-on: https://gerrit.libreoffice.org/19968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-14sw lok comments: implement mouse move and mouse upMiklos Vajna1-1/+4
As long as we don't tweak the map mode of the comment widgets permanently we also have to disable the selection engine's timer, as that would emit events without the correct map mode: so disable that for the LOK case for now. Change-Id: If377ff2f064c30feb473f153f9d5b29b8ace7113
2015-11-13vcl: loplugin:passstuffbyrefMiklos Vajna1-2/+2
Change-Id: I4ad2b77112a2c9bfbf76f0b84275d88046ed3851
2015-11-13Vcl: Add TooltipLabel to vcl buttons alsoSamuel Mehrbrodt2-4/+11
Change-Id: I332041e2d1d53f56cd38c1cd1ca325252535a53c
2015-11-12Resolves: tdf#93317 Modified Document Dialog misses focus on Gtk3Caolán McNamara1-0/+1
Change-Id: I16ddac82a76a1e665797e4be192d3642f2660d9f
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann1-1/+1
Change-Id: I90a955eb3e485723bb81e7164edcf60f7b0e94c7
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann54-623/+623
Change-Id: I05e89f9896170d4df3d1377549ea074f06b884a0
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann4-39/+39
Change-Id: I7ac150458a72963f3336d30ef9d99d7c0d81c024
2015-11-04yyyyyNoel Grandin1-1/+1
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-03vcl: Mark it as constTakeshi Abe1-1/+1
Change-Id: I0ddaf1cf9d0a3f36f88bea3101b7059e04d755ff
2015-10-30tdf#93684 - Remove SalFrame::SyncRyan McCoskrie1-6/+0
Change-Id: Icae9cf0a17f9cdf9a671c7e7278019d6980602b1 Reviewed-on: https://gerrit.libreoffice.org/18453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-22tdf#94138 fix printing of edit form fieldsTomaž Vajngerl1-1/+1
There are 2 bugs: - In Window::GetDrawPixelFont we asked for the font to the current window, which didn't work correctly when printing. The device itself should provide the font and not the window. - In paint method the font wasn't setup correctly which should happen before painting by calling ApplySettings. The effect of this is that print preview didn't show the correct font for the edit control and similar when you copy + paste the edit control. The work around for this is to call ApplySettings again. Change-Id: I74960355823c71c1d5a18a82bbc86561a3c4b760
2015-10-22vcl: add Window::SetClipboard()Miklos Vajna1-0/+6
Change-Id: I385f64b7d5015c9a34f34a436b0ee2ce6b3a83d3
2015-10-20loplugin:defaultparamsStephan Bergmann7-12/+10
Change-Id: I3e5ee77b51eb8e1207d3f95e6a1d9d8272532ba6
2015-10-19loplugin:defaultparamsStephan Bergmann6-13/+13
Change-Id: I8db42173f116372b1c849284540c111635c3582e
2015-10-19convert DBG_ASSERTWARNING to SAL_WARN_IFNoel Grandin3-3/+3
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes much more sense. Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19convert remaing DBG_WARNING to SAL_INFONoel Grandin1-1/+0
and drop the macro Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-16convert Link<> to typedNoel Grandin1-13/+11
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin2-8/+4
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15loplugin:vclwidgetsStephan Bergmann1-1/+1
Change-Id: I2e73a85a3d8cab0a73c8c776d7406d99411d95d0
2015-10-15vcl: Initial NotebookBar implementation.Jan Holesovsky4-14/+147
See https://wiki.documentfoundation.org/Development/NotebookBar Change-Id: I91535c13d68261f7195989ec78bd305cf572c87c
2015-10-15cppcheck:variableScopeNoel Grandin3-24/+15
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884 Reviewed-on: https://gerrit.libreoffice.org/19364 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-14convert Link<> to typedNoel Grandin1-4/+4
Change-Id: I1876f327607e0e23292950741df348d4ec31fde1
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann6-65/+65
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12convert Link<> to typedNoel Grandin1-12/+9
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12convert Link<> to typedNoel Grandin1-1/+1
Change-Id: Ib9a493af0f64c5f3eb50f392805c3278ed2164a0 Reviewed-on: https://gerrit.libreoffice.org/19304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann1-14/+8
Change-Id: I11b99fca91b266bdf6c29dc142511bf01dbd4bed
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann1-2/+0
Change-Id: Ib9eae95b8ace37d31e905bc098c67de97b7816e3
2015-10-09Abstract out repeated code into lambdasStephan Bergmann1-43/+29
...to silence a clang-analyzer-deadcode.DeadStores on the last update of nLeft and nRight, each. Also, adding a gap of 3 to nRight in case no further buttons will be layed out next to maDockRect resp. maHideRect is irrelevant, as nRight will not be used for any further layout computations in those cases. Change-Id: I251d4470099b1f98782ebdfd0c776d881bb7fae5
2015-10-08fix for tdf#94827 - ToolBox events aren't deliveredNoel Grandin1-3/+4
regression from 1e67e94f1a308ca60d4934e9fe9d5c048225ebe8 "convert Link<> to typed" Change-Id: Ibb20366f0edcb9425d61ce5e9d5fb1a34533785b
2015-10-07fix some indentCaolán McNamara1-13/+13
Change-Id: I59f5a38f6c62b97eb73d85177be408996568e2cd
2015-10-06loplugin:unusedmethodsNoel Grandin1-8/+0
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06loplugin:mergeclassesNoel Grandin1-25/+49
and move the boost-depending code inside the module, no need to expose that dependency and include that header in all client code. Change-Id: Ib991572d7a54a9ad16825d688e76f8e3a824803c
2015-10-05convert SAL_FRAME_STYLE to scoped enumNoel Grandin1-16/+16
Change-Id: Ic3f7fddcea36c18ffe43c4c633d415f596a58cbc Reviewed-on: https://gerrit.libreoffice.org/19094 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-02Allow non ASCII chars as accelerator keysNiklas Johansson1-2/+2
Non ASCII characters like åäö can be used as accelerator keys (Alt+<x>). This already works however at the moment it is not exposed properly to accessibility tools such as screen readers. After this patch at least NVDA gets information about accelerator keys that are non ascii. On Linux we need to adapt code in vcl/unx/atk/a11y/atkaction.cxx. There is also vcl/source/window/dlgctrl.cxx#Window::GetActivationKey should probably have similar treatment and I guess that it is related to accelerator keys in dialogs but I need to confirm that. I'm a bit unsure how to best do that so I'll save it for later. Change-Id: I1f1509a26d781011d217670266bd10b2107811d5 Reviewed-on: https://gerrit.libreoffice.org/19078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-30tdf#92702 Unable to select menu items that were initially off-screenLászló Németh1-1/+1
Revert "Last item of menu with title cannot be hilighted" This reverts commit 8ced97caa409d6dc8f69230145e9c9f281fb84fe.
2015-09-30Fix typosAndrea Gelmini11-13/+13
Change-Id: I2cf36eb80068adcf57238a286f09bdc96b4e01f8 Reviewed-on: https://gerrit.libreoffice.org/18994 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann5-55/+55
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29XFrame parameter to SetMenuBar() is actually never used.Jan Holesovsky2-3/+6
Change-Id: I9413f575c0964d6cbf8a32d0b85c9f2c686bb8fc
2015-09-21convert Link<> to typedNoel Grandin1-7/+22
Change-Id: If3e2b00092440ebd42ae5b73ae2b0e44c3702683
2015-09-20convert Link<> to typedNoel Grandin7-35/+44
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511 Reviewed-on: https://gerrit.libreoffice.org/18700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-20convert Link<> to typedNoel Grandin1-19/+37
Change-Id: I86bf78c69251b5cd4d18edf3542e70eb2e8f32e1 Reviewed-on: https://gerrit.libreoffice.org/18699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-16GL paint-flushing guard re-work.Michael Meeks1-12/+4
Unfortunately, since we can have 2x SalGraphics' on a OutputDevice, and one of these can be a printer - things got very confused around which context to glFlush. This de-tangles the various reference-counts. Change-Id: I1062be0b02a91fc9009deaa3ec29c5dbb227df20 Reviewed-on: https://gerrit.libreoffice.org/18604 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-16clean up VclEventListeners and VclEventListeners2Noel Grandin1-4/+12
Move them inside the vcl module. there is no need to expose their implementation. Make the VclEventListeners2 implementation similar to the VclEventListeners implemenation - I can't see the benefit of this extra complication with invalidated iterators, given the very small number of listeners typically on such a list. Change-Id: I040ddd24b10d2109af13ee25b5181703af17a109
2015-09-16convert Link<> to typedNoel Grandin3-5/+5
Change-Id: If6334d32abbec379acbb9def98fdf6cb5144238b
2015-09-16convert Link<> to typedNoel Grandin3-6/+6
Change-Id: I628de57f87b4ba20a797d345bdf71cf10cf148fc