summaryrefslogtreecommitdiff
path: root/vcl/source/window
AgeCommit message (Collapse)AuthorFilesLines
2020-09-02AlwaysDisableInput newly unusedCaolán McNamara1-28/+1
Change-Id: I0cdb7b74487f2338d16eca85616f840d921dad5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101874 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02IsCallHandlersOnInputDisabled newly always return falseCaolán McNamara2-12/+0
Change-Id: I4abfab9a413e3e43e23839f2cf3b0c26dcdea3a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101853 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02SetCallHandlersOnInputDisabled is newly unusedCaolán McNamara1-12/+0
Change-Id: I4225ce786b83f44178a477ac034d8f8f5198159e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101852 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01reduce KeyFuncType down to just the used categoriesCaolán McNamara1-14/+3
Change-Id: I97608bcabb30eba94278562254f7f9954af080f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101837 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-31Remove remains of private:image/ via ImageIdentifier addon propertyMaxim Monastirsky1-5/+2
This is broken since commit 5c39b28a87060f80404079ab77604f664addb063 ("tdf#96059 Replaced imageproducer with CommandInfoProvider") but so far no one complained (maybe because the usefulness of such internal images from extensions is questionable at least). Given also that the whole ImageIdentifier feature (even its still working part) is obsolete since OOo 2.0.3 (according to the OOo dev guide), and that the availability of a particular image from an internal hardcoded image list by a particular numerical id is more an implementation detail, let's just remove the broken code instead of fixing it. In the meantime, the code was also copied into the newly introduced notebookbar addon code, so I handled it there too. There are also the registry schema and a sdk example that mention this feature, and need to be adjusted. Interesting that the particular example used there - private:image/3216 is actually broken since 2011 with commit 2559cab126f81375197051fb5b07ba6abb9efc77 ("FDO#42454 - EasyHack: remove code associated with unused icons"). Change-Id: I968b4fb8c5b207654476dd92c57d8db0815520ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101529 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-29Fix typo in codeAndrea Gelmini1-3/+3
It passed "make check" on Linux Change-Id: I261b3dedd78494ec22a6903f0ab65231965881c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101604 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-28Change OUStringLiteral from char[] to char16_t[]Stephan Bergmann1-1/+1
This is a prerequisite for making conversion from OUStringLiteral to OUString more efficient at least for C++20 (by replacing its internals with a constexpr- generated sal_uString-compatible layout with a SAL_STRING_STATIC_FLAG refCount, conditionally for C++20 for now). For a configure-wise bare-bones build on Linux, size reported by `du -bs instdir` grew by 118792 bytes from 1155636636 to 1155755428. In most places just a u"..." string literal prefix had to be added. In some places char const a[] = "..."; variables have been changed to char16_t, and a few places required even further changes to code (which prompted the addition of include/o3tl/string_view.hxx helper function o3tl::equalsIgnoreAsciiCase and the additional OUString::createFromAscii overload). For all uses of macros expanding to string literals, the relevant uses have been rewritten as u"" MACRO instead of changing the macro definitions. It should be possible to change at least some of those macro definitions (and drop the u"" from their call sites) in follow-up commits. Change-Id: Iec4ef1a057d412d22443312d40c6a8a290dc6144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101483 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-27SvtIconChoiceCtrl can move into toolkit only headersCaolán McNamara1-1/+1
Change-Id: Ice3c01019d3e961c0ef1dce7d3eaf4f602269fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27add a DisableCycleFocusOut flag for an all-welded hierarchyCaolán McNamara1-2/+2
so we can differentiate the case of embedded welded widgets co-sharing the tab-cycle sequence with vcl widgets vs the case its all welded widgets Change-Id: I5c57b4e98d2f5c543522a72e31d554a67c259307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101485 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27tdf#136162 implement applying atk properties to gen menusCaolán McNamara3-11/+62
Change-Id: I77dbc21910b01524d281869a83d9d12efd419bf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27factor out an applyAtkPropertiesCaolán McNamara1-6/+11
Change-Id: Ib7fda3bbf25046f307dcd080e918d159358b4c90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27use monoborder widget css name as a WindowBorderStyle::MONO replacementCaolán McNamara1-1/+12
Change-Id: I563f917c741130909a9d726754cd3eb23a651a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26make get_extents_relative_to constCaolán McNamara1-3/+3
Change-Id: I031c42cd85395a777c20bdd052da4233bc2fedab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25tdf#136094 Handle background color in drawNativeControlMichael Weghorn2-2/+11
Make gtk3's 'GtkSalGraphics::drawNativeControl' take into account a control's background color, if any is explicitly set: Set background/fill color (in 'Edit::ApplySettings') also for the case where the control is drawn "natively", but don't draw the background in the generic 'Window::Erase' method for the case of native drawing; instead handle it when drawing the control itself. This adds an additional parameter to pass the background color to the relevant '{d,D}rawNativeControl' methods (defaulting to 'COL_AUTO') and implements the required handling to apply the background color for the gtk3 case. qt5/kf5 will probably be handled in an upcoming commit as well. Windows as well as the "gen" VCL plugin were not affected by the issue, so remain unchanged and just ignore the new parameter. In a quick test on on macOS, the rendering of the controls in the sample doc was broken beyond just the missing background colors (s. screenshot attached to tdf#136094); the behavior there also remains unchanged by this patch, the new parameter is ignored for now. Change-Id: I01923a504fea2367ae96032104f09099e35f410e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101284 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2020-08-24uilogger : Add support in the Logger and DSL for the ToolBoxAhmed ElShreif1-0/+2
The support is tested on the FindBar and it works well . For example the DSL syntax in the FindBar should be like: >>"Click on item number 3 in FindBar" Change-Id: I3ec5f5afc260df4b38dc4e420fcc48d9c774c29f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100811 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-08-19move VclMultiLineEdit to toolkit-only headersCaolán McNamara2-2/+2
Change-Id: I2e8728061e484f79768fcfe67d674cb76367a94d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100951 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18new loplugin:unusedvarsglobalNoel Grandin1-1/+0
I copied and modified the unusedfields plugin to find unused variables. Change-Id: I18ed6daa202da70a2e564e4fe4760aed7ce070ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14loplugin:simplifybool moreNoel Grandin3-3/+3
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14tdf#135526 ranges overflowing to become negativeCaolán McNamara1-1/+6
the properties panel uses huge min/maxes which can overflow when the number of digits changes Change-Id: Idbb998a065ce8f2b918fceea2076b794cbde3368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100731 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12SvTreeListBox can move into toolkit headers nowCaolán McNamara1-1/+1
Change-Id: I6b3b6ef1530a192f4b6bf87aa9688687063683ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-10tdf#135495 builder file format has annoyingly escaped into user configCaolán McNamara1-1/+2
Change-Id: I38882e2c6e1815ac5fd747642c8934e3e4ca3ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100438 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-08loplugin:unusedmethodsNoel Grandin1-108/+0
Change-Id: I58819edd0965ff52c3fc6c20d84bc5951a79bbe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100381 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04loplugin:flatten in vcl/windowNoel Grandin32-2372/+2372
Change-Id: I94e69e988f038e85b1fb78985211d478bb5ed9b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100033 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxxGabor Kelemen1-0/+4
Recheck after 7-0 branchoff Also drop the now unused file include/vcl/field.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-02Revert "android: avoid expensive load of un-used sidebar icons on mobile."Jan Holesovsky1-6/+0
Unfortunately we need this on Android for the tablets, otherwise the sidebar lacks the icons. Also it is not easily possible to use the isLOKMobilePhone() check here, because that is per-view in general, and handled in sfx in particular, making it hard to use here in vcl. This reverts commit 9a38b194eec5bcf6cb8d073e5d35173c5856f28f. Change-Id: I2b599e884ad4d00b7c246743c180a5324c9a143d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99300 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-07-27map gtk-new symbol to SymbolType::PLUSCaolán McNamara1-0/+2
Change-Id: Id2fdbc9873377871c929b10e8152151bec02812c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99516 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-27make margin-start/margin-left and margin-end/margin-right synonymsCaolán McNamara1-2/+2
Change-Id: I15dc9a87ca0a25d34b1280eb5e776e933a080a62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99486 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-25move getUIRootDir to AllSettingsCaolán McNamara5-8/+8
Change-Id: I3b7774a043a2c99531e1c76b531df4358699bba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-23GtkSpinButton->NumericField no longer usedCaolán McNamara1-12/+4
Change-Id: I2015f02840e23063fae9295437aa2d5e26fe613b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99319 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-21m_bLegacy is always false for dialogCaolán McNamara1-1/+1
Change-Id: I3cc208c1b7576dc47b6259a1a388f1aeaf65c435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-17tdf#134523 variable is null during reentrant callsCaolán McNamara1-2/+3
Change-Id: Ic7aef7b406bd77d242870cbd04e55264cad9b7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-17jsdialog: Add mobile version of data validation dialogSzymon Kłos1-1/+6
Change-Id: I8c59892196ae015852fff6004c72e1990b35c1af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97762 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98902 Tested-by: Jenkins
2020-07-16loplugin:unusedmethodsNoel Grandin1-7/+0
Change-Id: Ibc1ec64cba8eb083aaff28848a42337cc597ea19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-15replace TimeSpinButton with FormattedSpinButtonCaolán McNamara1-72/+0
with a TimeFormatter rather than have duplicate functionality Change-Id: I99f1f2aabee5f81485f97755ba3675870317cfb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-15weld TimeControlCaolán McNamara1-7/+4
Change-Id: Idb19639eb39bc83fb8bdc7c2181bf63e9c522d18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98670 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-14jsdialog: enable watermark dialogSzymon Kłos1-1/+2
Change-Id: I4badd0d2f6c9c0d2828152685aa14c2e1d358fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97623 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98230 Tested-by: Jenkins
2020-07-14uitest : Add support for "ToolBox" Objects for example" "bottom find bar"Ahmed ElShreif1-0/+7
This patch will help us in testing any ToolBox Objects by this lines : >> variable_name = MainWindow.getChild(Bar_name) >> variable_name.executeAction("CLICK", mkPropertyValues({"POS": poition_x })) for position_x you just put the id of which entry in the ToolBox do you want to press on it . Also This patch set the ID of the bottom find bar to be "FindBar" to be able to select it in UITests . Change-Id: I360cdbde47be188c49c6d61bf5df4df5caa6a23e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98549 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-12VerticalTabControl can be in private headerCaolán McNamara1-0/+1
Change-Id: I95ee7a1477fb84eb9fcf2f70ab7d262b9eb47088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08drop WB_BORDER if the border style is invisibleCaolán McNamara1-1/+3
Change-Id: Ie88818cb2b61d411f868f748d6a7c2fdf8028e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08prepareWidgetOwnScrolling already set WB_BORDERCaolán McNamara1-6/+0
the pRealParent != pParent case already caused WB_BORDER to be set in prepareWidgetOwnScrolling Change-Id: Id33d9f8d10b8076a26b31e2dcdc70e3419bba5be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98376 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08distinguish between dialog screenshoting and rendering a widgetCaolán McNamara1-4/+8
Change-Id: I43ee0c68d72c97a15d26e2ffea577c2a44ba91e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08Add mobile version of find replace dialogSzymon Kłos1-1/+2
Change-Id: If651f84b97a1ed6b08b9f4eb56ce95fe659cddf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97606 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98229 Tested-by: Jenkins
2020-07-06exile fmtfield.hxx to toolkit headersCaolán McNamara1-1/+1
Change-Id: I4d16dd079d4f8900d5e04677742679d6592f7066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-06this warning is very common now because of native widgets in the hierarchyCaolán McNamara1-2/+0
so its not helpful anymore Change-Id: I79b66628b71503ed413dfe305f01af8423958b6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98196 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-05return a reference instead of a pointerCaolán McNamara1-6/+6
Change-Id: Ib8b9133991a9c36e737171ae6dfb6a87cc91e1ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03change FormattedField so it doesn't inherit from Formatter but provides oneCaolán McNamara1-5/+6
Change-Id: I728380fb4e2ed914c4b96c0915075af097846c55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97825 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03tdf#131942 no progress bar saving in CalcNoel Grandin1-2/+19
regression from commit a7de363cead5cd0021d2e3df4573d4cbe27df23b. remove unnecessary Window::Update() calls, which immediately follow Invalidate Change-Id: If081f9a54ad7fe528a7885ac796f0ec6a7059872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96975 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03notebookbar: remember LOKWindowId in interim buildersSzymon Kłos1-3/+3
In case of notebookbar we need to remember the same id in every builder for each view to be able to use interim widgets. Then widgets are added to the same map as main notebookbar widgets. SfxViewShell is used as a common id as it is easily accessible. Change-Id: I4fbf2da320396efc80b08bcee9e341c165b1a290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97199 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97834 Tested-by: Jenkins
2020-07-03remove some dead WindowType valuesNoel Grandin3-13/+0
Change-Id: I7eb67e48a87e8cc2babbd46d482294877b08ab99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03jsdialog: working number format fieldSzymon Kłos1-1/+3
Change-Id: Ibc3dcd34008767a7a38cc9b52a23935e0387f67e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97016 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97815 Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-22 10:30:28 +0000