summaryrefslogtreecommitdiff
path: root/vcl/source/window
AgeCommit message (Collapse)AuthorFilesLines
2019-01-11Resolves: tdf#122404 unlock just the toplevels that were lockedCaolán McNamara1-0/+25
push what toplevels got locked to just unlock those ones. otherwise the just dismissed toplevel may still be present in the Application toplevel list. merge all the similar examples of this. Change-Id: I77c0d55d1e4b3bcc3b8d88fef00ba289edd1e831 Reviewed-on: https://gerrit.libreoffice.org/66080 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-11Resolves: tdf#120632 consider submenus on restoring focus from menuCaolán McNamara2-1/+13
additionally to the menu having focus, if a submenu of that menu has focus, then restore the focus when the whole hierarchy execution ends return focus to the toplevel menu's saved focus widget Change-Id: Iefd467fb1ba67ffd0a303505a893d2453e0ffbb3 Reviewed-on: https://gerrit.libreoffice.org/66132 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-09Resolves: tdf#120977 intended default button overriddenCaolán McNamara2-1/+38
for those cases where the built-in buttons are not inserted Change-Id: Ibb091832c097a15dc22a7994d94f8db6a4e47520 Reviewed-on: https://gerrit.libreoffice.org/64492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 043c2f39bfd5f70885dede547cb3c3b78ed8c5b9) Reviewed-on: https://gerrit.libreoffice.org/64619
2018-11-27Resolves: tdf#121238 format welded metricspinbuttons the same as historicallyCaolán McNamara1-5/+5
i.e. not with the UI Language, but with the Locale setting. Change-Id: I5146ece3356fdb67c3c715c6d17e608ec92e739a Reviewed-on: https://gerrit.libreoffice.org/63089 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-11-21Resolves: tdf#121547 do normal dialog layout firstCaolán McNamara1-1/+4
then, if still too small, re-layout with the bigger size Change-Id: I1425e7a55dced4bd93e365a38383eda07fb16d16 Reviewed-on: https://gerrit.libreoffice.org/63708 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-17Resolves: tdf#121432 don't insert an extra page when parent is tabcontrolCaolán McNamara1-24/+28
but the new child is a toplevel widget Change-Id: Ib794e076e2626485b9d9231daf914db6dd9b5e2f Reviewed-on: https://gerrit.libreoffice.org/63439 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-15Resolves: tdf#121229 ignore internal children of VclScrolledWindowCaolán McNamara2-4/+8
Reviewed-on: https://gerrit.libreoffice.org/63357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 20b2903354138f8ab19261fab74658fcf6af70e3) Change-Id: Iecc474db8093520ba2d90aedfc5da66507f3033b Reviewed-on: https://gerrit.libreoffice.org/63359 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-12Resolves: tdf#121181 expand message boxes to show full titleCaolán McNamara1-0/+14
as MsgBox used to do Change-Id: I03d459b8c18f60a19ea5b0034a8d98f6aa4f5ce4 Reviewed-on: https://gerrit.libreoffice.org/63159 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-31Resolves: tdf#120277 special character dialog not appearing in OnlineCaolán McNamara1-2/+30
the magic smoke connecting the dialog to the viewshell was in SfxModalDialog, so not inheriting from that drops the connection add a SfxDialogController to enable setting up the connection Change-Id: I29c45cd43e05295309fc647b039db0c6565ca0d1 Reviewed-on: https://gerrit.libreoffice.org/61311 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-30Resolves: tdf#120988 mismatch of in/out locale formattingCaolán McNamara1-11/+7
Change-Id: I9def43c111adc877aeec9f1990f5dd76fabdbf8f Reviewed-on: https://gerrit.libreoffice.org/62486 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-26tdf#120807 check for valid ImplGetWindowImpl()Jan-Marek Glogowski1-1/+1
Change-Id: Ia1135d11990abc303849bd1b6a549c82008c79de Reviewed-on: https://gerrit.libreoffice.org/62260 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit db0051744330d82986e8f2629a027bc4a5dc1b4a) Reviewed-on: https://gerrit.libreoffice.org/62278 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-23wrong pointer checkCaolán McNamara1-1/+1
since... commit 2636ab883adbcb1f6593787934c6d6d3fff67c21 Date: Mon Sep 15 20:13:54 2014 +0200 vcl menu: Rename CloseStartedFrom() to ClosePopup() + adapt code. Change-Id: Ie30f6d907907551e23e592b8502107e75c333f2e Reviewed-on: https://gerrit.libreoffice.org/62045 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-22tdf#120651 have to sort radiogroup by tab positionCaolán McNamara1-0/+3
Change-Id: I8fcf4c4b186d8292c85babaa90e98396a5fbc71b Reviewed-on: https://gerrit.libreoffice.org/61883 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-20tdf#90376 revert the dock windows' Idles to TimersJan-Marek Glogowski1-19/+17
The dock windows' Timers were converted to Idles in commit eef25e0e7c03 ("changed timers to idles"). Since the Idles poll the mouse buttons, they starve all lower priority events. From the comment in ImplDockFloatWin2::Move, this is a hack to get the mouse release event from the window decorations in X11. Change-Id: Ibba3c58dd8b3d95dbd9296cc111ab32968bee230 Reviewed-on: https://gerrit.libreoffice.org/59590 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit afd49c198769b5e7fc01a68ce7a6847aa0d0ddd8) Reviewed-on: https://gerrit.libreoffice.org/60720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28tdf#119556 Sync "Use only paper size from printer preferences"Michael Weghorn1-0/+9
Since commit ee6dad51150fd53d19f882edfefa879e18f9897d, the "Use only paper size from printer settings" is shown at two places in the print dialog 1) in the "Options" tab 2) in the "Properties" -> "Paper" tab This makes the setting being correctly updated in the UI in 1) as well if changed in 2). The other way around was already working previously. Change-Id: I41d29a11b4e1695a4b2f676b8d7a9c01e4abde3e Reviewed-on: https://gerrit.libreoffice.org/59581 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 571df3ede6f09c945c4cdfd37f34ef760b6b1af2) Reviewed-on: https://gerrit.libreoffice.org/59729 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-14Resolves: tdf#119251 parse non-default units in user inputted valuesCaolán McNamara1-0/+11
Change-Id: I28f8338f5c318f2228b742e2e171d53820cb0cc8 Reviewed-on: https://gerrit.libreoffice.org/58985 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-08tdf#118453 Reactivate navitagor submenu drag mode and displaySalimHabchi3-0/+18
I add a function to get the data from the submenu Change-Id: If8aedc72abfc7ca967377f0e588167f9f62fe137 Reviewed-on: https://gerrit.libreoffice.org/57269 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 7cc85bfd54645d3786828816972a2f039cb134e9) Reviewed-on: https://gerrit.libreoffice.org/58685 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-30Inaccurate symbol signs fixed (tdf#118381)Thorsten Wagner1-4/+29
Change-Id: I2af1d3e4c924acd2ae601f0b40fcf1b2be17c397 Reviewed-on: https://gerrit.libreoffice.org/56426 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-on: https://gerrit.libreoffice.org/58328 Tested-by: Jenkins
2018-07-10Notebookbar:Context for printpreview is working.Kshitij Pathania1-3/+5
This is a combination of 3 commits. Notebookbar:Context for printpreview is now working Also the context stuff is now working well even after print preview is set Change-Id: Ia43f512394cf4d162b4019257c039aecb664df22 Reviewed-on: https://gerrit.libreoffice.org/56740 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> tdf#118546: GetNotebookBar() may return nullptr Change-Id: I411ea0abcb5fd5fac0db7fe0c4bad16a0c1b9d77 Reviewed-on: https://gerrit.libreoffice.org/57006 Reviewed-by: Kshitij Pathania <kshitijpathania@gmail.com> Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Conserved the alphabetical order in contexts. ThreeDObject is remained on top as its entry begin with 3. All others are sorted now except the generalised ones in last. Change-Id: Id56550da450f0d2a0dd770a78360d20ada90f048 Reviewed-on: https://gerrit.libreoffice.org/56984 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/57190
2018-07-06tdf#107266 made background continous for menubar and notebookbarKshitij Pathania1-0/+15
Change-Id: Ieed538741f2a252c8acf1e751bb2ddbe6361b2fa Reviewed-on: https://gerrit.libreoffice.org/55118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 09cc173d59c0b79dca1ea11b37c858e8716062d3) Reviewed-on: https://gerrit.libreoffice.org/56991 Tested-by: Jenkins
2018-07-03weld SwWatermarkDialogCaolán McNamara1-2/+7
Change-Id: Iff3ddfb4dd75088e39ea7675b085f1bbde2c2045 Reviewed-on: https://gerrit.libreoffice.org/56414 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-30tdf#86612: statusbar: hide some elements if width is not sufficientVasily Melenchuk1-12/+48
new statusbar element property mandatory=true/false to determine if this element can be hidden if total statusbar width is not enough to fit all elements. marked some calc and draw statusbar elements as not mandatory. Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f Reviewed-on: https://gerrit.libreoffice.org/56443 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit d77f8eef165a7c6fd97cc06dcbc4ead55e7b633c) Reviewed-on: https://gerrit.libreoffice.org/56591
2018-06-26tdf#117175 wayland: Make popup windows not show off-screenMaxim Monastirsky1-0/+1
Depends on the gtk-3-24 dev branch, for the public gdk_window_move_to_rect symbol. (cherry picked from commit 0da89ede1fee3a9079b7b41ee8b34504ddeb5ee5) Correctly mirror autofilter in rtl ui, tdf#117175 related (cherry picked from commit 2bfc4cefc21ab18e9ff7cc5fdc743bcc856d103c) Fix lists position in dialogs Regression of 2bfc4cefc21ab18e9ff7cc5fdc743bcc856d103c ("Correctly mirror autofilter in rtl ui, tdf#117175 related") If a window has a parent, it doesn't necessarily mean it's not a top level. (cherry picked from commit eb84dcb9c0a202f4917169acdce50775778b72ec) Change-Id: Ic7a34ceb3d133ecac2addac54cf5f635eea332ed Reviewed-on: https://gerrit.libreoffice.org/56439 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-25tdf#116208 vcl opengl: fix lack of updates in status barMiklos Vajna1-0/+3
Commit f0821f9a347c7752a3c741c3451a2f1630173720 (Cache text layout of statusbar items, 2017-06-08) was a performance improvement of not laying out the text of status bar text during each & every paint. One of these places didn't work correctly with Chinese text, so commit a4ed3d9a1ffa1b51ba4352a955c950235f099fdc (tdf#115353 Status bar: no cache in settext, 2018-03-01) attempted to disable the caching at that particular place by removing the update of the cache. This resulted in lack of updates, e.g. during typing into Writer and checking the word count part of the status bar. Fix this (and at the same time keep the original problem fixed) by still not using the layout cache and that problematic place, but instead of just not updating the cache actually invalidate it -- probably that was the intention in the force place already. (cherry picked from commit 0ad7226aee21cc6dbb30d061d76491b01e39de66) Change-Id: Ib7b91e5f24bc68d2f8cae2efea64340585ad9bd5 Reviewed-on: https://gerrit.libreoffice.org/56371 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-20weld SvxColorTabPageCaolán McNamara1-0/+4
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18weld SfxManageStyleSheetPageCaolán McNamara1-1/+1
Change-Id: I3769d294e5a5458d3172c330360f7e6207c3d1b1 Reviewed-on: https://gerrit.libreoffice.org/55966 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14Icons in menubutton are visible nowKshitij Pathania1-1/+1
Change-Id: Icccf8ebfafcb556327def38bc37d1d25a1b6e58d Reviewed-on: https://gerrit.libreoffice.org/55744 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 51b72278b3c64978d0219f406ed5ab194cac2e0c) Reviewed-on: https://gerrit.libreoffice.org/55821
2018-06-14weld SvxCharTwoLinesPageCaolán McNamara1-2/+10
Change-Id: I54a8963cd8b12f5fd51bf6b3bb791a4a15fbd13d Reviewed-on: https://gerrit.libreoffice.org/55766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-10support comboboxtext id valuesCaolán McNamara1-7/+16
Change-Id: Ibebdaab5b073a55cb646687890bc16d5f55c0341 Reviewed-on: https://gerrit.libreoffice.org/55487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-08sync tristate/inconsistent featureCaolán McNamara1-0/+3
Change-Id: Id1107f4fb1f51f377ad546f9b673f9037fee1538 Reviewed-on: https://gerrit.libreoffice.org/55469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31focus rect for value setCaolán McNamara1-0/+7
Change-Id: I208cf42db4256bb7286222781cf2bf29f843c673 Reviewed-on: https://gerrit.libreoffice.org/55122 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-23Revert "vcl: StartPresentationMode should be using a sal_uInt32.."Noel Grandin1-1/+1
This reverts commit 9321c560943330fbc76dacfebff67bd740fbc95b. This is just plain wrong. Both the call sites and the function that this method in turn calls want to use sal_Int32. It doesn't seem to cause any actual problems, but that's probably just lucky. Change-Id: Id77867094b9c7c209edd8b575c9203aee6515ff3 Reviewed-on: https://gerrit.libreoffice.org/54691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-22lok: charts context menu was misplaced + wrong LogicToLogic conversionMarco Cecchetti1-1/+13
Chart context menu was misplaced since the context menu expects a position related to the document window not to the chart window. Moreover map mode is not enabled for chart window, that leads to use the LogicToLogic routine which unfortunately provides a wrong pixel to twips conversion. In fact we gets a 20 twips per pixel conversion since LogicToLogic uses a fixed 72 dpi value, instead of a correctly computed output device real dpi or at least the most commonly used 96 dpi value. Change-Id: Idb4220d03fddd4b6d643c1c0fb52754bafed7e36 Reviewed-on: https://gerrit.libreoffice.org/53118 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/54649 Reviewed-on: https://gerrit.libreoffice.org/54655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-05-22Revert "lokdialog: Give non-programmatic name to autofilter"Jan Holesovsky1-2/+0
In the meantime, we are able to treat the title-less pop-ups just fine. This reverts commit a895f6356159f4267c0ac24781814ae0cbcba0b9. Change-Id: I1e2913190e9a1141eddf9aba0732e57bd5407987 Reviewed-on: https://gerrit.libreoffice.org/54629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-05-21weld ScSortDlg, ScTabPageSortOptions and ScTabPageSortFieldsCaolán McNamara1-1/+7
Change-Id: I103e5e3670f8c95c1f480ce0c36e08c3de74e900 Reviewed-on: https://gerrit.libreoffice.org/54541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21loplugin:staticaccessTor Lillqvist1-1/+1
Change-Id: I9e8accc56fc1d3b095390944a5ae2fc80bcbc05d
2018-05-21lokdialog: For the tunneled top-level popups, provide the position in twips.Jan Holesovsky1-5/+15
Change-Id: I7b1ca50b06c3bdf0958bb88946873c6ddf717b0e Reviewed-on: https://gerrit.libreoffice.org/51952 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/54628 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2018-05-18Avoid mixing up units in LogicRectangle methodTamás Zolnai2-2/+13
For main document window we use logic coordinates, but for dialog / floating windows we use pixels. Use a different method name to make it clear which unit we use in the code. Change-Id: I7aee7a03013d24e1a2e37072e224e7d4e7830f02 Reviewed-on: https://gerrit.libreoffice.org/54500 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-05-18lok: Use GetSizePixel() here which calculates also with borderTamás Zolnai1-1/+1
Change-Id: I6f96abdd4d85c8dfed8bf83e1b2a30192a54bd2d Reviewed-on: https://gerrit.libreoffice.org/54494 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-05-17lok: Always specify the invalidate rectangle explicitelyTamás Zolnai2-1/+9
It will be needed for a later change in online code. Change-Id: Ic8f898b78ccaaaec849a1894b5e70fb730d70d6d Reviewed-on: https://gerrit.libreoffice.org/54443 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-05-17lok: One pixel is not invalidated on the right side for dialog previewsTamás Zolnai1-1/+1
For example: Character dialog -> Highlighting or Character dialog -> Font. Change-Id: I0d1269cdb9d4f482caea27b23ae204351f7dac23 Reviewed-on: https://gerrit.libreoffice.org/54446 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-05-17loplugin:unusedfields in vclNoel Grandin2-8/+3
Change-Id: Id0913b209b089e3c66a7e449e31f8d5d5b1b4f83 Reviewed-on: https://gerrit.libreoffice.org/54413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-12Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic1234560cf9bf646e5499f3192fb37f1d36a6010 Reviewed-on: https://gerrit.libreoffice.org/54165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-12unnecessary duplicate SetImageCaolán McNamara1-1/+0
Change-Id: Ie337eeae3c8295c4d7e62401f438c50d5bfc9693 Reviewed-on: https://gerrit.libreoffice.org/54159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10move Java from config_features to already existing config_javaRene Engelhard1-1/+1
Change-Id: I085fab2bcdc5910d1386fc20768fe7063ce3e28e Reviewed-on: https://gerrit.libreoffice.org/54071 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-05-10weld SdStartPresentationDlgCaolán McNamara1-0/+78
to get duration spinbutton working need to know where the cursor is in the spinbutton and to change the adjustment factor depending on that, and need to additionally disable the vcl round to nearest base unit on up/down Change-Id: I6dd09e1639454cb4820d3aeb0c0c698fcebd417e Reviewed-on: https://gerrit.libreoffice.org/54065 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10Related: tdf#117499 set default titles for non-gtk3 message dialogsCaolán McNamara1-0/+17
Change-Id: Ie2de7fe79e5861351c3fd6512bb970def9a31e4e Reviewed-on: https://gerrit.libreoffice.org/53991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-08Refactor CommonSalLayout font handlingJan-Marek Glogowski1-1/+1
Moves all platform specific code from CommonSalLayout into the platform specific plugins. This way the vcl library won't depend on the Qt5 libraries and the Qt5Font header can be moved into the qt5 VCL plugin. While at it, switch the CommonSalLayouts font reference from the FontSelectPattern to the LogicalFontInstance and also add the harfbuzz font handling to the instance. Change-Id: Ida910b8d88837ea949a2f84394ccc0cfae153060 Reviewed-on: https://gerrit.libreoffice.org/47408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-07Move PhysicalFontFace member of FontSelectPatternJan-Marek Glogowski1-1/+1
A FontSelectPattern describes a general font request. It can be used to find the best matching LogicalFontInstance. The instance will be created based on a PhysicalFontFace, which is really a factory since commit 8b700794b2746070814e9ff416ecd7bbb1c902e7. Following this workflow, this moves the PhysicalFontFace pointer to the instance and makes it constant. Which leaves some special symbol font handling code in the hash and instance lookup code path. It used to query the font face directly from the instance. I'm not sure of the correct handling. The related commits where made to fix #i89002#, which has an attached test document. 1. commit 849f618270da313f9339dda29a9f35938434c91d 2. commit 8c9823d311fdf8092cc75873e4565325d204a658 The document is as broken as it was before the patch. The symbol substitution still works, but the 'Q's are missing when displaying a symbol font. I also don't understand all the reinterpret_casts for fake font ids. I guess this was used to prevent the crashes I see, where a PhysicalFontFace referenced in a valid LogicalFontInstance is freed and a later FontId check in the GlyphCache crashes. So this now checks for a valid cache instead. Change-Id: If8ee5a6288e66cfa4c419289fbdd5b5da128c6ea Reviewed-on: https://gerrit.libreoffice.org/47279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-05Fix typosAndrea Gelmini1-1/+1
Change-Id: I92078fdece135754744d85424956dbb071f3899e Reviewed-on: https://gerrit.libreoffice.org/53638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-07 14:14:58 +0000