summaryrefslogtreecommitdiff
path: root/vcl/source/treelist
AgeCommit message (Collapse)AuthorFilesLines
2020-09-11drop misleading GetWindowTextColor useCaolán McNamara1-1/+0
We use a font from StyleSettings::GetFieldFont(), but use a font color from StyleSettings::GetWindowTextColor() and then immediately afterwards use SetTextColor(StyleSettings::GetFieldTextColor()); Change-Id: I60f653947242a4e2d5fe48bd1d0df7a3ab693685 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11convert IMAP_OBJ to scoped enumNoel Grandin2-32/+32
Change-Id: Id265c098a173b2daf581568779d99c7574f067c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102406 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-11convert IMAP_FORMAT to scoped enumNoel Grandin1-13/+13
Change-Id: I58090ced672267614ade2e3e81e6264d01b77901 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-02move Edit into toolkit only headersCaolán McNamara1-1/+1
Change-Id: If51bf7143116721e8f16272cf8aff797651d5ed1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-29loplugin:unusedmethodsNoel Grandin1-10/+0
Change-Id: I2be47d2faf883b519f693e2d5ad58a5ab111849f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101629 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26make get_extents_relative_to constCaolán McNamara1-1/+1
Change-Id: I031c42cd85395a777c20bdd052da4233bc2fedab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-20loplugin:singlevalfieldsNoel Grandin1-114/+4
Change-Id: I4cd20d1a449196b68c7dbe153c60e68b9563bea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20loplugin:virtualdeadNoel Grandin1-5/+5
Change-Id: Ib41d80d1e068d66edabdfb36061dd382dc34b04c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20loplugin:constantparamNoel Grandin1-2/+2
Change-Id: I59a37e1d37fa749cba5159daa23fe663bcc55435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17loplugin:unusedmethodsNoel Grandin2-28/+0
Change-Id: I31002cc322c43498ef8c37f6b7f94ae1a8278ba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:unusedmethodsNoel Grandin4-60/+0
Change-Id: I2dd10873be73256a3689233c7b1e37bde8f685ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:unnecessaryvirtualNoel Grandin1-1/+1
Change-Id: Iafad1df533d5fefd335066427a0fb9e2d8bfa91d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:virtualdeadNoel Grandin2-7/+0
Change-Id: Ic002692801113de5778826db5e3faf9869a48307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14loplugin:simplifybool moreNoel Grandin1-2/+2
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-12SvTreeListBox can move into toolkit headers nowCaolán McNamara9-19/+19
Change-Id: I6b3b6ef1530a192f4b6bf87aa9688687063683ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12svlbitm.hxx can be toolkit only nowCaolán McNamara5-5/+5
Change-Id: Ie5ad0febca0747fa66c2caede619d14e468da032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100498 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12expand out DELETEZ in vclNoel Grandin1-2/+4
Change-Id: Ibcaef8c5dd057cb9b1711440e5f9da43817078f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100587 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08loplugin:virtualdeadNoel Grandin3-46/+0
Change-Id: Ib2a4ebad50e9c6f0d71a9ac3a1bc8ac11e775496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-07IMnemonicEntryList interface of SvTreeListBox is unusedCaolán McNamara1-40/+14
Change-Id: I56a97d0ef82353aaf3c2ab482c1d782b5dfc8000 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100263 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-07nothing calls EnableEntryMnemonics anymoreCaolán McNamara2-26/+0
Change-Id: I8ef10b4d2f350b4025e46a153766d60510d1b7d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-06for hover-select require mouse to be really over the rowCaolán McNamara1-0/+4
Change-Id: I67f7e30f87555df8094625e0de3679b0215feb50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04loplugin:elidestringvar (clang-cl)Stephan Bergmann1-2/+1
...plus ensuing loplugin:unnecessaryparen in vcl/source/treelist/transfer.cxx Change-Id: I1abf2e0c589c2c124399c1337f5dd703ee7d04a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100094 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04loplugin:unusedmethodsNoel Grandin1-5/+0
Change-Id: I5fa2bbeff17a9933ff55afb0c3544d025d096a63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04loplugin:flatten in vclNoel Grandin1-39/+39
Change-Id: I271cc67ecf34acbf0edbda960e33315fb6a1f9dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31drop unused SvTreeList::LastSelectedCaolán McNamara1-9/+0
Change-Id: I3c51030b8b7a03d944bdaa5e8bc4fb0f443061f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99892 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03DragDropMode::CTRL_COPY is deadNoel Grandin1-16/+11
since commit 3c5e074a8fe5e0a18d326d37bc54a5ec0f077e4e Date: Fri Jun 19 12:37:05 2020 +0100 weld DataNavigator Change-Id: Ib1a0474e0543f863236d58195653c6369c21e2fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-02Upcoming improved loplugin:staticanonymous -> redundantstatic: vclStephan Bergmann2-2/+2
Change-Id: I7559ab5c98a22e315549b5dfc651e937697cac22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97742 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-27cid#1464969 Unchecked return valueCaolán McNamara1-3/+1
Change-Id: I74c1f2d3e45222be7357e0ded70beeb5437ff892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25loplugin:virtualdeadNoel Grandin2-8/+1
Change-Id: Idcaaecd5be080e43b731f8edcbbfb8aed5e2e28c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ib724da1f07be9e8f4d0d505f7f2886990cab661f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-18ReleaseMouse if disposed during mouse downCaolán McNamara1-0/+3
Change-Id: I9595e014e639de1b3e71fc9387cea248bb6d74e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17ignore positions on top of scrollbars for GetTargetAtPointCaolán McNamara1-0/+22
Change-Id: I6d63ac3723b392e7c82836ea5d4455ebde8a8e08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12allow hover-select to unselect when mouse outside treeviewCaolán McNamara1-3/+9
Change-Id: Id991d4c3cdbb6a97c0024430bbff9ccbb29a2d52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09tdf#129856 invalidate old internal border if we scrollCaolán McNamara1-1/+8
and will redraw a new one Change-Id: I2438af94e54f31c617cc183c61fbaaef31b5601f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95911 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-07Resolves: tdf#133744 stop processing if DoubleClickHdl consumed eventCaolán McNamara1-2/+1
Change-Id: I69bb7d670b04b082df294d5ea56dfd6e8d6d4fe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-06focus rect in treeview doesn't match the selected areaCaolán McNamara1-13/+0
regression from... commit 753084a3f73bb8a88412feac7aa40a2750e6e9f3 Date: Wed Dec 11 12:56:57 2019 +0200 loplugin:singlevalfields which detected that m_bIsCellFocusEnabled is always false but inadvertently make a change of -void SvImpLBox::CalcCellFocusRect( SvTreeListEntry const * pEntry, tools::Rectangle& rRect ) +void SvImpLBox::CalcCellFocusRect( tools::Rectangle& rRect ) { - if ( !(pEntry && m_bIsCellFocusEnabled) ) - return; which treats m_bIsCellFocusEnabled as always true. Always false would make CalcCellFocusRect a no-op so just remove the method to fix things. Change-Id: I46bfa122058a9e4384d2b1e2dc9e844ada22cc69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-05Upcoming loplugin:elidestringvar: vclStephan Bergmann1-5/+2
Change-Id: Id746bbb3caeb7555e2a89b13fa6dcb089778002a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95597 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04customize dialog menu treeview icons misplacedCaolán McNamara1-2/+2
since... commit b4f7a08ea5d5fd39057f2a6c7f9a8c015370557f Date: Sun May 31 17:04:21 2020 +0100 use extra optimization of fdo#75058 universally always update the expand/collapse positions Change-Id: I4d55ec6c29fb8d1a4d086847fc990329f9b3e223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95514 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-03skip unselectable entriesCaolán McNamara1-1/+1
Change-Id: I55b7d64f84e2a5b7ab2e1ee8ce6a2f22440b9cfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-02add separators to TreeViewCaolán McNamara1-1/+32
Change-Id: I5e49913dfac82c1243d16ed0a0267a3647f51311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-01support hover-selection in SvTreeListBoxCaolán McNamara2-2/+10
Change-Id: I5ad124d7c9e5219a557069bc7283208124c734af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95269 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-01tdf#133527: the code may be called without solar mutex guardMike Kaganski1-0/+4
... so make sure to get one before using releaser Change-Id: Ifd746e4bb4bdb0110d25fe1ff71fa3dfef67c4da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95231 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-30tdf#133365: only release solar mutex on WindowsMike Kaganski1-0/+6
Regression after f2561331534459f8aebc57e8615fa5f626521bcb Change-Id: Id12a81b2ca79edb7ae056b357dcfd1d8f4bb56ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95088 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-29loplugin:simplifybool in ucb..vclNoel Grandin1-1/+1
Change-Id: Ib63623f5ca3f6559e02a0013c3cbd6174f7aec14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-27Resolves: tdf#133385 dangling pTargetEntry after remove or clearCaolán McNamara1-1/+6
Change-Id: Id04b08ea5af1341d548f7bb1e3c3c7f5b7197548 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94944 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26emit activate-row in vcl treeview on returnCaolán McNamara1-2/+1
to align it with the gtk one which does this Change-Id: Id439fe684f263f59285ba9291fc803f88309c066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94875 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-25support activate-on-single-clickCaolán McNamara2-4/+11
Change-Id: Iac0231b3bd84d664b1ab59023ef8242f3bd08940 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94773 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-24Prevent deadlock accessing clipboardMike Kaganski1-0/+8
Main thread call stack: win32u.dll!NtUserMsgWaitForMultipleObjectsEx() user32.dll!RealMsgWaitForMultipleObjectsEx() combase.dll!CCliModalLoop::BlockFn(void * * ahEvent, unsigned long cEvents, unsigned long * lpdwSignaled) Line 2233 combase.dll!ModalLoop(CSyncClientCall * pClientCall) Line 166 combase.dll!ClassicSTAThreadDispatchCrossApartmentCall(tagRPCOLEMESSAGE * pMessage, OXIDEntry * pOXIDEntry, CSyncClientCall * pClientCall) Line 321 [Inline Frame] combase.dll!CSyncClientCall::SwitchAptAndDispatchCall(tagRPCOLEMESSAGE * pMessage) Line 5696 combase.dll!CSyncClientCall::SendReceive2(tagRPCOLEMESSAGE * pMessage, unsigned long * pstatus) Line 5377 [Inline Frame] combase.dll!SyncClientCallRetryContext::SendReceiveWithRetry(tagRPCOLEMESSAGE *) Line 1617 [Inline Frame] combase.dll!CSyncClientCall::SendReceiveInRetryContext(SyncClientCallRetryContext *) Line 567 combase.dll!ClassicSTAThreadSendReceive(CSyncClientCall * pClientCall, tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus) Line 549 combase.dll!CSyncClientCall::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 783 combase.dll!CClientChannel::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 653 combase.dll!NdrExtpProxySendReceive(void * pThis, _MIDL_STUB_MESSAGE * pStubMsg) Line 2002 rpcrt4.dll!NdrpClientCall3() rpcrt4.dll!NdrClientCall3() [Inline Frame] combase.dll!IDataObject_RemoteGetData_Proxy(IDataObject *) Line 2082 combase.dll!IDataObject_GetData_Proxy(IDataObject * This, tagFORMATETC * pformatetcIn, tagSTGMEDIUM * pMedium) Line 1270 sysdtrans.dll!CAPNDataObject::GetData(tagFORMATETC * pFormatetc, tagSTGMEDIUM * pmedium) Line 146 sysdtrans.dll!CDOTransferable::getClipboardData(CFormatEtc & aFormatEtc) Line 421 sysdtrans.dll!CDOTransferable::getTransferData(const com::sun::star::datatransfer::DataFlavor & aFlavor) Line 251 vcllo.dll!TransferableDataHelper::GetAny(const com::sun::star::datatransfer::DataFlavor & rFlavor, const rtl::OUString & rDestDoc) Line 1461 vcllo.dll!TransferableDataHelper::GetSequence(const com::sun::star::datatransfer::DataFlavor & rFlavor, const rtl::OUString & rDestDoc) Line 2043 vcllo.dll!TransferableDataHelper::GetSotStorageStream(const com::sun::star::datatransfer::DataFlavor & rFlavor, tools::SvRef<SotStorageStream> & rxStream) Line 2061 vcllo.dll!TransferableDataHelper::GetSotStorageStream(SotClipboardFormatId nFormat, tools::SvRef<SotStorageStream> & rxStream) Line 2055 swlo.dll!SwTransferable::PasteFileContent(TransferableDataHelper & rData, SwWrtShell & rSh, SotClipboardFormatId nFormat, bool bMsg, bool bIgnoreComments) Line 2060 swlo.dll!SwTransferable::PasteData(TransferableDataHelper & rData, SwWrtShell & rSh, unsigned char nAction, SotExchangeActionFlags nActionFlags, SotClipboardFormatId nFormat, SotExchangeDest nDestination, bool bIsPasteFormat, bool bIsDefault, const Point * pPt, char nDropAction, bool bPasteSelection, RndStdIds nAnchorType, bool bIgnoreComments, SwPasteContext * pContext, PasteTableType ePasteTable) Line 1743 swlo.dll!SwTransferable::Paste(SwWrtShell & rSh, TransferableDataHelper & rData, RndStdIds nAnchorType, bool bIgnoreComments, PasteTableType ePasteTable) Line 1576 swlo.dll!SwBaseShell::ExecClpbrd(SfxRequest & rReq) Line 304 swlo.dll!SfxStubSwBaseShellExecClpbrd(SfxShell * pShell, SfxRequest & rReq) Line 2189 sfxlo.dll!SfxShell::CallExec(void(*)(SfxShell *, SfxRequest &) pFunc, SfxRequest & rReq) Line 197 sfxlo.dll!SfxDispatcher::Call_Impl(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, bool bRecord) Line 255 sfxlo.dll!SfxDispatcher::Execute_(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, SfxCallMode eCallMode) Line 752 sfxlo.dll!SfxBindings::Execute_Impl(SfxRequest & aReq, const SfxSlot * pSlot, SfxShell * pShell) Line 1059 sfxlo.dll!SfxDispatchController_Impl::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> & rListener) Line 758 sfxlo.dll!SfxOfficeDispatch::dispatchWithNotification(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> & rListener) Line 242 fwelo.dll!framework::DispatchHelper::executeDispatch(const com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> & xDispatch, const com::sun::star::util::URL & aURL, bool SyncronFlag, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments) Line 152 fwelo.dll!framework::DispatchHelper::executeDispatch(const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> & xDispatchProvider, const rtl::OUString & sURL, const rtl::OUString & sTargetFrameName, long nSearchFlags, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments) Line 109 unotest.dll!unotest::MacrosTest::dispatchCommand(const com::sun::star::uno::Reference<com::sun::star::lang::XComponent> & xComponent, const rtl::OUString & rCommand, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rPropertyValues) Line 77 test_sw_uiwriter.dll!testTdf132187::TestBody() Line 91 test_sw_uiwriter.dll!std::_Invoker_pmf_pointer::_Call<void (__cdecl testTdf132187::*)(void),testTdf132187 * &>(void(testTdf132187::*)() _Pmf, testTdf132187 * & _Arg1) Line 1610 test_sw_uiwriter.dll!std::invoke<void (__cdecl testTdf132187::*&)(void),testTdf132187 * &>(void(testTdf132187::*)() & _Obj, testTdf132187 * & <_Args_0>) Line 1610 test_sw_uiwriter.dll!std::_Invoker_ret<std::_Unforced,0>::_Call<void (__cdecl testTdf132187::*&)(void),testTdf132187 * &>(void(testTdf132187::*)() & <_Vals_0>, testTdf132187 * & <_Vals_1>) Line 1646 test_sw_uiwriter.dll!std::_Call_binder<std::_Unforced,0,void (__cdecl testTdf132187::*)(void),std::tuple<testTdf132187 *>,std::tuple<>>(std::_Invoker_ret<std::_Unforced,0> __formal, std::integer_sequence<unsigned __int64,0> __formal, void(testTdf132187::*)() & _Obj, std::tuple<testTdf132187 *> & _Tpl, std::tuple<> && _Ut) Line 1433 test_sw_uiwriter.dll!std::_Binder<std::_Unforced,void (__cdecl testTdf132187::*&)(void),testTdf132187 * &>::operator()<>() Line 1473 test_sw_uiwriter.dll!std::_Invoker_functor::_Call<std::_Binder<std::_Unforced,void (__cdecl testTdf132187::*&)(void),testTdf132187 * &> &>(std::_Binder<std::_Unforced,void (__cdecl testTdf132187::*&)(void),testTdf132187 * &> & _Obj) Line 1610 test_sw_uiwriter.dll!std::invoke<std::_Binder<std::_Unforced,void (__cdecl testTdf132187::*&)(void),testTdf132187 * &> &>(std::_Binder<std::_Unforced,void (__cdecl testTdf132187::*&)(void),testTdf132187 * &> & _Obj) Line 1610 test_sw_uiwriter.dll!std::_Invoker_ret<void,1>::_Call<std::_Binder<std::_Unforced,void (__cdecl testTdf132187::*&)(void),testTdf132187 * &> &>(std::_Binder<std::_Unforced,void (__cdecl testTdf132187::*&)(void),testTdf132187 * &> & <_Vals_0>) Line 1629 test_sw_uiwriter.dll!std::_Func_impl_no_alloc<std::_Binder<std::_Unforced,void (__cdecl testTdf132187::*&)(void),testTdf132187 * &>,void>::_Do_call() Line 927 test_sw_uiwriter.dll!std::_Func_class<void>::operator()() Line 977 test_sw_uiwriter.dll!CppUnit::TestCaller<testTdf132187>::runTest() Line 176 cppunitd_dll.dll!CppUnit::TestCaseMethodFunctor::operator()() Line 33 vclbootstrapprotector.dll!`anonymous namespace'::Protector::protect(const CppUnit::Functor & functor, const CppUnit::ProtectorContext & __formal) Line 46 cppunitd_dll.dll!CppUnit::ProtectorChain::ProtectFunctor::operator()() Line 21 unobootstrapprotector.dll!`anonymous namespace'::Prot::protect(const CppUnit::Functor & functor, const CppUnit::ProtectorContext & __formal) Line 79 cppunitd_dll.dll!CppUnit::ProtectorChain::ProtectFunctor::operator()() Line 21 unoexceptionprotector.dll!`anonymous namespace'::Prot::protect(const CppUnit::Functor & functor, const CppUnit::ProtectorContext & context) Line 61 cppunitd_dll.dll!CppUnit::ProtectorChain::ProtectFunctor::operator()() Line 21 cppunitd_dll.dll!CppUnit::DefaultProtector::protect(const CppUnit::Functor & functor, const CppUnit::ProtectorContext & context) Line 15 cppunitd_dll.dll!CppUnit::ProtectorChain::ProtectFunctor::operator()() Line 21 cppunitd_dll.dll!CppUnit::ProtectorChain::protect(const CppUnit::Functor & functor, const CppUnit::ProtectorContext & context) Line 86 cppunitd_dll.dll!CppUnit::TestResult::protect(const CppUnit::Functor & functor, CppUnit::Test * test, const std::string & shortDescription) Line 182 cppunitd_dll.dll!CppUnit::TestCase::run(CppUnit::TestResult * result) Line 91 cppunitd_dll.dll!CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult * controller) Line 65 cppunitd_dll.dll!CppUnit::TestComposite::run(CppUnit::TestResult * result) Line 24 cppunitd_dll.dll!CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult * controller) Line 65 cppunitd_dll.dll!CppUnit::TestComposite::run(CppUnit::TestResult * result) Line 24 cppunitd_dll.dll!CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult * result) Line 47 cppunitd_dll.dll!CppUnit::TestResult::runTest(CppUnit::Test * test) Line 150 cppunitd_dll.dll!CppUnit::TestRunner::run(CppUnit::TestResult & controller, const std::string & testPath) Line 96 cppunittester.exe!`anonymous namespace'::ProtectedFixtureFunctor::run() Line 316 cppunittester.exe!sal_main() Line 466 cppunittester.exe!main(int argc, char * * argv) Line 373 cppunittester.exe!invoke_main() Line 79 cppunittester.exe!__scrt_common_main_seh() Line 288 cppunittester.exe!__scrt_common_main() Line 331 cppunittester.exe!mainCRTStartup() Line 17 kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() The worker thread call stack: ntdll.dll!NtWaitForAlertByThreadId() ntdll.dll!RtlpWaitOnAddressWithTimeout() ntdll.dll!RtlpWaitOnAddress() ntdll.dll!RtlpWaitOnCriticalSection() ntdll.dll!RtlpEnterCriticalSectionContended() ntdll.dll!RtlEnterCriticalSection() sal3.dll!osl_acquireMutex(_oslMutexImpl * Mutex) Line 66 vclplug_winlo.dll!osl::Mutex::acquire() Line 57 vclplug_winlo.dll!SalYieldMutex::doAcquire(unsigned long nLockCount) Line 165 comphelper.dll!comphelper::SolarMutex::acquire(unsigned long nLockCount) Line 87 vcllo.dll!osl::Guard<comphelper::SolarMutex>::Guard<comphelper::SolarMutex>(comphelper::SolarMutex & t) Line 136 vcllo.dll!SolarMutexGuard::SolarMutexGuard() Line 1347 vcllo.dll!TransferableHelper::getTransferData2(const com::sun::star::datatransfer::DataFlavor & rFlavor, const rtl::OUString & rDestDoc) Line 294 vcllo.dll!TransferableHelper::getTransferData(const com::sun::star::datatransfer::DataFlavor & rFlavor) Line 287 sysdtrans.dll!CXTDataObject::renderAnyDataAndSetupStgMedium(tagFORMATETC & fetc, tagSTGMEDIUM & stgmedium) Line 341 sysdtrans.dll!CXTDataObject::GetData(tagFORMATETC * pFormatetc, tagSTGMEDIUM * pmedium) Line 261 sysdtrans.dll!CXNotifyingDataObject::GetData(tagFORMATETC * pFormatetc, tagSTGMEDIUM * pmedium) Line 86 ole32.dll!CClipDataObject::GetData(tagFORMATETC * pformatetc, tagSTGMEDIUM * pmedium) Line 1045 [Inline Frame] combase.dll!IDataObject_GetData_Stub(IDataObject * This, tagFORMATETC *) Line 1291 combase.dll!IDataObject_RemoteGetData_Thunk(_MIDL_STUB_MESSAGE * pStubMsg) Line 2112 rpcrt4.dll!Ndr64StubWorker() rpcrt4.dll!NdrStubCall3() combase.dll!CStdStubBuffer_Invoke(IRpcStubBuffer * This, tagRPCOLEMESSAGE * prpcmsg, IRpcChannelBuffer * pRpcChannelBuffer) Line 1524 [Inline Frame] combase.dll!InvokeStubWithExceptionPolicyAndTracing::__l6::<lambda_c9f3956a20c9da92a64affc24fdd69ec>::operator()() Line 1385 combase.dll!ObjectMethodExceptionHandlingAction<<lambda_c9f3956a20c9da92a64affc24fdd69ec>>(InvokeStubWithExceptionPolicyAndTracing::__l6::<lambda_c9f3956a20c9da92a64affc24fdd69ec> action, ObjectMethodExceptionHandlingInfo * pExceptionHandlingInfo, ExceptionHandlingResult * pExceptionHandlingResult, void *) Line 87 [Inline Frame] combase.dll!InvokeStubWithExceptionPolicyAndTracing(IRpcStubBuffer * pMsg, tagRPCOLEMESSAGE *) Line 1383 combase.dll!DefaultStubInvoke(bool bIsAsyncBeginMethod, IServerCall * pServerCall, IRpcChannelBuffer * pChannel, IRpcStubBuffer * pStub, unsigned long * pdwFault) Line 1452 [Inline Frame] combase.dll!SyncStubCall::Invoke(IServerCall *) Line 1509 combase.dll!SyncServerCall::StubInvoke(IRpcChannelBuffer * pChannel, IRpcStubBuffer * pStub, unsigned long * pdwFault) Line 826 [Inline Frame] combase.dll!StubInvoke(tagRPCOLEMESSAGE * pMsg, CStdIdentity * pStdID, IRpcStubBuffer *) Line 1734 combase.dll!ServerCall::ContextInvoke(tagRPCOLEMESSAGE * pMessage, IRpcStubBuffer * pStub, CServerChannel * pChannel, tagIPIDEntry * pIPIDEntry, unsigned long * pdwFault) Line 1418 [Inline Frame] combase.dll!CServerChannel::ContextInvoke(tagRPCOLEMESSAGE *) Line 1327 [Inline Frame] combase.dll!DefaultInvokeInApartment(tagRPCOLEMESSAGE *) Line 3352 combase.dll!ReentrantSTAInvokeInApartment(tagRPCOLEMESSAGE * pMsg, unsigned long dwCallCat, bool bIsTouchedASTACall, IRpcStubBuffer * pStub, CServerChannel * pChnl, tagIPIDEntry * pIPIDEntry, unsigned long * pdwFault) Line 112 combase.dll!AppInvoke(ServerCall * pServerCall, CServerChannel * pChannel, IRpcStubBuffer * pStub, void * pStubBuffer, void * pIPIDEntry, tagIPIDEntry * pLocalb, WireLocalThis *) Line 1182 combase.dll!ComInvokeWithLockAndIPID(ServerCall * pServerCall, tagIPIDEntry * pIPIDEntry, bool * pbCallerResponsibleForRequestMessageCleanup) Line 2290 [Inline Frame] combase.dll!ComInvoke(ServerCall *) Line 1803 [Inline Frame] combase.dll!ThreadDispatch(ServerCall *) Line 416 combase.dll!ThreadWndProc(HWND__ * window, unsigned int message, unsigned __int64 wparam, __int64 params) Line 744 user32.dll!UserCallWinProcCheckWow() user32.dll!DispatchMessageWorker() sysdtrans.dll!CMtaOleClipboard::run() Line 652 sysdtrans.dll!CMtaOleClipboard::oleThreadProc(void * pParam) Line 673 ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() Main thread acquires solar mutex in SfxDispatchController_Impl::dispatch, and calls IDataObject::GetData. Worker thread serves the call, and waits for the solar mutex => deadlock. Change-Id: Ic408a779af9390531d1fc4272995f12849716a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94679 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-24inline some use-once typedefsNoel Grandin1-4/+1
Change-Id: Idddba2f3fd05265b08dbc88edb6152d34a166052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-22remove Size arg from Window::Draw and depend on GetSizePixelCaolán McNamara1-2/+2
90% of cases pass GetSizePixel as the Size arg already and this aligns Window::Draw with how Window::PaintToDevice works Change-Id: If5b024179a4b7a3b099177c2f6d4b1fb006b95ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-04 16:28:40 +0000