summaryrefslogtreecommitdiff
path: root/vcl/source/control/spinfld.cxx
AgeCommit message (Collapse)AuthorFilesLines
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin1-1/+1
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18loplugin:constparams in vclNoel Grandin1-1/+1
Change-Id: I36afe2107e07ffb9b73c0b76be600e3e999a0fd4 Reviewed-on: https://gerrit.libreoffice.org/40116 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-28loplugin:oncevar in vclNoel Grandin1-6/+3
Change-Id: I37a6dacda12e1c2910737d74aa344c7e2e195aeb Reviewed-on: https://gerrit.libreoffice.org/39328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-17loplugin:unusedfields in vcl part1Noel Grandin1-2/+0
Change-Id: I67d176003f39992cd0ff9271a7d6ce26d2cb6619 Reviewed-on: https://gerrit.libreoffice.org/38828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30teach redundantcast plugin about functional castsNoel Grandin1-1/+1
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin1-6/+6
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19remove freshly unused menu support from src filesCaolán McNamara1-2/+0
Change-Id: I038711a0c4d440d452d5b2ae1bfcba5c9305815b Reviewed-on: https://gerrit.libreoffice.org/36646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna1-34/+34
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-14Convert WindowType to scoped enumNoel Grandin1-11/+11
Change-Id: I85cfe02f28729e13f2c0dd3d91cd89e6f3e3b6a9 Reviewed-on: https://gerrit.libreoffice.org/34219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03TyposJulien Nabet1-1/+1
Change-Id: Ic54695e86b4b462419fa7d5ded7b1ddb19ee8ed5 Reviewed-on: https://gerrit.libreoffice.org/33904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski1-1/+1
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-13new loplugin: useuniqueptr: vclNoel Grandin1-1/+1
Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec Reviewed-on: https://gerrit.libreoffice.org/32948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin1-4/+4
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl1-2/+2
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-10-18Resolves: tdf#97065 gtk3: Date field displayed incompleteCaolán McNamara1-1/+3
a spinfield with a dropdown is sort of weird, we should probably revisit this and see if SPIN and DROPDOWN are mutually exclusive and for DROPDOWN use ComboBox styles Change-Id: Id7f5c54974dc2dfd63ab30df18e14f6a67a8ea90
2016-10-18loplugin:unusedmethodsNoel Grandin1-6/+0
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-07no SpinFields are directly loaded from .src files nowCaolán McNamara1-13/+0
Change-Id: Ie9280d465e86b5f5b87ffd7b2944f3ed789724d1
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann1-1/+1
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-07-15new loplugin unnecessary overrideNoel Grandin1-5/+0
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-20Convert PART to scoped enumNoel Grandin1-17/+17
Change-Id: If4c2849beb207593d3d450ae3846ed24eaf66ca4 Reviewed-on: https://gerrit.libreoffice.org/26173 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-18uitest: move declaration for the uitesting wrapper objects to include/ dirMarkus Mohrhard1-1/+1
This allows non-vcl wrapper objects to inherit from the vcl base classes. This is especially important for the WindowUIObject base class object. Change-Id: I91ef69839ff4c031d3bcd21d70b4b9e7d62ad572
2016-06-18uitest: a slightly better approach for the factory problem in the ui testingMarkus Mohrhard1-0/+6
Change-Id: I15dbf2446791c4be9be4e18e63c0d03104d8d405
2016-06-17convert DBG_ASSERT in vclNoel Grandin1-1/+1
Change-Id: I732fb1a789f90ca7a7f393cc41a6afe84fecf3d3 Reviewed-on: https://gerrit.libreoffice.org/26200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert ControlType to scoped enumNoel Grandin1-22/+22
Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-18Resolves: tdf#97953 spinbuttons are not suitable for reuse as up/down arrowsCaolán McNamara1-0/+11
Change-Id: Ibcd7bd4099210a26513caac6e3b16a88a4c8abad
2016-02-18StyleSettingsOptions::SpinArrow is not set by anyoneCaolán McNamara1-23/+7
Tragically this means the loss of a OS/2 comment Change-Id: Ia3f7b0a840e6b73cf4fae5f98dd4cf97d4e7b87c
2016-02-18StyleSettingsOptions::SpinUpDown is not set by anyoneCaolán McNamara1-6/+0
Change-Id: I26d5189b6a20844bac2a671a30def1b01aa786a8
2016-02-18refactor ImplDrawSpinButtonCaolán McNamara1-53/+50
there is (supposed to be anyway) no logic change here, just unwind the overly complex flow Change-Id: I9c96f41b0480a60c486b476f383d856b464cd62d
2016-02-17tdf#97922 - get control area right for spinbuttons.Michael Meeks1-1/+2
Also avoid caching both spin-buttons and some other complex types. The cache key needs to be able to include more state. Change-Id: I8eff6b1c5c51d27afb796cae66b45390433138b4
2016-02-15tdf#97739 - ensure we have a valid rectangle for spin-button controls.Michael Meeks1-1/+2
Otherwise OpenGL can't render, cache and diff these; so we loose them. Change-Id: Iac4f3ee0fc68154f708a881d5e0255fc9f8df62d
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock1-4/+4
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
2015-12-12<vcl/spin.h> can be private to vclTor Lillqvist1-1/+1
Change-Id: If723dd72479ab8d072581e9ffbf7a1462c5fecda
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-3/+3
Change-Id: I05e89f9896170d4df3d1377549ea074f06b884a0
2015-10-19loplugin:defaultparamsStephan Bergmann1-1/+1
Change-Id: I8db42173f116372b1c849284540c111635c3582e
2015-10-15convert Link<> to typedNoel Grandin1-4/+4
Change-Id: I2ef1e5fe5c6dc65c254b3a16b0b12fca5caba16e
2015-10-15cppcheck:variableScopeNoel Grandin1-2/+1
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884 Reviewed-on: https://gerrit.libreoffice.org/19364 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann1-9/+9
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-08-17make Control::ImplCallEventListenersAndHandler take a lambdaNoel Grandin1-4/+4
so that we make the Link<> calls type-safe, without having to make this a template method Change-Id: I2e36bd6aa7c63440f72d266b593e101965b5ebce
2015-06-19rendercontext: Fix painting of double-buffered spinboxes.Jan Holesovsky1-10/+25
Change-Id: I8cd2275d2607559c283d84d66b6d1f0588944cbe
2015-05-27convert WINDOW_DRAW flags to scoped enumNoel Grandin1-4/+4
Change-Id: I9400a286fab18d683b4c109007961685f01b6da3
2015-05-23VclPtr - add compat methods for old-style focus / notification.Michael Meeks1-1/+1
The previous code would only invoke Window:: methods by the time we hit the destructor; do the same to avoid fixing more scattered crashers for now. Change-Id: Ibdcd1290309bb7fc31a44d534c52d357da022591 Reviewed-on: https://gerrit.libreoffice.org/15880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-22convert WINDOW constants for GetWindow() methods to scoped enumNoel Grandin1-3/+3
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33
2015-05-22convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin1-6/+6
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-20cleanup codeTomaž Vajngerl1-167/+165
Change-Id: I0fdcb3d179d87ae202199d2eb904e701bad45ab1
2015-05-20fixes for changes in "edit"Tomaž Vajngerl1-4/+1
Change-Id: Ied0f44e38ac52f13c9c229366342849aa29ec754
2015-05-13Remove EditBoxValue again and just use the native widgets size requestCaolán McNamara1-3/+3
Change-Id: Ib9d0f06bffc9e9d31149a622350145024a9b8a99
2015-05-13convert BUTTON_DRAW constants to scoped enumNoel Grandin1-7/+7
Change-Id: I6ad6558c855736a4a5268593ced9c8300235d4bd
2015-05-12convert SYMBOL_DRAW constants to scoped enumNoel Grandin1-9/+9
Change-Id: I1a2200782941b1c7b826fd9fb03193e009cce697 Reviewed-on: https://gerrit.libreoffice.org/15676 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11convert COMMAND_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-07Refactor "SpinField" & "SpinButton" - use RenderContextTomaž Vajngerl1-79/+75
Change-Id: I589f49179b446ae24037546075070641de5cb927