summaryrefslogtreecommitdiff
path: root/vcl/osx
AgeCommit message (Collapse)AuthorFilesLines
2014-06-05various: remove SAL_THROW macroNoel Grandin2-4/+4
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-03WaE: 'convertBaseToScreen:' is deprecated: first deprecated in OS X 10.7Tor Lillqvist1-0/+4
Change-Id: I04cc155e69d25021d294bccc588450b1f20e1fde
2014-06-03WaE: 'scrollerWidth' is deprecated: first deprecated in OS X 10.7Tor Lillqvist1-1/+4
Change-Id: I2451687c10f91e7d5242b04974cb7bdd745de51c
2014-06-03WaE: 'NSPrintSavePath' is deprecated: first deprecated in OS X 10.6Tor Lillqvist1-1/+1
Change-Id: I810b42da1d62c66c2ab6fb7bb6f71d1d00115dfa
2014-06-03WaE: comparison of two values with different enumeration typesTor Lillqvist1-1/+2
Change-Id: I611eefd20043386d00984f76a28d111e1c0495f1
2014-06-03WaE: 'setFlipped' is deprecated: first deprecated in OS X 10.6Tor Lillqvist1-2/+1
Not sure if using lockFocusFlipped: has the same effect, but will see... Change-Id: I957874bcf59c2c521bd5b2b2ca6f44fb0400e64f
2014-06-03WaE: case value not in enumerated type 'NSEventSubtype'Tor Lillqvist1-1/+2
Change-Id: Iaf5de07b7f0da7294681b9cdc152575a756a73c7
2014-06-03Initial attempt at implementing NSTextInputClient instead of NSTextInputTor Lillqvist1-8/+17
NSTextInput was deprecated in 10.6. Change-Id: I6bce9e91a68014a6ca28bff6a820c27817f9baaf
2014-06-03WaE: 'NSCountWindows' is deprecated: first deprecated in OS X 10.6Tor Lillqvist1-7/+3
Change-Id: I7163d3821ac0dfc0d471cf31e98f72953c78d878
2014-06-01fdo#68849: Add header guards to all include filesJens Carl1-0/+5
Added header guards to files in directory vcl/ Change-Id: I76ad0c34f2b107d56e92c5a6a8f4c61554c93e2f Reviewed-on: https://gerrit.libreoffice.org/9597 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-29remove more unnecesary OUString constructor useNoel Grandin1-1/+1
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin1-1/+1
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-25cppcheck: unusedFunctionThomas Arnhold1-7/+0
Change-Id: I81f2a4be65bbc9359e51accccb746f1e8ea48c4f
2014-05-23Related: #i124191# small cleanup for salframeview.mmHerbert Dürr1-13/+13
clean up some minor warts while the behaviour remains unchanged. (cherry picked from commit 8ba6a0be8a0ac9075b2faa68bf71245f4aff0d16) Conflicts: vcl/osx/salframeview.mm Change-Id: I613bf0f40429db6516f82e79438e86bffb7f71cb
2014-05-20Don't use two separate names for the same thingTor Lillqvist1-1/+1
Change-Id: Iad76d452d5dbaa03099c1a649d7f278b0151f340
2014-05-20We don't support the Apple Remote in sandboxed modeTor Lillqvist1-0/+2
Change-Id: Ie0a456647376b9d249850227d3481be5b4ee991d
2014-05-17Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part15Julien Nabet1-5/+5
Change-Id: I38e855966598342eb2352e70e04f7a5e09e54f83
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold1-2/+2
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-14loplugin:passsequencebyrefStephan Bergmann1-9/+8
Change-Id: I3a6656117b2d2aa9d9cdcadc53a804e963f805a7
2014-05-11Fix previous commit (vcl/MacOsX part)Julien Nabet2-5/+5
Change-Id: I65998bbbba01943eeb41fd8ee4f1ed5fe2eb91b1
2014-05-11Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10Julien Nabet2-5/+5
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-09Fix typo, thanks to Cor Nouws for noticingTor Lillqvist1-1/+1
Change-Id: Ib20fa5dbbc8bfbd399c3266c175ba1971e9a4774
2014-05-05Correct keycode mappings for KEY_QUOTE{LEFT,RIGHT}Tor Lillqvist1-2/+2
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h says that 0x27 is kVK_ANSI_Quote, which we call KEY_QUOTERIGHT, i.e. the plain ASCII apostrophe, while 0x32 is not the ASCII tilde but kVK_ANSI_Grave, which we call KEY_QUOTELEFT. Makes the Command-' binding (see Kohei's 56cce6fd8151a916e1be540ac18724b46d1b15fc) work at least for the US English keyboard. But not for the Finnish keyboard, for instance, where the key labeled with an apostrophe (or "ASCII-style" single quote) generates a different keycode than the single quote key on the US English keyboard. (Which, I guess, isn't surprising as it after all is a different physical key.) In other words, situation normal, using keycodes is a horror as always... Change-Id: Ibf8f994370fec75849391e1dba30c7b7d54d237f
2014-05-05Untabify and remove trailing spacesTor Lillqvist1-117/+117
Change-Id: I2acd44d54966dd227f5dc23ca4acde3c50ca8347
2014-05-05Align table entries into equal-size columnsTor Lillqvist1-48/+48
Change-Id: I9fd2980a32bd0a3eb4849a53f29cc10b9a371f4c
2014-05-05GetKeyName for KEY_{TILDE,BRACKET{LEFT,RIGHT},SEMICOLON,QUOTERIGHT}Tor Lillqvist1-5/+5
Change-Id: Id320bc41fefff17035c8a30115dc94af5cbf9503
2014-05-05Add more unmapped VCL keycodes to the commentTor Lillqvist1-0/+7
Change-Id: If417d8091896c9f6c9650cf7d6036ffacbcc0884
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin1-1/+1
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-14typo: suiteable -> suitableThomas Arnhold1-3/+3
2014-04-14OLD_TAB_STYLE never definedThomas Arnhold1-5/+1
2014-04-11Remove unused functionStephan Bergmann1-7/+0
Change-Id: I150cbe9ca96f0fb9a6b1116f79a0711d78252ba5
2014-04-10Kill the ImplSVGDIData::mbNoXORClipping flagTor Lillqvist1-1/+0
Instead, act as if it was true on all platforms. Don't do XOR clipping on any platform. Simpler code is better code, and XOR tricks are generally very much out of fashion these days, I have been told. Didn't seem to have any visible ill effects on Linux at least. Change-Id: I6192006c77a4a81363ec7b3292f72d512d5e9b53 Reviewed-on: https://gerrit.libreoffice.org/8901 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-04-07Clean up ImplSVMainHook declarationStephan Bergmann1-0/+1
Change-Id: I51d7eac6160a3c3abc96733fa30fdcbb41bb5509
2014-04-03Typo: corect->correctJulien Nabet1-1/+1
Change-Id: I31267af8aae35d647b8c4b0a0c5f926ad4779919
2014-04-02Kill superfluous vertical whitespaceTor Lillqvist27-418/+0
Change-Id: I81ce8fd7022bf283db668705efdfb0666f87bde9
2014-04-01Explicitly mark overriding destructors as "virtual," Mac OS X reduxStephan Bergmann2-2/+2
Change-Id: Ib7ab02bc3cdadbdfe0e0787560d1dd562eb85be9
2014-03-30vcl-osx fix: 'NSEvent' may not respond to '-magnification'Douglas Mencken1-3/+11
(error: invalid operands of types 'float' and 'objc_object*' to binary 'operator+') Change-Id: Iade7acde31fad21d7dde1a8c20c8900d9cbbd446 Reviewed-on: https://gerrit.libreoffice.org/8792 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-21Improve Accessibility mapping of roles for MacNiklas Johansson1-3/+3
Since role Heading now is exposed to A11y we need to give it a better role then unknown, otherwise it gets inaccessible to VoiceOver. Until I get a better grip on how to best expose AXHeading, let's map it to textAreaRole so we at least get back to the behaviour before IA2 integration. Header and Footer is probably best mapped to AXGroup. Change-Id: I6353f4d25c18e6e550df289ca2e999ad1c01f2a8 Reviewed-on: https://gerrit.libreoffice.org/8682 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-20Remove unnecessary vcl::SolarMutexObjectStephan Bergmann1-4/+3
Change-Id: I6dfdd7d5d211b66019dfbe364101140e28a3584d
2014-03-19loplugin:passstringbyrefStephan Bergmann1-1/+1
Change-Id: I3189ff08bd984b8f4fa127aeb40e8c13e5cc01c9
2014-03-05Switch to -magnification instead of -deltaZ for mac osx pinch-to-zoomJoren De Cuyper1-2/+2
Using pinch-to-zoom in LibreOffice result in following warning in terminal: soffice[2376:507] -deltaZ is deprecated for NSEventTypeMagnify. Please use -magnification. Following https://groups.google.com/a/chromium.org/forum/#!topic/chromium-reviews/lMxCG03aZNs -deltaZ is deprecated since OSX 10.6. Therefore use -magnification. The forum also mentions the fact the steps are 500 times smaller. Lets use this factor 500 to keep the behavior as consistent as possible Change-Id: Ie769c518492e5b149a5301b19cae8d841047cb22 Reviewed-on: https://gerrit.libreoffice.org/8345 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-03Use cstdlib std::abs instead of stdlib.h abs: Mac-specific codeStephan Bergmann1-2/+3
Change-Id: I919b1a931145a49c32ec601109be083b49f10f7b
2014-02-28Rename GetGraphics to AcquireGraphicsChris Sherlock2-3/+3
Currently there are a number of classes that have a function called GetGraphics(). It returns a SalGraphics instance if one is available for the sole use of the caller. Some variants keep a pool of available SalGraphics and return one not currently in use by anyone, creating extra ones on demand, sometimes up to a set limit and returning NULL on reaching that limit of simultaneously in use SalGraphics. This is confusing. What is really happening from the perspective of the calling is that is that we are attempting to *acquire* ownership of a SalGraphics instance. Therefore, rename GetGraphics to AcquireGraphics() which returns a handle to a SalGraphics if we can acquire a free graphics instance, and NULL if we cannot, which makes it cleared that ReleaseGraphics should be called on the result of AcquireGraphics. The classes that were changed to include the new acquire function are: * SalFrame * SalVirtualDevice * SalInfoPrinter * PspSalInfoPrinter * X11SalFrame * X11SalVirtualDevice * GtkSalFrame * KDESalFrame * TDESalFrame * WinSalFrame * WinSalInfoPrinter * WinSalVirtualDevice * SvpSalFrame * SvpSalVirtualDevice * AquaSalFrame * AquaSalInfoPrinter * AquaSalVirtualDevice Change-Id: Ic39c08a4bcaf665ae08ba2808cd03b0e80790c46 Reviewed-on: https://gerrit.libreoffice.org/8070 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28Add SAL_OVERRIDE markup for the vcl OS X and iOS code, and follow-up cleanupTor Lillqvist11-113/+68
Thanks to SAL_OVERRIDE, I found a couple of unused functions and several that were virtual even if they did not override anything and were not overridden in any derived class. Change-Id: I5981111d2fc38f75a384c52359546a973e772393
2014-02-28sal_Bool/bool falloutTor Lillqvist3-7/+7
Change-Id: Id31598b9c6485ecddcbbc3b2f216f67daca9a795
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock6-23/+13
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann13-84/+84
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from vclAlexander Wilms13-40/+40
Conflicts: vcl/source/app/settings.cxx vcl/source/window/dockmgr.cxx vcl/source/window/dockwin.cxx vcl/source/window/floatwin.cxx vcl/source/window/toolbox2.cxx Change-Id: Ie67681549a76e77064b09d4b5bf80fe4c6010341 Reviewed-on: https://gerrit.libreoffice.org/8339 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25loplugin:literaltoboolconversionStephan Bergmann2-2/+2
Change-Id: I74bd9af6936f00fb26273606f7924f99ee7767d3
2014-02-25Mac vcl: sal_Bool -> bool sequelStephan Bergmann3-34/+34
Change-Id: Ie180b99a1a2d71922009c85c16ccb33b7968bd03