summaryrefslogtreecommitdiff
path: root/uui
AgeCommit message (Collapse)AuthorFilesLines
2017-07-06use OString::operator== in preference to ::equalsNoel Grandin1-1/+1
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf Reviewed-on: https://gerrit.libreoffice.org/39646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06use more begin()/end() for SequenceNoel Grandin1-9/+5
Change-Id: I399be6b6ef7a6ce01e883569a177c0969bc29c69
2017-06-28loplugin:oncevar in ucb..vbahelperNoel Grandin2-13/+6
Change-Id: I1fc7c7505a42b3bf9d4a5ab22961930b9831d4ae Reviewed-on: https://gerrit.libreoffice.org/39327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23inline some ERRCODE_AREA aliasesNoel Grandin1-1/+1
and drop unused ERRCODE_AREA_OFA_END constant Change-Id: Ic34ecda7f842c5db93807b3f21aa1062966ca523 Reviewed-on: https://gerrit.libreoffice.org/39089 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21convert ErrCode to strong typedefNoel Grandin5-79/+79
would have preferred to re-use o3tl::strong_int, of which this is a modified copy, but there are lots of convenience accessors which are nice to define on the class. Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a Reviewed-on: https://gerrit.libreoffice.org/38497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke8-8/+0
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-14use ERRCODE_NONE instead of 0Noel Grandin1-1/+1
peeling off a small chunk of my ErrCode strong_int conversion Change-Id: Idc89e8496083beed7608cba705cd981139eb7111 Reviewed-on: https://gerrit.libreoffice.org/38777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-13no need to define __RSC hereNoel Grandin1-2/+0
Change-Id: I5bfe4196307569bc181854db4612d7fc79f480b5 Reviewed-on: https://gerrit.libreoffice.org/38726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06tdf#106942 Wrong message when lock file is empty or corruptJuergen Funk11-33/+181
1. Erase empty or corrupt lockfile, when reading it fails and skip "Locked Document Dialog" in that case 2. Show Dialog (use LockFileIgnoreRequest -> LockFailedQueryBox) when create lock file is not possible. Two Dialogs: "lock file create error" and "empty lockfile is present" Set the document to read-only when creating lockfile is not possible. If lockfile is corrupt or empty, inform the user. They can interrupt loading the document or open it read-only, which also erases the corrupt lock file after closing the document 3. Handling for the two Dialogs Use LockFileIgnoreRequst for create lockfile error and add a new LockFileCorruptRequest, (lock file is corrupt). Change and generate new messages for both dialogs in english Change-Id: I35c377f85b5113e8ffb89d83b9544b8ebc81d89f Reviewed-on: https://gerrit.libreoffice.org/36658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-05spelling instanciate -> instantiateNoel Grandin2-2/+2
Change-Id: Ic1393da64328c0dc7e2860334b204139bf537d81 Reviewed-on: https://gerrit.libreoffice.org/38401 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-01merge ofa res file into svt oneCaolán McNamara1-1/+1
Change-Id: I3f22301e4301ab90e4a1090f2c47cf2403422282 Reviewed-on: https://gerrit.libreoffice.org/38309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-28remove unnecessary use of OString::getStrNoel Grandin1-7/+1
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-16loplugin:checkunusedparams variousNoel Grandin3-19/+15
Change-Id: I5d1cc807134230d86e0226a12fada204004312d3 Reviewed-on: https://gerrit.libreoffice.org/37675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock1-1/+1
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert uui module away from OSL_ASSERT to assertChris Sherlock1-1/+1
Change-Id: I8aefdc3172578535fde5ea6b86b80af7a017e5e8
2017-05-05tdf#107649: add TrySystemCredentialsFirst config optionMike Kaganski1-5/+11
This will allow automatically try system credentials for any URI (including unknown) before displaying dialogs. This is intended for corporate enviromnents. Default value of this option is false, keeping current behavior. Change-Id: I96cb18e089134325e1f92f1afdef331975000e3b Reviewed-on: https://gerrit.libreoffice.org/37297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-04-28clang-tidy readability-simplify-boolean-exprNoel Grandin1-4/+1
Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a Reviewed-on: https://gerrit.libreoffice.org/36450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock3-3/+3
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25vcl: change ErrorHandlerFlags to DialogMaskChris Sherlock4-40/+40
Change-Id: I1959ac97f679d8d719f851f9869962b39a20ded9 Reviewed-on: https://gerrit.libreoffice.org/36841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock3-3/+3
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25make __RSC a builtin define for the RSC compilerNoel Grandin9-18/+0
instead of randomly defining it in only some of .src files Change-Id: Ifec3920740723d248400f451d717b5288c421b8d Reviewed-on: https://gerrit.libreoffice.org/36832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock2-0/+2
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2-2/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-20loplugin:unusedmethodsNoel Grandin2-1/+1
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-13Removed duplicated includesAndrea Gelmini2-4/+0
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-12can use gb_CppunitTest_use_configuration and still access .ui filesCaolán McNamara1-2/+1
after... commit 506cab1a01b0481d0831a7a692a26dc5a5b55e91 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Apr 12 16:14:10 2017 +0100 take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR Change-Id: I9cffdc092206c038da32a32a2cfe629e68b5c258 Change-Id: I906d16037cdf0b9203a4120cb1a5e9846a5c7b7f Reviewed-on: https://gerrit.libreoffice.org/36482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: uuiStephan Bergmann1-6/+2
Change-Id: I2ecf4a804a9fa4056f956bea245b64cb7c087595
2017-04-03use actual UNO enums in test..vbahelperNoel Grandin2-9/+9
Change-Id: I2e38462045efedc31903589a3fa4e6f62d74d8de Reviewed-on: https://gerrit.libreoffice.org/36042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-20remove unused defines from HRC files in misc(2)Noel Grandin2-6/+0
Change-Id: I6d27c03925e7756022c3e343c0873c4dd1dd90dc Reviewed-on: https://gerrit.libreoffice.org/35324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann1-10/+2
Change-Id: Ieae74cca9d156503b7b75cc2da49b831b17f9633 Reviewed-on: https://gerrit.libreoffice.org/34252 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-09Reapply "create ErrorHandlerFlags scoped enum for error handling flags""Noel Grandin4-43/+51
This effectively reverts commit 32cae6a2eaa41568888df9c8fc5605debd8d704a. Change-Id: I15bb0a5c4acaeee6d47dd93a71601d9687d701bc Reviewed-on: https://gerrit.libreoffice.org/34028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08replace localresource of strings and keys with StringArrayCaolán McNamara3-295/+152
Change-Id: I402f5485af0c1e60677b8291c879bc7ca14633d3
2017-02-07Revert "create ErrorHandlerFlags scoped enum for error handling flags"Michael Stahl4-51/+43
This reverts commit 05e78bde26d8b8b257ed22a0ce20c5b386a629d1. Depends on the other commit that needs reverting
2017-02-07revert unready stuffCaolán McNamara3-152/+295
Change-Id: I2b112a17a2bc70bfe4d5a6af7964a3c1d7eacf9b
2017-02-07interim convert to ResArrayCaolán McNamara3-295/+152
Change-Id: I74c8ad1242611321401f6282dfbce3205977394a
2017-02-07there is no cnt (chaos) resource file anymoreCaolán McNamara1-9/+3
Change-Id: I97f0606c6003ca12c651841ec26145728fc5c808
2017-02-07replace calculation to get RID_SVXERRCODE with RID_SVXERRCODECaolán McNamara1-1/+2
presumably a hackaround from old deliver-headers era Change-Id: Idbaeec7bb8523776045ce5355235a4397b2195e4
2017-02-07create ErrorHandlerFlags scoped enum for error handling flagsNoel Grandin4-43/+51
Change-Id: I30c80979c87bad7bc98f36a158c31c88d80d1caf Reviewed-on: https://gerrit.libreoffice.org/33991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31tdf#105566 Show InfoBar when signature is invalidSamuel Mehrbrodt1-7/+3
gpg4libre Change-Id: I272ac155889e25b9af91ff723a014588a65b045a Reviewed-on: https://gerrit.libreoffice.org/33737 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-26Remove dynamic exception specificationsStephan Bergmann6-46/+17
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, uuiStephan Bergmann1-1/+1
Change-Id: I0350334f8d9a1f56044dd574328bdc3a21d4509d
2017-01-19new loplugin: useuniqueptr: unotools..xmlscriptNoel Grandin1-10/+3
Change-Id: I6966d44cff644112dd837adfe7d9c4f459457271 Reviewed-on: https://gerrit.libreoffice.org/33298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-19tweak to avoid coverity#1371169 Missing move assignment operatorCaolán McNamara1-8/+15
Change-Id: I0d29ce18c19c26a7526dad98d77db4670d0c5303
2016-12-06OSL_TRACE->SAL in unotools..uuiNoel Grandin1-1/+1
Change-Id: I7f391604401b8a10f5d451673ed6223c031c56ab
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann1-5/+0
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin2-2/+2
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-11-25convert LF constants to o3tl::typed_flagsNoel Grandin3-30/+37
Change-Id: I4fa3a62e53eb02fe60c9ca0675709b76e56a7912
2016-11-21add missing deps on ui filesDavid Tardon1-0/+4
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud1-1/+1
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-18includes should be at the top of the fileNoel Grandin1-3/+1
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>