summaryrefslogtreecommitdiff
path: root/uui
AgeCommit message (Collapse)AuthorFilesLines
2018-03-12tdf#115742: use correct parameterAron Budea1-1/+1
Change-Id: I3e9d30b64533007040761f152d15875f2fbcb4ce Reviewed-on: https://gerrit.libreoffice.org/51177 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-03-12Build fix after e169df73408a48427a2b4b2a1927da09fc740169Mike Kaganski1-1/+1
Change-Id: I5aa972e6c9b5f9c24f69350171b9ac570a866003 Reviewed-on: https://gerrit.libreoffice.org/51162 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-03-12tdf#115742: allow ignoring stale lockfile on saveMike Kaganski5-26/+47
This change reuses TryLaterQueryBox, but only uses the new option to ignore the lock and save. Other options ("Try Again" and "Save As") are not used, because this functionality is not implemented currently (TODO/LATER). Change-Id: Idf825be23cf97d2b338c0cf5d532f8460843bf48 Reviewed-on: https://gerrit.libreoffice.org/50371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50409 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-09tdf#108210: Allow to ignore a lock file if there's no filesystem lockMike Kaganski6-54/+67
Two cases are handled: when a file is being opened, and when it was opened read-only already, and one tries to reopen it in edit mode. The option to ignore locking and open the file anyway is only offered when there is no filesystem lock present on the file. Change-Id: I377d3cae4c949ae64d449634acea8fb3f68a5700 Reviewed-on: https://gerrit.libreoffice.org/49448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/49470 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-02-09tdf#106942 Wrong message when lock file is empty or corruptJuergen Funk11-34/+182
1. Erase empty or corrupt lockfile, when reading it fails and skip "Locked Document Dialog" in that case 2. Show Dialog (use LockFileIgnoreRequest -> LockFailedQueryBox) when create lock file is not possible. Two Dialogs: "lock file create error" and "empty lockfile is present" Set the document to read-only when creating lockfile is not possible. If lockfile is corrupt or empty, inform the user. They can interrupt loading the document or open it read-only, which also erases the corrupt lock file after closing the document 3. Handling for the two Dialogs Use LockFileIgnoreRequst for create lockfile error and add a new LockFileCorruptRequest, (lock file is corrupt). Change and generate new messages for both dialogs in english Change-Id: I35c377f85b5113e8ffb89d83b9544b8ebc81d89f Reviewed-on: https://gerrit.libreoffice.org/36658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/49468 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2017-12-18convert DecodeMechanism to scoped enumNoel Grandin2-2/+2
(cherry picked from commit bfde4866e07746eafa2f0d6173c29d805cc35ad0) (cherry picked from commit 3de922d4a695e253d4ca2d42b70e0b35b52e9b7c) Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2017-05-06tdf#107649: add TrySystemCredentialsFirst config optionMike Kaganski1-5/+11
This will allow automatically try system credentials for any URI (including unknown) before displaying dialogs. This is intended for corporate enviromnents. Default value of this option is false, keeping current behavior. Change-Id: I96cb18e089134325e1f92f1afdef331975000e3b Reviewed-on: https://gerrit.libreoffice.org/37297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit ffd8e6b44e7dacb28047661fd6b73061790761cf) Reviewed-on: https://gerrit.libreoffice.org/37303 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-21add missing deps on ui filesDavid Tardon1-0/+4
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud1-1/+1
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-18includes should be at the top of the fileNoel Grandin1-3/+1
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Fix typosSamuel Mehrbrodt1-1/+1
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann1-2/+2
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann1-8/+1
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09uui: fix use-after-free on password dialogMichael Stahl1-2/+2
VclPtr returned from CreatePasswordToOpenModifyDialog implicitly converts to plain pointer then deletes the dialog. (regression from some vclptr refactoring) Change-Id: I4ccdeabcd6ee718104c0f7f65d67a20ce2c70ca3
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara1-1/+1
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-19loplugin:expandablemethods in UnoControls..vbahelperNoel Grandin7-19/+3
Change-Id: Iec2c5e13119d97c9ca87e083c0f7cb00227e5231 Reviewed-on: https://gerrit.libreoffice.org/29997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-15clang-cl loplugin: uuiStephan Bergmann1-1/+1
Change-Id: Ie8cab2cf21258a8043db596291c442a6a13b113b Reviewed-on: https://gerrit.libreoffice.org/29842 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-13tdf#74608: Ctor function for css.comp.uui.UUIInteractionRequestStringResolverMatúš Kukan4-62/+13
Change-Id: I42c0c2cc8797647aa9dd676034137a1430e42fee
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara6-5/+1
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05convert MapUnit to scoped enumNoel Grandin1-1/+1
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann16-32/+32
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03set translatable attributes in .ui filesAndras Timar1-1/+1
Change-Id: Idcdf9fbbc6b980a376fc0b5d607cbb48aa1dc5f1 Reviewed-on: https://gerrit.libreoffice.org/29503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-10-03loplugin:countusersofdefaultparams in sw..vclNoel Grandin1-1/+1
Change-Id: I152df55f5a30e073c66cfd3a64d5090a20cb232d Reviewed-on: https://gerrit.libreoffice.org/29471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann17-17/+17
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-07loplugin:constantparam in vclNoel Grandin1-1/+1
Change-Id: I0cae8e5de1170dec4c82df7f1f5377143a079876 Reviewed-on: https://gerrit.libreoffice.org/28686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-18tdf#87938 Add descriptive instructions to 2fa dialogYousuf Philips3-30/+108
Change-Id: I0bbe3ae4591785e32467dec8554493f0b549d009 Reviewed-on: https://gerrit.libreoffice.org/28105 Reviewed-by: Szymon Kłos <eszkadev@gmail.com> Tested-by: Szymon Kłos <eszkadev@gmail.com>
2016-08-18screenshots: add new global make targetArmin Le Grand1-1/+2
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand1-74/+2
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for uuiArmin Le Grand4-0/+264
All *.ui files create a screenshot, but not all look useful Change-Id: I95c254a2f98e0d5b1efc4f167be8499c5cf82436
2016-07-29VclPtr: password prompts never disposeCaolán McNamara1-14/+12
Change-Id: I917e5457be6de152b39e91ad41b6ed196dfe3e45
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin1-0/+1
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28loplugin:singlevalfields in variousNoel Grandin2-3/+1
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-15This doesn’t need to be translatableAdolfo Jayme Barrientos1-1/+1
Change-Id: I6a79214d24452dc2813d22d60f97eead220a7c5b
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann1-1/+1
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-05-23Google 2FA: better info for userSzymon Kłos3-2/+35
Google sends SMS with code in format "G-XXXXXX". User should enter only numbers wihout "G-". + added "G-" label which is shown in the Google authentication code request before PIN field Change-Id: I8eaecbbe7b8803269444f947e97ee67c33db61b2
2016-05-19loplugin:unusedmethods in unotoolsNoel Grandin1-4/+0
Change-Id: I5729c2a20dd5fb310570cb9e4bb0e0874dbc8049 Reviewed-on: https://gerrit.libreoffice.org/25102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16tdf#87938 libcmis: Google 2FA implementationSzymon Kłos2-2/+5
2 Factor Authentication for Google Drive, changes: + parsing additional page with challenge - pin code verification + calling the interaction dialog requesting the code + dialog title changed to more general: Authentication Code + dialog shows url field only if not empty Change-Id: Idb3ebbad6a12849b9e50af87b46324bfbe966bab Reviewed-on: https://gerrit.libreoffice.org/25002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-05-13clang-tidy modernize-loop-convert in toolkit to uuiNoel Grandin1-3/+3
Change-Id: I805aa1389ef8dde158f0b776d6b59579fa3082e4 Reviewed-on: https://gerrit.libreoffice.org/24921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-02Related tdf#98644: In login dialog, give a hint that the password was wrongStephan Bergmann3-13/+58
...by changing the dialog text from "Enter user name and password for..." to "Wrong user name and password for..." when an old password is already given. Change-Id: Ie167c5ea263e9f75e0269c528dc88b69270208f3
2016-04-22Avoid reserved identifierStephan Bergmann1-3/+3
Change-Id: I3dde927ee22032e0f516df16a7f9921ccb3cca7f
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2-4/+4
Change-Id: I0bdb1669eff6b2e2fbecae7d1cc720dfc0d53c20
2016-04-18clean-up: unused using declarations and includesJochen Nitschke1-2/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin5-8/+8
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke1-1/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke1-3/+4
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack1-1/+1
Including no keywords from extern "C" blocks Change-Id: I7769c9d2a131d7389ef6ab08c0fbd12bc624778c Reviewed-on: https://gerrit.libreoffice.org/23678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin1-1/+1
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock12-34/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara1-1/+0
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-26loplugin:unusedfields variousNoel Grandin1-1/+0
Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 11:44:50 +0000