summaryrefslogtreecommitdiff
path: root/unoxml
AgeCommit message (Collapse)AuthorFilesLines
2014-04-15Clean up function declarationsStephan Bergmann3-12/+9
Change-Id: I1be08414e3c816f01a9712eeb9474acc16838389
2014-04-08coverity#707456 Uncaught exceptionCaolán McNamara2-8/+8
also coverity#707455, coverity#707454, coverity#707453 Change-Id: Ife1c2959eeee00cf83762eccc559ed001f64b5c1
2014-04-05coverity#708568 Uninitialized scalar fieldCaolán McNamara1-1/+4
Change-Id: I0aeb615809001bd17d51eb66c0ebf429f960bca3
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin4-14/+14
i.e. convert "::sal_Bool" to "sal_Bool" Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann35-673/+673
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin2-6/+6
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann64-990/+990
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from unoxmlAlexander Wilms3-29/+29
Change-Id: I405f2df6621197effd7e2b19844fe4d0bf7f58aa Reviewed-on: https://gerrit.libreoffice.org/8335 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-28bool improvementsStephan Bergmann1-4/+4
Change-Id: Ibf171ce82595a135c544fcf31c666e384e1fbd26
2014-01-09librdf_Repository: make older compilers happyMichael Stahl1-3/+9
Change-Id: Ide4df8f621f810b20be811db06d46edd5a9dc5f8
2014-01-09librdf_Repository: fix missing mutex lock in various destructorsMichael Stahl1-3/+16
Change-Id: I5756ab6ff6de0b2532bef9866063f361e330a009
2014-01-09fdo#72928: fix deadlocks in librdf_RepositoryMichael Stahl1-149/+324
Refactor to do all calls on parameters before locking the mutex. This requires splitting up some librdf_TypeConverter methods into an extract function and a make function, with an intermediate representation between. Also rename some internal functions to make it clear which are called with Lock and which with NoLock. Change-Id: Iddc42461d95351785578ef6a80fbf5d056356c16
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann2-4/+4
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin1-3/+3
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin2-20/+20
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-07fdo#63020: Replace ::comphelper::stl_begin()...Marcos Paulo de Souza1-3/+1
And use some templates inside include/com/sun/star/uno/Sequence.hxx Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47 Reviewed-on: https://gerrit.libreoffice.org/6599 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-05fixincludeguards.sh: uno*Thomas Arnhold33-66/+66
Change-Id: I8fb3c25cd583b688104a0ee8620696e7b2958ab5
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin1-1/+1
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-11-Werror,-Wunused-variableStephan Bergmann2-42/+30
Change-Id: I7777008aac6331d7598f496c4808ab34c73f814e
2013-10-07fdo#54938: Adapt supportsService implementations to cppu::supportsServiceMarcos Paulo de Souza8-53/+16
Change-Id: I683c0d30c3286ed5d725d4eefe8b3977b82ee316 Reviewed-on: https://gerrit.libreoffice.org/6035 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-2/+0
Change-Id: I520782b2a4cc7a7b100471f18980515acb2e4ede
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-1/+0
Change-Id: I7b38539b6c4153d6e5268551c8d3f8cbaf5be400
2013-09-26typo fixes in commentsAndras Timar1-2/+2
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-20The original bytes were probably meant as UTF-8, not UTF-16Stephan Bergmann1-1/+1
...not that it matters much /what/ characters are used in the sample text, of course. And no-argument java.lang.String.getBytes() appears to indeed use the legacy Mac OS Roman encoding on Mac OS X... Change-Id: I51cd8c16f14e2df8b75d9961150518c8a03d53ca
2013-09-20java.lang.String.getBytes() has platform-dependent semanticsStephan Bergmann1-2/+2
Change-Id: Ia36e73215f666a26e5898310aabefb68d3f695c2
2013-09-20New unit test to the DOMTree test suiteMiguel Gomez1-0/+53
Ensure that a parsed document that contains a malformed xmlns tag doesn't cause a segfault when serializing it through the XSAXSerializable interface. Change-Id: I00811494b37a307711c1a7a86403a56da8b23776 Reviewed-on: https://gerrit.libreoffice.org/6004 Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-20unoxml: avoid SIGSEV when xmlNsPtr prefix is NULLAndres Gomez1-1/+1
When serializing a XDocument with "xmlns" elements, they usually come with a prefix like in xmlns:xlink="http://www.w3.org/1999/xlink". When the prefix doesn exist like in xmlns="", the prefix member of the xmlNsPtr structure is NULL and unsafe operations on it like "strlen" may cause a SIGSEV. Change-Id: Icdfcddeccb37c246a48aa1239b7f3c5b0b3727e3 Reviewed-on: https://gerrit.libreoffice.org/6003 Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-08-31fdo#62475 - remove visual noisePhilipp Riemer1-6/+0
This is a follow up commit to - 22d1beb78a475e4846af945afde1c4d6c263b5d6 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75 Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-20Re-work 8bit characters in source code, or remove them.Michael Meeks1-1/+1
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3 Reviewed-on: https://gerrit.libreoffice.org/5550 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-07-08-Werror,-Wlogical-not-parentheses (Clang trunk towards 3.4)Stephan Bergmann1-3/+3
...the apparently mistyped conditions happened to work well for the expected values of m_aState. Change-Id: I75f1f4ff8343098be4932c286ddb101d5e913183
2013-06-26fdo#64672 prevent raptor from setting global libxml2 error handlersMichael Stahl1-0/+11
Raptor already sets up all 4 error handlers in xmlSAXHandler so why it would need the global ones in addition to that is a mystery anyway. Messing with libxml2's globals can only cause trouble. Change-Id: I2935efe5c4cd75d48cc4ecdeaa8437e91b48349e
2013-06-19fdo#43460 unoxml,writerfilter,xmlsecurity: use isEmpty()Jelle van der Waa1-1/+1
Change-Id: Iba3b39086212803bc41384f5c8f51e42712a5249 Reviewed-on: https://gerrit.libreoffice.org/4349 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-05use uno::Reference#clear() method...Noel Grandin2-3/+3
...instead of assigning an empty value. Reduces code noise. Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-05-24WaE: implicit conversion of NULL constant to nullptr_tTor Lillqvist3-4/+4
Change-Id: I2eefbca1ef986219f04504cba4ca09a22972e8cb
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin7-17/+17
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-04-22unordf: put in a version check for librdf_stream_get_context2Michael Stahl1-4/+8
Strangely Apple llvm-g++ 4.2.1 ignores the warning-disabling macro here and gives a deprecation warning, so use a version check instead. Change-Id: Ibc09930a907baea8665828529332d40de156b70e
2013-04-19Java cleanup, remove the rest of the unnecessary castsNoel Grandin1-2/+2
Change-Id: Ia61d250f6b3711abc29569c5ece38a6f87e38daa Reviewed-on: https://gerrit.libreoffice.org/3432 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák47-265/+225
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-03unordf: add unit test for CVE-2012-0037Michael Stahl2-0/+33
Change-Id: Ife037f05ddf66bc8c0598cb9521e95a1fa15c26e
2013-04-03unordf: replace external entity disabling handler code ...Michael Stahl1-10/+0
... with a configure check for the fixed raptor library. Change-Id: I495d5d28e9a4e7b6234f8f9d17c2bda36154316d
2013-03-20simplify OUString assignmentsChr. Rossmanith3-10/+10
Change-Id: Ieffd80aa84c9a041785bb81b3a904a32d00cb2bb Reviewed-on: https://gerrit.libreoffice.org/2863 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-03-14remove legacy build.pl prj/build.lst files.Michael Meeks1-2/+0
2013-03-04doubled includesThomas Arnhold3-3/+0
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-02-28remove all d.lstMichael Stahl1-0/+0
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
2013-02-24remove RTL_CONSTASCII_(U)STRINGPARAMChr. Rossmanith2-9/+9
Change-Id: Ica4dc859229c2ba0dc052a97ff23178895c25580 Reviewed-on: https://gerrit.libreoffice.org/2368 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2013-01-26gbuild: remove various pointless calls that don't add anythingMichael Stahl2-8/+0
Change-Id: I7eccac4fa8890c2873c6bbd7f8f5bf5b0dd006d2
2013-01-26gbuild: do not copy boost headers aroundMichael Stahl2-1/+5
- do not use gb_UnpackedTarball_copy_header_files for boost - adapt the optimization in concat-deps.c for new path - use boost_headers in all LinkTargets that require it - add explicit include paths to mysqlc, mysqlcppconn, libvisio, liborcus Change-Id: I0c43e73ed43cc9d2e6bce8faf55e992d655a0bb9
2012-12-30convert redland to gbuild and add to tail_buildPeter Foley1-3/+8
Change-Id: I953fb203b1a24920f236c2f6e1fd9d82edda1f0f Reviewed-on: https://gerrit.libreoffice.org/1493 Reviewed-by: Peter Foley <pefoley2@verizon.net> Tested-by: Peter Foley <pefoley2@verizon.net>
2012-11-30c++ API: use css alias in generated headers, adds global css declThorsten Behrens5-14/+0
This changes all generated API headers (.hpp and .hdl) to use a namespace alias 'css' instead of the pointlessly long com::sun::star Makes the change in cppumaker & associated tools, adds a global namespace alias definition in sal/types.h, and removes a kiloton of local, now pointless-to-harmful versions of that alias from all over the code. Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-28We only support MSVC 2008 (_MSC_VER 1500) or laterTor Lillqvist1-1/+1
We can drop or simplify many conditionals. Change-Id: I37e820e515cc09845c30b62c89ddb3b6ff370f97