summaryrefslogtreecommitdiff
path: root/unoxml
AgeCommit message (Collapse)AuthorFilesLines
2015-09-10unoxml: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe37-71/+79
with the variadic variants. Change-Id: Id753717b228061c810a0122e551326ab001949a9 Reviewed-on: https://gerrit.libreoffice.org/18460 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-03unoxml: Add missing includeDavid Ostrovsky1-0/+1
Change-Id: I5497abb747dc12080f076aaf81b946710bcd5570 Reviewed-on: https://gerrit.libreoffice.org/18319 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann3-9/+9
Change-Id: Iddea2a6462b52e39aab31e96fbc83836cf157e27
2015-07-30loplugin:unusedmethodsNoel Grandin3-15/+1
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann1-2/+1
Change-Id: Ic38df50884b370417ed62b65ac7f90a13faea230
2015-07-10do not include boost/utility.hppMichael Stahl1-1/+1
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-08Fix typosAndrea Gelmini1-1/+1
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-06loplugin:unusedmethods basebmpNoel Grandin1-2/+0
Change-Id: I9e89fea4e94a91edbbe355780c2a12d6e6cb6e4a Reviewed-on: https://gerrit.libreoffice.org/16728 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-04Fix typosAndrea Gelmini1-1/+1
Change-Id: Id9296115f30858e7fd470a199e59343a96d7deec Reviewed-on: https://gerrit.libreoffice.org/16712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-23Revert "Typo: iff->if"Julien Nabet1-1/+1
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet1-1/+1
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe1-3/+3
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann1-1/+1
Change-Id: Ic50468d68c92779a589894963ab4099eefb8adf4
2015-05-26cppcheck: noExplicitConstructorCaolán McNamara6-8/+8
Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann1-1/+1
Change-Id: Ic046e96b395713336cb33ce48a003183f7648d36
2015-04-25remove some @author tags from suspiciously unidiomatic codeMichael Stahl1-1/+0
Change-Id: I3930420fe502978f8e14a688f2eb99c74d185f7b
2015-04-13loplugin:staticmethodsNoel Grandin1-35/+34
Change-Id: I33a8ca28b0c3bf1c31758d93238e74927bebde9c
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann1-1/+1
Change-Id: Ia275bf01d6c72e01e9144a99121f4a9858e88c8a
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann1-1/+1
Change-Id: Ie12eb8940ebb6059d234f5af25800812c085002a
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann1-1/+1
Change-Id: I85007c6fdceca1c070ca9b4cb62715a5c92bfe15
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann2-3/+5
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage1-5/+5
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-05Updated all precompiled headers.Ashod Nakashian1-1/+1
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara2-27/+0
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-28remove unused typedefsNoel Grandin1-1/+0
found with some minor modifications to find/find-unused-defines.sh Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd Reviewed-on: https://gerrit.libreoffice.org/14194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin2-2/+2
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-22loplugin:cstylecastStephan Bergmann1-6/+6
Change-Id: I126e06a0c7b442dfc4fcad7c05ff6caf07896a8f
2015-01-20Some more loplugin:cstylecast: unoxmlStephan Bergmann14-101/+101
Change-Id: I7467e033c998d9ee4283a146088c3b09d161f3cd
2015-01-19fdo#39440 reduce scope of local variablesMichael Weghorn1-3/+2
This addresses some cppcheck warnings. Change-Id: I1cd8b118e2598b8b18fb445851a3bb41e554267b Reviewed-on: https://gerrit.libreoffice.org/13967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara1-2/+2
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin1-2/+2
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: static fields that should not be staticNoel Grandin1-1/+1
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-18unoxml: Use appropriate OUString functions on string constantsStephan Bergmann2-2/+2
Change-Id: I6be6717b1714e2f7115ec8e27c5026a439bf1b05
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann1-2/+2
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-15java: remove some unused fields and variablesNoel Grandin1-2/+1
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15unoxml: Use appropriate OUString functions on string constantsStephan Bergmann2-23/+21
Change-Id: If4467034e026409dc9d6f0b5ffcafcf98ff8778e
2014-12-11document 440749 Explicit null dereferencedCaolán McNamara1-0/+1
Change-Id: I9f2e97504953742f09981632b7901fcd2fae6747
2014-12-11java: reduce visibility of fields and methodsNoel Grandin2-8/+8
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: improve use of WrappedTargetException to set cause properlyNoel Grandin1-21/+0
since we introduced the new constructors that pass the cause all the way up to java.lang.Throwable. Also simplify some exeception printing sites, because Throwable will correctly print out child exceptions for us. Change-Id: Ibbecce3c6f971fbc80d6de2052ab4f33a4503c0a
2014-12-10java: simplify the getMSF() methodsNoel Grandin1-3/+2
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl2-0/+4
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl15-0/+25
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2-5/+5
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann3-10/+20
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin3-20/+10
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin1-5/+5
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-03coverity#705527 drop testlistener that logs to c:\listener.outCaolán McNamara5-245/+0
Change-Id: Id9eab9e44d4b0e705289fa45be0fc2343903de09
2014-11-03coverity#982488 unchecked dynamic_castDavid Tardon1-0/+1
Change-Id: I7008b3a96400a4d1520a03d985c0b421ff587bcb
2014-10-13coverity#707458 Uncaught exception (better fix)Michael Stahl1-12/+19
getStatementsGraph_NoLock() cannot throw the exception because of the i_Internal=true parameter, which may confuse Converity; but possibly xIter->nextElement() could throw this in a multi-threaded scenario... Change-Id: I204c0e5b38fee919d6cfe9247bde76b6ea78ed0f
2014-10-10coverity#707458 Uncaught exceptionCaolán McNamara1-0/+2
Change-Id: Ia446cc0b8b26bb158b36ca64cbf45bf172f37bdf