summaryrefslogtreecommitdiff
path: root/unotools
AgeCommit message (Collapse)AuthorFilesLines
2016-06-14loplugin:overrideStephan Bergmann2-2/+2
Change-Id: Ib66e1f58eaa383a66660a28e39cdbd11dade2972
2016-06-14tdf#89329: use shared_ptr for pImpl in misccfgXisco Fauli1-23/+19
Change-Id: I90d3d008f68991613775234b29379c31b8f4ad39 Reviewed-on: https://gerrit.libreoffice.org/26237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14tdf#89329: use shared_ptr for pImpl in compatibility...Xisco Fauli1-45/+22
... and remove some, at least from my point of view, useless comments Change-Id: Id97c90dd7764ae4569468abc73c79ae9b2a56e75 Reviewed-on: https://gerrit.libreoffice.org/26235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14tdf#89329: use shared_ptr for pImpl in defaultoptions...Xisco Fauli1-12/+13
instead of unique_ptr as in commit 7bc1c79c26e52d5196fb36eee5c2f12f12d49ba6 Change-Id: I4e57378a333455b818162c6cc8484be9dcaddb03 Reviewed-on: https://gerrit.libreoffice.org/26236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14tdf#89329: use shared_ptr for pImpl in syslocaleXisco Fauli1-9/+7
Change-Id: I646495e3538cb438a06765fe8cde252bad667bea Reviewed-on: https://gerrit.libreoffice.org/25969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-13loplugin:sallogareasStephan Bergmann4-7/+7
Change-Id: I97fe4a566531015fe6c9fd275aaa46723aee9513
2016-06-12convert more DBG_ASSERT(false to SAL_WARNNoel Grandin4-8/+9
Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko1-4/+1
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08Resolves: tdf#89394 revert attempt to ditch missing file from recent filesCaolán McNamara1-29/+8
this reverts commit 93eefe54f5d6b6092371bad1e86444489d29eee2 Author: Krisztian Pinter <pin.terminator@gmail.com> Date: Fri Sep 6 14:45:13 2013 +0200 Make SvtHistoryOptions not return files if they can't be opened which seemed like a good idea, but was only really to fix a cosmetic problem, while the outcome was a more serious issue Change-Id: Ic9c9c136e1e50f5e28fe377b64f56e501fb836ca
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl2-5/+5
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in configvaluecontainerXisco Fauli1-1/+0
Change-Id: Ide38cacc59a44515287d51dadb23836eaac14518 Reviewed-on: https://gerrit.libreoffice.org/25904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in accessiblestatesethelperXisco Fauli1-8/+4
Change-Id: I768bfd5a19a2633e6d6cd37f919c20cbfc76824e Reviewed-on: https://gerrit.libreoffice.org/25905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in accessiblerelationsethelperXisco Fauli1-6/+3
Change-Id: I29578afa206e869a5b2e6fb42c7f5ebf4a6f2fe8 Reviewed-on: https://gerrit.libreoffice.org/25906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove some manual ref counting in svx and xmloffNoel Grandin1-15/+9
Change-Id: Ica0b6ff8ff7fa9e65cd758160d6e3ea7110ebb46 Reviewed-on: https://gerrit.libreoffice.org/25824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Some clean up of uses of css::uno::Any::setValueStephan Bergmann1-12/+7
Change-Id: I04e8aef35a6083b61d775c8eb3f96757da2b31bd
2016-05-30tdf#89329: use unique_ptr for pImpl in fltrcfgXisco Fauli1-47/+46
Change-Id: Icbb7d122d7f553215de562a98b0127764b30faa1 Reviewed-on: https://gerrit.libreoffice.org/25628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30tdf#89329: use unique_ptr for pImpl in defaultoptionsXisco Fauli1-2/+2
Change-Id: I355888c44d1413f8d0ebd7a247649b79647c38ec Reviewed-on: https://gerrit.libreoffice.org/25629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24tdf#99973 - Crash when changing Locale Setting in optionsNoel Grandin1-3/+2
regression from commit 0f672545 "clang-tidy modernize-loop-convert in toolkit to uui", probably because the list is being modified while the loop is executing Change-Id: I18cd21001aee132e06d577c469aed5eb46a16a7f Reviewed-on: https://gerrit.libreoffice.org/25368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin1-1/+1
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in unotoolsNoel Grandin8-218/+8
Change-Id: I5729c2a20dd5fb310570cb9e4bb0e0874dbc8049 Reviewed-on: https://gerrit.libreoffice.org/25102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13clang-tidy modernize-loop-convert in toolkit to uuiNoel Grandin3-9/+9
Change-Id: I805aa1389ef8dde158f0b776d6b59579fa3082e4 Reviewed-on: https://gerrit.libreoffice.org/24921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12loplugin:passstuffbyrefStephan Bergmann1-1/+1
Change-Id: Ifa990214aaf749d039043aa51d3301dc0f1f0e4f
2016-05-12Silence -Werror,-Wimplicit-fallthrough under NDEBUGStephan Bergmann1-6/+9
Change-Id: Iff742ad9a53086028049dd2df3bf63303c32c317
2016-05-11Fix horrible codestyleSamuel Mehrbrodt1-41/+32
Change-Id: I3bbeb625abd9ba130fc6fea97689ead682fa074b Reviewed-on: https://gerrit.libreoffice.org/24893 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-10-Werror=empty-bodyStephan Bergmann1-1/+1
("suggest braces around empty body in an ‘else’ statement") Change-Id: I7c6de1ed2cc1c2cc39e2c8f530866c31ab038907
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann1-1/+1
Change-Id: Ic764a6499b8f5ecac62d326151b0957c53866e08
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann3-3/+3
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann1-3/+1
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann4-40/+27
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03use Any constructor for bool values, instead of temporary varsNoel Grandin1-2/+1
mostly found with: git grep -n 'setValue.*cppu.*UnoType.*bool.*get' Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5 Reviewed-on: https://gerrit.libreoffice.org/24464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22tdf#81833: form protection can be modified as compatibility optionOliver Specht1-7/+24
ProtectForm is supported to prevent editing outside of form controls but could only be imported from doc and stored in odt but not changed. Now it is part of Writer's compatibility settings dialog. Change-Id: I7337fb3f0774d3c1d26cd8e1485958399b2a70e2 Reviewed-on: https://gerrit.libreoffice.org/24294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann6-6/+6
Change-Id: I57c1bd476183c941a70cc0c60fd4e42bbe95ccb2
2016-04-14loplugin:passstuffbyref in variousNoel Grandin3-8/+8
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-12Avoid reserved identifiersStephan Bergmann1-46/+46
Change-Id: I5390fe81a7b35d62a27cd1ec6fb00ea012e70dd9
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke4-7/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11clang-tidy performance-unnecessary-value-param in unotoolsNoel Grandin3-18/+18
Change-Id: Ife11111b0265da5d5a8a98766a94f3b640b357f5
2016-04-04loplugin:constantparam in unotoolsNoel Grandin2-10/+6
Change-Id: I0501e6e7eadd735b1666a8ecb2c5e6da73ce7e67 Reviewed-on: https://gerrit.libreoffice.org/23728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04reduce unnecessary reallocingNoel Grandin3-6/+9
Change-Id: I62368cf733ca6397099a843f3bbae3da08552798 Reviewed-on: https://gerrit.libreoffice.org/23761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan1-1/+1
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #3tymyjan1-1/+1
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4 Reviewed-on: https://gerrit.libreoffice.org/23752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke1-2/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-24don't allocate and destroy a LocaleDataItem for each cell, tdf#97989Markus Mohrhard1-3/+33
Change-Id: I8bcdc7a42c87d17fde1dc9c79bc361bb625f992b Reviewed-on: https://gerrit.libreoffice.org/23480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-16loplugin:constantparam in unotools/Noel Grandin6-36/+22
Change-Id: I016cf96af3a93c8f2114657a7e59599f68446ddc Reviewed-on: https://gerrit.libreoffice.org/23296 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15define ODFSVER_LATEST at a central placeEike Rathke1-4/+2
It's already enough to have to adapt the SvtSaveOptions::GetODFSaneDefaultVersion() mapping for new ODFDefaultVersion values, get rid of the SvXMLExport::getSaneDefaultVersion() place. In the hope that DO NOT USE is taken seriously.. Change-Id: I1eeae698249f68cc375b22cc4cc799107bc14e41
2016-03-13quieten debugging soffice startupCaolán McNamara1-1/+1
Change-Id: I3f9ef32d789b7b344cc09bbed6f344e428a31ca4
2016-03-10Avoid reserved identifierStephan Bergmann1-3/+3
Change-Id: I6ac0dfb8bb013e8106bdeb9df00aef3abe4d3af6
2016-03-08tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar4-41/+18
Updates pointed by Sweet5hark Change-Id: I747e92ca9ee39a027b1e9b27b131f249a33b77db Reviewed-on: https://gerrit.libreoffice.org/22980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-07tdf#97703 removed empty setUp/tearDown methodsChirag Manwani1-5/+0
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604 Reviewed-on: https://gerrit.libreoffice.org/22959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-02unotools: handle classification path in SvtDefaultOptionsMiklos Vajna1-4/+9
With this, it's possible to reset a custom classification path back to its default value. Change-Id: If0230fa6bb6ab014634dcdface8c470321163097
2016-03-02sfx2 classification: use SvtPathOptionsMiklos Vajna1-1/+15
In preparation to be able to edit the policy path from SvxPathTabPage. Change-Id: I7a8e03e9acf2e8096a5e00d1424c75fe31735c1d